161432 2016-08-31 02:03:11 -0700 [Fetch API] Request construction failure should not set "bodyUsed" 2016-08-31 09:46:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 151937 1 youennf youennf commit-queue oldest_to_newest 1224926 0 youennf 2016-08-31 02:03:11 -0700 As illustrated by chromium fetch tests, Request construction failure should not set "bodyUsed". 1224927 1 287506 youennf 2016-08-31 02:07:22 -0700 Created attachment 287506 Patch 1224976 2 287506 commit-queue 2016-08-31 09:46:42 -0700 Comment on attachment 287506 Patch Clearing flags on attachment: 287506 Committed r205253: <http://trac.webkit.org/changeset/205253> 1224978 3 commit-queue 2016-08-31 09:46:49 -0700 All reviewed patches have been landed. Closing bug. 287506 2016-08-31 02:07:22 -0700 2016-08-31 09:46:42 -0700 Patch bug-161432-20160831110508.patch text/plain 6092 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FmMDkyYTcyN2MzZGI2 NDY1YTVhNDVjZTIxZWRhYmRmODM3ODNmNC4uZDI1MmU0MDQ1MDhlYjVlMjYwNjc2ODIyYTY0ZDZl NjM2NmI0YzdjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA4LTMxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbRmV0Y2ggQVBJXSBSZXF1 ZXN0IGNvbnN0cnVjdGlvbiBmYWlsdXJlIHNob3VsZCBub3Qgc2V0ICJib2R5VXNlZCIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTQzMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgYWRk ZWQgc3ViLXRlc3QgY29taW5nIGZyb20gY2hyb21pdW0gZmV0Y2ggdGVzdCBzdWl0ZS4KKworICAg ICAgICAqIE1vZHVsZXMvZmV0Y2gvRmV0Y2hSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Om1ldGhvZENhbkhhdmVCb2R5KToKKyAgICAgICAgKFdlYkNvcmU6OkZldGNoUmVxdWVzdDo6c2V0 Qm9keSk6IENoZWNrIHdoZXRoZXIgcmVxdWVzdCBjYW4gaGF2ZSBhIGJvZHkgYmVmb3JlIGRpc3R1 cmJpbmcgdGhlIHBhc3NlZCByZXF1ZXN0LgorICAgICAgICAoV2ViQ29yZTo6dmFsaWRhdGVCb2R5 QW5kTWV0aG9kKTogRGVsZXRlZC4KKwogMjAxNi0wOC0zMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgImdldCIgdG8gQ3VzdG9tRWxlbWVudHNSZWdpc3Ry eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlcXVlc3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlcXVlc3QuY3BwCmluZGV4 IDE4NWFkY2M3OTVlNmM3ZjRlODY4YTMxNjlmNTNmZjNlNGRmNTJhN2QuLjgwZTYxYzA3OTVlOTEw M2JjNmExMWQ3ZGI2YzU0ODcyODYxOGQ2YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvZmV0Y2gvRmV0Y2hSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2ZldGNoL0ZldGNoUmVxdWVzdC5jcHAKQEAgLTE5MywxMCArMTkzLDggQEAgc3RhdGljIGJvb2wg YnVpbGRPcHRpb25zKEZldGNoUmVxdWVzdDo6SW50ZXJuYWxSZXF1ZXN0JiByZXF1ZXN0LCBTY3Jp cHRFeGVjdXRpb24KICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotc3RhdGljIGJvb2wgdmFsaWRhdGVC b2R5QW5kTWV0aG9kKGNvbnN0IEZldGNoQm9keSYgYm9keSwgY29uc3QgRmV0Y2hSZXF1ZXN0OjpJ bnRlcm5hbFJlcXVlc3QmIGludGVybmFsUmVxdWVzdCkKK3N0YXRpYyBib29sIG1ldGhvZENhbkhh dmVCb2R5KGNvbnN0IEZldGNoUmVxdWVzdDo6SW50ZXJuYWxSZXF1ZXN0JiBpbnRlcm5hbFJlcXVl c3QpCiB7Ci0gICAgaWYgKGJvZHkuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICByZXR1cm4gaW50ZXJuYWxSZXF1ZXN0LnJlcXVlc3QuaHR0cE1ldGhvZCgpICE9ICJHRVQiICYm IGludGVybmFsUmVxdWVzdC5yZXF1ZXN0Lmh0dHBNZXRob2QoKSAhPSAiSEVBRCI7CiB9CiAKQEAg LTI1Nyw2ICsyNTUsMTEgQEAgRmV0Y2hIZWFkZXJzKiBGZXRjaFJlcXVlc3Q6OmluaXRpYWxpemVX aXRoKEZldGNoUmVxdWVzdCYgaW5wdXQsIGNvbnN0IERpY3Rpb25hcnkKIHZvaWQgRmV0Y2hSZXF1 ZXN0OjpzZXRCb2R5KEpTQzo6RXhlY1N0YXRlJiBleGVjU3RhdGUsIEpTQzo6SlNWYWx1ZSBib2R5 LCBGZXRjaFJlcXVlc3QqIHJlcXVlc3QsIEV4Y2VwdGlvbkNvZGUmIGVjKQogewogICAgIGlmICgh Ym9keS5pc051bGwoKSkgeworICAgICAgICBpZiAoIW1ldGhvZENhbkhhdmVCb2R5KG1faW50ZXJu YWxSZXF1ZXN0KSkgeworICAgICAgICAgICAgZWMgPSBUeXBlRXJyb3I7CisgICAgICAgICAgICBy ZXR1cm47CisgICAgICAgIH0KKwogICAgICAgICBBU1NFUlQoc2NyaXB0RXhlY3V0aW9uQ29udGV4 dCgpKTsKICAgICAgICAgbV9ib2R5ID0gRmV0Y2hCb2R5OjpleHRyYWN0KCpzY3JpcHRFeGVjdXRp b25Db250ZXh0KCksIGV4ZWNTdGF0ZSwgYm9keSk7CiAgICAgICAgIGlmIChtX2JvZHkudHlwZSgp ID09IEZldGNoQm9keTo6VHlwZTo6Tm9uZSkgewpAQCAtMjY1LDE0ICsyNjgsMTYgQEAgdm9pZCBG ZXRjaFJlcXVlc3Q6OnNldEJvZHkoSlNDOjpFeGVjU3RhdGUmIGV4ZWNTdGF0ZSwgSlNDOjpKU1Zh bHVlIGJvZHksIEZldGNoUmUKICAgICAgICAgfQogICAgIH0KICAgICBlbHNlIGlmIChyZXF1ZXN0 ICYmICFyZXF1ZXN0LT5tX2JvZHkuaXNFbXB0eSgpKSB7CisgICAgICAgIGlmICghbWV0aG9kQ2Fu SGF2ZUJvZHkobV9pbnRlcm5hbFJlcXVlc3QpKSB7CisgICAgICAgICAgICBlYyA9IFR5cGVFcnJv cjsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCiAgICAgICAgIG1fYm9keSA9IEZl dGNoQm9keTo6ZXh0cmFjdEZyb21Cb2R5KCZyZXF1ZXN0LT5tX2JvZHkpOwogICAgICAgICByZXF1 ZXN0LT5zZXREaXN0dXJiZWQoKTsKICAgICB9CiAKICAgICBtX2JvZHkudXBkYXRlQ29udGVudFR5 cGUobV9oZWFkZXJzKTsKLQotICAgIGlmICghdmFsaWRhdGVCb2R5QW5kTWV0aG9kKG1fYm9keSwg bV9pbnRlcm5hbFJlcXVlc3QpKQotICAgICAgICBlYyA9IFR5cGVFcnJvcjsKIH0KIAogU3RyaW5n IEZldGNoUmVxdWVzdDo6cmVmZXJyZXIoKSBjb25zdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKaW5kZXggZTVmNDcwNjJjODNlZjczYzUyOTI3MjczYzQwNTUyZDBkZDVhNDljNC4uOWY1OWQ4 ZWUyNWNkYTNlYWE2NzA3ZjQzNDZmNjI5YWNjODZmZGVlZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDgtMzEgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFtGZXRjaCBBUEldIFJlcXVlc3QgY29uc3RydWN0 aW9uIGZhaWx1cmUgc2hvdWxkIG5vdCBzZXQgImJvZHlVc2VkIgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxNDMyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gv YXBpL3JlcXVlc3QvcmVxdWVzdC1kaXN0dXJiZWQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHdl Yi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvcmVxdWVzdC9yZXF1ZXN0LWRpc3R1cmJlZC5odG1s OgorCiAyMDE2LTA4LTMwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBbRmV0Y2ggQVBJXSBCbG9iIG5vdCBmb3VuZCBVUkwgc2hvdWxkIHJlc3VsdCBpbiBhIG5l dHdvcmsgZXJyb3IKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvZmV0Y2gvYXBpL3JlcXVlc3QvcmVxdWVzdC1kaXN0dXJiZWQtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9h cGkvcmVxdWVzdC9yZXF1ZXN0LWRpc3R1cmJlZC1leHBlY3RlZC50eHQKaW5kZXggN2E0MGRkNmIx ZDMxMTk3YWFlNWIyMGRkOTFlNWIzNjNiNGIwYmE2YS4uOWY0OGRkYWUyMTFkZjQ4MTVlNTA0ZWM4 MDE4NGEyNTkwNTJkOGZiZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvcmVxdWVzdC9yZXF1ZXN0LWRpc3R1cmJlZC1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9mZXRjaC9hcGkvcmVxdWVzdC9yZXF1ZXN0LWRpc3R1cmJlZC1leHBlY3RlZC50eHQKQEAgLTQs NCArNCw1IEBAIFBBU1MgQ2hlY2sgY2xvbmluZyBhIGRpc3R1cmJlZCByZXF1ZXN0CiBQQVNTIENo ZWNrIGNyZWF0aW5nIGEgbmV3IHJlcXVlc3QgZnJvbSBhIGRpc3R1cmJlZCByZXF1ZXN0IAogUEFT UyBJbnB1dCByZXF1ZXN0IHVzZWQgZm9yIGNyZWF0aW5nIG5ldyByZXF1ZXN0IGJlY2FtZSBkaXN0 dXJiZWQgCiBQQVNTIENoZWNrIGNvbnN1bWluZyBhIGRpc3R1cmJlZCByZXF1ZXN0IAorUEFTUyBS ZXF1ZXN0IGNvbnN0cnVjdGlvbiBmYWlsdXJlIHNob3VsZCBub3Qgc2V0ICJib2R5VXNlZCIgCiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv ZmV0Y2gvYXBpL3JlcXVlc3QvcmVxdWVzdC1kaXN0dXJiZWQuaHRtbCBiL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL3JlcXVlc3QvcmVxdWVzdC1k aXN0dXJiZWQuaHRtbAppbmRleCA5NThkZWY0MTc2OGI3ZmNkY2MzNjQyZGZhZGY3M2Y0NDE0YTQ1 YjljLi5mYTlkYjVmYmQ1NGFiNTZiNWJiODkzMTMwYWI1NzRlMGM4ZWFmMmUwIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9y ZXF1ZXN0L3JlcXVlc3QtZGlzdHVyYmVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvcmVxdWVzdC9yZXF1ZXN0LWRpc3R1cmJl ZC5odG1sCkBAIC01MCw2ICs1MCwzMCBAQAogICAgICAgICBhc3NlcnRfdHJ1ZShib2R5Q29uc3Vt ZWQuYm9keVVzZWQgLCAiYm9keVVzZWQgaXMgdHJ1ZSB3aGVuIHJlcXVlc3QgaXMgZGlzdHVyYmVk Iik7CiAgICAgICAgIHJldHVybiBwcm9taXNlX3JlamVjdHModGVzdCwgbmV3IFR5cGVFcnJvcigp LCBib2R5Q29uc3VtZWQuYmxvYigpKTsKICAgICAgIH0sICJDaGVjayBjb25zdW1pbmcgYSBkaXN0 dXJiZWQgcmVxdWVzdCIpOworCisgICAgICB0ZXN0KGZ1bmN0aW9uKCkgeworICAgICAgICB2YXIg cmVxID0gbmV3IFJlcXVlc3QoVVJMLCB7bWV0aG9kOiAnUE9TVCcsIGJvZHk6ICdoZWxsbyd9KTsK KyAgICAgICAgYXNzZXJ0X2ZhbHNlKHJlcS5ib2R5VXNlZCwKKyAgICAgICAgICAgICAgICAgICAg ICdSZXF1ZXN0IHNob3VsZCBub3QgYmUgZmxhZ2dlZCBhcyB1c2VkIGlmIGl0IGhhcyBub3QgYmVl biAnICsKKyAgICAgICAgICAgICAgICAgICAgICdjb25zdW1lZC4nKTsKKyAgICAgICAgYXNzZXJ0 X3Rocm93cygKKyAgICAgICAgICB7bmFtZTogJ1R5cGVFcnJvcid9LAorICAgICAgICAgIGZ1bmN0 aW9uKCkgeyBuZXcgUmVxdWVzdChyZXEsIHttZXRob2Q6ICdHRVQnfSk7IH0sCisgICAgICAgICAg J0EgZ2V0IHJlcXVlc3QgbWF5IG5vdCBoYXZlIGJvZHkuJyk7CisKKyAgICAgICAgYXNzZXJ0X2Zh bHNlKHJlcS5ib2R5VXNlZCwgJ0FmdGVyIHRoZSBHRVQgY2FzZScpOworCisgICAgICAgIGFzc2Vy dF90aHJvd3MoCisgICAgICAgICAge25hbWU6ICdUeXBlRXJyb3InfSwKKyAgICAgICAgICBmdW5j dGlvbigpIHsgbmV3IFJlcXVlc3QocmVxLCB7bWV0aG9kOiAnQ09OTkVDVCd9KTsgfSwKKyAgICAg ICAgICAnUmVxdWVzdCgpIHdpdGggYSBmb3JiaWRkZW4gbWV0aG9kIG11c3QgdGhyb3cuJyk7CisK KyAgICAgICAgYXNzZXJ0X2ZhbHNlKHJlcS5ib2R5VXNlZCwgJ0FmdGVyIHRoZSBmb3JiaWRkZW4g bWV0aG9kIGNhc2UnKTsKKworICAgICAgICB2YXIgcmVxMiA9IG5ldyBSZXF1ZXN0KHJlcSk7Cisg ICAgICAgIGFzc2VydF90cnVlKHJlcS5ib2R5VXNlZCwKKyAgICAgICAgICAgICAgICAgICAgJ1Jl cXVlc3Qgc2hvdWxkIGJlIGZsYWdnZWQgYXMgdXNlZCBpZiBpdCBoYXMgYmVlbiBjb25zdW1lZC4n KTsKKyAgICAgIH0sICdSZXF1ZXN0IGNvbnN0cnVjdGlvbiBmYWlsdXJlIHNob3VsZCBub3Qgc2V0 ICJib2R5VXNlZCInKTsKICAgICA8L3NjcmlwdD4KICAgPC9ib2R5PgogPC9odG1sPgo=