161418 2016-08-30 17:32:36 -0700 Web Inspector: Can't edit JS resource 2016-10-04 17:19:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED WONTFIX InRadar P2 Normal --- 1 nvasilyev hi bburg hi joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1224811 0 nvasilyev 2016-08-30 17:32:36 -0700 Steps: 1. Open http://nv.github.io/webkit-inspector-bugs/debugger-popover-indentation/ 2. Open index.js in Debugger or Resources tab. 3. Focus on the content view and type something. Expected: Typing works. Actual: Can't type. 1224812 1 webkit-bug-importer 2016-08-30 17:33:03 -0700 <rdar://problem/28087839> 1224821 2 joepeck 2016-08-30 18:27:16 -0700 Users should only be able to edit local (file:///) JavaScript resources. I don't think we've ever been able to edit arbitrary JavaScript resources. 1224833 3 hi 2016-08-30 18:56:48 -0700 (In reply to comment #2) > Users should only be able to edit local (file:///) JavaScript resources. I > don't think we've ever been able to edit arbitrary JavaScript resources. That's how I thought it worked ¯\_(ツ)_/¯ (ScriptContentView allows editing with "file" scheme URLs and TextResourceContentView allows editing with CSS files or "file" scheme URLS); I know that TextEditor defines its CodeMirror instance with "readOnly: true", and SourceCodeTextEditor doesn't seem to change that. 1224836 4 nvasilyev 2016-08-30 19:07:58 -0700 (In reply to comment #2) > Users should only be able to edit local (file:///) JavaScript resources. I > don't think we've ever been able to edit arbitrary JavaScript resources. I think we should change that. Most decently sized websites aren't developed using file scheme. Of the top of my head, there are two common use cases: 1. Local development server running on http://localhost:1234 or http://myapp.dev. 2. Remote development server with locally mounted partition (via SSHFS). 1224856 5 hi 2016-08-30 22:07:10 -0700 (In reply to comment #4) > (In reply to comment #2) > > Users should only be able to edit local (file:///) JavaScript resources. I > > don't think we've ever been able to edit arbitrary JavaScript resources. > > I think we should change that. Most decently sized websites aren't developed > using file scheme. Of the top of my head, there are two common use cases: > > 1. Local development server running on http://localhost:1234 or > http://myapp.dev. > 2. Remote development server with locally mounted partition (via SSHFS). I agree that local development could benefit from this, but what would editing the resource do (will the new code written ever be executable)? How about editing a non-local resource? How do we even distinguish whether the resource is local? 1224874 6 nvasilyev 2016-08-30 22:46:21 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > Users should only be able to edit local (file:///) JavaScript resources. I > > > don't think we've ever been able to edit arbitrary JavaScript resources. > > > > I think we should change that. Most decently sized websites aren't developed > > using file scheme. Of the top of my head, there are two common use cases: > > > > 1. Local development server running on http://localhost:1234 or > > http://myapp.dev. > > 2. Remote development server with locally mounted partition (via SSHFS). > > I agree that local development could benefit from this, but what would > editing the resource do (will the new code written ever be executable)? > How about editing a non-local resource? Exactly the same thing as for local resource — just save it. We currently don't re-execute JavaScript when saving. > How do we even distinguish whether the > resource is local? I don't think it's possible. I want Command-S to always show a dialog to save a file, that's all. 1224882 7 287491 hi 2016-08-30 23:17:44 -0700 Created attachment 287491 Patch 1225125 8 nvasilyev 2016-08-31 15:44:46 -0700 (In reply to comment #7) > Created attachment 287491 [details] > Patch I just realized that if we're making non-local JS editable, we should do the same for HTML, or any text resource, too. I don't think we should have anything special about the file protocol. There are issues with managing edited HTML and JS, but they aren't specific to the file protocol. For example: foo.js: 1. window.addEventListener("click", function() { 2. console.log("click") 3. }) If we set a breakpoint on line 2 and then delete lines 1-3, this breakpoint will be still active and it will trigger on click. This is, however, a separate issue and it has nothing to do with the file protocol. 1225481 9 bburg 2016-09-01 13:01:40 -0700 I am not convinced there is any point allowing to edit the JS if we aren't going to re-execute it or save it to a local filesystem. 1225514 10 nvasilyev 2016-09-01 14:01:21 -0700 (In reply to comment #9) > I am not convinced there is any point allowing to edit the JS if we aren't > going to re-execute it or save it to a local filesystem. Please read my point in comment #4: > ... > Most decently sized websites aren't developed > using file scheme. Of the top of my head, there are two common use cases: > > 1. Local development server running on http://localhost:1234 or > http://myapp.dev. > 2. Remote development server with locally mounted partition (via SSHFS). In these two cases, it makes sense to allow editing JS. The use case is: 1. Make some JS changes in Web Inspector on http://myapp.dev. 2. Reload the page. 3. See http://myapp.dev with updated JS. 1225531 11 287491 joepeck 2016-09-01 14:17:28 -0700 Comment on attachment 287491 Patch We should discuss and decide an editing policy that makes the most sense. I don't think arbitrarily editing JavaScript/HTML that never gets run on a page, and is lost when the page navigates / reloads, is the right approach. Based on comments so far, a far more useful and less confusing reason to make resources editable would be if we included the ability to then USE the Web Inspector modified contents to override the next network request for the resource. Then scenarios like editing + reloading could work, and debugging scenarios where you just want to test a quick fix ("what if I changed this HTML / JS Function"). In any case, this needs a more thought out policy. 1236471 12 mattbaker 2016-10-04 17:19:16 -0700 (In reply to comment #11) > Comment on attachment 287491 [details] > Patch > > We should discuss and decide an editing policy that makes the most sense. I > don't think arbitrarily editing JavaScript/HTML that never gets run on a > page, and is lost when the page navigates / reloads, is the right approach. > > Based on comments so far, a far more useful and less confusing reason to > make resources editable would be if we included the ability to then USE the > Web Inspector modified contents to override the next network request for the > resource. Then scenarios like editing + reloading could work, and debugging > scenarios where you just want to test a quick fix ("what if I changed this > HTML / JS Function"). > > In any case, this needs a more thought out policy. Closing for now. This needs further consideration. 287491 2016-08-30 23:17:44 -0700 2016-09-01 14:17:28 -0700 Patch bug-161418-20160830231531.patch text/plain 5857 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE5YWQyYjc0ZGRiOGU3NjIyMmIyZTBmZDZkZDdm YWE2MGU0YjYwZjAuLjQ1YjY5ZTQwMjA0ZGUwN2U0YmUyMTI5YTM1YTVmN2M5ZmU4Yjk3OTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA4LTMwICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENhbid0IGVkaXQgSlMgcmVzb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTQxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRDb250ZW50 Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRDb250ZW50Vmlldyk6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0Q29udGVudFZpZXcucHJvdG90eXBlLl9jb250ZW50V2ls bFBvcHVsYXRlKToKKyAgICAgICAgTW92ZWQgc2V0dGluZyBvZiByZWFkT25seSB0byBjb25zdHJ1 Y3RvciBzaW5jZSBlZGl0aW5nIG9mIEpTIHJlc291cmNlcyBpcyBub3cgYWxsb3dlZC4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGV4dFJlc291cmNlQ29udGVudFZpZXcuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dFJlc291cmNlQ29udGVudFZpZXcucHJvdG90eXBlLl9j b250ZW50V2lsbFBvcHVsYXRlKToKKyAgICAgICAgQWRkIGFkZGl0aW9uYWwgY2FzZSBmb3Igc2V0 dGluZyByZWFkT25seSB0byBmYWxzZSB3aGVuIHRoZSByZXNvdXJjZSBpcyBKYXZhU2NyaXB0IGNv ZGUuCisKIDIwMTYtMDgtMzAgIEpvaGFuIEsuIEplbnNlbiAgPGpvaGFuX2plbnNlbkBhcHBsZS5j b20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIHJlc291cmNlIHRpbWluZyBtb2RlbCB3 aXRoIHRpbWluZyBpbmZvcm1hdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRDb250ZW50Vmlldy5qcwppbmRleCAx NTAwMjc5MjI1ZTk0MmNlYzk2MmMxZjdkODY4NTUzZDQzYTdkOGQwLi5kY2E4MTAxYzJlMDQyNzRk MGEwMjY3YmI3NWRkNTgzZDQxMmVkNDViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRDb250ZW50Vmlldy5qcwpA QCAtMzQsNyArMzQsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0Q29udGVudFZpZXcgPSBjbGFzcyBT Y3JpcHRDb250ZW50VmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5DbwogICAgICAgICB0aGlzLmVs ZW1lbnQuY2xhc3NMaXN0LmFkZCgic2NyaXB0Iik7CiAKICAgICAgICAgLy8gQXBwZW5kIGEgc3Bp bm5lciB3aGlsZSB3YWl0aW5nIGZvciBfY29udGVudFdpbGxQb3B1bGF0ZS4KLSAgICAgICAgdmFy IHNwaW5uZXIgPSBuZXcgV2ViSW5zcGVjdG9yLkluZGV0ZXJtaW5hdGVQcm9ncmVzc1NwaW5uZXI7 CisgICAgICAgIGxldCBzcGlubmVyID0gbmV3IFdlYkluc3BlY3Rvci5JbmRldGVybWluYXRlUHJv Z3Jlc3NTcGlubmVyOwogICAgICAgICB0aGlzLmVsZW1lbnQuYXBwZW5kQ2hpbGQoc3Bpbm5lci5l bGVtZW50KTsKIAogICAgICAgICB0aGlzLl9zY3JpcHQgPSBzY3JpcHQ7CkBAIC00NiwyMCArNDYs MjEgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdENvbnRlbnRWaWV3ID0gY2xhc3MgU2NyaXB0Q29udGVu dFZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuQ28KICAgICAgICAgY29uc29sZS5hc3NlcnQoc2Ny aXB0LnJhbmdlLnN0YXJ0Q29sdW1uID09PSAwKTsKIAogICAgICAgICB0aGlzLl90ZXh0RWRpdG9y ID0gbmV3IFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvcihzY3JpcHQpOworICAgICAg ICB0aGlzLl90ZXh0RWRpdG9yLnJlYWRPbmx5ID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX3RleHRF ZGl0b3IuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5FdmVudC5FeGVj dXRpb25MaW5lTnVtYmVyRGlkQ2hhbmdlLCB0aGlzLl9leGVjdXRpb25MaW5lTnVtYmVyRGlkQ2hh bmdlLCB0aGlzKTsKICAgICAgICAgdGhpcy5fdGV4dEVkaXRvci5hZGRFdmVudExpc3RlbmVyKFdl Ykluc3BlY3Rvci5UZXh0RWRpdG9yLkV2ZW50Lk51bWJlck9mU2VhcmNoUmVzdWx0c0RpZENoYW5n ZSwgdGhpcy5fbnVtYmVyT2ZTZWFyY2hSZXN1bHRzRGlkQ2hhbmdlLCB0aGlzKTsKICAgICAgICAg dGhpcy5fdGV4dEVkaXRvci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y LkV2ZW50LkZvcm1hdHRpbmdEaWRDaGFuZ2UsIHRoaXMuX3RleHRFZGl0b3JGb3JtYXR0aW5nRGlk Q2hhbmdlLCB0aGlzKTsKICAgICAgICAgdGhpcy5fdGV4dEVkaXRvci5hZGRFdmVudExpc3RlbmVy KFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvci5FdmVudC5Db250ZW50V2lsbFBvcHVs YXRlLCB0aGlzLl9jb250ZW50V2lsbFBvcHVsYXRlLCB0aGlzKTsKICAgICAgICAgdGhpcy5fdGV4 dEVkaXRvci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRv ci5FdmVudC5Db250ZW50RGlkUG9wdWxhdGUsIHRoaXMuX2NvbnRlbnREaWRQb3B1bGF0ZSwgdGhp cyk7CiAKLSAgICAgICAgdmFyIHRvb2xUaXAgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlByZXR0 eSBwcmludCIpOwotICAgICAgICB2YXIgYWN0aXZhdGVkVG9vbFRpcCA9IFdlYkluc3BlY3Rvci5V SVN0cmluZygiT3JpZ2luYWwgZm9ybWF0dGluZyIpOworICAgICAgICBjb25zdCB0b29sVGlwID0g V2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJQcmV0dHkgcHJpbnQiKTsKKyAgICAgICAgY29uc3QgYWN0 aXZhdGVkVG9vbFRpcCA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiT3JpZ2luYWwgZm9ybWF0dGlu ZyIpOwogICAgICAgICB0aGlzLl9wcmV0dHlQcmludEJ1dHRvbk5hdmlnYXRpb25JdGVtID0gbmV3 IFdlYkluc3BlY3Rvci5BY3RpdmF0ZUJ1dHRvbk5hdmlnYXRpb25JdGVtKCJwcmV0dHktcHJpbnQi LCB0b29sVGlwLCBhY3RpdmF0ZWRUb29sVGlwLCAiSW1hZ2VzL05hdmlnYXRpb25JdGVtQ3VybGV5 QnJhY2VzLnN2ZyIsIDEzLCAxMyk7CiAgICAgICAgIHRoaXMuX3ByZXR0eVByaW50QnV0dG9uTmF2 aWdhdGlvbkl0ZW0uYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuQnV0dG9uTmF2aWdhdGlv bkl0ZW0uRXZlbnQuQ2xpY2tlZCwgdGhpcy5fdG9nZ2xlUHJldHR5UHJpbnQsIHRoaXMpOwogICAg ICAgICB0aGlzLl9wcmV0dHlQcmludEJ1dHRvbk5hdmlnYXRpb25JdGVtLmVuYWJsZWQgPSBmYWxz ZTsgLy8gRW5hYmxlZCB3aGVuIHRoZSB0ZXh0IGVkaXRvciBpcyBwb3B1bGF0ZWQgd2l0aCBjb250 ZW50LgogCi0gICAgICAgIHZhciB0b29sVGlwVHlwZXMgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmco IlNob3cgdHlwZSBpbmZvcm1hdGlvbiIpOwotICAgICAgICB2YXIgYWN0aXZhdGVkVG9vbFRpcFR5 cGVzID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJIaWRlIHR5cGUgaW5mb3JtYXRpb24iKTsKKyAg ICAgICAgY29uc3QgdG9vbFRpcFR5cGVzID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTaG93IHR5 cGUgaW5mb3JtYXRpb24iKTsKKyAgICAgICAgY29uc3QgYWN0aXZhdGVkVG9vbFRpcFR5cGVzID0g V2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJIaWRlIHR5cGUgaW5mb3JtYXRpb24iKTsKICAgICAgICAg dGhpcy5fc2hvd1R5cGVzQnV0dG9uTmF2aWdhdGlvbkl0ZW0gPSBuZXcgV2ViSW5zcGVjdG9yLkFj dGl2YXRlQnV0dG9uTmF2aWdhdGlvbkl0ZW0oInNob3ctdHlwZXMiLCB0b29sVGlwVHlwZXMsIGFj dGl2YXRlZFRvb2xUaXBUeXBlcywgIkltYWdlcy9OYXZpZ2F0aW9uSXRlbVR5cGVzLnN2ZyIsIDEz LCAxNCk7CiAgICAgICAgIHRoaXMuX3Nob3dUeXBlc0J1dHRvbk5hdmlnYXRpb25JdGVtLmFkZEV2 ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkJ1dHRvbk5hdmlnYXRpb25JdGVtLkV2ZW50LkNsaWNr ZWQsIHRoaXMuX3RvZ2dsZVR5cGVBbm5vdGF0aW9ucywgdGhpcyk7CiAgICAgICAgIHRoaXMuX3No b3dUeXBlc0J1dHRvbk5hdmlnYXRpb25JdGVtLmVuYWJsZWQgPSBmYWxzZTsKQEAgLTE5MSwxMCAr MTkyLDYgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdENvbnRlbnRWaWV3ID0gY2xhc3MgU2NyaXB0Q29u dGVudFZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuQ28KICAgICAgICAgaWYgKHRoaXMuX3RleHRF ZGl0b3IuZWxlbWVudC5wYXJlbnROb2RlID09PSB0aGlzLmVsZW1lbnQpCiAgICAgICAgICAgICBy ZXR1cm47CiAKLSAgICAgICAgLy8gQWxsb3cgZWRpdGluZyBhbnkgbG9jYWwgZmlsZSBzaW5jZSBl ZGl0cyBjYW4gYmUgc2F2ZWQgYW5kIHJlbG9hZGVkIHJpZ2h0IGZyb20gdGhlIEluc3BlY3Rvci4K LSAgICAgICAgaWYgKHRoaXMuX3NjcmlwdC51cmxDb21wb25lbnRzLnNjaGVtZSA9PT0gImZpbGUi KQotICAgICAgICAgICAgdGhpcy5fdGV4dEVkaXRvci5yZWFkT25seSA9IGZhbHNlOwotCiAgICAg ICAgIHRoaXMuZWxlbWVudC5yZW1vdmVDaGlsZHJlbigpOwogICAgICAgICB0aGlzLmFkZFN1YnZp ZXcodGhpcy5fdGV4dEVkaXRvcik7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dFJlc291cmNlQ29udGVudFZpZXcuanMgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0UmVzb3VyY2VDb250 ZW50Vmlldy5qcwppbmRleCAyYTZjOGI5NTA4ZGQ1MDQ0NWY3OWE1N2YyN2MyODM2NTc2ZTQ4OTZj Li4yZTYxY2FmM2Y1N2EwNmE2MjI0Nzg4MmUyMzQyYmYzOTE4NjYxNzUzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0UmVzb3VyY2VDb250 ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UZXh0UmVzb3VyY2VDb250ZW50Vmlldy5qcwpAQCAtMTgxLDYgKzE4MSw5IEBAIFdlYkluc3Bl Y3Rvci5UZXh0UmVzb3VyY2VDb250ZW50VmlldyA9IGNsYXNzIFRleHRSZXNvdXJjZUNvbnRlbnRW aWV3IGV4dGVuZHMgV2ViCiAgICAgICAgIGlmICh0aGlzLl90ZXh0RWRpdG9yLnBhcmVudFZpZXcg PT09IHRoaXMpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgaWYgKHRoaXMucmVzb3Vy Y2UudHlwZSA9PT0gV2ViSW5zcGVjdG9yLlJlc291cmNlLlR5cGUuU2NyaXB0KQorICAgICAgICAg ICAgdGhpcy5fdGV4dEVkaXRvci5yZWFkT25seSA9IGZhbHNlOworCiAgICAgICAgIC8vIENoZWNr IHRoZSBNSU1FLXR5cGUgZm9yIENTUyBzaW5jZSBSZXNvdXJjZS5UeXBlLlN0eWxlc2hlZXQgYWxz byBpbmNsdWRlcyBYU0wsIHdoaWNoIHdlIGNhbid0IGVkaXQgeWV0LgogICAgICAgICBpZiAodGhp cy5yZXNvdXJjZS50eXBlID09PSBXZWJJbnNwZWN0b3IuUmVzb3VyY2UuVHlwZS5TdHlsZXNoZWV0 ICYmIHRoaXMucmVzb3VyY2Uuc3ludGhldGljTUlNRVR5cGUgPT09ICJ0ZXh0L2NzcyIpCiAgICAg ICAgICAgICB0aGlzLl90ZXh0RWRpdG9yLnJlYWRPbmx5ID0gZmFsc2U7Cg==