161394 2016-08-30 11:19:49 -0700 AX: WKWebView for macOS does not allow configuration of tabsToLinks 2016-09-12 14:44:42 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Mac OS X 10.11 RESOLVED FIXED InRadar P2 Normal --- 1 dsaunders45459 webkit-unassigned andersca bburg commit-queue darin dasau mitz sam webkit-bug-importer oldest_to_newest 1224632 0 dsaunders45459 2016-08-30 11:19:49 -0700 WebView allows setting [WebPreferences setTabsToLinks:] to allow the tab key to navigate between links in the web page. WKWebView does not expose this preference, which is an accessibility bug to us. To the end user interacting with the embedded browser, they are not aware they need to press options + tab to be able to access the link through keyboard. They expect the tab key which navigate between other cocoa controls in the window to navigate to the DOM elements that accept keyboard focus. Safari allows setTabsToLinks as a configurable setting, but the WKWebView control provided does not share this setting with Safari and no way to configure it through our code creating a WKWebView instance. 1224636 1 webkit-bug-importer 2016-08-30 11:20:25 -0700 <rdar://problem/28078982> 1224825 2 287469 dasau 2016-08-30 18:40:12 -0700 Created attachment 287469 Patch 1224983 3 287469 andersca 2016-08-31 10:01:34 -0700 Comment on attachment 287469 Patch We have to figure out whether this is something we want to expose on WKPreferences or not - it could either be a WKWebViewConfiguration property or a WKWebView property. 1226761 4 dasau 2016-09-06 11:21:41 -0700 I think this is more of a preference than a WKWebView property. The same property is available in WebPreferences for WebView control, so it makes sense to me to add in WKPreferences. Most of the properties on WKWebView change their state based on the web page contents loaded in the control, which is not the case with tabsToLinks. There is not a WKWebViewConfiguration equivalent of WebView to base the location on (some properties on WebPreferences for WebView have moved to WKWebViewConfiguration), but you also find this option as a preference in Safari. The user may want to configure it based on the WKWebView application. 1226770 5 andersca 2016-09-06 11:40:37 -0700 (In reply to comment #4) > I think this is more of a preference than a WKWebView property. The same > property is available in WebPreferences for WebView control, so it makes > sense to me to add in WKPreferences. Most of the properties on WKWebView > change their state based on the web page contents loaded in the control, > which is not the case with tabsToLinks. There is not a > WKWebViewConfiguration equivalent of WebView to base the location on (some > properties on WebPreferences for WebView have moved to > WKWebViewConfiguration), but you also find this option as a preference in > Safari. The user may want to configure it based on the WKWebView application. After talking to some of my fellow colleagues, I tend to agree - WKPreferences is intended to be used for "things you might want to show in a preferences window", and "tabs to links" is one of the Safari preferences. That said, I think we can come up with a better name than "tabsToLinks". It sounds like it converts tabs into links. 1226774 6 dasau 2016-09-06 11:55:48 -0700 (In reply to comment #5) > (In reply to comment #4) > > I think this is more of a preference than a WKWebView property. The same > > property is available in WebPreferences for WebView control, so it makes > > sense to me to add in WKPreferences. Most of the properties on WKWebView > > change their state based on the web page contents loaded in the control, > > which is not the case with tabsToLinks. There is not a > > WKWebViewConfiguration equivalent of WebView to base the location on (some > > properties on WebPreferences for WebView have moved to > > WKWebViewConfiguration), but you also find this option as a preference in > > Safari. The user may want to configure it based on the WKWebView application. > > After talking to some of my fellow colleagues, I tend to agree - > WKPreferences is intended to be used for "things you might want to show in a > preferences window", and "tabs to links" is one of the Safari preferences. > > That said, I think we can come up with a better name than "tabsToLinks". It > sounds like it converts tabs into links. I was keeping consistency with what is exposed in WebPreferences. Have there been other name changes between WebView and WKWebView for similar properties? I could call it tabNavigatesToLinks or linkTabStopEnabled 1228393 7 bburg 2016-09-09 17:05:36 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > I think this is more of a preference than a WKWebView property. The same > > > property is available in WebPreferences for WebView control, so it makes > > > sense to me to add in WKPreferences. Most of the properties on WKWebView > > > change their state based on the web page contents loaded in the control, > > > which is not the case with tabsToLinks. There is not a > > > WKWebViewConfiguration equivalent of WebView to base the location on (some > > > properties on WebPreferences for WebView have moved to > > > WKWebViewConfiguration), but you also find this option as a preference in > > > Safari. The user may want to configure it based on the WKWebView application. > > > > After talking to some of my fellow colleagues, I tend to agree - > > WKPreferences is intended to be used for "things you might want to show in a > > preferences window", and "tabs to links" is one of the Safari preferences. > > > > That said, I think we can come up with a better name than "tabsToLinks". It > > sounds like it converts tabs into links. > > > I was keeping consistency with what is exposed in WebPreferences. Have there > been other name changes between WebView and WKWebView for similar > properties? I could call it tabNavigatesToLinks or linkTabStopEnabled tabNavigatesToLinks sounds better to me. Anders, is there anything else holding up review of this patch aside from the renaming? 1228394 8 287469 bburg 2016-09-09 17:05:58 -0700 Comment on attachment 287469 Patch Please rename tabsToLinks to tabNavigatesToLinks. 1228547 9 288503 dasau 2016-09-10 15:16:38 -0700 Created attachment 288503 Patch 1228832 10 288503 andersca 2016-09-12 11:47:55 -0700 Comment on attachment 288503 Patch After discussing the name some more, we feel that "tabFocusesLinks" better explains what this preference does - navigates sounds like it will actually navigate to the webpage that the link points to. Everything else looks great though, so please rename the property and we'll get it landed. 1228895 11 288610 dasau 2016-09-12 14:20:16 -0700 Created attachment 288610 Patch 1228904 12 288610 commit-queue 2016-09-12 14:44:36 -0700 Comment on attachment 288610 Patch Clearing flags on attachment: 288610 Committed r205825: <http://trac.webkit.org/changeset/205825> 1228906 13 commit-queue 2016-09-12 14:44:42 -0700 All reviewed patches have been landed. Closing bug. 287469 2016-08-30 18:40:12 -0700 2016-09-10 15:16:35 -0700 Patch bug-161394-20160830183800.patch text/plain 4067 dasau SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTE2NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA4LTMwICBEQU4gU0FV TkRFUlMgIDxkYXNhdUBtaWNyb3NvZnQuY29tPgorCisgICAgICAgIEFYOiBXS1dlYlZpZXcgZm9y IG1hY09TIGRvZXMgbm90IGFsbG93IGNvbmZpZ3VyYXRpb24gb2YgdGFic1RvTGlua3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTM5NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1ByZWZlcmVuY2VzLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1ByZWZlcmVuY2VzLm1tOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIGVuY29kZVdpdGhDb2Rl cjpdKToKKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBpbml0V2l0aENvZGVyOl0pOgorICAgICAg ICAoLVtXS1ByZWZlcmVuY2VzIHRhYnNUb0xpbmtzXSk6CisgICAgICAgICgtW1dLUHJlZmVyZW5j ZXMgc2V0VGFic1RvTGlua3M6XSk6CisKIDIwMTYtMDgtMjkgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIENoaWxkUHJvY2Vzc1Byb3h5 Ojpmcm9tQ29ubmVjdGlvbgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1ByZWZlcmVuY2VzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgJKHJldmlzaW9uIDIwNTE2NikKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5oCSh3b3JraW5nIGNvcHkp CkBAIC02Myw2ICs2MywxMyBAQCBXS19DTEFTU19BVkFJTEFCTEUobWFjb3N4KDEwLjEwKSwgaW9z KDguCiAgQGRpc2N1c3Npb24gVGhlIGRlZmF1bHQgdmFsdWUgaXMgTk8uCiAgKi8KIEBwcm9wZXJ0 eSAobm9uYXRvbWljKSBCT09MIHBsdWdJbnNFbmFibGVkOworCisvKiEKKyBAcHJvcGVydHkgdGFi c1RvTGlua3MKKyBAYWJzdHJhY3QgSWYgdGFic1RvTGlua3MgaXMgWUVTLCB0aGUgdGFiIGtleSB3 aWxsIGZvY3VzIGxpbmtzIGFuZCBmb3JtIGNvbnRyb2xzLgorIFRoZSBvcHRpb24ga2V5IHRlbXBv cmFyaWx5IHJldmVyc2VzIHRoaXMgcHJlZmVyZW5jZS4KKyAqLworQHByb3BlcnR5IChub25hdG9t aWMpIEJPT0wgdGFic1RvTGlua3MgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSkp OwogI2VuZGlmCiAKIEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tQcmVmZXJlbmNlcy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0JKHJldmlzaW9uIDIwNTE2NikKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQkod29ya2luZyBj b3B5KQpAQCAtNjYsNiArNjYsNyBAQCAtICh2b2lkKWVuY29kZVdpdGhDb2RlcjooTlNDb2RlciAq KWNvZGVyCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIFtjb2RlciBlbmNvZGVCb29sOnNlbGYuamF2 YUVuYWJsZWQgZm9yS2V5OkAiamF2YUVuYWJsZWQiXTsKICAgICBbY29kZXIgZW5jb2RlQm9vbDpz ZWxmLnBsdWdJbnNFbmFibGVkIGZvcktleTpAInBsdWdJbnNFbmFibGVkIl07CisgICAgW2NvZGVy IGVuY29kZUJvb2w6c2VsZi50YWJzVG9MaW5rcyBmb3JLZXk6QCJ0YWJzVG9MaW5rcyJdOwogI2Vu ZGlmCiB9CiAKQEAgLTgxLDYgKzgyLDcgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoQ29kZXI6 KE5TQ29kZXIgKgogI2lmIFBMQVRGT1JNKE1BQykKICAgICBzZWxmLmphdmFFbmFibGVkID0gW2Nv ZGVyIGRlY29kZUJvb2xGb3JLZXk6QCJqYXZhRW5hYmxlZCJdOwogICAgIHNlbGYucGx1Z0luc0Vu YWJsZWQgPSBbY29kZXIgZGVjb2RlQm9vbEZvcktleTpAInBsdWdJbnNFbmFibGVkIl07CisgICAg c2VsZi50YWJzVG9MaW5rcyA9IFtjb2RlciBkZWNvZGVCb29sRm9yS2V5OkAidGFic1RvTGlua3Mi XTsKICNlbmRpZgogCiAgICAgcmV0dXJuIHNlbGY7CkBAIC0xNDAsNiArMTQyLDE2IEBAIC0gKHZv aWQpc2V0UGx1Z0luc0VuYWJsZWQ6KEJPT0wpcGx1Z0luc0UKICAgICBfcHJlZmVyZW5jZXMtPnNl dFBsdWdpbnNFbmFibGVkKHBsdWdJbnNFbmFibGVkKTsKIH0KIAorLSAoQk9PTCl0YWJzVG9MaW5r cworeworICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPnRhYnNUb0xpbmtzKCk7Cit9CisKKy0gKHZv aWQpc2V0VGFic1RvTGlua3M6KEJPT0wpdGFic1RvTGlua3MKK3sKKyAgICBfcHJlZmVyZW5jZXMt PnNldFRhYnNUb0xpbmtzKHRhYnNUb0xpbmtzKTsKK30KKwogI2VuZGlmCiAKICNwcmFnbWEgbWFy ayBXS09iamVjdCBwcm90b2NvbCBpbXBsZW1lbnRhdGlvbgpJbmRleDogVG9vbHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjA1MjE0KQorKysgVG9v bHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDgtMzAg IERBTiBTQVVOREVSUyAgPGRhc2F1QG1pY3Jvc29mdC5jb20+CisKKyAgICAgICAgQVg6IFdLV2Vi VmlldyBmb3IgbWFjT1MgZG9lcyBub3QgYWxsb3cgY29uZmlndXJhdGlvbiBvZiB0YWJzVG9MaW5r cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMzk0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9Db2RpbmcubW06CisgICAgICAgIChURVNUKToK KwogMjAxNi0wOC0zMCAgUmlja3kgTW9uZGVsbG8gIDxybW9uZGVsbG9AYXBwbGUuY29tPgogCiAg ICAgICAgIFlvdVR1YmVQbHVnaW5SZXBsYWNlbWVudFRlc3QncyBVUkwgdHJhbnNmb3JtYXRpb24g bG9naWMgc2hvdWxkIGhhdmUgdGVzdHMKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0MkNvY29hL0NvZGluZy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdDJDb2NvYS9Db2RpbmcubW0JKHJldmlzaW9uIDIwNTE2NikKKysrIFRvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL0NvZGluZy5tbQkod29ya2luZyBjb3B5 KQpAQCAtNTEsNiArNTEsNyBAQCBURVNUKENvZGluZywgV0tQcmVmZXJlbmNlcykKICAgICBbYSBz ZXRKYXZhU2NyaXB0Q2FuT3BlbldpbmRvd3NBdXRvbWF0aWNhbGx5Ok5PXTsKICAgICBbYSBzZXRK YXZhRW5hYmxlZDpZRVNdOwogICAgIFthIHNldFBsdWdJbnNFbmFibGVkOllFU107CisgICAgW2Eg c2V0VGFic1RvTGlua3M6WUVTXTsKICNlbmRpZgogCiAgICAgYXV0byBiID0gZW5jb2RlQW5kRGVj b2RlKGEuZ2V0KCkpOwpAQCAtNjIsNiArNjMsNyBAQCBURVNUKENvZGluZywgV0tQcmVmZXJlbmNl cykKICNpZiBQTEFURk9STShNQUMpCiAgICAgRVhQRUNUX0VRKFthIGphdmFFbmFibGVkXSwgW2Ig amF2YUVuYWJsZWRdKTsKICAgICBFWFBFQ1RfRVEoW2EgcGx1Z0luc0VuYWJsZWRdLCBbYiBwbHVn SW5zRW5hYmxlZF0pOworICAgIEVYUEVDVF9FUShbYSB0YWJzVG9MaW5rc10sIFtiIHRhYnNUb0xp bmtzXSk7CiAjZW5kaWYKIH0KIAo= 288503 2016-09-10 15:16:38 -0700 2016-09-12 14:20:13 -0700 Patch bug-161394-20160910151409.patch text/plain 4215 dasau SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTc4NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA5LTEwICBEQU4gU0FV TkRFUlMgIDxkYXNhdUBtaWNyb3NvZnQuY29tPgorCisgICAgICAgIEFYOiBXS1dlYlZpZXcgZm9y IG1hY09TIGRvZXMgbm90IGFsbG93IGNvbmZpZ3VyYXRpb24gb2YgdGFic1RvTGlua3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTM5NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1ByZWZlcmVuY2VzLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1ByZWZlcmVuY2VzLm1tOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIGVuY29kZVdpdGhDb2Rl cjpdKToKKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBpbml0V2l0aENvZGVyOl0pOgorICAgICAg ICAoLVtXS1ByZWZlcmVuY2VzIHRhYk5hdmlnYXRlc1RvTGlua3NdKToKKyAgICAgICAgKC1bV0tQ cmVmZXJlbmNlcyBzZXRUYWJOYXZpZ2F0ZXNUb0xpbmtzOl0pOgorCiAyMDE2LTA5LTA5ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFdLVGh1bWJuYWls VmlldyBzaG91bGQgZXhwb3NlIGEgbW9kZSB3aGVyZSBpdCBjYW4gYmUgcmVwYXJlbnRlZCB3aXRo b3V0IHJlc25hcHNob3R0aW5nCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLUHJlZmVyZW5jZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMuaAkocmV2aXNpb24gMjA1Nzg3KQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLmgJKHdvcmtpbmcgY29w eSkKQEAgLTYzLDYgKzYzLDEzIEBAIFdLX0NMQVNTX0FWQUlMQUJMRShtYWNvc3goMTAuMTApLCBp b3MoOC4KICBAZGlzY3Vzc2lvbiBUaGUgZGVmYXVsdCB2YWx1ZSBpcyBOTy4KICAqLwogQHByb3Bl cnR5IChub25hdG9taWMpIEJPT0wgcGx1Z0luc0VuYWJsZWQ7CisKKy8qIQorIEBwcm9wZXJ0eSB0 YWJOYXZpZ2F0ZXNUb0xpbmtzCisgQGFic3RyYWN0IElmIHRhYk5hdmlnYXRlc1RvTGlua3MgaXMg WUVTLCB0aGUgdGFiIGtleSB3aWxsIGZvY3VzIGxpbmtzIGFuZCBmb3JtIGNvbnRyb2xzLgorIFRo ZSBvcHRpb24ga2V5IHRlbXBvcmFyaWx5IHJldmVyc2VzIHRoaXMgcHJlZmVyZW5jZS4KKyAqLwor QHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgdGFiTmF2aWdhdGVzVG9MaW5rcyBXS19BUElfQVZB SUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSk7CiAjZW5kaWYKIAogQGVuZApJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQko cmV2aXNpb24gMjA1Nzg3KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1ByZWZlcmVuY2VzLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02Niw2ICs2Niw3IEBAIC0gKHZvaWQp ZW5jb2RlV2l0aENvZGVyOihOU0NvZGVyICopY29kZXIKICNpZiBQTEFURk9STShNQUMpCiAgICAg W2NvZGVyIGVuY29kZUJvb2w6c2VsZi5qYXZhRW5hYmxlZCBmb3JLZXk6QCJqYXZhRW5hYmxlZCJd OwogICAgIFtjb2RlciBlbmNvZGVCb29sOnNlbGYucGx1Z0luc0VuYWJsZWQgZm9yS2V5OkAicGx1 Z0luc0VuYWJsZWQiXTsKKyAgICBbY29kZXIgZW5jb2RlQm9vbDpzZWxmLnRhYk5hdmlnYXRlc1Rv TGlua3MgZm9yS2V5OkAidGFiTmF2aWdhdGVzVG9MaW5rcyJdOwogI2VuZGlmCiB9CiAKQEAgLTgx LDYgKzgyLDcgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoQ29kZXI6KE5TQ29kZXIgKgogI2lm IFBMQVRGT1JNKE1BQykKICAgICBzZWxmLmphdmFFbmFibGVkID0gW2NvZGVyIGRlY29kZUJvb2xG b3JLZXk6QCJqYXZhRW5hYmxlZCJdOwogICAgIHNlbGYucGx1Z0luc0VuYWJsZWQgPSBbY29kZXIg ZGVjb2RlQm9vbEZvcktleTpAInBsdWdJbnNFbmFibGVkIl07CisgICAgc2VsZi50YWJOYXZpZ2F0 ZXNUb0xpbmtzID0gW2NvZGVyIGRlY29kZUJvb2xGb3JLZXk6QCJ0YWJOYXZpZ2F0ZXNUb0xpbmtz Il07CiAjZW5kaWYKIAogICAgIHJldHVybiBzZWxmOwpAQCAtMTQwLDYgKzE0MiwxNiBAQCAtICh2 b2lkKXNldFBsdWdJbnNFbmFibGVkOihCT09MKXBsdWdJbnNFCiAgICAgX3ByZWZlcmVuY2VzLT5z ZXRQbHVnaW5zRW5hYmxlZChwbHVnSW5zRW5hYmxlZCk7CiB9CiAKKy0gKEJPT0wpdGFiTmF2aWdh dGVzVG9MaW5rcworeworICAgIHJldHVybiBfcHJlZmVyZW5jZXMtPnRhYnNUb0xpbmtzKCk7Cit9 CisKKy0gKHZvaWQpc2V0VGFiTmF2aWdhdGVzVG9MaW5rczooQk9PTCl0YWJOYXZpZ2F0ZXNUb0xp bmtzCit7CisgICAgX3ByZWZlcmVuY2VzLT5zZXRUYWJzVG9MaW5rcyh0YWJOYXZpZ2F0ZXNUb0xp bmtzKTsKK30KKwogI2VuZGlmCiAKICNwcmFnbWEgbWFyayBXS09iamVjdCBwcm90b2NvbCBpbXBs ZW1lbnRhdGlvbgpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0No YW5nZUxvZwkocmV2aXNpb24gMjA1Nzg3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDktMTAgIERBTiBTQVVOREVSUyAgPGRhc2F1QG1p Y3Jvc29mdC5jb20+CisKKyAgICAgICAgQVg6IFdLV2ViVmlldyBmb3IgbWFjT1MgZG9lcyBub3Qg YWxsb3cgY29uZmlndXJhdGlvbiBvZiB0YWJzVG9MaW5rcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMzk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJD b2NvYS9Db2RpbmcubW06CisgICAgICAgIChURVNUKToKKwogMjAxNi0wOS0xMCAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIHBhcnNlSFRNTEludGVnZXIoKSBzaG91 bGQgdGFrZSBhIFN0cmluZ1ZpZXcgaW4gcGFyYW1ldGVyCkluZGV4OiBUb29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9Db2RpbmcubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvQ29kaW5nLm1tCShyZXZpc2lvbiAyMDU3ODcp CisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9Db2RpbmcubW0JKHdv cmtpbmcgY29weSkKQEAgLTUxLDYgKzUxLDcgQEAgVEVTVChDb2RpbmcsIFdLUHJlZmVyZW5jZXMp CiAgICAgW2Egc2V0SmF2YVNjcmlwdENhbk9wZW5XaW5kb3dzQXV0b21hdGljYWxseTpOT107CiAg ICAgW2Egc2V0SmF2YUVuYWJsZWQ6WUVTXTsKICAgICBbYSBzZXRQbHVnSW5zRW5hYmxlZDpZRVNd OworICAgIFthIHNldFRhYk5hdmlnYXRlc1RvTGlua3M6WUVTXTsKICNlbmRpZgogCiAgICAgYXV0 byBiID0gZW5jb2RlQW5kRGVjb2RlKGEuZ2V0KCkpOwpAQCAtNjIsNiArNjMsNyBAQCBURVNUKENv ZGluZywgV0tQcmVmZXJlbmNlcykKICNpZiBQTEFURk9STShNQUMpCiAgICAgRVhQRUNUX0VRKFth IGphdmFFbmFibGVkXSwgW2IgamF2YUVuYWJsZWRdKTsKICAgICBFWFBFQ1RfRVEoW2EgcGx1Z0lu c0VuYWJsZWRdLCBbYiBwbHVnSW5zRW5hYmxlZF0pOworICAgIEVYUEVDVF9FUShbYSB0YWJOYXZp Z2F0ZXNUb0xpbmtzXSwgW2IgdGFiTmF2aWdhdGVzVG9MaW5rc10pOwogI2VuZGlmCiB9CiAK 288610 2016-09-12 14:20:16 -0700 2016-09-12 14:44:36 -0700 Patch bug-161394-20160912141743.patch text/plain 4132 dasau SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNTc4NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA5LTEyICBEQU4gU0FV TkRFUlMgIDxkYXNhdUBtaWNyb3NvZnQuY29tPgorCisgICAgICAgIEFYOiBXS1dlYlZpZXcgZm9y IG1hY09TIGRvZXMgbm90IGFsbG93IGNvbmZpZ3VyYXRpb24gb2YgdGFic1RvTGlua3MKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTM5NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1ByZWZlcmVuY2VzLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1ByZWZlcmVuY2VzLm1tOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIGVuY29kZVdpdGhDb2Rl cjpdKToKKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlcyBpbml0V2l0aENvZGVyOl0pOgorICAgICAg ICAoLVtXS1ByZWZlcmVuY2VzIHRhYkZvY3VzZXNMaW5rc10pOgorICAgICAgICAoLVtXS1ByZWZl cmVuY2VzIHNldFRhYkZvY3VzZXNMaW5rczpdKToKKwogMjAxNi0wOS0wOSAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBXS1RodW1ibmFpbFZpZXcgc2hv dWxkIGV4cG9zZSBhIG1vZGUgd2hlcmUgaXQgY2FuIGJlIHJlcGFyZW50ZWQgd2l0aG91dCByZXNu YXBzaG90dGluZwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1By ZWZlcmVuY2VzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1ByZWZlcmVuY2VzLmgJKHJldmlzaW9uIDIwNTc4NykKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5oCSh3b3JraW5nIGNvcHkpCkBAIC02 Myw2ICs2MywxMyBAQCBXS19DTEFTU19BVkFJTEFCTEUobWFjb3N4KDEwLjEwKSwgaW9zKDguCiAg QGRpc2N1c3Npb24gVGhlIGRlZmF1bHQgdmFsdWUgaXMgTk8uCiAgKi8KIEBwcm9wZXJ0eSAobm9u YXRvbWljKSBCT09MIHBsdWdJbnNFbmFibGVkOworCisvKiEKKyBAcHJvcGVydHkgdGFiRm9jdXNl c0xpbmtzCisgQGFic3RyYWN0IElmIHRhYkZvY3VzZXNMaW5rcyBpcyBZRVMsIHRoZSB0YWIga2V5 IHdpbGwgZm9jdXMgbGlua3MgYW5kIGZvcm0gY29udHJvbHMuCisgVGhlIG9wdGlvbiBrZXkgdGVt cG9yYXJpbHkgcmV2ZXJzZXMgdGhpcyBwcmVmZXJlbmNlLgorICovCitAcHJvcGVydHkgKG5vbmF0 b21pYykgQk9PTCB0YWJGb2N1c2VzTGlua3MgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFD X1RCQSkpOwogI2VuZGlmCiAKIEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0JKHJldmlzaW9uIDIwNTc4NykKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQkod29y a2luZyBjb3B5KQpAQCAtNjYsNiArNjYsNyBAQCAtICh2b2lkKWVuY29kZVdpdGhDb2RlcjooTlND b2RlciAqKWNvZGVyCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIFtjb2RlciBlbmNvZGVCb29sOnNl bGYuamF2YUVuYWJsZWQgZm9yS2V5OkAiamF2YUVuYWJsZWQiXTsKICAgICBbY29kZXIgZW5jb2Rl Qm9vbDpzZWxmLnBsdWdJbnNFbmFibGVkIGZvcktleTpAInBsdWdJbnNFbmFibGVkIl07CisgICAg W2NvZGVyIGVuY29kZUJvb2w6c2VsZi50YWJGb2N1c2VzTGlua3MgZm9yS2V5OkAidGFiRm9jdXNl c0xpbmtzIl07CiAjZW5kaWYKIH0KIApAQCAtODEsNiArODIsNyBAQCAtIChpbnN0YW5jZXR5cGUp aW5pdFdpdGhDb2RlcjooTlNDb2RlciAqCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIHNlbGYuamF2 YUVuYWJsZWQgPSBbY29kZXIgZGVjb2RlQm9vbEZvcktleTpAImphdmFFbmFibGVkIl07CiAgICAg c2VsZi5wbHVnSW5zRW5hYmxlZCA9IFtjb2RlciBkZWNvZGVCb29sRm9yS2V5OkAicGx1Z0luc0Vu YWJsZWQiXTsKKyAgICBzZWxmLnRhYkZvY3VzZXNMaW5rcyA9IFtjb2RlciBkZWNvZGVCb29sRm9y S2V5OkAidGFiRm9jdXNlc0xpbmtzIl07CiAjZW5kaWYKIAogICAgIHJldHVybiBzZWxmOwpAQCAt MTQwLDYgKzE0MiwxNiBAQCAtICh2b2lkKXNldFBsdWdJbnNFbmFibGVkOihCT09MKXBsdWdJbnNF CiAgICAgX3ByZWZlcmVuY2VzLT5zZXRQbHVnaW5zRW5hYmxlZChwbHVnSW5zRW5hYmxlZCk7CiB9 CiAKKy0gKEJPT0wpdGFiRm9jdXNlc0xpbmtzCit7CisgICAgcmV0dXJuIF9wcmVmZXJlbmNlcy0+ dGFic1RvTGlua3MoKTsKK30KKworLSAodm9pZClzZXRUYWJGb2N1c2VzTGlua3M6KEJPT0wpdGFi Rm9jdXNlc0xpbmtzCit7CisgICAgX3ByZWZlcmVuY2VzLT5zZXRUYWJzVG9MaW5rcyh0YWJGb2N1 c2VzTGlua3MpOworfQorCiAjZW5kaWYKIAogI3ByYWdtYSBtYXJrIFdLT2JqZWN0IHByb3RvY29s IGltcGxlbWVudGF0aW9uCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDU4MjIpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNi0wOS0xMiAgREFOIFNBVU5ERVJTICA8ZGFz YXVAbWljcm9zb2Z0LmNvbT4KKworICAgICAgICBBWDogV0tXZWJWaWV3IGZvciBtYWNPUyBkb2Vz IG5vdCBhbGxvdyBjb25maWd1cmF0aW9uIG9mIHRhYnNUb0xpbmtzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjEzOTQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0MkNvY29hL0NvZGluZy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDE2LTA5LTEyICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IG1v cmUgVVJMUGFyc2VyIHF1aXJrcwpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQyQ29jb2EvQ29kaW5nLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0MkNvY29hL0NvZGluZy5tbQkocmV2aXNpb24gMjA1Nzg3KQorKysgVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvQ29kaW5nLm1tCSh3b3JraW5nIGNvcHkpCkBA IC01MSw2ICs1MSw3IEBAIFRFU1QoQ29kaW5nLCBXS1ByZWZlcmVuY2VzKQogICAgIFthIHNldEph dmFTY3JpcHRDYW5PcGVuV2luZG93c0F1dG9tYXRpY2FsbHk6Tk9dOwogICAgIFthIHNldEphdmFF bmFibGVkOllFU107CiAgICAgW2Egc2V0UGx1Z0luc0VuYWJsZWQ6WUVTXTsKKyAgICBbYSBzZXRU YWJGb2N1c2VzTGlua3M6WUVTXTsKICNlbmRpZgogCiAgICAgYXV0byBiID0gZW5jb2RlQW5kRGVj b2RlKGEuZ2V0KCkpOwpAQCAtNjIsNiArNjMsNyBAQCBURVNUKENvZGluZywgV0tQcmVmZXJlbmNl cykKICNpZiBQTEFURk9STShNQUMpCiAgICAgRVhQRUNUX0VRKFthIGphdmFFbmFibGVkXSwgW2Ig amF2YUVuYWJsZWRdKTsKICAgICBFWFBFQ1RfRVEoW2EgcGx1Z0luc0VuYWJsZWRdLCBbYiBwbHVn SW5zRW5hYmxlZF0pOworICAgIEVYUEVDVF9FUShbYSB0YWJGb2N1c2VzTGlua3NdLCBbYiB0YWJG b2N1c2VzTGlua3NdKTsKICNlbmRpZgogfQogCg==