161393 2016-08-30 11:16:23 -0700 Object.getPrototypeOf() should return null cross-origin 2016-08-31 13:44:03 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161396 https://bugs.webkit.org/show_bug.cgi?id=161455 WebExposed P2 Normal --- 1 cdumez cdumez cdumez commit-queue darin ggaren keith_miller mark.lam msaboff rniwa saam sam oldest_to_newest 1224630 0 cdumez 2016-08-30 11:16:23 -0700 Object.getPrototypeOf() should return null cross-origin: - https://html.spec.whatwg.org/#windowproxy-getprototypeof - https://html.spec.whatwg.org/#location-getprototypeof Firefox and Chrome return null. However, WebKit returns undefined. 1224631 1 287413 cdumez 2016-08-30 11:18:36 -0700 Created attachment 287413 Patch 1225002 2 cdumez 2016-08-31 11:20:22 -0700 Ping review? 1225012 3 287413 ggaren 2016-08-31 11:44:37 -0700 Comment on attachment 287413 Patch r=me Not directly related to this patch, but it seems weird that Object.getPrototypeOf() needs to walk the stack. Why can't it just compare the callee's global object to the passed-in object's global object? 1225021 4 287413 commit-queue 2016-08-31 12:05:46 -0700 Comment on attachment 287413 Patch Clearing flags on attachment: 287413 Committed r205258: <http://trac.webkit.org/changeset/205258> 1225022 5 commit-queue 2016-08-31 12:06:20 -0700 All reviewed patches have been landed. Closing bug. 287413 2016-08-30 11:18:36 -0700 2016-08-31 12:05:46 -0700 Patch 161393_getPrototypeOf.patch text/plain 4369 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2Y2YwNzlmLi5lYWEzMjI3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDgt MzAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBPYmplY3QuZ2V0 UHJvdG90eXBlT2YoKSBzaG91bGQgcmV0dXJuIG51bGwgY3Jvc3Mtb3JpZ2luCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjEzOTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGF5b3V0IHRlc3QgY292 ZXJhZ2UuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vz cy1vYmplY3QtZ2V0UHJvdG90eXBlT2YtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVz dHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLW9iamVjdC1nZXRQcm90b3R5cGVPZi5odG1s OgorCiAyMDE2LTA4LTI5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgVW5za2lwIHNldmVyYWwgd2ViLXBsYXRmb3JtLXRlc3RzIHRoYXQgYXJlIG5vdyBwYXNzaW5n CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1l LWFjY2Vzcy1vYmplY3QtZ2V0UHJvdG90eXBlT2YtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3Mtb2JqZWN0LWdldFByb3RvdHlw ZU9mLWV4cGVjdGVkLnR4dAppbmRleCA1MTk4ODQzLi5jOTNhODdkIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1vYmplY3QtZ2V0 UHJvdG90eXBlT2YtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2Vj dXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLW9iamVjdC1nZXRQcm90b3R5cGVPZi1leHBlY3RlZC50 eHQKQEAgLTEsNyArMSw5IEBACiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTogQmxvY2tlZCBhIGZy YW1lIHdpdGggb3JpZ2luICJodHRwOi8vMTI3LjAuMC4xOjgwMDAiIGZyb20gYWNjZXNzaW5nIGEg ZnJhbWUgd2l0aCBvcmlnaW4gImh0dHA6Ly9sb2NhbGhvc3Q6ODAwMCIuIFByb3RvY29scywgZG9t YWlucywgYW5kIHBvcnRzIG11c3QgbWF0Y2guCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTogQmxv Y2tlZCBhIGZyYW1lIHdpdGggb3JpZ2luICJodHRwOi8vMTI3LjAuMC4xOjgwMDAiIGZyb20gYWNj ZXNzaW5nIGEgZnJhbWUgd2l0aCBvcmlnaW4gImh0dHA6Ly9sb2NhbGhvc3Q6ODAwMCIuIFByb3Rv Y29scywgZG9tYWlucywgYW5kIHBvcnRzIG11c3QgbWF0Y2guCiBUaGlzIHRlc3RzIHRoYXQgeW91 IGNhbid0IGdldCB0aGUgcHJvdG90eXBlIG9mIHRoZSB3aW5kb3cgb3IgaGlzdG9yeSBvYmplY3Rz IGNyb3NzLW9yaWdpbiB1c2luZyBPYmplY3QuZ2V0UHJvdG90eXBlT2YoKS4KIAotUEFTUzogT2Jq ZWN0LmdldFByb3RvdHlwZU9mKHRhcmdldFdpbmRvdykgc2hvdWxkIGJlICd1bmRlZmluZWQnIGFu ZCBpcy4KK1BBU1M6IE9iamVjdC5nZXRQcm90b3R5cGVPZih0YXJnZXRXaW5kb3cpIHNob3VsZCBi ZSAnbnVsbCcgYW5kIGlzLgorUEFTUzogT2JqZWN0LmdldFByb3RvdHlwZU9mKHRhcmdldFdpbmRv dy5sb2NhdGlvbikgc2hvdWxkIGJlICdudWxsJyBhbmQgaXMuCiBQQVNTIHRhcmdldFdpbmRvdy5o aXN0b3J5IHRocmV3IGV4Y2VwdGlvbiBTZWN1cml0eUVycm9yIChET00gRXhjZXB0aW9uIDE4KTog QmxvY2tlZCBhIGZyYW1lIHdpdGggb3JpZ2luICJodHRwOi8vMTI3LjAuMC4xOjgwMDAiIGZyb20g YWNjZXNzaW5nIGEgZnJhbWUgd2l0aCBvcmlnaW4gImh0dHA6Ly9sb2NhbGhvc3Q6ODAwMCIuIFBy b3RvY29scywgZG9tYWlucywgYW5kIHBvcnRzIG11c3QgbWF0Y2guLgogUEFTUzogc3VjY2Vzc2Z1 bGx5UGFyc2VkIHNob3VsZCBiZSAndHJ1ZScgYW5kIGlzLgogCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1vYmplY3QtZ2V0UHJv dG90eXBlT2YuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJh bWUtYWNjZXNzLW9iamVjdC1nZXRQcm90b3R5cGVPZi5odG1sCmluZGV4IGMzNDQ4NDcuLjJkNjY3 YjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJh bWUtYWNjZXNzLW9iamVjdC1nZXRQcm90b3R5cGVPZi5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLW9iamVjdC1nZXRQcm90b3R5cGVP Zi5odG1sCkBAIC0xNiw3ICsxNiw4IEBACiAgICAgICAgIHsKICAgICAgICAgICAgIHRhcmdldFdp bmRvdyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKS5jb250ZW50V2luZG93Owog Ci0gICAgICAgICAgICBzaG91bGRCZVVuZGVmaW5lZCgiT2JqZWN0LmdldFByb3RvdHlwZU9mKHRh cmdldFdpbmRvdykiKTsKKyAgICAgICAgICAgIHNob3VsZEJlTnVsbCgiT2JqZWN0LmdldFByb3Rv dHlwZU9mKHRhcmdldFdpbmRvdykiKTsKKyAgICAgICAgICAgIHNob3VsZEJlTnVsbCgiT2JqZWN0 LmdldFByb3RvdHlwZU9mKHRhcmdldFdpbmRvdy5sb2NhdGlvbikiKTsKICAgICAgICAgICAgIHNo b3VsZFRocm93RXJyb3JOYW1lKCJ0YXJnZXRXaW5kb3cuaGlzdG9yeSIsICJTZWN1cml0eUVycm9y Iik7CiAKICAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK aW5kZXggZmJjNGMwYy4uNGQ1MWJiNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTYtMDgtMzAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwor ICAgICAgICBPYmplY3QuZ2V0UHJvdG90eXBlT2YoKSBzaG91bGQgcmV0dXJuIG51bGwgY3Jvc3Mt b3JpZ2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjEzOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBP YmplY3QuZ2V0UHJvdG90eXBlT2YoKSBzaG91bGQgcmV0dXJuIG51bGwgY3Jvc3Mtb3JpZ2luOgor ICAgICAgICAtIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcvI3dpbmRvd3Byb3h5LWdldHBy b3RvdHlwZW9mCisgICAgICAgIC0gaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy8jbG9jYXRp b24tZ2V0cHJvdG90eXBlb2YKKworICAgICAgICBGaXJlZm94IGFuZCBDaHJvbWUgcmV0dXJuIG51 bGwuIEhvd2V2ZXIsIFdlYktpdCB3YXMgcmV0dXJuaW5nIHVuZGVmaW5lZC4KKworICAgICAgICAq IHJ1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpPYmplY3RDb25z dHJ1Y3RvckdldFByb3RvdHlwZU9mRnVuY3Rvcjo6b3BlcmF0b3IoKSk6CisKIDIwMTYtMDgtMjkg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OKHIyMDI1NjgpOiBXZWIgSW5zcGVjdG9yOiBFeHBhbmRpbmcgQXJyYXkgUHJvdG90eXBlIGlu IENvbnNvbGUgc2hvd3Mgbm8gcHJvcGVydGllcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwCmluZGV4IDQ2ZDBjYzguLjQ2NGIzMDAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVj dG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PYmplY3RDb25zdHJ1 Y3Rvci5jcHAKQEAgLTE4Nyw2ICsxODcsOCBAQCBwdWJsaWM6CiAKICAgICAgICAgaWYgKG1fb2Jq ZWN0LT5hbGxvd3NBY2Nlc3NGcm9tKHZpc2l0b3ItPmNhbGxGcmFtZSgpKSkKICAgICAgICAgICAg IG1fcmVzdWx0ID0gbV9vYmplY3QtPmdldFByb3RvdHlwZShtX2V4ZWMtPnZtKCksIG1fZXhlYyk7 CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIG1fcmVzdWx0ID0ganNOdWxsKCk7CiAgICAgICAg IHJldHVybiBTdGFja1Zpc2l0b3I6OkRvbmU7CiAgICAgfQogCg==