161366 2016-08-29 17:23:12 -0700 REGRESSION (r205094): LayoutTest editing/pasteboard/5478250.html is a flaky failure 2016-09-22 11:50:44 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161411 https://bugs.webkit.org/show_bug.cgi?id=161919 InRadar P2 Normal --- 1 ryanhaddad jbedard ap jbedard thorton webkit-bug-importer oldest_to_newest 1224459 0 ryanhaddad 2016-08-29 17:23:12 -0700 REGRESSION: LayoutTest editing/pasteboard/5478250.html is a flaky failure https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/7837 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fpasteboard%2F5478250.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/editing/pasteboard/5478250-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/editing/pasteboard/5478250-actual.txt @@ -17,7 +17,8 @@ RenderText {#text} at (111,0) size 35x18 text run at (111,0) width 35: "bold." RenderBlock {DIV} at (0,18) size 784x18 - RenderInline {SPAN} at (0,0) size 398x18 - RenderText {#text} at (0,0) size 398x18 - text run at (0,0) width 398: "This text should bold and left justified with \"Some text...\"." -caret: position 61 of child 0 {#text} of child 0 {SPAN} of child 2 {DIV} of child 4 {DIV} of body + RenderInline {SPAN} at (0,0) size 402x18 + RenderInline {B} at (0,0) size 402x18 + RenderText {#text} at (0,0) size 402x18 + text run at (0,0) width 402: "This text should bold and left justified with \"Some text\x{2026}\"." +caret: position 59 of child 0 {#text} of child 0 {B} of child 0 {SPAN} of child 2 {DIV} of child 4 {DIV} of body 1224462 1 ryanhaddad 2016-08-29 17:26:24 -0700 Earliest failure seen with: https://trac.webkit.org/log/?verbose=on&rev=205094&stop_rev=205093 1224465 2 ryanhaddad 2016-08-29 17:31:03 -0700 Maybe related to https://trac.webkit.org/changeset/205094 1224622 3 ryanhaddad 2016-08-30 11:07:18 -0700 Marked test as flaky on mac-wk2 debug in http://trac.webkit.org/projects/webkit/changeset/205187 1224807 4 jbedard 2016-08-30 17:28:53 -0700 Just a few comments so that this is documented. I find it highly unlikely that it was https://trac.webkit.org/changeset/205094. This change added a function to the test runner that is only called by two tests, which were failing before the change. editing/pasteboard/5478250.html does not call the added function. Looking at the immediate preceding change, however, https://trac.webkit.org/changeset/205093, may be a potential culprit, as the error we see in editing.pasteboard/5478250.html has to do with CSS. I suspect that this bug depends on test order, although I have not managed to reproduce it, so I cannot definitively say that is what is going on. 1225013 5 jbedard 2016-08-31 11:45:13 -0700 I'm actually curious as to why this test is passing at all. Opening it in Safari seems to indicate the test should be failing 100% of the time. Oddly, I can't get it to fail in the test suite, it seems like it should be failing there too if it is failing in Safari. Test results: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20%28Tests%29/r205108%20%287815%29/results.html 1225792 6 ap 2016-09-02 09:46:39 -0700 I can reproduce locally. The difference almost certainly means that text replacement now fires, and changes three dots into an ellipsis, so r205094 does seem somewhat related. > I'm actually curious as to why this test is passing at all. The test only verifies that the text is bold when running as a pixel test - render tree doesn't encode whether the text was bold. So that regression occurred long ago, unnoticed. We'll need a separate bug for that. 1225798 7 ap 2016-09-02 09:55:40 -0700 Steps to reproduce: run-webkit-tests --child-processes=1 editing/inserting/smart-link-when-caret-is-moved-before-URL.html editing/pasteboard/5478250.html -v --no-retry 1226725 8 webkit-bug-importer 2016-09-06 10:04:02 -0700 <rdar://problem/28171977> 1226726 9 ap 2016-09-06 10:04:45 -0700 Bug 161411 seems like it probably shares the root cause with this. 1226740 10 jbedard 2016-09-06 10:35:45 -0700 *** Bug 161411 has been marked as a duplicate of this bug. *** 1226743 11 jbedard 2016-09-06 10:41:40 -0700 This is because of a failure to reset state when a new test begins, specifically due to setAutomaticLinkDetectionEnabled(bool) not reseting. 1226747 12 ryanhaddad 2016-09-06 10:47:20 -0700 Removed flaky expectations and skipped editing/inserting/smart-link-when-caret-is-moved-before-URL.html in https://trac.webkit.org/r205491 1226851 13 jbedard 2016-09-06 15:05:36 -0700 Further investigation has revealed that the "setAutomaticLinkDetectionEnabled" flag is reset before each test (although, many of the TestRunner's functions are not reset before each test). The flag also remains reset through out the test. Yet, somehow state is being retained between tests. 1227374 14 jbedard 2016-09-07 15:12:11 -0700 This is a bug with the TestRunner. The test runner is attempting to modify the text checker from the WebContent process instead of the UI process. 1227655 15 jbedard 2016-09-08 11:22:31 -0700 To fully fix this bug, API additions will need to be made. It is unclear why WKTextChecker.h, the file which provides these checks for most platforms, is excluded on Apple's builds. The primary functionality provided, spelling and grammar checking, are defined by Apple's text checker. 1230458 16 jbedard 2016-09-16 10:45:18 -0700 https://bugs.webkit.org/show_bug.cgi?id=161919 contains the more permanent fix to this issue. 1232562 17 jbedard 2016-09-22 11:50:44 -0700 This issue has been fixed as of r206261: <http://trac.webkit.org/changeset/206261>.