161304 2016-08-28 17:14:56 -0700 Web Inspector: Value checks of secondsPerPixel cause errors 2016-09-01 15:07:00 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1224100 0 hi 2016-08-28 17:14:56 -0700 WebKit/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/TimelineRecordBar.js:232:23: CONSOLE ERROR WebKit/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/TimelineDataGridNode.js:230:23: CONSOLE ERROR Both lines are along the lines of: console.assert(graphDataSource.secondsPerPixel); I'm guessing that this may be due to the fact that secondsPerPixel is initially 0, which will trigger assertions. 1224101 1 webkit-bug-importer 2016-08-28 17:15:09 -0700 <rdar://problem/28050070> 1224497 2 mattbaker 2016-08-29 20:52:22 -0700 These are mostly the fault of NetworkTimelineView, which wasn't clearing all its cached data on recording reset, and in addition didn't check that time stamps were actually changing before doing a layout. The latter resulted in trying to refresh graphs when endTime - startTime === 0, resulting in an invalid value for secondsPerPixel. 1224499 3 287368 mattbaker 2016-08-29 20:58:06 -0700 Created attachment 287368 [Patch] Proposed Fix 1225419 4 287368 bburg 2016-09-01 11:29:27 -0700 Comment on attachment 287368 [Patch] Proposed Fix This patch is missing a changelog. Ideally it would explain the sequence of events to cause this assertion and why the sequence is now different. 1225523 5 287675 mattbaker 2016-09-01 14:09:45 -0700 Created attachment 287675 [Patch] Proposed Fix 1225526 6 287675 bburg 2016-09-01 14:11:25 -0700 Comment on attachment 287675 [Patch] Proposed Fix r=me, very thank you for changelog ;-) 1225530 7 mattbaker 2016-09-01 14:17:08 -0700 (In reply to comment #6) > Comment on attachment 287675 [details] > [Patch] Proposed Fix > > r=me, very thank you for changelog ;-) It was already written, just got left behind :) 1225559 8 287675 commit-queue 2016-09-01 15:06:55 -0700 Comment on attachment 287675 [Patch] Proposed Fix Clearing flags on attachment: 287675 Committed r205320: <http://trac.webkit.org/changeset/205320> 1225560 9 commit-queue 2016-09-01 15:07:00 -0700 All reviewed patches have been landed. Closing bug. 287368 2016-08-29 20:58:06 -0700 2016-09-01 14:09:42 -0700 [Patch] Proposed Fix bug-161304-20160829205557.patch text/plain 2790 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGltZWxpbmVWaWV3LmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RpbWVsaW5lVmlldy5q cwppbmRleCBjZjk2OTJiNThjMjhiYmUwODZjODUzMmEyZTQ3ZDAwMTc4MjM4NTEyLi4xMjEyNzBk ZWY3ODQ5MDM2NjA2ZmYwNjg4MmRjMzEyYzUxNjA2ZGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGltZWxpbmVWaWV3LmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1l bGluZVZpZXcuanMKQEAgLTE1OCw2ICsxNTgsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVs aW5lVmlldyA9IGNsYXNzIE5ldHdvcmtUaW1lbGluZVZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0bwog ICAgICAgICB0aGlzLl9kYXRhR3JpZC5yZXNldCgpOwogCiAgICAgICAgIHRoaXMuX3BlbmRpbmdS ZWNvcmRzID0gW107CisgICAgICAgIHRoaXMuX3Jlc291cmNlRGF0YUdyaWROb2RlTWFwLmNsZWFy KCk7CiAgICAgfQogCiAgICAgLy8gVGltZWxpbmVEYXRhR3JpZCBzb3J0IGRlbGVnYXRlCkBAIC0y MDksMTIgKzIxMCwxOSBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVsaW5lVmlldyA9IGNsYXNz IE5ldHdvcmtUaW1lbGluZVZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0bwogICAgIHsKICAgICAgICAg dGhpcy5lbmRUaW1lID0gTWF0aC5taW4odGhpcy5lbmRUaW1lLCB0aGlzLmN1cnJlbnRUaW1lKTsK IAorICAgICAgICBsZXQgb2xkWmVyb1RpbWUgPSB0aGlzLl90aW1lbGluZVJ1bGVyLnplcm9UaW1l OworICAgICAgICBsZXQgb2xkU3RhcnRUaW1lID0gdGhpcy5fdGltZWxpbmVSdWxlci5zdGFydFRp bWU7CisgICAgICAgIGxldCBvbGRFbmRUaW1lID0gdGhpcy5fdGltZWxpbmVSdWxlci5lbmRUaW1l OworCiAgICAgICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIuemVyb1RpbWUgPSB0aGlzLnplcm9UaW1l OwogICAgICAgICB0aGlzLl90aW1lbGluZVJ1bGVyLnN0YXJ0VGltZSA9IHRoaXMuc3RhcnRUaW1l OwogICAgICAgICB0aGlzLl90aW1lbGluZVJ1bGVyLmVuZFRpbWUgPSB0aGlzLmVuZFRpbWU7CiAK LSAgICAgICAgZm9yIChsZXQgZGF0YUdyaWROb2RlIG9mIHRoaXMuX3Jlc291cmNlRGF0YUdyaWRO b2RlTWFwLnZhbHVlcygpKQotICAgICAgICAgICAgZGF0YUdyaWROb2RlLnJlZnJlc2hHcmFwaCgp OworICAgICAgICAvLyBXZSBvbmx5IG5lZWQgdG8gcmVmcmVzaCB0aGUgZ3JhcGhzIHdoZW4gdGhl IGFueSBvZiB0aGUgdGltZXMgY2hhbmdlLgorICAgICAgICBpZiAodGhpcy56ZXJvVGltZSAhPT0g b2xkWmVyb1RpbWUgfHwgdGhpcy5zdGFydFRpbWUgIT09IG9sZFN0YXJ0VGltZSB8fCB0aGlzLmVu ZFRpbWUgIT09IG9sZEVuZFRpbWUpIHsKKyAgICAgICAgICAgIGZvciAobGV0IGRhdGFHcmlkTm9k ZSBvZiB0aGlzLl9yZXNvdXJjZURhdGFHcmlkTm9kZU1hcC52YWx1ZXMoKSkKKyAgICAgICAgICAg ICAgICBkYXRhR3JpZE5vZGUucmVmcmVzaEdyYXBoKCk7CisgICAgICAgIH0KIAogICAgICAgICB0 aGlzLl9wcm9jZXNzUGVuZGluZ1JlY29yZHMoKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRl bnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwppbmRleCBmZDVjNGIyODc0MjE3N2YwMjY4NzAw N2MzZGYyZmUyMzJlY2VlNjMxLi41MDQ5OTEyNmQzZjAwZGU4ZTdlMTFmYWMzZWM2OWYwNGEzYjY0 YTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMK QEAgLTYxOCw2ICs2MTgsOSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50 VmlldyA9IGNsYXNzIFRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgZQogCiAgICAgX3JlY29y ZGluZ1Jlc2V0KGV2ZW50KQogICAgIHsKKyAgICAgICAgZm9yIChsZXQgdGltZWxpbmVWaWV3IG9m IHRoaXMuX3RpbWVsaW5lVmlld01hcC52YWx1ZXMoKSkKKyAgICAgICAgICAgIHRpbWVsaW5lVmll dy5yZXNldCgpOworCiAgICAgICAgIHRoaXMuX2N1cnJlbnRUaW1lID0gTmFOOwogICAgICAgICB0 aGlzLl9kaXNjb250aW51aXR5U3RhcnRUaW1lID0gTmFOOwogCkBAIC02MzUsOCArNjM4LDYgQEAg V2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGlu ZVJlY29yZGluZ0NvbnRlbnRWaWV3IGUKIAogICAgICAgICB0aGlzLl90aW1lbGluZU92ZXJ2aWV3 LnJlc2V0KCk7CiAgICAgICAgIHRoaXMuX292ZXJ2aWV3VGltZWxpbmVWaWV3LnJlc2V0KCk7Ci0g ICAgICAgIGZvciAodmFyIHRpbWVsaW5lVmlldyBvZiB0aGlzLl90aW1lbGluZVZpZXdNYXAudmFs dWVzKCkpCi0gICAgICAgICAgICB0aW1lbGluZVZpZXcucmVzZXQoKTsKICAgICAgICAgdGhpcy5f Y2xlYXJUaW1lbGluZU5hdmlnYXRpb25JdGVtLmVuYWJsZWQgPSBmYWxzZTsKICAgICB9CiAK 287675 2016-09-01 14:09:45 -0700 2016-09-01 15:06:55 -0700 [Patch] Proposed Fix bug-161304-20160901140731.patch text/plain 4184 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi MjRiZTlhNjM4NWIwYTkxZjhhMzQyYTllNGQyYTY5OTQyOWExY2VkLi5jMjlhMzU2OTM4MTdiNjI5 Y2RjZTU5ZGQzMmI5OGEzZTY0MWM2YWQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wOS0wMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVmFsdWUgY2hlY2tzIG9mIHNlY29uZHNQZXJQaXhl bCBjYXVzZSBlcnJvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MTMwNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjgwNTAwNzA+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL05ldHdvcmtUaW1lbGluZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0 d29ya1RpbWVsaW5lVmlldy5wcm90b3R5cGUucmVzZXQpOgorICAgICAgICBDbGVhciByZXNvdXJj ZSBub2RlIG1hcCwgd2hpY2ggaXMgdXNlZCB0byBkZXRlcm1pbmUgd2hpY2ggbm9kZXMKKyAgICAg ICAgdG8gcmVmcmVzaCBkdXJpbmcgbGF5b3V0LgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0 d29ya1RpbWVsaW5lVmlldy5wcm90b3R5cGUubGF5b3V0KToKKyAgICAgICAgTGlrZSBPdmVydmll d1RpbWVsaW5lVmlldywgb25seSByZWZyZXNoIG5vZGUgZ3JhcGhzIHdoZW4gdGltZXMgY2hhbmdl LgorICAgICAgICBUaGlzIHByZXZlbnRzIHJlZnJlc2hpbmcgbm9kZXMgd2hlbiAoZW5kVGltZSAt IHN0YXJ0VGltZSkgPT09IDAuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxp bmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuX3JlY29yZGluZ1Jlc2V0KToKKyAgICAg ICAgVGltZWxpbmVWaWV3cyBtdXN0IGJlIGNsZWFyZWQgYmVmb3JlIGNhbGxpbmcgX3VwZGF0ZVRp bWVzIHRvIGF2b2lkCisgICAgICAgIGRvaW5nIGxheW91dHMgaW4gdGltZWxpbmUgdmlld3MgY29u dGFpbmluZyBzdGFsZSBkYXRhLgorCiAyMDE2LTA5LTAxICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFz aWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1pbmlmaWNhdGlvbiBk ZXRlY3Rpb24gcHJvZHVjZXMgZmFsc2UgcG9zaXRpdmVzIGZvciBzbWFsbCByZXNvdXJjZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdv cmtUaW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9OZXR3b3JrVGltZWxpbmVWaWV3LmpzCmluZGV4IGNmOTY5MmI1OGMyOGJiZTA4NmM4NTMy YTJlNDdkMDAxNzgyMzg1MTIuLjEyMTI3MGRlZjc4NDkwMzY2MDZmZjA2ODgyZGMzMTJjNTE2MDZk ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L05ldHdvcmtUaW1lbGluZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTmV0d29ya1RpbWVsaW5lVmlldy5qcwpAQCAtMTU4LDYgKzE1OCw3IEBA IFdlYkluc3BlY3Rvci5OZXR3b3JrVGltZWxpbmVWaWV3ID0gY2xhc3MgTmV0d29ya1RpbWVsaW5l VmlldyBleHRlbmRzIFdlYkluc3BlY3RvCiAgICAgICAgIHRoaXMuX2RhdGFHcmlkLnJlc2V0KCk7 CiAKICAgICAgICAgdGhpcy5fcGVuZGluZ1JlY29yZHMgPSBbXTsKKyAgICAgICAgdGhpcy5fcmVz b3VyY2VEYXRhR3JpZE5vZGVNYXAuY2xlYXIoKTsKICAgICB9CiAKICAgICAvLyBUaW1lbGluZURh dGFHcmlkIHNvcnQgZGVsZWdhdGUKQEAgLTIwOSwxMiArMjEwLDE5IEBAIFdlYkluc3BlY3Rvci5O ZXR3b3JrVGltZWxpbmVWaWV3ID0gY2xhc3MgTmV0d29ya1RpbWVsaW5lVmlldyBleHRlbmRzIFdl Ykluc3BlY3RvCiAgICAgewogICAgICAgICB0aGlzLmVuZFRpbWUgPSBNYXRoLm1pbih0aGlzLmVu ZFRpbWUsIHRoaXMuY3VycmVudFRpbWUpOwogCisgICAgICAgIGxldCBvbGRaZXJvVGltZSA9IHRo aXMuX3RpbWVsaW5lUnVsZXIuemVyb1RpbWU7CisgICAgICAgIGxldCBvbGRTdGFydFRpbWUgPSB0 aGlzLl90aW1lbGluZVJ1bGVyLnN0YXJ0VGltZTsKKyAgICAgICAgbGV0IG9sZEVuZFRpbWUgPSB0 aGlzLl90aW1lbGluZVJ1bGVyLmVuZFRpbWU7CisKICAgICAgICAgdGhpcy5fdGltZWxpbmVSdWxl ci56ZXJvVGltZSA9IHRoaXMuemVyb1RpbWU7CiAgICAgICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIu c3RhcnRUaW1lID0gdGhpcy5zdGFydFRpbWU7CiAgICAgICAgIHRoaXMuX3RpbWVsaW5lUnVsZXIu ZW5kVGltZSA9IHRoaXMuZW5kVGltZTsKIAotICAgICAgICBmb3IgKGxldCBkYXRhR3JpZE5vZGUg b2YgdGhpcy5fcmVzb3VyY2VEYXRhR3JpZE5vZGVNYXAudmFsdWVzKCkpCi0gICAgICAgICAgICBk YXRhR3JpZE5vZGUucmVmcmVzaEdyYXBoKCk7CisgICAgICAgIC8vIFdlIG9ubHkgbmVlZCB0byBy ZWZyZXNoIHRoZSBncmFwaHMgd2hlbiB0aGUgYW55IG9mIHRoZSB0aW1lcyBjaGFuZ2UuCisgICAg ICAgIGlmICh0aGlzLnplcm9UaW1lICE9PSBvbGRaZXJvVGltZSB8fCB0aGlzLnN0YXJ0VGltZSAh PT0gb2xkU3RhcnRUaW1lIHx8IHRoaXMuZW5kVGltZSAhPT0gb2xkRW5kVGltZSkgeworICAgICAg ICAgICAgZm9yIChsZXQgZGF0YUdyaWROb2RlIG9mIHRoaXMuX3Jlc291cmNlRGF0YUdyaWROb2Rl TWFwLnZhbHVlcygpKQorICAgICAgICAgICAgICAgIGRhdGFHcmlkTm9kZS5yZWZyZXNoR3JhcGgo KTsKKyAgICAgICAgfQogCiAgICAgICAgIHRoaXMuX3Byb2Nlc3NQZW5kaW5nUmVjb3JkcygpOwog ICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCmlu ZGV4IGZkNWM0YjI4NzQyMTc3ZjAyNjg3MDA3YzNkZjJmZTIzMmVjZWU2MzEuLjUwNDk5MTI2ZDNm MDBkZThlN2UxMWZhYzNlYzY5ZjA0YTNiNjRhNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcwpAQCAtNjE4LDYgKzYxOCw5IEBAIFdlYkluc3BlY3Rv ci5UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdD b250ZW50VmlldyBlCiAKICAgICBfcmVjb3JkaW5nUmVzZXQoZXZlbnQpCiAgICAgeworICAgICAg ICBmb3IgKGxldCB0aW1lbGluZVZpZXcgb2YgdGhpcy5fdGltZWxpbmVWaWV3TWFwLnZhbHVlcygp KQorICAgICAgICAgICAgdGltZWxpbmVWaWV3LnJlc2V0KCk7CisKICAgICAgICAgdGhpcy5fY3Vy cmVudFRpbWUgPSBOYU47CiAgICAgICAgIHRoaXMuX2Rpc2NvbnRpbnVpdHlTdGFydFRpbWUgPSBO YU47CiAKQEAgLTYzNSw4ICs2MzgsNiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdD b250ZW50VmlldyA9IGNsYXNzIFRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcgZQogCiAgICAg ICAgIHRoaXMuX3RpbWVsaW5lT3ZlcnZpZXcucmVzZXQoKTsKICAgICAgICAgdGhpcy5fb3ZlcnZp ZXdUaW1lbGluZVZpZXcucmVzZXQoKTsKLSAgICAgICAgZm9yICh2YXIgdGltZWxpbmVWaWV3IG9m IHRoaXMuX3RpbWVsaW5lVmlld01hcC52YWx1ZXMoKSkKLSAgICAgICAgICAgIHRpbWVsaW5lVmll dy5yZXNldCgpOwogICAgICAgICB0aGlzLl9jbGVhclRpbWVsaW5lTmF2aWdhdGlvbkl0ZW0uZW5h YmxlZCA9IGZhbHNlOwogICAgIH0KIAo=