161296 2016-08-27 20:27:00 -0700 [iOS] Build fails in JSCLLIntOffsetsExtractor - Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0' 2016-09-06 17:31:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad Other RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161661 P2 Normal --- 1 king7532 dbates ap commit-queue dbates ddkilzer keith_miller king7532 lforschler mark.lam mitz msaboff saam oldest_to_newest 1224013 0 king7532 2016-08-27 20:27:00 -0700 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@205094 268f45cc-cd09-0410-ab3c-d52691b4dbfc $ sw_vers ProductName: Mac OS X ProductVersion: 10.12 BuildVersion: 16A304a $ xcode-select -p /Applications/Xcode-beta.app/Contents/Developer $ xcodebuild -version Xcode 8.0 Build version 8S201h # Xcode 8 beta 6 - Aug 15, 2016 Steps to reproduce: 1. Build WebKit: Tools/Scripts/build-webkit --ios-simulator Expected Result: Should build WebKit for the iOS Simulator Actual Result: Build fails: === BUILD TARGET JSCLLIntOffsetsExtractor OF PROJECT JavaScriptCore WITH CONFIGURATION Release === Check dependencies Base.xcconfig line 23: Unable to find included file "../../../../Internal/Configurations/HaveInternalSDK.xcconfig" Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0' ** BUILD FAILED ** The following build commands failed: Check dependencies (1 failure) 1226946 1 288070 dbates 2016-09-06 17:10:19 -0700 Created attachment 288070 Patch 1226948 2 288070 mitz 2016-09-06 17:12:11 -0700 Comment on attachment 288070 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288070&action=review > Source/JavaScriptCore/Configurations/Base.xcconfig:97 > +AD_HOC_CODE_SIGNING_ALLOWED[sdk=iphonesimulator*] = YES; Is the sdk qualifier necessary here? If it works without it, I think we should not specify it. 1226952 3 dbates 2016-09-06 17:20:29 -0700 (In reply to comment #2) > Comment on attachment 288070 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=288070&action=review > > > Source/JavaScriptCore/Configurations/Base.xcconfig:97 > > +AD_HOC_CODE_SIGNING_ALLOWED[sdk=iphonesimulator*] = YES; > > Is the sdk qualifier necessary here? If it works without it, I think we > should not specify it. Will remove the SDK qualifier before landing as it is not necessary. 1226960 4 dbates 2016-09-06 17:31:22 -0700 Committed r205528: <http://trac.webkit.org/changeset/205528> 288070 2016-09-06 17:10:19 -0700 2016-09-06 17:12:11 -0700 Patch bug-161296-20160906170756.patch text/plain 1537 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1NDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy OWM4NWNlNDE4ZjNjYzgxYmJlNDE2MDU0OWI3ZTY4ZDVlZGQwZDExLi40OGIyZDFhODkzNmM5MTU3 YjE5ZmE3NTBkODA0NmU5ZDZmNmQ1MzM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wOS0wNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CisKKyAgICAgICAgW2lPUyBTaW11bGF0b3JdIEJ1aWxkIGZhaWxzIGluIEpTQ0xMSW50T2Zmc2V0 c0V4dHJhY3RvciAtIEFkIEhvYyBjb2RlIHNpZ25pbmcgaXMgbm90IGFsbG93ZWQgd2l0aCBTREsg J1NpbXVsYXRvciAtIGlPUyAxMC4wJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYxMjk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWxsb3cgYWQtaG9jIGNvZGUgc2lnbmluZyB3aGVuIGJ1aWxkaW5nIEph dmFTY3JpcHRDb3JlIGNvbW1hbmQgbGluZSB0b29scyBmb3Igc2ltdWxhdG9yCisgICAgICAgIHdp dGggdGhlIGlPUyAxMCBiZXRhIFNESy4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0Jhc2Uu eGNjb25maWc6CisKIDIwMTYtMDktMDYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4K IAogICAgICAgICBUeXBlZCBhcnJheXMgc2hvdWxkIHVzZSBNYXJrZWRTcGFjZSBpbnN0ZWFkIG9m IENvcGllZFNwYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJh dGlvbnMvQmFzZS54Y2NvbmZpZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9u cy9CYXNlLnhjY29uZmlnCmluZGV4IGJiMjFkYTEzOWQwMTJkNjE4ZDczNWQ0NThhNDM2MGUyOGY2 YTAxMjYuLmExZGJjNmUxZTk2MjhhMzk2NmJjOWVlMGNlMzFhN2MyZDk2ZWE0MmIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCkBA IC05NCw2ICs5NCw3IEBAIFRBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9SXzExID0gMTAxMTAw OwogVEFSR0VUX01BQ19PU19YX1ZFUlNJT05fTUFKT1JfMTIgPSAxMDEyMDA7CiBUQVJHRVRfTUFD X09TX1hfVkVSU0lPTl9NQUpPUl8xMyA9IDEwMTMwMDsKIAorQURfSE9DX0NPREVfU0lHTklOR19B TExPV0VEW3Nkaz1pcGhvbmVzaW11bGF0b3IqXSA9IFlFUzsKIENPREVfU0lHTl9JREVOVElUWSA9 IC07CiAKIFNVUFBPUlRFRF9QTEFURk9STVMgPSBpcGhvbmVvcyBpcGhvbmVzaW11bGF0b3IgbWFj b3N4IGFwcGxldHZvcyBhcHBsZXR2c2ltdWxhdG9yIHdhdGNob3Mgd2F0Y2hzaW11bGF0b3I7Cg==