161246 2016-08-26 08:41:52 -0700 Typo fix after r56209 2016-08-26 09:34:57 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 35308 1 ossy ossy commit-queue darin kenneth oldest_to_newest 1223509 0 ossy 2016-08-26 08:41:52 -0700 http://trac.webkit.org/changeset/56209 caused build failure with GCC 6 ( 6.5 years later :)) ) ../../Source/WebCore/page/FrameView.cpp: In member function ‘void WebCore::FrameView::adjustMediaTypeForPrinting(bool)’: ../../Source/WebCore/page/FrameView.cpp:1606:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] if (m_mediaTypeWhenNotPrinting.isNull()) ^~ ../../Source/WebCore/page/FrameView.cpp:1608:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ setMediaType("print"); ^~~~~~~~~~~~ "setMediaType("print");" line was indented misleadingly, it should be fixed. Darin's comment was good in https://bugs.webkit.org/show_bug.cgi?id=35308#c16, but the landed patch was wrong. Let's make GCC happy. ;) 1223511 1 287106 ossy 2016-08-26 08:43:40 -0700 Created attachment 287106 Patch 1223543 2 287106 commit-queue 2016-08-26 09:34:53 -0700 Comment on attachment 287106 Patch Clearing flags on attachment: 287106 Committed r205015: <http://trac.webkit.org/changeset/205015> 1223544 3 commit-queue 2016-08-26 09:34:57 -0700 All reviewed patches have been landed. Closing bug. 287106 2016-08-26 08:43:40 -0700 2016-08-26 09:34:53 -0700 Patch bug-161246-20160826174136.patch text/plain 1329 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1MDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2FlMmI3YTNjMWNmNTQ3 YTIxOTI3MzAzNzRjODkwNTk3N2U5YTYxOC4uMWNlZWJkZTc3NmVlMGMwYWUwMDY2ODg0NDViYTVj YjhmMDBjMThlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA4LTI2ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgVHlwbyBmaXggYWZ0 ZXIgcjU2MjA5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjEyNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6YWRq dXN0TWVkaWFUeXBlRm9yUHJpbnRpbmcpOgorCiAyMDE2LTA4LTI2ICBOYWVsIE91ZWRyYW9nbyAg PG5hZWwub3VlZHJhb2dvQGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBNYWtlIGN1c3RvbSBjb25z dHJ1Y3RvcnMgY29uc2lzdGVudCB3aXRoIGdlbmVyYXRlZCBiaW5kaW5ncyBjb2RlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggMzA3NWY3Y2MwM2JiZWE2ZWMzNmRkMzM1NDVkODY0YzQy M2I5ZmIzMi4uYjJmNGJjMWI1ODE2ZTA1ZTM3MTFmMWI1MWE2M2IxNDdmNTM0YzQ4OCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMTYwNSw3ICsxNjA1LDcgQEAgdm9pZCBGcmFtZVZp ZXc6OmFkanVzdE1lZGlhVHlwZUZvclByaW50aW5nKGJvb2wgcHJpbnRpbmcpCiAgICAgaWYgKHBy aW50aW5nKSB7CiAgICAgICAgIGlmIChtX21lZGlhVHlwZVdoZW5Ob3RQcmludGluZy5pc051bGwo KSkKICAgICAgICAgICAgIG1fbWVkaWFUeXBlV2hlbk5vdFByaW50aW5nID0gbWVkaWFUeXBlKCk7 Ci0gICAgICAgICAgICBzZXRNZWRpYVR5cGUoInByaW50Iik7CisgICAgICAgIHNldE1lZGlhVHlw ZSgicHJpbnQiKTsKICAgICB9IGVsc2UgewogICAgICAgICBpZiAoIW1fbWVkaWFUeXBlV2hlbk5v dFByaW50aW5nLmlzTnVsbCgpKQogICAgICAgICAgICAgc2V0TWVkaWFUeXBlKG1fbWVkaWFUeXBl V2hlbk5vdFByaW50aW5nKTsK