16124 2007-11-24 18:38:54 -0800 Add printf format attribute to several functions to fix some GCC warnings 2019-05-02 16:18:07 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 laszlo_gombos webkit-unassigned arkr17997 cdumez laszlo_gombos mrowe oldest_to_newest 62225 0 laszlo_gombos 2007-11-24 18:38:54 -0800 GCC has an extension to specify type check for format strings. See http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#Function-Attributes for details. This syntax is already used in PlatformString.h and in DeprecatedString.h in WebCore. This fix get rid of the following GCC warning XMLTokenizer.cpp:881: warning: function might be possible candidate for ‘printf’ format attribute 62226 1 17493 laszlo_gombos 2007-11-24 18:39:45 -0800 Created attachment 17493 Fix attached. 62233 2 17493 mjs 2007-11-24 19:08:31 -0800 Comment on attachment 17493 Fix attached. Substance of the change looks good. A few comments on style: 1) We usually use #if COMPILER(GCC) rather than #if __GNUC__ 2) It might be a good idea to make a macro that's defined to either the right attribtue or nothing depending on the compiler, to avoid sprinking the code with compiler #ifdefs. Please make those adjustments (feel free to also fix existing uses of the printf attribute). r- for now, will gladly re-review with those fixes. 62243 3 sam 2007-11-24 19:28:10 -0800 You can actually use the new WTF_ATTRIBUTE_PRINTF defined in wtf/Assertions.h for this. 62249 4 17497 laszlo_gombos 2007-11-24 20:41:38 -0800 Created attachment 17497 Revised patch Maciej, could not agree more. Sam, thanks for the tip. Revised patch attached. 62251 5 17497 mrowe 2007-11-24 20:54:51 -0800 Comment on attachment 17497 Revised patch The attributes on warningHandler, fatalErrorHandler and friends should probably go on the functions themselves rather than forward-declaring them such as you have. Why does handleError need the attribute? It does not appear to be used with a format string. 62252 6 17498 laszlo_gombos 2007-11-24 21:21:44 -0800 Created attachment 17498 2nd revised patch Mark, you're right about handleError(), I took it out from the patch. The format attribute can only be used in function declaration, that is why warningHandler() and friends needs to be forward-declared. 62258 7 mrowe 2007-11-24 23:04:58 -0800 (In reply to comment #6) > Created an attachment (id=17498) [edit] > 2nd revised patch > > Mark, you're right about handleError(), I took it out from the patch. > > The format attribute can only be used in function declaration, that is why > warningHandler() and friends needs to be forward-declared. I don't believe that is the case. See <http://trac.webkit.org/projects/webkit/browser/trunk/JavaScriptCore/wtf/Assertions.cpp?rev=27947#L50>, for instance. 62272 8 17498 sam 2007-11-25 03:58:16 -0800 Comment on attachment 17498 2nd revised patch r- based on marks comments 62283 9 17506 laszlo_gombos 2007-11-25 08:06:50 -0800 Created attachment 17506 3rd revised patch Mark, you're right, it compiles with GCC 4.1 - I checked. Revised patch attached. 62289 10 17506 sam 2007-11-25 11:18:06 -0800 Comment on attachment 17506 3rd revised patch r=me 62339 11 mrowe 2007-11-25 18:13:19 -0800 Landed in r28028. Thanks for being patient with the review process! 1502832 12 lforschler 2019-02-06 09:02:44 -0800 Mass moving XML DOM bugs to the "DOM" Component. 17493 2007-11-24 18:39:45 -0800 2007-11-24 20:41:38 -0800 Fix attached. printf_attr_patch.txt text/plain 2709 laszlo_gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI4MDA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTEt MjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uZ29tYm9zQGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcHJpbnRmIGZvcm1hdCBh dHRyaWJ1dGUgdG8gc2V2ZXJhbCBmdW5jdGlvbnMgdG8gZ2V0IHJpZCBvZgorICAgICAgICBzb21l IGNvbXBpbGVyIHdhcm5pbmdzIGFuZCBhZGQgbW9yZSB0eXBlLXNhZmV0eSB3aGVuIGNvbXBpbGVk IHdpdGggR0NDCisKKyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmNwcDoKKyAgICAgICAgKiBk b20vWE1MVG9rZW5pemVyLmg6CisKIDIwMDctMTEtMjQgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW0gSGF0Y2hlci4KSW5kZXg6IGRvbS9YTUxU b2tlbml6ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRvbS9YTUxUb2tlbml6ZXIuY3BwCShyZXZpc2lv biAyODAwOCkKKysrIGRvbS9YTUxUb2tlbml6ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCw2 ICs3OCwzMiBAQCB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogY29uc3QgaW50IG1heEVycm9y cyA9IDI1OwogCiAjaWZuZGVmIFVTRV9RWE1MU1RSRUFNCitzdGF0aWMgdm9pZCB3YXJuaW5nSGFu ZGxlcih2b2lkKiBjbG9zdXJlLCBjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pCisjaWYgX19HTlVD X18KKyAgICBfX2F0dHJpYnV0ZV9fICgoZm9ybWF0IChwcmludGYsIDIsIDMpKSkKKyNlbmRpZgor OworCitzdGF0aWMgdm9pZCBmYXRhbEVycm9ySGFuZGxlcih2b2lkKiBjbG9zdXJlLCBjb25zdCBj aGFyKiBtZXNzYWdlLCAuLi4pCisjaWYgX19HTlVDX18KKyAgICBfX2F0dHJpYnV0ZV9fICgoZm9y bWF0IChwcmludGYsIDIsIDMpKSkKKyNlbmRpZgorOworCitzdGF0aWMgdm9pZCBub3JtYWxFcnJv ckhhbmRsZXIodm9pZCogY2xvc3VyZSwgY29uc3QgY2hhciogbWVzc2FnZSwgLi4uKQorI2lmIF9f R05VQ19fCisgICAgX19hdHRyaWJ1dGVfXyAoKGZvcm1hdCAocHJpbnRmLCAyLCAzKSkpCisjZW5k aWYKKzsKKworc3RhdGljIHZvaWQgYmFsYW5jZWRXYXJuaW5nSGFuZGxlcih2b2lkKiBjbG9zdXJl LCBjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pCisjaWYgX19HTlVDX18KKyAgICBfX2F0dHJpYnV0 ZV9fICgoZm9ybWF0IChwcmludGYsIDIsIDMpKSkKKyNlbmRpZgorOworI2VuZGlmCisKKyNpZm5k ZWYgVVNFX1FYTUxTVFJFQU0KIGNsYXNzIFBlbmRpbmdDYWxsYmFja3MgewogcHVibGljOgogICAg IFBlbmRpbmdDYWxsYmFja3MoKQpJbmRleDogZG9tL1hNTFRva2VuaXplci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGRvbS9YTUxUb2tlbml6ZXIuaAkocmV2aXNpb24gMjgwMDgpCisrKyBkb20vWE1MVG9rZW5p emVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTg0LDcgKzg0LDEyIEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogI2lmbmRlZiBVU0VfUVhNTFNUUkVBTQogICAgICAgICAvLyBjYWxsYmFja3MgZnJvbSBw YXJzZXIgU0FYCi0gICAgICAgIHZvaWQgZXJyb3IoRXJyb3JUeXBlLCBjb25zdCBjaGFyKiBtZXNz YWdlLCB2YV9saXN0IGFyZ3MpOworICAgICAgICB2b2lkIGVycm9yKEVycm9yVHlwZSB0eXBlLCBj b25zdCBjaGFyKiBtZXNzYWdlLCB2YV9saXN0IGFyZ3MpCisjaWYgX19HTlVDX18KKyAgICAgICAg ICAgIF9fYXR0cmlidXRlX18gKChmb3JtYXQgKHByaW50ZiwgMywgMCkpKQorI2VuZGlmCisgICAg ICAgIDsKKwogICAgICAgICB2b2lkIHN0YXJ0RWxlbWVudE5zKGNvbnN0IHhtbENoYXIqIHhtbExv Y2FsTmFtZSwgY29uc3QgeG1sQ2hhciogeG1sUHJlZml4LCBjb25zdCB4bWxDaGFyKiB4bWxVUkks IGludCBuYl9uYW1lc3BhY2VzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHht bENoYXIqKiBuYW1lc3BhY2VzLCBpbnQgbmJfYXR0cmlidXRlcywgaW50IG5iX2RlZmF1bHRlZCwg Y29uc3QgeG1sQ2hhcioqIGxpYnhtbEF0dHJpYnV0ZXMpOwogICAgICAgICB2b2lkIGVuZEVsZW1l bnROcygpOwpAQCAtMTA5LDcgKzExNCwxMSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAg IGJvb2wgaGFzRXJyb3IoKSBjb25zdDsKICNlbmRpZgogCi0gICAgICAgIHZvaWQgaGFuZGxlRXJy b3IoRXJyb3JUeXBlIHR5cGUsIGNvbnN0IGNoYXIqIG0sIGludCBsaW5lTnVtYmVyLCBpbnQgY29s dW1uTnVtYmVyKTsKKyAgICAgICAgdm9pZCBoYW5kbGVFcnJvcihFcnJvclR5cGUgdHlwZSwgY29u c3QgY2hhciogbSwgaW50IGxpbmVOdW1iZXIsIGludCBjb2x1bW5OdW1iZXIpCisjaWYgX19HTlVD X18KKyAgICAgICAgICAgIF9fYXR0cmlidXRlX18gKChmb3JtYXQgKHByaW50ZiwgMywgMCkpKQor I2VuZGlmCisgICAgICAgIDsKIAogICAgICAgICB2aXJ0dWFsIGJvb2wgd2VsbEZvcm1lZCgpIGNv bnN0IHsgcmV0dXJuICFtX3Nhd0Vycm9yOyB9CiAK 17497 2007-11-24 20:41:38 -0800 2007-11-24 21:21:44 -0800 Revised patch printf_attr_patch.txt text/plain 3747 laszlo_gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI4MDEx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMTEt MjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uZ29tYm9zQGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcHJpbnRmIGZvcm1hdCBh dHRyaWJ1dGUgdG8gc2V2ZXJhbCBmdW5jdGlvbnMuIFVzZSB0aGUgdGhlIG5ldyBXVEZfQVRUUklC VVRFX1BSSU5URiBkZWZpbmUuCisKKyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmNwcDoKKyAg ICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmg6CisgICAgICAgICogcGxhdGZvcm0vRGVwcmVjYXRl ZFN0cmluZy5oOgorICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtU3RyaW5nLmg6CisKIDIwMDct MTEtMjQgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBUaW0gSGF0Y2hlci4KSW5kZXg6IGRvbS9YTUxUb2tlbml6ZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGRvbS9YTUxUb2tlbml6ZXIuY3BwCShyZXZpc2lvbiAyODAxMCkKKysrIGRvbS9YTUxUb2tlbml6 ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCw2ICs3OCwxMyBAQCB1c2luZyBuYW1lc3BhY2Ug SFRNTE5hbWVzOwogY29uc3QgaW50IG1heEVycm9ycyA9IDI1OwogCiAjaWZuZGVmIFVTRV9RWE1M U1RSRUFNCitzdGF0aWMgdm9pZCB3YXJuaW5nSGFuZGxlcih2b2lkKiBjbG9zdXJlLCBjb25zdCBj aGFyKiBtZXNzYWdlLCAuLi4pIFdURl9BVFRSSUJVVEVfUFJJTlRGKDIsIDMpOworc3RhdGljIHZv aWQgZmF0YWxFcnJvckhhbmRsZXIodm9pZCogY2xvc3VyZSwgY29uc3QgY2hhciogbWVzc2FnZSwg Li4uKSBXVEZfQVRUUklCVVRFX1BSSU5URigyLCAzKTsKK3N0YXRpYyB2b2lkIG5vcm1hbEVycm9y SGFuZGxlcih2b2lkKiBjbG9zdXJlLCBjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pIFdURl9BVFRS SUJVVEVfUFJJTlRGKDIsIDMpOworc3RhdGljIHZvaWQgYmFsYW5jZWRXYXJuaW5nSGFuZGxlcih2 b2lkKiBjbG9zdXJlLCBjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pIFdURl9BVFRSSUJVVEVfUFJJ TlRGKDIsIDMpOworI2VuZGlmCisKKyNpZm5kZWYgVVNFX1FYTUxTVFJFQU0KIGNsYXNzIFBlbmRp bmdDYWxsYmFja3MgewogcHVibGljOgogICAgIFBlbmRpbmdDYWxsYmFja3MoKQpJbmRleDogZG9t L1hNTFRva2VuaXplci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRvbS9YTUxUb2tlbml6ZXIuaAkocmV2aXNp b24gMjgwMTApCisrKyBkb20vWE1MVG9rZW5pemVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTg0LDcg Kzg0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAjaWZuZGVmIFVTRV9RWE1MU1RSRUFNCiAg ICAgICAgIC8vIGNhbGxiYWNrcyBmcm9tIHBhcnNlciBTQVgKLSAgICAgICAgdm9pZCBlcnJvcihF cnJvclR5cGUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UsIHZhX2xpc3QgYXJncyk7CisgICAgICAgIHZv aWQgZXJyb3IoRXJyb3JUeXBlLCBjb25zdCBjaGFyKiBtZXNzYWdlLCB2YV9saXN0IGFyZ3MpIFdU Rl9BVFRSSUJVVEVfUFJJTlRGKDMsIDApOyAKICAgICAgICAgdm9pZCBzdGFydEVsZW1lbnROcyhj b25zdCB4bWxDaGFyKiB4bWxMb2NhbE5hbWUsIGNvbnN0IHhtbENoYXIqIHhtbFByZWZpeCwgY29u c3QgeG1sQ2hhciogeG1sVVJJLCBpbnQgbmJfbmFtZXNwYWNlcywKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25zdCB4bWxDaGFyKiogbmFtZXNwYWNlcywgaW50IG5iX2F0dHJpYnV0ZXMs IGludCBuYl9kZWZhdWx0ZWQsIGNvbnN0IHhtbENoYXIqKiBsaWJ4bWxBdHRyaWJ1dGVzKTsKICAg ICAgICAgdm9pZCBlbmRFbGVtZW50TnMoKTsKQEAgLTEwOSw3ICsxMDksNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgICAgIGJvb2wgaGFzRXJyb3IoKSBjb25zdDsKICNlbmRpZgogCi0gICAg ICAgIHZvaWQgaGFuZGxlRXJyb3IoRXJyb3JUeXBlIHR5cGUsIGNvbnN0IGNoYXIqIG0sIGludCBs aW5lTnVtYmVyLCBpbnQgY29sdW1uTnVtYmVyKTsKKyAgICAgICAgdm9pZCBoYW5kbGVFcnJvcihF cnJvclR5cGUgdHlwZSwgY29uc3QgY2hhciogbSwgaW50IGxpbmVOdW1iZXIsIGludCBjb2x1bW5O dW1iZXIpIFdURl9BVFRSSUJVVEVfUFJJTlRGKDMsIDApOwogCiAgICAgICAgIHZpcnR1YWwgYm9v bCB3ZWxsRm9ybWVkKCkgY29uc3QgeyByZXR1cm4gIW1fc2F3RXJyb3I7IH0KIApJbmRleDogcGxh dGZvcm0vRGVwcmVjYXRlZFN0cmluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3JtL0RlcHJlY2F0 ZWRTdHJpbmcuaAkocmV2aXNpb24gMjgwMTApCisrKyBwbGF0Zm9ybS9EZXByZWNhdGVkU3RyaW5n LmgJKHdvcmtpbmcgY29weSkKQEAgLTM4NSwxMSArMzg1LDcgQEAgcHVibGljOgogICAgIERlcHJl Y2F0ZWRTdHJpbmcgJnNldE51bSh1bnNpZ25lZCBsb25nKTsKICAgICBEZXByZWNhdGVkU3RyaW5n ICZzZXROdW0oZG91YmxlKTsKIAotICAgIERlcHJlY2F0ZWRTdHJpbmcmIGZvcm1hdChjb25zdCBj aGFyICosIC4uLikgCi0jaWYgX19HTlVDX18KLSAgICBfX2F0dHJpYnV0ZV9fICgoZm9ybWF0IChw cmludGYsIDIsIDMpKSkKLSNlbmRpZgotICAgIDsKKyAgICBEZXByZWNhdGVkU3RyaW5nJiBmb3Jt YXQoY29uc3QgY2hhciAqLCAuLi4pIFdURl9BVFRSSUJVVEVfUFJJTlRGKDIsIDMpOwogCiAgICAg RGVwcmVjYXRlZFN0cmluZyAmYXBwZW5kKGNvbnN0IERlcHJlY2F0ZWRTdHJpbmcgJik7CiAgICAg RGVwcmVjYXRlZFN0cmluZyAmYXBwZW5kKERlcHJlY2F0ZWRDaGFyKTsKSW5kZXg6IHBsYXRmb3Jt L1BsYXRmb3JtU3RyaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vUGxhdGZvcm1TdHJpbmcu aAkocmV2aXNpb24gMjgwMTApCisrKyBwbGF0Zm9ybS9QbGF0Zm9ybVN0cmluZy5oCSh3b3JraW5n IGNvcHkpCkBAIC0xMzMsMTEgKzEzMyw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgU3RyaW5nIG51 bWJlcih1bnNpZ25lZCBsb25nIGxvbmcpOwogICAgIHN0YXRpYyBTdHJpbmcgbnVtYmVyKGRvdWJs ZSk7CiAgICAgCi0gICAgc3RhdGljIFN0cmluZyBmb3JtYXQoY29uc3QgY2hhciAqLCAuLi4pCi0j aWYgX19HTlVDX18KLSAgICAgICAgX19hdHRyaWJ1dGVfXyAoKGZvcm1hdCAocHJpbnRmLCAxLCAy KSkpCi0jZW5kaWYKLSAgICAgICAgOworICAgIHN0YXRpYyBTdHJpbmcgZm9ybWF0KGNvbnN0IGNo YXIgKiwgLi4uKSBXVEZfQVRUUklCVVRFX1BSSU5URigxLCAyKTsKIAogICAgIFZlY3RvcjxTdHJp bmc+IHNwbGl0KGNvbnN0IFN0cmluZyYgc2VwYXJhdG9yLCBib29sIGFsbG93RW1wdHlFbnRyaWVz ID0gZmFsc2UpIGNvbnN0OwogICAgIFZlY3RvcjxTdHJpbmc+IHNwbGl0KFVDaGFyIHNlcGFyYXRv ciwgYm9vbCBhbGxvd0VtcHR5RW50cmllcyA9IGZhbHNlKSBjb25zdDsK 17498 2007-11-24 21:21:44 -0800 2007-11-25 08:06:50 -0800 2nd revised patch printf_attr_patch.txt text/plain 3385 laszlo_gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI4MDEx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMTEt MjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uZ29tYm9zQGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcHJpbnRmIGZvcm1hdCBh dHRyaWJ1dGUgdG8gc2V2ZXJhbCBmdW5jdGlvbnMuIFVzZSB0aGUgdGhlIG5ldyBXVEZfQVRUUklC VVRFX1BSSU5URiBkZWZpbmUuCisKKyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmNwcDoKKyAg ICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmg6CisgICAgICAgICogcGxhdGZvcm0vRGVwcmVjYXRl ZFN0cmluZy5oOgorICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtU3RyaW5nLmg6CisKIDIwMDct MTEtMjQgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBUaW0gSGF0Y2hlci4KSW5kZXg6IGRvbS9YTUxUb2tlbml6ZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGRvbS9YTUxUb2tlbml6ZXIuY3BwCShyZXZpc2lvbiAyODAxMCkKKysrIGRvbS9YTUxUb2tlbml6 ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCw2ICs3OCwxMyBAQCB1c2luZyBuYW1lc3BhY2Ug SFRNTE5hbWVzOwogY29uc3QgaW50IG1heEVycm9ycyA9IDI1OwogCiAjaWZuZGVmIFVTRV9RWE1M U1RSRUFNCitzdGF0aWMgdm9pZCB3YXJuaW5nSGFuZGxlcih2b2lkKiBjbG9zdXJlLCBjb25zdCBj aGFyKiBtZXNzYWdlLCAuLi4pIFdURl9BVFRSSUJVVEVfUFJJTlRGKDIsIDMpOworc3RhdGljIHZv aWQgZmF0YWxFcnJvckhhbmRsZXIodm9pZCogY2xvc3VyZSwgY29uc3QgY2hhciogbWVzc2FnZSwg Li4uKSBXVEZfQVRUUklCVVRFX1BSSU5URigyLCAzKTsKK3N0YXRpYyB2b2lkIG5vcm1hbEVycm9y SGFuZGxlcih2b2lkKiBjbG9zdXJlLCBjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pIFdURl9BVFRS SUJVVEVfUFJJTlRGKDIsIDMpOworc3RhdGljIHZvaWQgYmFsYW5jZWRXYXJuaW5nSGFuZGxlcih2 b2lkKiBjbG9zdXJlLCBjb25zdCBjaGFyKiBtZXNzYWdlLCAuLi4pIFdURl9BVFRSSUJVVEVfUFJJ TlRGKDIsIDMpOworI2VuZGlmCisKKyNpZm5kZWYgVVNFX1FYTUxTVFJFQU0KIGNsYXNzIFBlbmRp bmdDYWxsYmFja3MgewogcHVibGljOgogICAgIFBlbmRpbmdDYWxsYmFja3MoKQpJbmRleDogZG9t L1hNTFRva2VuaXplci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRvbS9YTUxUb2tlbml6ZXIuaAkocmV2aXNp b24gMjgwMTApCisrKyBkb20vWE1MVG9rZW5pemVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTg0LDcg Kzg0LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAjaWZuZGVmIFVTRV9RWE1MU1RSRUFNCiAg ICAgICAgIC8vIGNhbGxiYWNrcyBmcm9tIHBhcnNlciBTQVgKLSAgICAgICAgdm9pZCBlcnJvcihF cnJvclR5cGUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UsIHZhX2xpc3QgYXJncyk7CisgICAgICAgIHZv aWQgZXJyb3IoRXJyb3JUeXBlLCBjb25zdCBjaGFyKiBtZXNzYWdlLCB2YV9saXN0IGFyZ3MpIFdU Rl9BVFRSSUJVVEVfUFJJTlRGKDMsIDApOyAKICAgICAgICAgdm9pZCBzdGFydEVsZW1lbnROcyhj b25zdCB4bWxDaGFyKiB4bWxMb2NhbE5hbWUsIGNvbnN0IHhtbENoYXIqIHhtbFByZWZpeCwgY29u c3QgeG1sQ2hhciogeG1sVVJJLCBpbnQgbmJfbmFtZXNwYWNlcywKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25zdCB4bWxDaGFyKiogbmFtZXNwYWNlcywgaW50IG5iX2F0dHJpYnV0ZXMs IGludCBuYl9kZWZhdWx0ZWQsIGNvbnN0IHhtbENoYXIqKiBsaWJ4bWxBdHRyaWJ1dGVzKTsKICAg ICAgICAgdm9pZCBlbmRFbGVtZW50TnMoKTsKSW5kZXg6IHBsYXRmb3JtL0RlcHJlY2F0ZWRTdHJp bmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9EZXByZWNhdGVkU3RyaW5nLmgJKHJldmlzaW9u IDI4MDEwKQorKysgcGxhdGZvcm0vRGVwcmVjYXRlZFN0cmluZy5oCSh3b3JraW5nIGNvcHkpCkBA IC0zODUsMTEgKzM4NSw3IEBAIHB1YmxpYzoKICAgICBEZXByZWNhdGVkU3RyaW5nICZzZXROdW0o dW5zaWduZWQgbG9uZyk7CiAgICAgRGVwcmVjYXRlZFN0cmluZyAmc2V0TnVtKGRvdWJsZSk7CiAK LSAgICBEZXByZWNhdGVkU3RyaW5nJiBmb3JtYXQoY29uc3QgY2hhciAqLCAuLi4pIAotI2lmIF9f R05VQ19fCi0gICAgX19hdHRyaWJ1dGVfXyAoKGZvcm1hdCAocHJpbnRmLCAyLCAzKSkpCi0jZW5k aWYKLSAgICA7CisgICAgRGVwcmVjYXRlZFN0cmluZyYgZm9ybWF0KGNvbnN0IGNoYXIgKiwgLi4u KSBXVEZfQVRUUklCVVRFX1BSSU5URigyLCAzKTsKIAogICAgIERlcHJlY2F0ZWRTdHJpbmcgJmFw cGVuZChjb25zdCBEZXByZWNhdGVkU3RyaW5nICYpOwogICAgIERlcHJlY2F0ZWRTdHJpbmcgJmFw cGVuZChEZXByZWNhdGVkQ2hhcik7CkluZGV4OiBwbGF0Zm9ybS9QbGF0Zm9ybVN0cmluZy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIHBsYXRmb3JtL1BsYXRmb3JtU3RyaW5nLmgJKHJldmlzaW9uIDI4MDEwKQor KysgcGxhdGZvcm0vUGxhdGZvcm1TdHJpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtMTMzLDExICsx MzMsNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFN0cmluZyBudW1iZXIodW5zaWduZWQgbG9uZyBs b25nKTsKICAgICBzdGF0aWMgU3RyaW5nIG51bWJlcihkb3VibGUpOwogICAgIAotICAgIHN0YXRp YyBTdHJpbmcgZm9ybWF0KGNvbnN0IGNoYXIgKiwgLi4uKQotI2lmIF9fR05VQ19fCi0gICAgICAg IF9fYXR0cmlidXRlX18gKChmb3JtYXQgKHByaW50ZiwgMSwgMikpKQotI2VuZGlmCi0gICAgICAg IDsKKyAgICBzdGF0aWMgU3RyaW5nIGZvcm1hdChjb25zdCBjaGFyICosIC4uLikgV1RGX0FUVFJJ QlVURV9QUklOVEYoMSwgMik7CiAKICAgICBWZWN0b3I8U3RyaW5nPiBzcGxpdChjb25zdCBTdHJp bmcmIHNlcGFyYXRvciwgYm9vbCBhbGxvd0VtcHR5RW50cmllcyA9IGZhbHNlKSBjb25zdDsKICAg ICBWZWN0b3I8U3RyaW5nPiBzcGxpdChVQ2hhciBzZXBhcmF0b3IsIGJvb2wgYWxsb3dFbXB0eUVu dHJpZXMgPSBmYWxzZSkgY29uc3Q7Cg== 17506 2007-11-25 08:06:50 -0800 2007-11-25 11:18:06 -0800 3rd revised patch printf_attr_patch.txt text/plain 3708 laszlo_gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI4MDE2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMTEt MjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uZ29tYm9zQGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcHJpbnRmIGZvcm1hdCBh dHRyaWJ1dGUgdG8gc2V2ZXJhbCBmdW5jdGlvbnMuIFVzZSB0aGUgdGhlIG5ldyBXVEZfQVRUUklC VVRFX1BSSU5URiBkZWZpbmUuCisKKyAgICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmNwcDoKKyAg ICAgICAgKiBkb20vWE1MVG9rZW5pemVyLmg6CisgICAgICAgICogcGxhdGZvcm0vRGVwcmVjYXRl ZFN0cmluZy5oOgorICAgICAgICAqIHBsYXRmb3JtL1BsYXRmb3JtU3RyaW5nLmg6CisKIDIwMDct MTEtMjIgIE5pa29sYXMgWmltbWVybWFubiAgPHppbW1lcm1hbm5Aa2RlLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogZG9tL1hNTFRva2VuaXplci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gZG9tL1hNTFRva2VuaXplci5jcHAJKHJldmlzaW9uIDI4MDE2KQorKysgZG9t L1hNTFRva2VuaXplci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNjUsNiArMTA2NSw3IEBAIHN0 YXRpYyB2b2lkIGNvbW1lbnRIYW5kbGVyKHZvaWQqIGNsb3N1cmUKICAgICBnZXRUb2tlbml6ZXIo Y2xvc3VyZSktPmNvbW1lbnQoY29tbWVudCk7CiB9CiAKK1dURl9BVFRSSUJVVEVfUFJJTlRGKDIs IDMpCiBzdGF0aWMgdm9pZCB3YXJuaW5nSGFuZGxlcih2b2lkKiBjbG9zdXJlLCBjb25zdCBjaGFy KiBtZXNzYWdlLCAuLi4pCiB7CiAgICAgdmFfbGlzdCBhcmdzOwpAQCAtMTA3Myw2ICsxMDc0LDcg QEAgc3RhdGljIHZvaWQgd2FybmluZ0hhbmRsZXIodm9pZCogY2xvc3VyZQogICAgIHZhX2VuZChh cmdzKTsKIH0KIAorV1RGX0FUVFJJQlVURV9QUklOVEYoMiwgMykKIHN0YXRpYyB2b2lkIGZhdGFs RXJyb3JIYW5kbGVyKHZvaWQqIGNsb3N1cmUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UsIC4uLikKIHsK ICAgICB2YV9saXN0IGFyZ3M7CkBAIC0xMDgxLDYgKzEwODMsNyBAQCBzdGF0aWMgdm9pZCBmYXRh bEVycm9ySGFuZGxlcih2b2lkKiBjbG9zCiAgICAgdmFfZW5kKGFyZ3MpOwogfQogCitXVEZfQVRU UklCVVRFX1BSSU5URigyLCAzKQogc3RhdGljIHZvaWQgbm9ybWFsRXJyb3JIYW5kbGVyKHZvaWQq IGNsb3N1cmUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UsIC4uLikKIHsKICAgICB2YV9saXN0IGFyZ3M7 CkBAIC0xNTUwLDYgKzE1NTMsNyBAQCBzdGF0aWMgdm9pZCBiYWxhbmNlZENvbW1lbnRIYW5kbGVy KHZvaWQqCiAgICAgc3RhdGljX2Nhc3Q8WE1MVG9rZW5pemVyKj4oY2xvc3VyZSktPmNvbW1lbnQo Y29tbWVudCk7CiB9CiAKK1dURl9BVFRSSUJVVEVfUFJJTlRGKDIsIDMpCiBzdGF0aWMgdm9pZCBi YWxhbmNlZFdhcm5pbmdIYW5kbGVyKHZvaWQqIGNsb3N1cmUsIGNvbnN0IGNoYXIqIG1lc3NhZ2Us IC4uLikKIHsKICAgICB2YV9saXN0IGFyZ3M7CkluZGV4OiBkb20vWE1MVG9rZW5pemVyLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gZG9tL1hNTFRva2VuaXplci5oCShyZXZpc2lvbiAyODAxNikKKysrIGRvbS9Y TUxUb2tlbml6ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODQsNyArODQsNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKICNpZm5kZWYgVVNFX1FYTUxTVFJFQU0KICAgICAgICAgLy8gY2FsbGJhY2tz IGZyb20gcGFyc2VyIFNBWAotICAgICAgICB2b2lkIGVycm9yKEVycm9yVHlwZSwgY29uc3QgY2hh ciogbWVzc2FnZSwgdmFfbGlzdCBhcmdzKTsKKyAgICAgICAgdm9pZCBlcnJvcihFcnJvclR5cGUs IGNvbnN0IGNoYXIqIG1lc3NhZ2UsIHZhX2xpc3QgYXJncykgV1RGX0FUVFJJQlVURV9QUklOVEYo MywgMCk7IAogICAgICAgICB2b2lkIHN0YXJ0RWxlbWVudE5zKGNvbnN0IHhtbENoYXIqIHhtbExv Y2FsTmFtZSwgY29uc3QgeG1sQ2hhciogeG1sUHJlZml4LCBjb25zdCB4bWxDaGFyKiB4bWxVUkks IGludCBuYl9uYW1lc3BhY2VzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHht bENoYXIqKiBuYW1lc3BhY2VzLCBpbnQgbmJfYXR0cmlidXRlcywgaW50IG5iX2RlZmF1bHRlZCwg Y29uc3QgeG1sQ2hhcioqIGxpYnhtbEF0dHJpYnV0ZXMpOwogICAgICAgICB2b2lkIGVuZEVsZW1l bnROcygpOwpJbmRleDogcGxhdGZvcm0vRGVwcmVjYXRlZFN0cmluZy5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHBsYXRmb3JtL0RlcHJlY2F0ZWRTdHJpbmcuaAkocmV2aXNpb24gMjgwMTYpCisrKyBwbGF0Zm9y bS9EZXByZWNhdGVkU3RyaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTM4NSwxMSArMzg1LDcgQEAg cHVibGljOgogICAgIERlcHJlY2F0ZWRTdHJpbmcgJnNldE51bSh1bnNpZ25lZCBsb25nKTsKICAg ICBEZXByZWNhdGVkU3RyaW5nICZzZXROdW0oZG91YmxlKTsKIAotICAgIERlcHJlY2F0ZWRTdHJp bmcmIGZvcm1hdChjb25zdCBjaGFyICosIC4uLikgCi0jaWYgX19HTlVDX18KLSAgICBfX2F0dHJp YnV0ZV9fICgoZm9ybWF0IChwcmludGYsIDIsIDMpKSkKLSNlbmRpZgotICAgIDsKKyAgICBEZXBy ZWNhdGVkU3RyaW5nJiBmb3JtYXQoY29uc3QgY2hhciAqLCAuLi4pIFdURl9BVFRSSUJVVEVfUFJJ TlRGKDIsIDMpOwogCiAgICAgRGVwcmVjYXRlZFN0cmluZyAmYXBwZW5kKGNvbnN0IERlcHJlY2F0 ZWRTdHJpbmcgJik7CiAgICAgRGVwcmVjYXRlZFN0cmluZyAmYXBwZW5kKERlcHJlY2F0ZWRDaGFy KTsKSW5kZXg6IHBsYXRmb3JtL1BsYXRmb3JtU3RyaW5nLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZv cm0vUGxhdGZvcm1TdHJpbmcuaAkocmV2aXNpb24gMjgwMTYpCisrKyBwbGF0Zm9ybS9QbGF0Zm9y bVN0cmluZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMsMTEgKzEzMyw3IEBAIHB1YmxpYzoKICAg ICBzdGF0aWMgU3RyaW5nIG51bWJlcih1bnNpZ25lZCBsb25nIGxvbmcpOwogICAgIHN0YXRpYyBT dHJpbmcgbnVtYmVyKGRvdWJsZSk7CiAgICAgCi0gICAgc3RhdGljIFN0cmluZyBmb3JtYXQoY29u c3QgY2hhciAqLCAuLi4pCi0jaWYgX19HTlVDX18KLSAgICAgICAgX19hdHRyaWJ1dGVfXyAoKGZv cm1hdCAocHJpbnRmLCAxLCAyKSkpCi0jZW5kaWYKLSAgICAgICAgOworICAgIHN0YXRpYyBTdHJp bmcgZm9ybWF0KGNvbnN0IGNoYXIgKiwgLi4uKSBXVEZfQVRUUklCVVRFX1BSSU5URigxLCAyKTsK IAogICAgIFZlY3RvcjxTdHJpbmc+IHNwbGl0KGNvbnN0IFN0cmluZyYgc2VwYXJhdG9yLCBib29s IGFsbG93RW1wdHlFbnRyaWVzID0gZmFsc2UpIGNvbnN0OwogICAgIFZlY3RvcjxTdHJpbmc+IHNw bGl0KFVDaGFyIHNlcGFyYXRvciwgYm9vbCBhbGxvd0VtcHR5RW50cmllcyA9IGZhbHNlKSBjb25z dDsK