161222 2016-08-25 18:54:37 -0700 EWS should indicate which bot processed the patch 2016-08-29 14:53:30 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161223 https://bugs.webkit.org/show_bug.cgi?id=161220 https://bugs.webkit.org/show_bug.cgi?id=161280 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates lforschler oldest_to_newest 1223362 0 aakash_jain 2016-08-25 18:54:37 -0700 Currently, it is hard to find out which bot processed a patch. Current method is to ssh in all the bots and look into the logs. EWS should clearly indicate which patch is being processed by which bot. 1223372 1 287062 aakash_jain 2016-08-25 19:11:39 -0700 Created attachment 287062 Proposed patch 1223392 2 287062 dbates 2016-08-25 20:23:15 -0700 Comment on attachment 287062 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=287062&action=review > Tools/QueueStatusServer/handlers/statusbubble.py:134 > + bubble["details_message"] = (statuses[0].bot_id + ", Recent messages:\n\n" Unit test? 1223393 3 287062 dbates 2016-08-25 20:24:12 -0700 Comment on attachment 287062 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=287062&action=review >> Tools/QueueStatusServer/handlers/statusbubble.py:134 >> + bubble["details_message"] = (statuses[0].bot_id + ", Recent messages:\n\n" > > Unit test? R => r ? 1223445 4 287082 aakash_jain 2016-08-26 02:05:12 -0700 Created attachment 287082 updated patch Changed R => r in " Recent messages". Also added "Started processing patch" message to progress_statuses, without this EWS will consider this as failure status and make the status bubbles orange. This particular code is in Tools/QueueStatusServer, we haven't maintained unit-tests for QueueStatusServer. 1223458 5 commit-queue 2016-08-26 02:45:18 -0700 The commit-queue encountered the following flaky tests while processing attachment 287082: The commit-queue is continuing to process your patch. 1223462 6 commit-queue 2016-08-26 02:46:12 -0700 The commit-queue encountered the following flaky tests while processing attachment 287082: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch. 1223471 7 287082 commit-queue 2016-08-26 03:56:41 -0700 Comment on attachment 287082 updated patch Clearing flags on attachment: 287082 Committed r205010: <http://trac.webkit.org/changeset/205010> 1223472 8 commit-queue 2016-08-26 03:56:46 -0700 All reviewed patches have been landed. Closing bug. 1223538 9 ap 2016-08-26 09:22:06 -0700 This seems somewhat confusing to me. A patch can move from one bot to another. If a test cycle finishes without a result, the lock is simply dropped, and any bot is free to pick up the patch for a retry. Which of the bots is given here, the first one or the current one? In either case, we need to make it explicit in the status. 1223576 10 aakash_jain 2016-08-26 10:38:36 -0700 In this patch, bot is shown only when patch is in processing, and it shows the first bot. Will write another patch to cover all the cases. 1224239 11 aakash_jain 2016-08-29 11:40:41 -0700 https://bugs.webkit.org/show_bug.cgi?id=161280 covers all the cases. It shows bot number corresponding to each status message. e.g.: https://webkit-queues.webkit.org/patch/287182 1224243 12 ap 2016-08-29 11:42:46 -0700 As far as I can tell, the bubble remains incorrect/confusing. 1224244 13 aakash_jain 2016-08-29 11:43:59 -0700 yeah, should we revert the bubble change done in this bug, or try to display bot_id in each status message in the bubble? 1224343 14 287322 aakash_jain 2016-08-29 14:08:32 -0700 Created attachment 287322 Semi-reverting this patch Removing bot id from status bubble. We still need other changes made in the previous patch. 1224362 15 ap 2016-08-29 14:21:49 -0700 Re-opening for CQ to work on the new patch. 1224372 16 287322 commit-queue 2016-08-29 14:53:25 -0700 Comment on attachment 287322 Semi-reverting this patch Clearing flags on attachment: 287322 Committed r205149: <http://trac.webkit.org/changeset/205149> 1224373 17 commit-queue 2016-08-29 14:53:30 -0700 All reviewed patches have been landed. Closing bug. 287062 2016-08-25 19:11:39 -0700 2016-08-26 02:05:12 -0700 Proposed patch ews-status-bubble-display-bot_id text/plain 1702 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNTAwMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA4LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1Mgc2hvdWxkIGluZGljYXRlIHdoaWNoIGJvdCBwcm9jZXNzZWQgdGhl IHBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjEyMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFF1ZXVlU3RhdHVzU2VydmVyL2hhbmRsZXJzL3N0YXR1c2J1YmJsZS5weToKKyAgICAgICAgKFN0 YXR1c0J1YmJsZS5fYnVpbGRfYnViYmxlKTogRGlzcGxheSB0aGUgYm90IGlkIGluIHN0YXR1cyBi dWJibGUuIEFsc28gcmVtb3ZlZCAiU3RhcnRlZCBwcm9jZXNzaW5nIiBtZXNzYWdlIHNpbmNlCisg ICAgICAgIGFmdGVyIGJ1ZyBmaXggb2YgMTYxMjIzLCBib3RzIHNlbmQgdGhlICJTdGFydGVkIHBy b2Nlc3NpbmcgcGF0Y2giIG1lc3NhZ2UgYW5kIGl0IHdvdWxkIGJlIGRpc3BsYXllZCBpbiBSZWNl bnQgbWVzc2FnZXMuCisgICAgICAgIEkgbWlnaHQgY29uc2lkZXIgZGlzcGxheWluZyBib3QgaWQg aW4gb3RoZXIgc3RhdHVzZXMgYXMgd2VsbCBsYXRlciBvbi4KKwogMjAxNi0wOC0yNSAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIENNYWtlIGJ1 aWxkIGZpeC4KSW5kZXg6IFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2hhbmRsZXJzL3N0YXR1c2J1 YmJsZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9z dGF0dXNidWJibGUucHkJKHJldmlzaW9uIDIwNTAwMSkKKysrIFRvb2xzL1F1ZXVlU3RhdHVzU2Vy dmVyL2hhbmRsZXJzL3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBjb3B5KQpAQCAtMTMxLDcgKzEz MSw3IEBAIGNsYXNzIFN0YXR1c0J1YmJsZSh3ZWJhcHAuUmVxdWVzdEhhbmRsZXIKICAgICAgICAg ICAgICAgICBzdGF0dXNlcykpCiAgICAgICAgICAgICBpZiBub3QgbGF0ZXN0X3Jlc3VsdGF0aXZl X3N0YXR1czoKICAgICAgICAgICAgICAgICBidWJibGVbInN0YXRlIl0gPSAic3RhcnRlZCIKLSAg ICAgICAgICAgICAgICBidWJibGVbImRldGFpbHNfbWVzc2FnZSJdID0gKCJTdGFydGVkIHByb2Nl c3NpbmcuXG5cblJlY2VudCBtZXNzYWdlczpcblxuIgorICAgICAgICAgICAgICAgIGJ1YmJsZVsi ZGV0YWlsc19tZXNzYWdlIl0gPSAoc3RhdHVzZXNbMF0uYm90X2lkICsgIiwgUmVjZW50IG1lc3Nh Z2VzOlxuXG4iCiAgICAgICAgICAgICAgICAgICAgICsgIlxuIi5qb2luKFtzdGF0dXMubWVzc2Fn ZSBmb3Igc3RhdHVzIGluIHN0YXR1c2VzXSkgKyAiXG5cbiIgKyBzZWxmLl9pc29fdGltZShzdGF0 dXNlc1swXS5kYXRlKSkKICAgICAgICAgICAgIGVsaWYgc3RhdHVzZXNbMF0ubWVzc2FnZSA9PSAi UGFzcyI6CiAgICAgICAgICAgICAgICAgYnViYmxlWyJzdGF0ZSJdID0gInBhc3MiCg== 287082 2016-08-26 02:05:12 -0700 2016-08-26 03:56:41 -0700 updated patch ews-status-bubble-display-bot_id1 text/plain 2046 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNTAwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTA4LTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1Mgc2hvdWxkIGluZGljYXRlIHdoaWNoIGJvdCBwcm9jZXNzZWQgdGhl IHBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjEyMjIKKworICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAgICAgICAgKiBR dWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9zdGF0dXNidWJibGUucHk6CisgICAgICAgIChTdGF0 dXNCdWJibGUuX2J1aWxkX2J1YmJsZSk6IERpc3BsYXkgdGhlIGJvdCBpZCBpbiBzdGF0dXMgYnVi YmxlLiBBbHNvIHJlbW92ZWQgIlN0YXJ0ZWQgcHJvY2Vzc2luZyIgbWVzc2FnZSBzaW5jZQorICAg ICAgICBhZnRlciBidWcgZml4IG9mIDE2MTIyMywgYm90cyBzZW5kIHRoZSAiU3RhcnRlZCBwcm9j ZXNzaW5nIHBhdGNoIiBtZXNzYWdlIGFuZCBpdCB3b3VsZCBiZSBkaXNwbGF5ZWQgaW4gUmVjZW50 IG1lc3NhZ2VzLgorICAgICAgICBBbHNvIGFkZGVkICJTdGFydGVkIHByb2Nlc3NpbmcgcGF0Y2gi IG1lc3NhZ2UgdG8gcHJvZ3Jlc3Nfc3RhdHVzZXMuCisgICAgICAgIEkgbWlnaHQgY29uc2lkZXIg ZGlzcGxheWluZyBib3QgaWQgaW4gb3RoZXIgc3RhdHVzZXMgYXMgd2VsbCBsYXRlciBvbi4KKwog MjAxNi0wOC0yNiAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgW0VGTF0gQ2hhbmdlIGhvbWVwYWdlIHVybCB0byB3d3cuZXdlYmtpdC5vcmcgb24gTWlu aUJyb3dzZXIKSW5kZXg6IFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2hhbmRsZXJzL3N0YXR1c2J1 YmJsZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9oYW5kbGVycy9z dGF0dXNidWJibGUucHkJKHJldmlzaW9uIDIwNTAwOSkKKysrIFRvb2xzL1F1ZXVlU3RhdHVzU2Vy dmVyL2hhbmRsZXJzL3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBjb3B5KQpAQCAtNDAsNiArNDAs NyBAQCBmcm9tIG1vZGVsLndvcmtpdGVtcyBpbXBvcnQgV29ya0l0ZW1zCiBmcm9tIHNldHMgaW1w b3J0IFNldAogCiBwcm9ncmVzc19zdGF0dXNlcyA9IFNldChbCisgICAgIlN0YXJ0ZWQgcHJvY2Vz c2luZyBwYXRjaCIsCiAgICAgIkNsZWFuZWQgd29ya2luZyBkaXJlY3RvcnkiLAogICAgICJVcGRh dGVkIHdvcmtpbmcgZGlyZWN0b3J5IiwKICAgICAiQXBwbGllZCBwYXRjaCIsCkBAIC0xMzEsNyAr MTMyLDcgQEAgY2xhc3MgU3RhdHVzQnViYmxlKHdlYmFwcC5SZXF1ZXN0SGFuZGxlcgogICAgICAg ICAgICAgICAgIHN0YXR1c2VzKSkKICAgICAgICAgICAgIGlmIG5vdCBsYXRlc3RfcmVzdWx0YXRp dmVfc3RhdHVzOgogICAgICAgICAgICAgICAgIGJ1YmJsZVsic3RhdGUiXSA9ICJzdGFydGVkIgot ICAgICAgICAgICAgICAgIGJ1YmJsZVsiZGV0YWlsc19tZXNzYWdlIl0gPSAoIlN0YXJ0ZWQgcHJv Y2Vzc2luZy5cblxuUmVjZW50IG1lc3NhZ2VzOlxuXG4iCisgICAgICAgICAgICAgICAgYnViYmxl WyJkZXRhaWxzX21lc3NhZ2UiXSA9IChzdGF0dXNlc1swXS5ib3RfaWQgKyAiLCByZWNlbnQgbWVz c2FnZXM6XG5cbiIKICAgICAgICAgICAgICAgICAgICAgKyAiXG4iLmpvaW4oW3N0YXR1cy5tZXNz YWdlIGZvciBzdGF0dXMgaW4gc3RhdHVzZXNdKSArICJcblxuIiArIHNlbGYuX2lzb190aW1lKHN0 YXR1c2VzWzBdLmRhdGUpKQogICAgICAgICAgICAgZWxpZiBzdGF0dXNlc1swXS5tZXNzYWdlID09 ICJQYXNzIjoKICAgICAgICAgICAgICAgICBidWJibGVbInN0YXRlIl0gPSAicGFzcyIK 287322 2016-08-29 14:08:32 -0700 2016-08-29 14:53:25 -0700 Semi-reverting this patch ews-status-bubble-remove-bot_id text/plain 1552 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNTE0MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTA4LTI5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1Mgc2hvdWxkIGluZGljYXRlIHdoaWNoIGJvdCBwcm9jZXNzZWQgdGhl IHBhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjEyMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFF1ZXVlU3RhdHVzU2VydmVyL2hhbmRsZXJzL3N0YXR1c2J1YmJsZS5weToKKyAgICAgICAgKFN0 YXR1c0J1YmJsZS5fYnVpbGRfYnViYmxlKTogUmVtb3ZlIHRoZSBib3QgaWQgZnJvbSBidWJibGVz IGFzIGl0IGlzIGNvbmZ1c2luZy4KKyAgICAgICAgYm90IGlkcyBhcmUgbm93IGRpc3BsYXllZCBp biBwYXRjaCBzdGF0dXMgcGFnZS4KKwogMjAxNi0wOC0yOSAgSkYgQmFzdGllbiAgPGpmYmFzdGll bkBhcHBsZS5jb20+CiAKICAgICAgICAgQnVnIDE2MTE2NSAtIGNoZWNrLXdlYmtpdC1zdHlsZSBk b2Vzbid0IHVuZGVyc3RhbmQgbWFjcm9zIGNvbnRhaW5pbmcgYGVsc2VgIG9yIGxhYmVscwpJbmRl eDogVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvaGFuZGxlcnMvc3RhdHVzYnViYmxlLnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2hhbmRsZXJzL3N0YXR1c2J1YmJsZS5w eQkocmV2aXNpb24gMjA1MTQyKQorKysgVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvaGFuZGxlcnMv c3RhdHVzYnViYmxlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMzIsNyArMTMyLDcgQEAgY2xhc3Mg U3RhdHVzQnViYmxlKHdlYmFwcC5SZXF1ZXN0SGFuZGxlcgogICAgICAgICAgICAgICAgIHN0YXR1 c2VzKSkKICAgICAgICAgICAgIGlmIG5vdCBsYXRlc3RfcmVzdWx0YXRpdmVfc3RhdHVzOgogICAg ICAgICAgICAgICAgIGJ1YmJsZVsic3RhdGUiXSA9ICJzdGFydGVkIgotICAgICAgICAgICAgICAg IGJ1YmJsZVsiZGV0YWlsc19tZXNzYWdlIl0gPSAoc3RhdHVzZXNbMF0uYm90X2lkICsgIiwgcmVj ZW50IG1lc3NhZ2VzOlxuXG4iCisgICAgICAgICAgICAgICAgYnViYmxlWyJkZXRhaWxzX21lc3Nh Z2UiXSA9ICgiUmVjZW50IG1lc3NhZ2VzOlxuXG4iCiAgICAgICAgICAgICAgICAgICAgICsgIlxu Ii5qb2luKFtzdGF0dXMubWVzc2FnZSBmb3Igc3RhdHVzIGluIHN0YXR1c2VzXSkgKyAiXG5cbiIg KyBzZWxmLl9pc29fdGltZShzdGF0dXNlc1swXS5kYXRlKSkKICAgICAgICAgICAgIGVsaWYgc3Rh dHVzZXNbMF0ubWVzc2FnZSA9PSAiUGFzcyI6CiAgICAgICAgICAgICAgICAgYnViYmxlWyJzdGF0 ZSJdID0gInBhc3MiCg==