161196 2016-08-25 09:37:45 -0700 generate-js-builtins.py should generate platform independent files 2016-08-25 11:41:15 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy bburg cgarcia clopez commit-queue gyuyoung.kim keith_miller mark.lam msaboff ossy saam youennf oldest_to_newest 1223084 0 ossy 2016-08-25 09:37:45 -0700 Now the order of the members are differnt on Mac and Linux platforms. I think the problem is that these members are stored in a set and the iteration order is different on different platforms. https://bugs.webkit.org/show_bug.cgi?id=159971#c18 EFL bot: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/29485 GTK bot: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/17870 1223091 1 286977 ossy 2016-08-25 09:49:33 -0700 Created attachment 286977 Patch 1223092 2 commit-queue 2016-08-25 09:51:16 -0700 This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`) 1223093 3 286977 mark.lam 2016-08-25 09:52:59 -0700 Comment on attachment 286977 Patch r=me 1223149 4 286977 commit-queue 2016-08-25 11:41:10 -0700 Comment on attachment 286977 Patch Clearing flags on attachment: 286977 Committed r204979: <http://trac.webkit.org/changeset/204979> 1223150 5 commit-queue 2016-08-25 11:41:15 -0700 All reviewed patches have been landed. Closing bug. 286977 2016-08-25 09:49:33 -0700 2016-08-25 11:41:10 -0700 Patch bug-161196-20160825184730.patch text/plain 1512 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0OTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YzgyYTFiNDU5MzljNjdlZjlkYjVkMzg0MzBmMjhiYzFjOWFmZDM1Li4wYWNiMTlkMWYzYzM1M2E2 NTY1NzVkNzBkYTcyYzQxMzkwMGMzNTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wOC0yNSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIGdlbmVyYXRlLWpzLWJ1aWx0aW5zLnB5IHNob3VsZCBnZW5lcmF0ZSBw bGF0Zm9ybSBpbmRlcGVuZGVudCBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2dlbmVyYXRlLWpzLWJ1aWx0aW5zLnB5OiBGaWxl cyBzaG91bGQgYmUgcHJvY2Vzc2VkIGluIGZpeGVkIG9yZGVyLgorCiAyMDE2LTA4LTI1ICBDYWlv IExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBOZXdSZWdleHAgc2hvdWxk IG5vdCBwcmV2ZW50IGlubGluaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv U2NyaXB0cy9nZW5lcmF0ZS1qcy1idWlsdGlucy5weSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9T Y3JpcHRzL2dlbmVyYXRlLWpzLWJ1aWx0aW5zLnB5CmluZGV4IDkxMWYxMzZjYmU1M2U1YTZjODUx MmNiMDZmNTA1Y2ZiZWI5NzIzNzMuLmMzZTQ5OGE5NWViMmFlZjVlNmJmYmQ3NDA4ZTM5MjkzNmY3 ODYwNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL2dlbmVyYXRl LWpzLWJ1aWx0aW5zLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL2dlbmVy YXRlLWpzLWJ1aWx0aW5zLnB5CkBAIC0xNDYsNyArMTQ2LDcgQEAgaWYgX19uYW1lX18gPT0gJ19f bWFpbl9fJzoKICAgICAgICAgZm9yIGZpbGVwYXRoIGluIG9zLmxpc3RkaXIoYXJnX29wdGlvbnMu aW5wdXRfZGlyZWN0b3J5KToKICAgICAgICAgICAgIGlucHV0X2ZpbGVwYXRocy5hcHBlbmQob3Mu cGF0aC5qb2luKGFyZ19vcHRpb25zLmlucHV0X2RpcmVjdG9yeSwgZmlsZXBhdGgpKQogCi0gICAg aW5wdXRfZmlsZXBhdGhzID0gZmlsdGVyKGxhbWJkYSBuYW1lOiBmbm1hdGNoLmZubWF0Y2gobmFt ZSwgJyouanMnKSwgaW5wdXRfZmlsZXBhdGhzKQorICAgIGlucHV0X2ZpbGVwYXRocyA9IHNvcnRl ZChmaWx0ZXIobGFtYmRhIG5hbWU6IGZubWF0Y2guZm5tYXRjaChuYW1lLCAnKi5qcycpLCBpbnB1 dF9maWxlcGF0aHMpKQogCiAgICAgb3B0aW9ucyA9IHsKICAgICAgICAgJ291dHB1dF9wYXRoJzog YXJnX29wdGlvbnMub3V0cHV0X2RpcmVjdG9yeSwK