161156 2016-08-24 12:50:07 -0700 REGRESSION: js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html has a flaky failure 2017-06-12 15:14:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad fpizlo ap benjamin csaavedra fpizlo ggaren jfbastien keith_miller mark.lam msaboff rniwa saam sam webkit-bug-importer ysuzuki oldest_to_newest 1222787 0 ryanhaddad 2016-08-24 12:50:07 -0700 LayoutTest js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html is a flaky failure https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20(Tests)/builds/17320 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fprototype-chain-caching-with-impure-get-own-property-slot-traps-5.html --- /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-actual.txt @@ -48,8 +48,8 @@ PASS typeof f() is "function" PASS typeof f() is "function" PASS typeof f() is "function" -PASS typeof f() is "object" -PASS typeof f() is "object" +FAIL typeof f() should be object. Was function. +FAIL typeof f() should be object. Was function. PASS typeof f() is "object" PASS typeof f() is "object" PASS typeof f() is "object" 1224665 1 ryanhaddad 2016-08-30 12:44:29 -0700 Marked test as flaky on mac in http://trac.webkit.org/projects/webkit/changeset/205196 1224731 2 rniwa 2016-08-30 15:02:06 -0700 Oh this is a real regression. We're not clearing the inline cache in time sometimes! 1225332 3 webkit-bug-importer 2016-09-01 09:04:33 -0700 <rdar://problem/28116283> 1317016 4 312334 fpizlo 2017-06-08 12:43:17 -0700 Created attachment 312334 the patch 1317022 5 fpizlo 2017-06-08 13:08:50 -0700 Landed in https://trac.webkit.org/changeset/217944/webkit 1317349 6 csaavedra 2017-06-09 04:27:15 -0700 The test is missing an expectation file. Is this intentional? 1317351 7 ysuzuki 2017-06-09 04:29:49 -0700 (In reply to Claudio Saavedra from comment #6) > The test is missing an expectation file. Is this intentional? I don't think so. We should add expectation file. 1317635 8 ryanhaddad 2017-06-09 14:40:30 -0700 (In reply to Yusuke Suzuki from comment #7) > (In reply to Claudio Saavedra from comment #6) > > The test is missing an expectation file. Is this intentional? > > I don't think so. We should add expectation file. I went ahead and added one in https://trac.webkit.org/changeset/218013/webkit 1317946 9 sam 2017-06-10 19:04:02 -0700 platform/Mac/TestExpectations still has js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html listed as [ Pass Failure ], pointing to this bug. Can we remove it from the list now? 1318320 10 saam 2017-06-12 12:00:42 -0700 (In reply to Sam Weinig from comment #9) > platform/Mac/TestExpectations still has > js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5. > html listed as [ Pass Failure ], pointing to this bug. Can we remove it from > the list now? I went ahead and did this: https://trac.webkit.org/changeset/218122/webkit 1318397 11 sam 2017-06-12 15:14:23 -0700 (In reply to Saam Barati from comment #10) > (In reply to Sam Weinig from comment #9) > > platform/Mac/TestExpectations still has > > js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5. > > html listed as [ Pass Failure ], pointing to this bug. Can we remove it from > > the list now? > > I went ahead and did this: > https://trac.webkit.org/changeset/218122/webkit Cool cool. 312334 2017-06-08 12:43:17 -0700 2017-06-08 12:45:07 -0700 the patch blah.patch text/plain 4031 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE3OTQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE3LTA2LTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTjoganMvZG9tL3Byb3RvdHlwZS1jaGFpbi1jYWNoaW5nLXdpdGgtaW1wdXJlLWdl dC1vd24tcHJvcGVydHktc2xvdC10cmFwcy01Lmh0bWwgaGFzIGEgZmxha3kgZmFpbHVyZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMTU2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBTaW5j ZSBMTEludCBkb2VzIG5vdCByZWdpc3RlciBpbXB1cmUgcHJvcGVydHkgd2F0Y2hwb2ludHMgZm9y IHNlbGYgcHJvcGVydHkgYWNjZXNzZXMsIGl0CisgICAgICAgIHNob3VsZG4ndCB0cnkgdG8gY2Fj aGUgYWNjZXNzZXMgdGhhdCByZXF1aXJlIGEgd2F0Y2hwb2ludC4KKyAgICAgICAgCisgICAgICAg IFRoaXMgbWFuaWZlc3RlZCBhcyBhIGZsYWt5IGZhaWx1cmUgYmVjYXVzZSB0aGUgdGVzdCB3b3Vs ZCBmaXJlIHRoZSB3YXRjaHBvaW50IGFmdGVyIHdlIGhhZAorICAgICAgICB1c3VhbGx5IGFscmVh ZHkgdGllcmVkIHVwLiBXaXRob3V0IGNvbmN1cnJlbnQgSklULCB3ZSB3b3VsZCBoYXZlIGFsd2F5 cyB0aWVyZWQgdXAgYmVmb3JlCisgICAgICAgIGdldHRpbmcgdG8gdGhlIGJhZCBjYXNlLiBXaXRo IGNvbmN1cnJlbnQgSklULCB3ZSB3b3VsZCBzb21ldGltZXMgbm90IHRpZXIgdXAgYnkgdGhhdCB0 aW1lLiBUaGlzCisgICAgICAgIGFsc28gYWRkcyBhIHRlc3QgdGhhdCBkZXRlcm1pbmlzdGljYWxs eSBmYWlsZWQgaW4gTExJbnQgd2l0aG91dCB0aGlzIGNoYW5nZTsgaXQgZG9lcyBzbyBieSBqdXN0 CisgICAgICAgIHJ1bm5pbmcgYSBsb3Qgc2hvcnRlci4KKworICAgICAgICAqIGxsaW50L0xMSW50 U2xvd1BhdGhzLmNwcDoKKyAgICAgICAgKEpTQzo6TExJbnQ6OkxMSU5UX1NMT1dfUEFUSF9ERUNM KToKKwogMjAxNy0wNi0wOCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWJBc3NlbWJseTogV2Ugc2hvdWxkIG9ubHkgY3JlYXRlIHdyYXBwZXJzIGZv ciBmdW5jdGlvbnMgdGhhdCBjYW4gYmUgZXhwb3J0ZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9MTEludFNsb3dQYXRocy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAkocmV2aXNpb24gMjE3ODY0KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjczLDcgKzY3Myw4IEBAIExMSU5UX1NMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9n ZXRfYnlfaWQKICAgICAgICAgICAgIC8vIFByZXZlbnQgdGhlIHByb3RvdHlwZSBjYWNoZSBmcm9t IGV2ZXIgaGFwcGVuaW5nLgogICAgICAgICAgICAgcGNbN10udS5vcGVyYW5kID0gMDsKICAgICAg ICAgCi0gICAgICAgICAgICBpZiAoc3RydWN0dXJlLT5wcm9wZXJ0eUFjY2Vzc2VzQXJlQ2FjaGVh YmxlKCkpIHsKKyAgICAgICAgICAgIGlmIChzdHJ1Y3R1cmUtPnByb3BlcnR5QWNjZXNzZXNBcmVD YWNoZWFibGUoKQorICAgICAgICAgICAgICAgICYmICFzdHJ1Y3R1cmUtPm5lZWRJbXB1cmVQcm9w ZXJ0eVdhdGNocG9pbnQoKSkgewogICAgICAgICAgICAgICAgIHZtLmhlYXAud3JpdGVCYXJyaWVy KGNvZGVCbG9jayk7CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgQ29uY3VycmVu dEpTTG9ja2VyIGxvY2tlcihjb2RlQmxvY2stPm1fbG9jayk7CkluZGV4OiBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAy MTc4NjQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNSBAQAorMjAxNy0wNi0wOCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisg ICAgICAgIFJFR1JFU1NJT046IGpzL2RvbS9wcm90b3R5cGUtY2hhaW4tY2FjaGluZy13aXRoLWlt cHVyZS1nZXQtb3duLXByb3BlcnR5LXNsb3QtdHJhcHMtNS5odG1sIGhhcyBhIGZsYWt5IGZhaWx1 cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTE1 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAg ICAgQWRkIGEgdmVyc2lvbiBvZiB0aGUgdGVzdCB0aGF0J3MgZ3VhcmFudGVlZCB0byBmYWlsIGlm IHRoZSBwcm9ibGVtIGl0J3MgdGVzdGluZyBmb3IgbWFuaWZlc3RzCisgICAgICAgIGluIHRoZSBM TEludC4KKworICAgICAgICAqIGpzL2RvbS9wcm90b3R5cGUtY2hhaW4tY2FjaGluZy13aXRoLWlt cHVyZS1nZXQtb3duLXByb3BlcnR5LXNsb3QtdHJhcHMtNS1zaG9ydC5odG1sOiBBZGRlZC4KKwog MjAxNy0wNi0wNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBk YXRlIHRvIHNsaWdodGx5IHN0cmljdGVyIHJ1bGVzIGZvciBjdXN0b20gZWxlbWVudCBuYW1lcyBm cm9tIG1vcmUgcmVjZW50IHN0YW5kYXJkIGRyYWZ0CkluZGV4OiBMYXlvdXRUZXN0cy9qcy9kb20v cHJvdG90eXBlLWNoYWluLWNhY2hpbmctd2l0aC1pbXB1cmUtZ2V0LW93bi1wcm9wZXJ0eS1zbG90 LXRyYXBzLTUtc2hvcnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9kb20vcHJv dG90eXBlLWNoYWluLWNhY2hpbmctd2l0aC1pbXB1cmUtZ2V0LW93bi1wcm9wZXJ0eS1zbG90LXRy YXBzLTUtc2hvcnQuaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9qcy9kb20vcHJv dG90eXBlLWNoYWluLWNhY2hpbmctd2l0aC1pbXB1cmUtZ2V0LW93bi1wcm9wZXJ0eS1zbG90LXRy YXBzLTUtc2hvcnQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMwIEBACis8IURPQ1RZ UEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCJUZXN0cyB3 aGF0IGhhcHBlbnMgd2hlbiB5b3UgbWFrZSBwcm90b3R5cGUgY2hhaW4gYWNjZXNzZXMgd2l0aCBp bXB1cmUgR2V0T3duUHJvcGVydHlTbG90IHRyYXBzIGluIHRoZSB3YXkuIik7CisKK2RvY3VtZW50 LmZvbyA9IGZ1bmN0aW9uICgpIHt9OworCitmdW5jdGlvbiBmKCkgeworICAgIHJldHVybiBkb2N1 bWVudC5mb287Cit9CisKK3ZhciBleHBlY3RlZCA9ICJcImZ1bmN0aW9uXCIiOworZm9yICh2YXIg aSA9IDA7IGkgPCAxMDsgKytpKSB7CisgICAgaWYgKGkgPT0gNSkgeworICAgICAgICB2YXIgaW1n ID0gbmV3IEltYWdlKCk7CisgICAgICAgIGltZy5uYW1lID0gImZvbyI7CisgICAgICAgIGRvY3Vt ZW50LmJvZHkuYXBwZW5kQ2hpbGQoaW1nKTsKKyAgICAgICAgZXhwZWN0ZWQgPSAiXCJvYmplY3Rc IiI7CisgICAgfQorICAgIHYgPSBmKCk7CisgICAgc2hvdWxkQmUoInR5cGVvZiBmKCkiLCBleHBl Y3RlZCk7Cit9CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=