161135 2016-08-24 04:41:33 -0700 [GTK] Use dbus-run-session when possible to avoid left-over dbus-daemon instances 2016-11-02 09:40:54 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 gustavo gustavo bugs-noreply clopez mcatanzaro oldest_to_newest 1222634 0 gustavo 2016-08-24 04:41:33 -0700 [GTK] Use dbus-run-session to avoid left-over dbus-daemon instances 1222635 1 gustavo 2016-08-24 05:06:28 -0700 There are tons of dbus-launch left-overs on buildbots that run the gtk API tests. We should use dbus-run-session if possible, which is designed for this use case and should be more dependable regarding left-overs. However, it does not work like dbus-launch, by printing out the environment for the bus, it needs to be used as a prefix for the executable, so it would require a bit of a refactoring. 1222796 2 286883 gustavo 2016-08-24 13:05:22 -0700 Created attachment 286883 Patch 1228030 3 mcatanzaro 2016-09-08 20:37:23 -0700 If you don't select the right component, we don't notice the bug! 1228031 4 mcatanzaro 2016-09-08 20:41:35 -0700 Do we have to keep the fallback codepath? Is dbus-run-session relatively new (unavailable in Ubuntu 14.04 or Debian Jessie)? If not, let's clean up the old code too. 1228034 5 clopez 2016-09-08 20:44:42 -0700 (In reply to comment #1) > There are tons of dbus-launch left-overs on buildbots that run the gtk API > tests. We should use dbus-run-session if possible, which is designed for > this use case and should be more dependable regarding left-overs. However, > it does not work like dbus-launch, by printing out the environment for the > bus, it needs to be used as a prefix for the executable, so it would require > a bit of a refactoring. You can set this environment variable on the bot: WEBKITBOT_TASKSTOKILL=dbus-daemon It will try to kill any process with that name. Check: https://trac.webkit.org/changeset/195587 But the above is an ugly hack, your patch address this issue better. 1231083 6 gustavo 2016-09-19 07:51:14 -0700 (In reply to comment #3) > If you don't select the right component, we don't notice the bug! Sorry, out of practice =/ I thought the [GTK] prefix was the main indication still. (In reply to comment #4) > Do we have to keep the fallback codepath? Is dbus-run-session relatively new > (unavailable in Ubuntu 14.04 or Debian Jessie)? If not, let's clean up the > old code too. Yes. I left the old code path there because it is fairly new. It's available in jessie but not ubuntu 14.04. 1246488 7 286883 mcatanzaro 2016-10-31 10:51:41 -0700 Comment on attachment 286883 Patch Sorry it got missed 1247350 8 mcatanzaro 2016-11-02 09:40:48 -0700 WONTFIXing this based on discussion in bug #161481 286883 2016-08-24 13:05:22 -0700 2016-11-02 09:40:54 -0700 Patch bug-161135-20160824170320.patch text/plain 3604 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0ODk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWViM2EzZmQzY2Q2MWExYTM3OTQ3ZDNmZjc1N2JhNmEw NWU4OGQ1MC4uMzMzNTk0MDk3ZDQ0NmFiYzhjNTZkM2YyYzk0MmQ4NjA4ZDM0NWMxMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE2LTA4LTI0ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFA Y29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFtHVEtdIFVzZSBkYnVzLXJ1bi1zZXNzaW9uIHdo ZW4gcG9zc2libGUgdG8gYXZvaWQgbGVmdC1vdmVyIGRidXMtZGFlbW9uIGluc3RhbmNlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMTM1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1 bi1ndGstdGVzdHM6CisgICAgICAgIChUZXN0UnVubmVyLl9ydW5fdGVzdF9jb21tYW5kLnJldHVy bl9jb2RlX2Zyb21fZXhpdF9zdGF0dXMpOgorICAgICAgICAoVGVzdFJ1bm5lci5fcnVuX3Rlc3Rf Y29tbWFuZCk6IHdyYXAgdGVzdCBpbiBkYnVzLXJ1bi1zZXNzaW9uIGlmIGl0IGlzIGF2YWlsYWJs ZS4KKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL2d0ay9XZWJLaXQyR3RrL1Rlc3RNYWluLmNwcDoK KyAgICAgICAgKG1haW4pOiBjaGVjayBmb3IgdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIHRoYXQg c2lnbmFscyBkYnVzLXJ1bi1zZXNzaW9uIHdhcyB1c2VkCisgICAgICAgIGFuZCBvbmx5IGNsZWFy IERCVVNfU0VTU0lPTl9CVVNfQUREUkVTUyBpZiBpdCB3YXNuJ3QuCisgICAgICAgICogVGVzdFdl YktpdEFQSS9ndGsvV2ViS2l0Mkd0ay9XZWJLaXRUZXN0QnVzLmNwcDoKKyAgICAgICAgKFdlYktp dFRlc3RCdXM6OnJ1bik6IGlmIGEgc2Vzc2lvbiBidXMgYWRkcmVzcyBleGlzdHMgaW4gdGhlIGVu dmlyb25tZW50LCBqdXN0IHVzZQorICAgICAgICBpdCwgaW5zdGVhZCBvZiB0cnlpbmcgdG8gbGF1 bmNoIGEgbmV3IG9uZSB3aXRoIGRidXMtbGF1bmNoLgorCiAyMDE2LTA4LTI0ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBXYXJuaW5nIGZpeGVz LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2NyaXB0 cy9ydW4tZ3RrLXRlc3RzCmluZGV4IDA5ODA3MzY2ODA1NzZmMGQwY2M5OWQ5MzJlZTZkYWUyMWU2 N2JiNzAuLjZkMGJlOGM2YTEzZDFjNzQ0ZDZmN2ZhMzc3M2YxOTliMjYxZTVlOWIgMTAwNzU1Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1n dGstdGVzdHMKQEAgLTI4OCw2ICsyODgsMTQgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAg ICAgICAgICAjIFNob3VsZCBuZXZlciBoYXBwZW4KICAgICAgICAgICAgICAgICByYWlzZSBSdW50 aW1lRXJyb3IoIlVua25vd24gY2hpbGQgZXhpdCBzdGF0dXMhIikKIAorICAgICAgICAjIFRyeSB0 byB1c2UgZGJ1cy1ydW4tc2Vzc2lvbgorICAgICAgICB0cnk6CisgICAgICAgICAgICBzdWJwcm9j ZXNzLmNoZWNrX291dHB1dChbJ2RidXMtcnVuLXNlc3Npb24nLCAnLS12ZXJzaW9uJ10pCisgICAg ICAgICAgICBjb21tYW5kLmluc2VydCgwLCAnZGJ1cy1ydW4tc2Vzc2lvbicpCisgICAgICAgICAg ICBzZWxmLl90ZXN0X2VudlsnREJVU19SVU5fU0VTU0lPTiddID0gJzEnCisgICAgICAgIGV4Y2Vw dDoKKyAgICAgICAgICAgIHBhc3MKKwogICAgICAgICBwaWQsIGZkID0gb3MuZm9ya3B0eSgpCiAg ICAgICAgIGlmIHBpZCA9PSAwOgogICAgICAgICAgICAgb3MuZXhlY3ZwZShjb21tYW5kWzBdLCBj b21tYW5kLCBzZWxmLl90ZXN0X2VudikKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv Z3RrL1dlYktpdDJHdGsvVGVzdE1haW4uY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9ndGsvV2Vi S2l0Mkd0ay9UZXN0TWFpbi5jcHAKaW5kZXggODA4MDk0MDBkMmFhYzk2Y2M3ZmUwZGRmYmU1MzM0 NmJiZWUwN2EzYy4uY2ZjYTMxMWI1OGJkOWY0OGUyMjFjNGMwYzQ0ZDI1ZmNjMDEzNWJkMyAxMDA2 NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9ndGsvV2ViS2l0Mkd0ay9UZXN0TWFpbi5jcHAK KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9ndGsvV2ViS2l0Mkd0ay9UZXN0TWFpbi5jcHAKQEAg LTYzLDcgKzYzLDEwIEBAIHN0YXRpYyB2b2lkIHJlbW92ZU5vbkVtcHR5RGlyZWN0b3J5KGNvbnN0 IGNoYXIqIGRpcmVjdG9yeVBhdGgpCiAKIGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikK IHsKLSAgICBnX3Vuc2V0ZW52KCJEQlVTX1NFU1NJT05fQlVTX0FERFJFU1MiKTsKKyAgICAvLyBJ ZiB3ZSBoYXZlIGJlZW4gd3JhcHBlZCBieSBkYnVzLXJ1bi1zZXNzaW9uLCB1c2UgdGhlIHNlc3Np b24gaXQgY3JlYXRlZC4KKyAgICBpZiAoIWdfZ2V0ZW52KCJEQlVTX1JVTl9TRVNTSU9OIikpCisg ICAgICAgIGdfdW5zZXRlbnYoIkRCVVNfU0VTU0lPTl9CVVNfQUREUkVTUyIpOworCiAgICAgZ3Rr X3Rlc3RfaW5pdCgmYXJnYywgJmFyZ3YsIDApOwogICAgIGdfc2V0ZW52KCJXRUJLSVRfRVhFQ19Q QVRIIiwgV0VCS0lUX0VYRUNfUEFUSCwgRkFMU0UpOwogICAgIGdfc2V0ZW52KCJXRUJLSVRfSU5K RUNURURfQlVORExFX1BBVEgiLCBXRUJLSVRfSU5KRUNURURfQlVORExFX1BBVEgsIEZBTFNFKTsK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ3RrL1dlYktpdDJHdGsvV2ViS2l0VGVz dEJ1cy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2d0ay9XZWJLaXQyR3RrL1dlYktpdFRlc3RC dXMuY3BwCmluZGV4IDFjZjI0MTQ2MTAxMDg3MmNkODdjNzdjNDhkMzdhNDM4YzFlMzMwNTEuLmQz ZDM1NTMzMTM1N2I1ODdmZmVjNzI0ODEyZTc1YTJkMGNiZTkxZjUgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvZ3RrL1dlYktpdDJHdGsvV2ViS2l0VGVzdEJ1cy5jcHAKKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9ndGsvV2ViS2l0Mkd0ay9XZWJLaXRUZXN0QnVzLmNwcApAQCAtMzAs NiArMzAsMTIgQEAgV2ViS2l0VGVzdEJ1czo6V2ViS2l0VGVzdEJ1cygpCiAKIGJvb2wgV2ViS2l0 VGVzdEJ1czo6cnVuKCkKIHsKKyAgICAvLyBJZiBhbiBhZGRyZXNzIGlzIHN0aWxsIHNldCBpdCBt ZWFucyB0aGUgdGVzdCBoYXMgYmVlbiBzdGFydGVkCisgICAgLy8gd3JhcHBlZCBieSBkYnVzLXJ1 bi1zZXNzaW9uLiBTZWUgdGhlIG1haW4oKSBmdW5jdGlvbi4KKyAgICBtX2FkZHJlc3MgPSBnX2dl dGVudigiREJVU19TRVNTSU9OX0JVU19BRERSRVNTIik7CisgICAgaWYgKCFtX2FkZHJlc3MuaXNO dWxsKCkpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgLy8gRklYTUU6IFVzZSBHVGVzdERC dXMgd2hlbiB3ZSBidW1wIGdsaWIgdG8gMi4zNC4KICAgICBHVW5pcXVlUHRyPGNoYXI+IGRidXNM YXVuY2goZ19maW5kX3Byb2dyYW1faW5fcGF0aCgiZGJ1cy1sYXVuY2giKSk7CiAgICAgaWYgKCFk YnVzTGF1bmNoKSB7Cg==