161134 2016-08-24 04:02:41 -0700 [Win] http server is not starting. 2016-08-24 11:35:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 161047 1 pvollan pvollan achristensen ap bfulgham commit-queue glenn lforschler ossy oldest_to_newest 1222631 0 pvollan 2016-08-24 04:02:41 -0700 The http server fails to start in the layout tests: ServerError raised: Failed to start httpd: AH00526: Syntax error on line 2 of -c/-C directives: Only first PHPINIDir directive honored per configuration tree - subsequent ones ignored 1222632 1 286847 pvollan 2016-08-24 04:16:47 -0700 Created attachment 286847 Patch 1222666 2 286847 bfulgham 2016-08-24 09:27:37 -0700 Comment on attachment 286847 Patch Looks good. It's a shame we can't keep Windows and other OS's more consistent here. 1222667 3 bfulgham 2016-08-24 09:29:34 -0700 Do you need to update the XAMPP 'php.ini' file to match what was done on macOS? Or perhaps Windows is running an older PHP that doesn't need it? #### ; Let <meta charset> work. A charset provided in Content-Type takes precedence, and PHP 5.6+ defaults to UTF-8. default_charset = "" #### 1222687 4 286847 ap 2016-08-24 10:03:24 -0700 Comment on attachment 286847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286847&action=review > Tools/ChangeLog:8 > + Avoid setting php ini folder twice, it has been set in http.conf. Is the line in http.conf needed? It seems wrong to have it, but then to override globally. 1222708 5 bfulgham 2016-08-24 10:28:38 -0700 (In reply to comment #4) > Comment on attachment 286847 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286847&action=review > > > Tools/ChangeLog:8 > > + Avoid setting php ini folder twice, it has been set in http.conf. > > Is the line in http.conf needed? It seems wrong to have it, but then to > override globally. PerArne: What happens if we remove the PHPINIDir line from the Windows apache configuration file? I think the php.conf in XAMPP is just the default setup, but I haven't investigated this myself. Can you try that before landing this change? 1222714 6 286847 ap 2016-08-24 10:36:58 -0700 Comment on attachment 286847 Patch Brent looked at the XAMPP php.ini, and looks like there are things in it that are needed. 1222722 7 286866 pvollan 2016-08-24 10:49:20 -0700 Created attachment 286866 Patch 1222725 8 pvollan 2016-08-24 10:52:09 -0700 Thanks for reviewing! I agree with your comments, I have updated the patch :) 1222734 9 pvollan 2016-08-24 10:56:58 -0700 (In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 286847 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=286847&action=review > > > > > Tools/ChangeLog:8 > > > + Avoid setting php ini folder twice, it has been set in http.conf. > > > > Is the line in http.conf needed? It seems wrong to have it, but then to > > override globally. > > PerArne: What happens if we remove the PHPINIDir line from the Windows > apache configuration file? I think the php.conf in XAMPP is just the default > setup, but I haven't investigated this myself. > > Can you try that before landing this change? I tried this, and it actually seems to fix some http tests :) 1222740 10 286866 ap 2016-08-24 11:10:22 -0700 Comment on attachment 286866 Patch r=me given that it works :) 1222749 11 286866 commit-queue 2016-08-24 11:35:15 -0700 Comment on attachment 286866 Patch Clearing flags on attachment: 286866 Committed r204907: <http://trac.webkit.org/changeset/204907> 1222750 12 commit-queue 2016-08-24 11:35:21 -0700 All reviewed patches have been landed. Closing bug. 286847 2016-08-24 04:16:47 -0700 2016-08-24 10:49:13 -0700 Patch bug-161134-20160824041446.patch text/plain 1919 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNDg5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA4LTI0ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBodHRwIHNlcnZlciBpcyBub3Qgc3RhcnRpbmcuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjExMzQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCBzZXR0aW5nIHBo cCBpbmkgZm9sZGVyIHR3aWNlLCBpdCBoYXMgYmVlbiBzZXQgaW4gaHR0cC5jb25mLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2VydmVycy9hcGFjaGVfaHR0cF9z ZXJ2ZXIucHk6CisgICAgICAgIChMYXlvdXRUZXN0QXBhY2hlSHR0cGQuX19pbml0X18pOgorCiAy MDE2LTA4LTI0ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBbV2luXSBXYXJuaW5nIGZpeGVzLgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvc2VydmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2VydmVycy9hcGFjaGVfaHR0cF9zZXJ2 ZXIucHkJKHJldmlzaW9uIDIwNDg5MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3NlcnZlcnMvYXBhY2hlX2h0dHBfc2VydmVyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC05 NCw3ICs5NCw2IEBAIGNsYXNzIExheW91dFRlc3RBcGFjaGVIdHRwZChodHRwX3NlcnZlcl8KICAg ICAgICAgICAgICctZicsICJcIiVzXCIiICUgc2VsZi5fZ2V0X2FwYWNoZV9jb25maWdfZmlsZV9w YXRoKHNlbGYudGVzdHNfZGlyLCBvdXRwdXRfZGlyKSwKICAgICAgICAgICAgICctQycsICJcJ0Rv Y3VtZW50Um9vdCBcIiVzXCJcJyIgJSBkb2N1bWVudF9yb290LAogICAgICAgICAgICAgJy1jJywg IlwnVHlwZXNDb25maWcgXCIlc1wiXCciICUgbWltZV90eXBlc19wYXRoLAotICAgICAgICAgICAg Jy1jJywgIlwnUEhQSU5JRGlyIFwiJXNcIlwnIiAlIHBocF9pbmlfZGlyLAogICAgICAgICAgICAg Jy1jJywgIlwnQ3VzdG9tTG9nIFwiJXNcIiBjb21tb25cJyIgJSBhY2Nlc3NfbG9nLAogICAgICAg ICAgICAgJy1jJywgIlwnRXJyb3JMb2cgXCIlc1wiXCciICUgZXJyb3JfbG9nLAogICAgICAgICAg ICAgJy1jJywgIlwnUGlkRmlsZSAlcyciICUgc2VsZi5fcGlkX2ZpbGUsCkBAIC0xMDUsNiArMTA0 LDcgQEAgY2xhc3MgTGF5b3V0VGVzdEFwYWNoZUh0dHBkKGh0dHBfc2VydmVyXwogCiAgICAgICAg IGlmIG5vdCBwb3J0X29iai5ob3N0LnBsYXRmb3JtLmlzX3dpbigpOgogICAgICAgICAgICAgc3Rh cnRfY21kLmV4dGVuZChbJy1DJywgIlwnVXNlciBcIiVzXCJcJyIgJSBvcy5lbnZpcm9uLmdldCgi VVNFUk5BTUUiLCBvcy5lbnZpcm9uLmdldCgiVVNFUiIsICIiKSldKQorICAgICAgICAgICAgc3Rh cnRfY21kLmV4dGVuZChbJy1jJywgIlwnUEhQSU5JRGlyIFwiJXNcIlwnIiAlIHBocF9pbmlfZGly XSkKIAogICAgICAgICBlbmFibGVfaXB2NiA9IHNlbGYuX3BvcnRfb2JqLmh0dHBfc2VydmVyX3N1 cHBvcnRzX2lwdjYoKQogICAgICAgICAjIFBlcmZvcm0gcGFydCBvZiB0aGUgY2hlY2tzIEFwYWNo ZSdzIEFQUiBkb2VzIHdoZW4gdHJ5aW5nIHRvIGxpc3RlbiB0bwo= 286866 2016-08-24 10:49:20 -0700 2016-08-24 11:35:15 -0700 Patch bug-161134-20160824104720.patch text/plain 1160 pvollan SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNDkwNCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA4LTI0ICBQZXIgQXJuZSBWb2xsYW4g IDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBodHRwIHNlcnZlciBpcyBub3Qg c3RhcnRpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjExMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBdm9pZCBzZXR0aW5nIHRoZSBwaHAgaW5pIGZvbGRlciB0d2ljZSwgaXQgaXMgbm90IGFsbG93 ZWQgYnkgeGFtcHAuCisKKyAgICAgICAgKiBodHRwL2NvbmYvYXBhY2hlMi40LWh0dHBkLXdpbi5j b25mOgorCiAyMDE2LTA4LTI0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAog ICAgICAgICBDaGFuZ2luZyBnYW1lcGFkIHRlc3QgdG8gdHJ5IHRvIGdldCBtb3JlIGluZm8gYWJv dXQgdGhlIGZhaWx1cmUgbW9kZSBvbiB0aGUgYm90cy4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAv Y29uZi9hcGFjaGUyLjQtaHR0cGQtd2luLmNvbmYKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv aHR0cC9jb25mL2FwYWNoZTIuNC1odHRwZC13aW4uY29uZgkocmV2aXNpb24gMjA0ODg2KQorKysg TGF5b3V0VGVzdHMvaHR0cC9jb25mL2FwYWNoZTIuNC1odHRwZC13aW4uY29uZgkod29ya2luZyBj b3B5KQpAQCAtMTI2LDggKzEyNiw2IEBAIFNlcnZlclNpZ25hdHVyZSBPbgogPC9JZk1vZHVsZT4K IAogPElmTW9kdWxlIG1vZF9waHA1LmM+Ci0gICAgUEhQSW5pRGlyICJDOi94YW1wcC9waHAiCi0K ICAgICBBZGRUeXBlIGFwcGxpY2F0aW9uL3gtaHR0cGQtcGhwIC5waHAKICAgICBBZGRUeXBlIGFw cGxpY2F0aW9uL3gtaHR0cGQtcGhwIC5iYXQKICAgICBBZGRUeXBlIGFwcGxpY2F0aW9uL3gtaHR0 cGQtcGhwLXNvdXJjZSAucGhwcwo=