161127 2016-08-23 23:41:54 -0700 RenderMathMLRow::firstLineBaseline does not need to be overridden in RenderMathMLMenclose 2016-08-28 01:43:07 -0700 1 1 1 Unclassified WebKit MathML WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 155879 161126 1 fred.wang fred.wang commit-queue dbarton esprehn+autocc glenn kondapallykalyan oldest_to_newest 1222605 0 fred.wang 2016-08-23 23:41:54 -0700 RenderMathMLRow::firstLineBaseline already provides the correct calculation of ascent for non-empty menclose. Empty menclose are not used in practice so the calculation is irrelevant but aligning on mrow seems fine. This will allow to get rid of the m_ascent member and will help to keep good vertical alignment of the 'D' in bug 161126. 1222608 1 286838 fred.wang 2016-08-23 23:51:27 -0700 Created attachment 286838 Patch 1222977 2 286838 fred.wang 2016-08-24 22:27:59 -0700 Comment on attachment 286838 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286838&action=review > Source/WebCore/ChangeLog:10 > + calculated value is irrelevant. Aligning on mrow (i.e. leaving firstLineBaseline undefined) Here it's actually "to 0" rather than "undefined". 1224038 3 fred.wang 2016-08-28 01:43:07 -0700 Committed r205099: <http://trac.webkit.org/changeset/205099> 286838 2016-08-23 23:51:27 -0700 2016-08-27 17:25:10 -0700 Patch bug-161127-20160824084926.patch text/plain 4825 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0ODg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjM2ZGQyYWExYzA4YTdm MmY4OTdhOWNmZDc4YzMwOWI5MDBhNTk2Ni4uMzQ0MjdkYTA5ZDM4OTkyNDU2YTM1YjE2NjI2M2Qw NjFkMDA1OTE4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDE2LTA4LTIzICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KIAorICAgICAgICBSZW5kZXJNYXRoTUxSb3c6 OmZpcnN0TGluZUJhc2VsaW5lIGRvZXMgbm90IG5lZWQgdG8gYmUgb3ZlcnJpZGRlbiBpbiBSZW5k ZXJNYXRoTUxNZW5jbG9zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTYxMTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVuZGVyTWF0aE1MUm93OjpmaXJzdExpbmVCYXNlbGluZSBhbHJlYWR5IHByb3Zp ZGVzIHRoZSBjb3JyZWN0IGNhbGN1bGF0aW9uIG9mIGFzY2VudCBmb3IKKyAgICAgICAgbm9uLWVt cHR5IG1lbmNsb3NlIGVsZW1lbnRzLiBFbXB0eSBtZW5jbG9zZSBlbGVtZW50cyBhcmUgbm90IHVz ZWQgaW4gcHJhY3RpY2Ugc28gdGhlCisgICAgICAgIGNhbGN1bGF0ZWQgdmFsdWUgaXMgaXJyZWxl dmFudC4gQWxpZ25pbmcgb24gbXJvdyAoaS5lLiBsZWF2aW5nIGZpcnN0TGluZUJhc2VsaW5lIHVu ZGVmaW5lZCkKKyAgICAgICAgaXMgZmluZS4gVGhpcyBjaGFuZ2UgYWxsb3dzIHRvIGdldCByaWQg b2YgdGhlIG1fYXNjZW50IG1lbWJlciBhbmQgaGVscHMgdG8ga2VlcCBnb29kIGJhc2VsaW5lCisg ICAgICAgIGFsaWdubWVudCB3aGVuIHRoZSB6b29tIGxldmVsIGNoYW5nZXMgKGJ1ZyAxNjExMjYp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRl c3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL21hdGhtbC9SZW5kZXJNYXRoTUxNZW5jbG9zZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJNYXRoTUxNZW5jbG9zZTo6UmVuZGVyTWF0aE1M TWVuY2xvc2UpOiBSZW1vdmUgaW5pdGlhbGl6YXRpb24gb2YgbV9hc2NlbnQuCisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJNYXRoTUxNZW5jbG9zZTo6bGF5b3V0QmxvY2spOiBObyBuZWVkIHRvIGNh bGN1bGF0ZSBtX2FzY2VudC4gVGhlIGhlaWdodCBhbmQKKyAgICAgICAgY29udGVudCBsb2NhdGlv biBjYW4gYmUgZGV0ZXJtaW5lZCB3aXRob3V0IGludHJvZHVjaW5nIGxvY2FsIHZhcmlhYmxlcyBh c2NlbnQgb3IgZGVzY2VudC4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck1hdGhNTE1lbmNsb3Nl OjpmaXJzdExpbmVCYXNlbGluZSk6IERlbGV0ZWQuIFdlIGp1c3QgdXNlIHRoZSBpbXBsZW1lbnRh dGlvbgorICAgICAgICBmcm9tIFJlbmRlck1hdGhNTFJvdy4KKyAgICAgICAgKiByZW5kZXJpbmcv bWF0aG1sL1JlbmRlck1hdGhNTE1lbmNsb3NlLmg6IERlbGV0ZSBtX2FzY2VudCBhbmQgZG8gbm90 IG92ZXJyaWRlCisgICAgICAgIGZpcnN0TGluZUJhc2VsaW5lLgorCisyMDE2LTA4LTIzICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKwogICAgICAgICBNb3JlIGNvbnNpc3RlbnQg aGVhZGVyIGluY2x1c2lvbnMgaW4gdGhlIE1hdGhNTCBtb2R1bGUKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MTA4MAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvbWF0aG1sL1JlbmRlck1hdGhNTE1lbmNsb3NlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MTWVuY2xvc2UuY3BwCmlu ZGV4IDA3N2VjNmRjY2M1NDQyYTY5OGYxNGY0MTFlMmRkOGViZDQ3NDEyMjAuLmFmYmM5Nzc5MDdk ZjdiNDVkYzRjN2U3MTE3NjFmNWY3NGZiZWE3MzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MTWVuY2xvc2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MTWVuY2xvc2UuY3BwCkBAIC00NCw3 ICs0NCw2IEBAIGNvbnN0IHVuc2lnbmVkIHNob3J0IGxvbmdEaXZMZWZ0U3BhY2UgPSAxMDsKIAog UmVuZGVyTWF0aE1MTWVuY2xvc2U6OlJlbmRlck1hdGhNTE1lbmNsb3NlKE1hdGhNTE1lbmNsb3Nl RWxlbWVudCYgZWxlbWVudCwgUmVuZGVyU3R5bGUmJiBzdHlsZSkKICAgICA6IFJlbmRlck1hdGhN TFJvdyhlbGVtZW50LCBXVEZNb3ZlKHN0eWxlKSkKLSAgICAsIG1fYXNjZW50KDApCiB7CiB9CiAK QEAgLTE3NSwyNCArMTc0LDE3IEBAIHZvaWQgUmVuZGVyTWF0aE1MTWVuY2xvc2U6OmxheW91dEJs b2NrKGJvb2wgcmVsYXlvdXRDaGlsZHJlbiwgTGF5b3V0VW5pdCkKICAgICBMYXlvdXRVbml0IGxl ZnRTcGFjZSwgcmlnaHRTcGFjZSwgdG9wU3BhY2UsIGJvdHRvbVNwYWNlOwogICAgIGdldFNwYWNl QXJvdW5kQ29udGVudChjb250ZW50V2lkdGgsIGNvbnRlbnRBc2NlbnQgKyBjb250ZW50RGVzY2Vu dCwgbGVmdFNwYWNlLCByaWdodFNwYWNlLCB0b3BTcGFjZSwgYm90dG9tU3BhY2UpOwogICAgIHNl dExvZ2ljYWxXaWR0aChsZWZ0U3BhY2UgKyBjb250ZW50V2lkdGggKyByaWdodFNwYWNlKTsKLSAg ICBtX2FzY2VudCA9IHRvcFNwYWNlICsgY29udGVudEFzY2VudDsKLSAgICBMYXlvdXRVbml0IGRl c2NlbnQgPSBjb250ZW50RGVzY2VudCArIGJvdHRvbVNwYWNlOwotICAgIExheW91dFBvaW50IGNv bnRlbnRMb2NhdGlvbihsZWZ0U3BhY2UsIG1fYXNjZW50IC0gY29udGVudEFzY2VudCk7CisgICAg c2V0TG9naWNhbEhlaWdodCh0b3BTcGFjZSArIGNvbnRlbnRBc2NlbnQgKyBjb250ZW50RGVzY2Vu dCArIGJvdHRvbVNwYWNlKTsKKworICAgIExheW91dFBvaW50IGNvbnRlbnRMb2NhdGlvbihsZWZ0 U3BhY2UsIHRvcFNwYWNlKTsKICAgICBmb3IgKGF1dG8qIGNoaWxkID0gZmlyc3RDaGlsZEJveCgp OyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmdCb3goKSkKICAgICAgICAgY2hpbGQt PnNldExvY2F0aW9uKGNoaWxkLT5sb2NhdGlvbigpICsgY29udGVudExvY2F0aW9uKTsKIAotICAg IHNldExvZ2ljYWxIZWlnaHQobV9hc2NlbnQgKyBkZXNjZW50KTsKLQogICAgIG1fY29udGVudFJl Y3QgPSBMYXlvdXRSZWN0KGxlZnRTcGFjZSwgdG9wU3BhY2UsIGNvbnRlbnRXaWR0aCwgY29udGVu dEFzY2VudCArIGNvbnRlbnREZXNjZW50KTsKIAogICAgIGNsZWFyTmVlZHNMYXlvdXQoKTsKIH0K IAotT3B0aW9uYWw8aW50PiBSZW5kZXJNYXRoTUxNZW5jbG9zZTo6Zmlyc3RMaW5lQmFzZWxpbmUo KSBjb25zdAotewotICAgIHJldHVybiBPcHRpb25hbDxpbnQ+KHN0YXRpY19jYXN0PGludD4obHJv dW5kZihtX2FzY2VudCkpKTsKLX0KLQogLy8gR3JhcGhpY3NDb250ZXh0OjpkcmF3TGluZSBkb2Vz IG5vdCBzZWVtIGFwcHJvcHJpYXRlIHRvIGRyYXcgbWVuY2xvc2UgbGluZXMuCiAvLyBUbyBhdm9p ZCB1bmV4cGVjdGVkIGJlaGF2aW9ycyBhbmQgaW5jb25zaXN0ZW5jeSB3aXRoIG90aGVyIG5vdGF0 aW9ucywgd2UganVzdCB1c2Ugc3Ryb2tlUGF0aC4KIHN0YXRpYyB2b2lkIGRyYXdMaW5lKFBhaW50 SW5mbyYgaW5mbywgY29uc3QgTGF5b3V0VW5pdCYgeFN0YXJ0LCBjb25zdCBMYXlvdXRVbml0JiB5 U3RhcnQsIGNvbnN0IExheW91dFVuaXQmIHhFbmQsIGNvbnN0IExheW91dFVuaXQmIHlFbmQpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbWF0aG1sL1JlbmRlck1hdGhNTE1l bmNsb3NlLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvbWF0aG1sL1JlbmRlck1hdGhNTE1l bmNsb3NlLmgKaW5kZXggMDlmN2JiY2NmMDE5ZjRjZTE5MjE5YTNjODg1YWI4MzIyZGVkZjg3OC4u MzNhMmZkYjM1OTNmZDc2Yzg3MDM4OGRmYjY3YTA5YzcwYTM4ZDEwMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL21hdGhtbC9SZW5kZXJNYXRoTUxNZW5jbG9zZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MTWVuY2xvc2UuaApA QCAtNDEsNyArNDEsNiBAQCBwcml2YXRlOgogICAgIGNvbnN0IGNoYXIqIHJlbmRlck5hbWUoKSBj b25zdCBmaW5hbCB7IHJldHVybiAiUmVuZGVyTWF0aE1MTWVuY2xvc2UiOyB9CiAgICAgdm9pZCBj b21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocygpIGZpbmFsOwogICAgIHZvaWQgbGF5b3V0Qmxv Y2soYm9vbCByZWxheW91dENoaWxkcmVuLCBMYXlvdXRVbml0IHBhZ2VMb2dpY2FsSGVpZ2h0ID0g MCkgZmluYWw7Ci0gICAgT3B0aW9uYWw8aW50PiBmaXJzdExpbmVCYXNlbGluZSgpIGNvbnN0IGZp bmFsOwogICAgIHZvaWQgcGFpbnQoUGFpbnRJbmZvJiwgY29uc3QgTGF5b3V0UG9pbnQmKSBmaW5h bDsKIAogICAgIExheW91dFVuaXQgcnVsZVRoaWNrbmVzcygpIGNvbnN0OwpAQCAtNDksNyArNDgs NiBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBnZXRTcGFjZUFyb3VuZENvbnRlbnQoTGF5b3V0VW5p dCBjb250ZW50V2lkdGgsIExheW91dFVuaXQgY29udGVudEhlaWdodCwgTGF5b3V0VW5pdCYgbGVm dFNwYWNlLCBMYXlvdXRVbml0JiByaWdodFNwYWNlLCBMYXlvdXRVbml0JiB0b3BTcGFjZSwgTGF5 b3V0VW5pdCYgYm90dG9tU3BhY2UpIGNvbnN0OwogCi0gICAgTGF5b3V0VW5pdCBtX2FzY2VudDsK ICAgICBMYXlvdXRSZWN0IG1fY29udGVudFJlY3Q7CiB9OwogCg==