161124 2016-08-23 18:55:24 -0700 [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests 2016-08-24 13:55:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser oldest_to_newest 1222551 0 simon.fraser 2016-08-23 18:55:24 -0700 [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests 1222553 1 286821 simon.fraser 2016-08-23 18:57:53 -0700 Created attachment 286821 Patch 1222693 2 286821 dbates 2016-08-24 10:09:40 -0700 Comment on attachment 286821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286821&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:181 > -WebFrame *mainFrame = 0; > +WebFrame *mainFrame; Is this correct? Notice that this variable has external linkage. From what I recall, only variables with static storage duration are guaranteed to be zero initialized. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:186 > -WebFrame *topLoadingFrame = nil; // !nil iff a load is in progress > +WebFrame *topLoadingFrame; // !nil iff a load is in progress Ditto. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:189 > +CFMutableSetRef disallowedURLs; Ditto. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:224 > +UIWebBrowserView *gWebBrowserView; > +UIWebScrollView *gWebScrollView; > +DumpRenderTreeWindow *gDrtWindow; Ditto. 1222814 3 simon.fraser 2016-08-24 13:55:33 -0700 https://trac.webkit.org/r204929 286821 2016-08-23 18:57:53 -0700 2016-08-24 10:09:40 -0700 Patch bug-161124-20160823185554.patch text/plain 7186 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0ODYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmM5ODVkY2M0NmY1YWVmYmRmYWQ1NGNmOGJmYjNiZjI4 ZDhlY2U2Ni4uMzczNjFlMjdkODUwM2FhYjFhODk5MDU3Njg2MjA1OGQ5ZWUxMDAzYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE2LTA4LTIzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1MgRFJUXSBNYWtlIGlPUyBEUlQgdXNlIHRoZSBzYW1lIHdpbmRvdyBzaXpl IGFzIFdlYktpdFRlc3RSdW5uZXIgZm9yIGZsZXhpYmxlIHZpZXdwb3J0IHRlc3RzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjExMjQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFVzZSB0aGUg bWFpbiBVSVNjcmVlbidzIGJvdW5kcyBmb3IgdGhlIHNpemUgb2YgdGhlIHdpbmRvdyBpbiBmbGV4 aWJsZSB2aWV3cG9ydCBtb2RlLAorICAgICAgICBhbmQgcmVtb3ZlIHRoZSAncGhvbmVCcm93c2Vy QWRkcmVzc0Jhck9mZnNldCcgaGFjaywgc28gdGhhdCBpdCBtYXRjaGVzIFdUUi4KKyAgICAgICAg CisgICAgICAgIFJlbW92ZSBzb21lIHVubmVjZXNzYXJ5IHplcm8gaW5pdGlhbGl6YXRpb25zIG9m IHN0YXRpYyB2YXJpYWJsZXMuCisgICAgICAgIAorICAgICAgICBDaGFuZ2UgX3NldFZpc2libGVT aXplIHRvIHVzZSB0aGUgd2luZG93IHNpemUsIHdoaWNoIHNob3VsZCBub3QgYmUgYSBiZWhhdmlv ciBjaGFuZ2UKKyAgICAgICAgYmVjYXVzZSB0aGlzIGl0IGp1c3QgdXNlZCBmb3IgdGV4dCBhdXRv c2l6aW5nLCB3aGljaCBpcyBkaXNhYmxlZCBieSBkZWZhdWx0LAorICAgICAgICBhbmQgb25seSB0 aGUgd2lkdGggaXMgY29uc3VsdGVkLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0R1 bXBSZW5kZXJUcmVlLm1tOgorICAgICAgICAoYWRqdXN0V2ViRG9jdW1lbnRGb3JGbGV4aWJsZVZp ZXdwb3J0KToKKyAgICAgICAgKGFkanVzdFdlYkRvY3VtZW50Rm9yU3RhbmRhcmRWaWV3cG9ydCk6 CisgICAgICAgIChjcmVhdGVXZWJWaWV3QW5kT2Zmc2NyZWVuV2luZG93KToKKwogMjAxNi0wOC0y MiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1dHRlcmZsaWVz IHNob3VsZCBiZSBhbGxvY2F0ZWQgaW4gQXV4aWxpYXJ5IE1hcmtlZFNwYWNlIGluc3RlYWQgb2Yg Q29waWVkU3BhY2UgYW5kIHdlIHNob3VsZCByZXdyaXRlIGFzIG11Y2ggb2YgdGhlIEdDIGFzIG5l ZWRlZCB0byBtYWtlIHRoaXMgbm90IGEgcmVncmVzc2lvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv bWFjL0R1bXBSZW5kZXJUcmVlLm1tCmluZGV4IGQ0ZTc1MGNkYmMxMjEzMDM2ZGIxMGQ0ZTFkYWVh Mzg5Nzk5OTA0ZWUuLjdmZDA4ODM3Y2RkNGVhYWU1YjcyMWZjZjIyYzJjNDI5YTNjOGFlMTkgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KQEAgLTE3NSwxOSAr MTc1LDE5IEBAIHN0YXRpYyB2b2lkIHJ1blRlc3QoY29uc3Qgc3RyaW5nJiB0ZXN0VVJMKTsKIAog dm9sYXRpbGUgYm9vbCBkb25lOwogCi1OYXZpZ2F0aW9uQ29udHJvbGxlciogZ05hdmlnYXRpb25D b250cm9sbGVyID0gMDsKK05hdmlnYXRpb25Db250cm9sbGVyKiBnTmF2aWdhdGlvbkNvbnRyb2xs ZXIgPSBudWxscHRyOwogUmVmUHRyPFRlc3RSdW5uZXI+IGdUZXN0UnVubmVyOwogCi1XZWJGcmFt ZSAqbWFpbkZyYW1lID0gMDsKK1dlYkZyYW1lICptYWluRnJhbWU7CiAvLyBUaGlzIGlzIHRoZSB0 b3Btb3N0IGZyYW1lIHRoYXQgaXMgbG9hZGluZywgZHVyaW5nIGEgZ2l2ZW4gbG9hZCwgb3Igbmls IHdoZW4gbm8gbG9hZCBpcyAKIC8vIGluIHByb2dyZXNzLiAgVXN1YWxseSB0aGlzIGlzIHRoZSBz YW1lIGFzIHRoZSBtYWluIGZyYW1lLCBidXQgbm90IGFsd2F5cy4gIEluIHRoZSBjYXNlCiAvLyB3 aGVyZSBhIGZyYW1lc2V0IGlzIGxvYWRlZCwgYW5kIHRoZW4gbmV3IGNvbnRlbnQgaXMgbG9hZGVk IGludG8gb25lIG9mIHRoZSBjaGlsZCBmcmFtZXMsCiAvLyB0aGF0IGNoaWxkIGZyYW1lIGlzIHRo ZSAidG9wbW9zdCBmcmFtZSB0aGF0IGlzIGxvYWRpbmciLgotV2ViRnJhbWUgKnRvcExvYWRpbmdG cmFtZSA9IG5pbDsgICAgIC8vICFuaWwgaWZmIGEgbG9hZCBpcyBpbiBwcm9ncmVzcworV2ViRnJh bWUgKnRvcExvYWRpbmdGcmFtZTsgLy8gIW5pbCBpZmYgYSBsb2FkIGlzIGluIHByb2dyZXNzCiAK IAotQ0ZNdXRhYmxlU2V0UmVmIGRpc2FsbG93ZWRVUkxzID0gMDsKLXN0YXRpYyBDRlJ1bkxvb3BU aW1lclJlZiB3YWl0VG9EdW1wV2F0Y2hkb2cgPSAwOworQ0ZNdXRhYmxlU2V0UmVmIGRpc2FsbG93 ZWRVUkxzOworc3RhdGljIENGUnVuTG9vcFRpbWVyUmVmIHdhaXRUb0R1bXBXYXRjaGRvZzsKIAog Ly8gRGVsZWdhdGVzCiBzdGF0aWMgRnJhbWVMb2FkRGVsZWdhdGUgKmZyYW1lTG9hZERlbGVnYXRl OwpAQCAtMjAxLDMxICsyMDEsMjcgQEAgRGVmYXVsdFBvbGljeURlbGVnYXRlICpkZWZhdWx0UG9s aWN5RGVsZWdhdGU7CiBzdGF0aWMgU2Nyb2xsVmlld1Jlc2l6ZXJEZWxlZ2F0ZSAqc2Nyb2xsVmll d1Jlc2l6ZXJEZWxlZ2F0ZTsKICNlbmRpZgogCi1zdGF0aWMgaW50IGR1bXBQaXhlbHNGb3JBbGxU ZXN0cyA9IE5POwotc3RhdGljIGJvb2wgZHVtcFBpeGVsc0ZvckN1cnJlbnRUZXN0ID0gZmFsc2U7 CitzdGF0aWMgaW50IGR1bXBQaXhlbHNGb3JBbGxUZXN0czsKK3N0YXRpYyBib29sIGR1bXBQaXhl bHNGb3JDdXJyZW50VGVzdDsKIHN0YXRpYyBpbnQgdGhyZWFkZWQ7CiBzdGF0aWMgaW50IGR1bXBU cmVlID0gWUVTOwogc3RhdGljIGludCB1c2VUaW1lb3V0V2F0Y2hkb2cgPSBZRVM7CiBzdGF0aWMg aW50IGZvcmNlQ29tcGxleFRleHQ7CiBzdGF0aWMgaW50IHVzZUFjY2VsZXJhdGVkRHJhd2luZzsK IHN0YXRpYyBpbnQgZ2NCZXR3ZWVuVGVzdHM7Ci1zdGF0aWMgaW50IHNob3dXZWJWaWV3ID0gTk87 Ci1zdGF0aWMgaW50IHByaW50VGVzdENvdW50ID0gTk87CitzdGF0aWMgaW50IHNob3dXZWJWaWV3 Oworc3RhdGljIGludCBwcmludFRlc3RDb3VudDsKIHN0YXRpYyBCT09MIHByaW50U2VwYXJhdG9y czsKIHN0YXRpYyBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IHBlcnNpc3RlbnRVc2VyU3R5bGVTaGVl dExvY2F0aW9uOwogc3RhdGljIHN0ZDo6c2V0PHN0ZDo6c3RyaW5nPiBhbGxvd2VkSG9zdHM7CiAK LXN0YXRpYyBXZWJIaXN0b3J5SXRlbSAqcHJldlRlc3RCRkl0ZW0gPSBuaWw7ICAvLyBjdXJyZW50 IGIvZiBpdGVtIGF0IHRoZSBlbmQgb2YgdGhlIHByZXZpb3VzIHRlc3QKK3N0YXRpYyBXZWJIaXN0 b3J5SXRlbSAqcHJldlRlc3RCRkl0ZW07IC8vIGN1cnJlbnQgYi9mIGl0ZW0gYXQgdGhlIGVuZCBv ZiB0aGUgcHJldmlvdXMgdGVzdAogCiAjaWYgUExBVEZPUk0oSU9TKQotY29uc3QgdW5zaWduZWQg cGhvbmVWaWV3SGVpZ2h0ID0gNDgwOwotY29uc3QgdW5zaWduZWQgcGhvbmVWaWV3V2lkdGggPSAz MjA7Ci1jb25zdCB1bnNpZ25lZCBwaG9uZUJyb3dzZXJTY3JvbGxWaWV3SGVpZ2h0ID0gNDE2Owot Y29uc3QgdW5zaWduZWQgcGhvbmVCcm93c2VyQWRkcmVzc0Jhck9mZnNldCA9IDYwOwogY29uc3Qg Q0dSZWN0IGxheW91dFRlc3RWaWV3cG9ydFJlY3QgPSB7IHswLCAwfSwge3N0YXRpY19jYXN0PENH RmxvYXQ+KFRlc3RSdW5uZXI6OnZpZXdXaWR0aCksIHN0YXRpY19jYXN0PENHRmxvYXQ+KFRlc3RS dW5uZXI6OnZpZXdIZWlnaHQpfSB9OwotVUlXZWJCcm93c2VyVmlldyAqZ1dlYkJyb3dzZXJWaWV3 ID0gbmlsOwotVUlXZWJTY3JvbGxWaWV3ICpnV2ViU2Nyb2xsVmlldyA9IG5pbDsKLUR1bXBSZW5k ZXJUcmVlV2luZG93ICpnRHJ0V2luZG93ID0gbmlsOworVUlXZWJCcm93c2VyVmlldyAqZ1dlYkJy b3dzZXJWaWV3OworVUlXZWJTY3JvbGxWaWV3ICpnV2ViU2Nyb2xsVmlldzsKK0R1bXBSZW5kZXJU cmVlV2luZG93ICpnRHJ0V2luZG93OwogI2VuZGlmCiAKICNpZmRlZiBfX09CSkMyX18KQEAgLTY0 NCw3ICs2NDAsNyBAQCBzdGF0aWMgdm9pZCBhY3RpdmF0ZUZvbnRzSU9TKCkKIAogCiAjaWYgUExB VEZPUk0oSU9TKQotdm9pZCBhZGp1c3RXZWJEb2N1bWVudEZvckZsZXhpYmxlVmlld3BvcnQoVUlX ZWJCcm93c2VyVmlldyAqd2ViQnJvd3NlclZpZXcsIFVJV2ViU2Nyb2xsVmlldyAqc2Nyb2xsVmll dykKK3N0YXRpYyB2b2lkIGFkanVzdFdlYkRvY3VtZW50Rm9yRmxleGlibGVWaWV3cG9ydChVSVdl YkJyb3dzZXJWaWV3ICp3ZWJCcm93c2VyVmlldywgVUlXZWJTY3JvbGxWaWV3ICpzY3JvbGxWaWV3 KQogewogICAgIC8vIFRoZXNlIHZhbHVlcyBtYXRjaCBNb2JpbGVTYWZhcmkncywgc2VlIC1bVGFi RG9jdW1lbnQgX2NyZWF0ZURvY3VtZW50Vmlld10uCiAgICAgW3dlYkJyb3dzZXJWaWV3IHNldE1p bmltdW1TY2FsZTowLjI1ZiBmb3JEb2N1bWVudFR5cGVzOlVJRXZlcnlEb2N1bWVudE1hc2tdOwpA QCAtNjU3LDE4ICs2NTMsMjEgQEAgdm9pZCBhZGp1c3RXZWJEb2N1bWVudEZvckZsZXhpYmxlVmll d3BvcnQoVUlXZWJCcm93c2VyVmlldyAqd2ViQnJvd3NlclZpZXcsIFVJV2UKICAgICBbKER1bXBS ZW5kZXJUcmVlQnJvd3NlclZpZXcgKil3ZWJCcm93c2VyVmlldyBzZXRTY3JvbGxpbmdVc2VzVUlX ZWJTY3JvbGxWaWV3OllFU107CiAgICAgW3dlYkJyb3dzZXJWaWV3IHNldERlbGVnYXRlOnNjcm9s bFZpZXdSZXNpemVyRGVsZWdhdGVdOwogCi0gICAgQ0dSZWN0IHZpZXdwb3J0UmVjdCA9IENHUmVj dE1ha2UoMCwgMCwgcGhvbmVWaWV3V2lkdGgsIHBob25lQnJvd3NlclNjcm9sbFZpZXdIZWlnaHQp OworICAgIENHUmVjdCBzY3JlZW5Cb3VuZHMgPSBbVUlTY3JlZW4gbWFpblNjcmVlbl0uYm91bmRz OworICAgIENHUmVjdCB2aWV3cG9ydFJlY3QgPSBDR1JlY3RNYWtlKDAsIDAsIHNjcmVlbkJvdW5k cy5zaXplLndpZHRoLCBzY3JlZW5Cb3VuZHMuc2l6ZS5oZWlnaHQpOworCiAgICAgW3Njcm9sbFZp ZXcgc2V0Qm91bmRzOnZpZXdwb3J0UmVjdF07CiAgICAgW3Njcm9sbFZpZXcgc2V0RnJhbWU6dmll d3BvcnRSZWN0XTsKIAogICAgIFt3ZWJCcm93c2VyVmlldyBzZXRNaW5pbXVtU2l6ZTp2aWV3cG9y dFJlY3Quc2l6ZV07CiAgICAgW3dlYkJyb3dzZXJWaWV3IHNldEF1dG9yZXNpemVzOllFU107Ci0g ICAgQ0dSZWN0IGJyb3dzZXJWaWV3RnJhbWUgPSBbd2ViQnJvd3NlclZpZXcgZnJhbWVdOwotICAg IGJyb3dzZXJWaWV3RnJhbWUub3JpZ2luID0gQ0dQb2ludE1ha2UoMCwgcGhvbmVCcm93c2VyQWRk cmVzc0Jhck9mZnNldCk7Ci0gICAgW3dlYkJyb3dzZXJWaWV3IHNldEZyYW1lOmJyb3dzZXJWaWV3 RnJhbWVdOworICAgIFt3ZWJCcm93c2VyVmlldyBzZXRGcmFtZTpzY3JlZW5Cb3VuZHNdOworCisg ICAgLy8gVGhpcyBqdXN0IGFmZmVjdHMgdGV4dCBhdXRvc2l6aW5nLgorICAgIFttYWluRnJhbWUg X3NldFZpc2libGVTaXplOkNHU2l6ZU1ha2Uoc2NyZWVuQm91bmRzLnNpemUud2lkdGgsIHNjcmVl bkJvdW5kcy5zaXplLmhlaWdodCldOwogfQogCi12b2lkIGFkanVzdFdlYkRvY3VtZW50Rm9yU3Rh bmRhcmRWaWV3cG9ydChVSVdlYkJyb3dzZXJWaWV3ICp3ZWJCcm93c2VyVmlldywgVUlXZWJTY3Jv bGxWaWV3ICpzY3JvbGxWaWV3KQorc3RhdGljIHZvaWQgYWRqdXN0V2ViRG9jdW1lbnRGb3JTdGFu ZGFyZFZpZXdwb3J0KFVJV2ViQnJvd3NlclZpZXcgKndlYkJyb3dzZXJWaWV3LCBVSVdlYlNjcm9s bFZpZXcgKnNjcm9sbFZpZXcpCiB7CiAgICAgW3dlYkJyb3dzZXJWaWV3IHNldE1pbmltdW1TY2Fs ZToxLjBmIGZvckRvY3VtZW50VHlwZXM6VUlFdmVyeURvY3VtZW50TWFza107CiAgICAgW3dlYkJy b3dzZXJWaWV3IHNldE1heGltdW1TY2FsZTo1LjBmIGZvckRvY3VtZW50VHlwZXM6VUlFdmVyeURv Y3VtZW50TWFza107CkBAIC02ODIsOSArNjgxLDExIEBAIHZvaWQgYWRqdXN0V2ViRG9jdW1lbnRG b3JTdGFuZGFyZFZpZXdwb3J0KFVJV2ViQnJvd3NlclZpZXcgKndlYkJyb3dzZXJWaWV3LCBVSVdl CiAKICAgICBbd2ViQnJvd3NlclZpZXcgc2V0TWluaW11bVNpemU6bGF5b3V0VGVzdFZpZXdwb3J0 UmVjdC5zaXplXTsKICAgICBbd2ViQnJvd3NlclZpZXcgc2V0QXV0b3Jlc2l6ZXM6Tk9dOwotICAg IENHUmVjdCBicm93c2VyVmlld0ZyYW1lID0gW3dlYkJyb3dzZXJWaWV3IGZyYW1lXTsKLSAgICBi cm93c2VyVmlld0ZyYW1lLm9yaWdpbiA9IENHUG9pbnRaZXJvOwotICAgIFt3ZWJCcm93c2VyVmll dyBzZXRGcmFtZTpicm93c2VyVmlld0ZyYW1lXTsKKyAgICBbd2ViQnJvd3NlclZpZXcgc2V0RnJh bWU6bGF5b3V0VGVzdFZpZXdwb3J0UmVjdF07CisKKyAgICAvLyBUaGlzIGp1c3QgYWZmZWN0cyB0 ZXh0IGF1dG9zaXppbmcuCisgICAgW21haW5GcmFtZSBfc2V0VmlzaWJsZVNpemU6Q0dTaXplTWFr ZShsYXlvdXRUZXN0Vmlld3BvcnRSZWN0LnNpemUud2lkdGgsIGxheW91dFRlc3RWaWV3cG9ydFJl Y3Quc2l6ZS5oZWlnaHQpXTsKKwogfQogI2VuZGlmCiAKQEAgLTg0MSw3ICs4NDIsNiBAQCBXZWJW aWV3ICpjcmVhdGVXZWJWaWV3QW5kT2Zmc2NyZWVuV2luZG93KCkKICAgICBOU0JpdG1hcEltYWdl UmVwICppbWFnZVJlcCA9IFt3ZWJWaWV3IGJpdG1hcEltYWdlUmVwRm9yQ2FjaGluZ0Rpc3BsYXlJ blJlY3Q6W3dlYlZpZXcgYm91bmRzXV07CiAgICAgW3dlYlZpZXcgY2FjaGVEaXNwbGF5SW5SZWN0 Olt3ZWJWaWV3IGJvdW5kc10gdG9CaXRtYXBJbWFnZVJlcDppbWFnZVJlcF07CiAjZWxzZQotICAg IFtbd2ViVmlldyBtYWluRnJhbWVdIF9zZXRWaXNpYmxlU2l6ZTpDR1NpemVNYWtlKHBob25lVmll d1dpZHRoLCBwaG9uZVZpZXdIZWlnaHQpXTsKICAgICBbW3dlYlZpZXcgcHJlZmVyZW5jZXNdIF9z ZXRUZWxlcGhvbmVOdW1iZXJQYXJzaW5nRW5hYmxlZDpOT107CiAKICAgICAvLyBJbml0aWFsaXpl IHRoZSBnbG9iYWwgVUlWaWV3cywgYW5kIHNldCB0aGUga2V5IFVJV2luZG93IHRvIGJlIHBhaW50 ZWQuCg==