161108 2016-08-23 14:55:26 -0700 AX: Add test for line text marker range on iOS 2016-08-24 11:14:19 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario n_wang samuel_white webkit-bug-importer oldest_to_newest 1222439 0 n_wang 2016-08-23 14:55:26 -0700 We should add a test to verify text marker range for line works correctly on iOS. 1222440 1 webkit-bug-importer 2016-08-23 14:55:48 -0700 <rdar://problem/27976405> 1222446 2 286784 n_wang 2016-08-23 15:04:08 -0700 Created attachment 286784 patch 1222533 3 286784 cfleizach 2016-08-23 18:06:50 -0700 Comment on attachment 286784 patch is this ready to review? 1222536 4 n_wang 2016-08-23 18:09:25 -0700 (In reply to comment #3) > Comment on attachment 286784 [details] > patch > > is this ready to review? Yes 1222700 5 286784 commit-queue 2016-08-24 10:17:34 -0700 Comment on attachment 286784 patch Rejecting attachment 286784 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 286784, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit 1ca05f1..8794dd3 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 204901 = 1ca05f12bbb830d7b92fc7e40b12341163352e40 r204902 = 8794dd3afd32b8b0860b2dcf262060809c6df8e1 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/1935040 1222741 6 n_wang 2016-08-24 11:10:34 -0700 Fixing it. 1222743 7 n_wang 2016-08-24 11:14:19 -0700 Committed r204906: <http://trac.webkit.org/changeset/204906> 286784 2016-08-23 15:04:08 -0700 2016-08-24 10:17:34 -0700 patch patch.txt text/plain 7088 n_wang SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNDg2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE2LTA4LTIzICBOYW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAg ICAgICAgQVg6IEFkZCB0ZXN0IGZvciBsaW5lIHRleHQgbWFya2VyIHJhbmdlIG9uIGlPUworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMTA4CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yNzk3NjQwNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2lvcy9BY2Nlc3NpYmlsaXR5 VUlFbGVtZW50SU9TLm1tOgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6bGluZVRl eHRNYXJrZXJSYW5nZUZvclRleHRNYXJrZXIpOgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxl bWVudDo6dGV4dE1hcmtlclJhbmdlRm9yRWxlbWVudCk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9pb3MvQWNjZXNzaWJpbGl0eVVJRWxlbWVudElPUy5tbToKKyAg ICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6bGluZVRleHRNYXJrZXJSYW5nZUZv clRleHRNYXJrZXIpOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojp0ZXh0 TWFya2VyUmFuZ2VGb3JFbGVtZW50KToKKwogMjAxNi0wOC0yMiAgRmlsaXAgUGl6bG8gIDxmcGl6 bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1dHRlcmZsaWVzIHNob3VsZCBiZSBhbGxvY2F0ZWQg aW4gQXV4aWxpYXJ5IE1hcmtlZFNwYWNlIGluc3RlYWQgb2YgQ29waWVkU3BhY2UgYW5kIHdlIHNo b3VsZCByZXdyaXRlIGFzIG11Y2ggb2YgdGhlIEdDIGFzIG5lZWRlZCB0byBtYWtlIHRoaXMgbm90 IGEgcmVncmVzc2lvbgpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9zL0FjY2Vzc2liaWxp dHlVSUVsZW1lbnRJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvaW9z L0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRJT1MubW0JKHJldmlzaW9uIDIwNDQ1MykKKysrIFRvb2xz L0R1bXBSZW5kZXJUcmVlL2lvcy9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50SU9TLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0xMDYsNiArMTA2LDggQEAgLSAoTlNBcnJheSAqKXRleHRNYXJrZXJSYW5nZUZv ck1hcmtlcnM6KAogLSAoaWQpbmV4dE1hcmtlckZvck1hcmtlcjooaWQpbWFya2VyOwogLSAoaWQp cHJldmlvdXNNYXJrZXJGb3JNYXJrZXI6KGlkKW1hcmtlcjsKIC0gKGlkKWFjY2Vzc2liaWxpdHlP YmplY3RGb3JUZXh0TWFya2VyOihpZCltYXJrZXI7CistIChpZClsaW5lU3RhcnRNYXJrZXJGb3JN YXJrZXI6KGlkKW1hcmtlcjsKKy0gKGlkKWxpbmVFbmRNYXJrZXJGb3JNYXJrZXI6KGlkKW1hcmtl cjsKIEBlbmQKIAogQGludGVyZmFjZSBOU09iamVjdCAoV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdy YXBwZXJQcml2YXRlKQpAQCAtNDMzLDkgKzQzNSwxNCBAQCBKU1N0cmluZ1JlZiBBY2Nlc3NpYmls aXR5VUlFbGVtZW50OjpwYXRoCiAKIC8vIFRleHQgbWFya2VycwogCi1BY2Nlc3NpYmlsaXR5VGV4 dE1hcmtlclJhbmdlIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmxpbmVUZXh0TWFya2VyUmFuZ2VG b3JUZXh0TWFya2VyKEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyKikKK0FjY2Vzc2liaWxpdHlUZXh0 TWFya2VyUmFuZ2UgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6bGluZVRleHRNYXJrZXJSYW5nZUZv clRleHRNYXJrZXIoQWNjZXNzaWJpbGl0eVRleHRNYXJrZXIqIHRleHRNYXJrZXIpCiB7Ci0gICAg cmV0dXJuIG51bGxwdHI7CisgICAgaWQgc3RhcnRUZXh0TWFya2VyID0gW21fZWxlbWVudCBsaW5l U3RhcnRNYXJrZXJGb3JNYXJrZXI6KGlkKXRleHRNYXJrZXItPnBsYXRmb3JtVGV4dE1hcmtlcigp XTsKKyAgICBpZCBlbmRUZXh0TWFya2VyID0gW21fZWxlbWVudCBsaW5lRW5kTWFya2VyRm9yTWFy a2VyOihpZCl0ZXh0TWFya2VyLT5wbGF0Zm9ybVRleHRNYXJrZXIoKV07CisgICAgTlNBcnJheSAq dGV4dE1hcmtlcnMgPSBbTlNBcnJheSBhcnJheVdpdGhPYmplY3RzOnN0YXJ0VGV4dE1hcmtlciwg ZW5kVGV4dE1hcmtlciwgbmlsXTsKKyAgICAKKyAgICBpZCB0ZXh0TWFya2VyUmFuZ2UgPSBbbV9l bGVtZW50IHRleHRNYXJrZXJSYW5nZUZvck1hcmtlcnM6dGV4dE1hcmtlcnNdOworICAgIHJldHVy biBBY2Nlc3NpYmlsaXR5VGV4dE1hcmtlclJhbmdlKHRleHRNYXJrZXJSYW5nZSk7CiB9CiAKIEFj Y2Vzc2liaWxpdHlUZXh0TWFya2VyUmFuZ2UgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dGV4dE1h cmtlclJhbmdlRm9yRWxlbWVudChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50KiBlbGVtZW50KQpJbmRl eDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9pb3MvQWNjZXNzaWJpbGl0 eVVJRWxlbWVudElPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL2lvcy9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50SU9TLm1tCShyZXZpc2lvbiAy MDQ0NTMpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2lvcy9BY2Nl c3NpYmlsaXR5VUlFbGVtZW50SU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC04Myw2ICs4Myw4IEBA IC0gKE5TQXJyYXkgKil0ZXh0TWFya2VyUmFuZ2VGb3JNYXJrZXJzOigKIC0gKGlkKW5leHRNYXJr ZXJGb3JNYXJrZXI6KGlkKW1hcmtlcjsKIC0gKGlkKXByZXZpb3VzTWFya2VyRm9yTWFya2VyOihp ZCltYXJrZXI7CiAtIChpZClhY2Nlc3NpYmlsaXR5T2JqZWN0Rm9yVGV4dE1hcmtlcjooaWQpbWFy a2VyOworLSAoaWQpbGluZVN0YXJ0TWFya2VyRm9yTWFya2VyOihpZCltYXJrZXI7CistIChpZCls aW5lRW5kTWFya2VyRm9yTWFya2VyOihpZCltYXJrZXI7CiBAZW5kCiAKIEBpbnRlcmZhY2UgTlNP YmplY3QgKFdlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyUHJpdmF0ZSkKQEAgLTk5Niw3ICs5 OTgsMTIgQEAgdm9pZCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpyZW1vdmVTZWxlYwogLy8gVGV4 dCBtYXJrZXJzCiBQYXNzUmVmUHRyPEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyUmFuZ2U+IEFjY2Vz c2liaWxpdHlVSUVsZW1lbnQ6OmxpbmVUZXh0TWFya2VyUmFuZ2VGb3JUZXh0TWFya2VyKEFjY2Vz c2liaWxpdHlUZXh0TWFya2VyKiB0ZXh0TWFya2VyKQogewotICAgIHJldHVybiBudWxscHRyOwor ICAgIGlkIHN0YXJ0VGV4dE1hcmtlciA9IFttX2VsZW1lbnQgbGluZVN0YXJ0TWFya2VyRm9yTWFy a2VyOihpZCl0ZXh0TWFya2VyLT5wbGF0Zm9ybVRleHRNYXJrZXIoKV07CisgICAgaWQgZW5kVGV4 dE1hcmtlciA9IFttX2VsZW1lbnQgbGluZUVuZE1hcmtlckZvck1hcmtlcjooaWQpdGV4dE1hcmtl ci0+cGxhdGZvcm1UZXh0TWFya2VyKCldOworICAgIE5TQXJyYXkgKnRleHRNYXJrZXJzID0gW05T QXJyYXkgYXJyYXlXaXRoT2JqZWN0czpzdGFydFRleHRNYXJrZXIsIGVuZFRleHRNYXJrZXIsIG5p bF07CisgICAgCisgICAgaWQgdGV4dE1hcmtlclJhbmdlID0gW21fZWxlbWVudCB0ZXh0TWFya2Vy UmFuZ2VGb3JNYXJrZXJzOnRleHRNYXJrZXJzXTsKKyAgICByZXR1cm4gQWNjZXNzaWJpbGl0eVRl eHRNYXJrZXJSYW5nZTo6Y3JlYXRlKHRleHRNYXJrZXJSYW5nZSk7CiB9CiAKIFBhc3NSZWZQdHI8 QWNjZXNzaWJpbGl0eVRleHRNYXJrZXJSYW5nZT4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dGV4 dE1hcmtlclJhbmdlRm9yRWxlbWVudChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50KiBlbGVtZW50KQpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gMjA0NDUzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDgtMjMgIE5hbiBXYW5nICA8bl93YW5n QGFwcGxlLmNvbT4KKworICAgICAgICBBWDogQWRkIHRlc3QgZm9yIGxpbmUgdGV4dCBtYXJrZXIg cmFuZ2Ugb24gaU9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjExMDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI3OTc2NDA1PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgbmV3IHRlc3Qg dG8gdGVzdCBsaW5lIHRleHQgbWFya2VyIHJhbmdlcyBvbiBpT1MuCisKKyAgICAgICAgKiBhY2Nl c3NpYmlsaXR5L2lvcy1zaW11bGF0b3IvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLWxpbmUtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2lvcy1zaW11bGF0b3IvdGV4 dC1tYXJrZXItcmFuZ2UtZm9yLWxpbmUuaHRtbDogQWRkZWQuCisKIDIwMTYtMDgtMTMgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICAnY29tcGF0TW9kZScgcHJvcGVy dHkgc2hvdWxkIGJlIG9uIERvY3VtZW50LCBub3QgSFRNTERvY3VtZW50CkluZGV4OiBMYXlvdXRU ZXN0cy9hY2Nlc3NpYmlsaXR5L2lvcy1zaW11bGF0b3IvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLWxp bmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkv aW9zLXNpbXVsYXRvci90ZXh0LW1hcmtlci1yYW5nZS1mb3ItbGluZS1leHBlY3RlZC50eHQJKG5v bmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9pb3Mtc2ltdWxhdG9yL3Rl eHQtbWFya2VyLXJhbmdlLWZvci1saW5lLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDEyIEBACitsaW5lIDEgCitsaW5lIDIKK1RoaXMgdmVyaWZpZXMgdGhhdCB3ZSBhcmUg Z2V0dGluZyBjb3JyZWN0IGxpbmUgdGV4dCBtYXJrZXIgcmFuZ2VzIG9uIGlPUy4KKworT24gc3Vj Y2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQg YnkgIlRFU1QgQ09NUExFVEUiLgorCisKK2xpbmUgMSAKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2Vk IGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L2lvcy1zaW11bGF0b3IvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLWxpbmUuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2lvcy1zaW11bGF0b3IvdGV4dC1tYXJr ZXItcmFuZ2UtZm9yLWxpbmUuaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9hY2Nl c3NpYmlsaXR5L2lvcy1zaW11bGF0b3IvdGV4dC1tYXJrZXItcmFuZ2UtZm9yLWxpbmUuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDM2IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0v L0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVz b3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyAgICA8Ym9keSBpZD0iYm9keSIgdGFi aW5kZXg9IjAiPgorICAgICAgICA8ZGl2IHRhYmluZGV4PSIwIiBpZD0idGV4dCI+CisgICAgICAg ICAgICBsaW5lIDEKKyAgICAgICAgICAgIDxicj5saW5lIDIKKyAgICAgICAgPC9kaXY+CisKKyAg ICAgICAgPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+CisgICAgICAgIDxkaXYgaWQ9ImNvbnNvbGUi PjwvZGl2PgorCisgICAgICAgIDxzY3JpcHQ+CisKKyAgICAgICAgICAgIGRlc2NyaXB0aW9uKCJU aGlzIHZlcmlmaWVzIHRoYXQgd2UgYXJlIGdldHRpbmcgY29ycmVjdCBsaW5lIHRleHQgbWFya2Vy IHJhbmdlcyBvbiBpT1MuIik7CisKKyAgICAgICAgICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgICAgICAgICBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5l bmFibGVFbmhhbmNlZEFjY2Vzc2liaWxpdHkodHJ1ZSk7CisgICAgICAgICAgICAgICAgdmFyIHdl YkFyZWEgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5yb290RWxlbWVudC5jaGlsZEF0SW5kZXgo MCk7CisKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGV4dCIpLmZv Y3VzKCk7CisgICAgICAgICAgICAgICAgdmFyIHRleHQgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxl ci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoInRleHQiKS5jaGlsZEF0SW5kZXgoMCk7CisKKyAgICAg ICAgICAgICAgICB2YXIgc3RhcnRNYXJrZXIgPSB0ZXh0LnN0YXJ0VGV4dE1hcmtlckZvclRleHRN YXJrZXJSYW5nZSh0ZXh0LnRleHRNYXJrZXJSYW5nZUZvckVsZW1lbnQodGV4dCkpOworICAgICAg ICAgICAgICAgIHN0YXJ0TWFya2VyID0gdGV4dC5uZXh0VGV4dE1hcmtlcihzdGFydE1hcmtlcik7 CisgICAgICAgICAgICAgICAgdmFyIGxpbmVUZXh0TWFya2VyUmFuZ2UgPSB0ZXh0LmxpbmVUZXh0 TWFya2VyUmFuZ2VGb3JUZXh0TWFya2VyKHN0YXJ0TWFya2VyKTsKKyAgICAgICAgICAgICAgICBk ZWJ1Zyh0ZXh0LnN0cmluZ0ZvclRleHRNYXJrZXJSYW5nZShsaW5lVGV4dE1hcmtlclJhbmdlKSk7 CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIDwvc2NyaXB0PgorCisgICAgICAgIDxzY3Jp cHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKworICAg IDwvYm9keT4KKzwvaHRtbD4KKwo=