161097 2016-08-23 11:36:54 -0700 [ES6] Module namespace object's Symbol.iterator method should only accept module namespace objects 2016-08-23 12:09:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki benjamin fpizlo ggaren jfbastien keith_miller mark.lam msaboff saam oldest_to_newest 1222324 0 ysuzuki 2016-08-23 11:36:54 -0700 [ES6] Module namespace object's Symbol.iterator method should only accept module namespace objects 1222325 1 286751 ysuzuki 2016-08-23 11:37:05 -0700 Created attachment 286751 Patch 1222342 2 286751 keith_miller 2016-08-23 12:03:23 -0700 Comment on attachment 286751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286751&action=review r=me with comment. > Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp:206 > + return JSValue::encode(throwTypeError(exec, ASCIILiteral("|this| should be a module namespace object"))); This could be "return throwVMTypeError(...)" instead of "return JSValue::encode(throwTypeError(...))" 1222343 3 286751 ysuzuki 2016-08-23 12:04:27 -0700 Comment on attachment 286751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286751&action=review Thank you :) >> Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp:206 >> + return JSValue::encode(throwTypeError(exec, ASCIILiteral("|this| should be a module namespace object"))); > > This could be "return throwVMTypeError(...)" instead of "return JSValue::encode(throwTypeError(...))" Nice! Changed. 1222349 4 ysuzuki 2016-08-23 12:09:19 -0700 Committed r204848: <http://trac.webkit.org/changeset/204848> 286751 2016-08-23 11:37:05 -0700 2016-08-23 12:03:23 -0700 Patch bug-161097-20160824033506.patch text/plain 3767 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MGY0OTJkM2Q2N2U5ZDVmODEyY2VmNTkzMTc3MmFlYjE2ZTI1M2FkLi4xZDE0MWE1MzQ0ZDI5MGY2 MjZlOWJhZTZjYWQ1ZWJkYzhiOGRlYmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wOC0yMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbRVM2XSBNb2R1bGUgbmFtZXNwYWNlIG9iamVjdCdzIFN5bWJvbC5p dGVyYXRvciBtZXRob2Qgc2hvdWxkIG9ubHkgYWNjZXB0IG1vZHVsZSBuYW1lc3BhY2Ugb2JqZWN0 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMDk3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50 aW1lL0pTTW9kdWxlTmFtZXNwYWNlT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6bW9kdWxlTmFt ZXNwYWNlT2JqZWN0U3ltYm9sSXRlcmF0b3IpOgorCiAyMDE2LTA4LTIyICBZdXN1a2UgU3V6dWtp ICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtFUzZdIE1vZHVsZXMnIGBleHBv cnQgZGVmYXVsdCBmdW5jdGlvbi9jbGFzc2Agc2hvdWxkIGJlIGRlY2xhcmF0aW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU01vZHVsZU5hbWVzcGFjZU9iamVj dC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU01vZHVsZU5hbWVzcGFjZU9i amVjdC5jcHAKaW5kZXggZDYxMDU4NjUyZjk1YzY5NDRmOTc5M2IyMGI5ZTVmYmYyZDA3NzVkNi4u YzZlZDgwNDEwNmRjNzcyODgwNmRkODFlMTBmNGI1NjI4Yjk3YzAwZCAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNNb2R1bGVOYW1lc3BhY2VPYmplY3QuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTTW9kdWxlTmFtZXNwYWNlT2JqZWN0 LmNwcApAQCAtMjAxLDEwICsyMDEsMTAgQEAgYm9vbCBKU01vZHVsZU5hbWVzcGFjZU9iamVjdDo6 ZGVmaW5lT3duUHJvcGVydHkoSlNPYmplY3QqLCBFeGVjU3RhdGUqIGV4ZWMsIFByb3AKIAogRW5j b2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBtb2R1bGVOYW1lc3BhY2VPYmplY3RTeW1ib2xJdGVy YXRvcihFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgSlNWYWx1ZSB0aGlzVmFsdWUgPSBleGVjLT50 aGlzVmFsdWUoKTsKLSAgICBpZiAoIXRoaXNWYWx1ZS5pc09iamVjdCgpKQotICAgICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKHRocm93VHlwZUVycm9yKGV4ZWMsIEFTQ0lJTGl0ZXJhbCgifHRo aXN8IHNob3VsZCBiZSBhbiBvYmplY3QiKSkpOwotICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUo SlNQcm9wZXJ0eU5hbWVJdGVyYXRvcjo6Y3JlYXRlKGV4ZWMsIGV4ZWMtPmxleGljYWxHbG9iYWxP YmplY3QoKS0+cHJvcGVydHlOYW1lSXRlcmF0b3JTdHJ1Y3R1cmUoKSwgYXNPYmplY3QodGhpc1Zh bHVlKSkpOworICAgIEpTTW9kdWxlTmFtZXNwYWNlT2JqZWN0KiBvYmplY3QgPSBqc0R5bmFtaWND YXN0PEpTTW9kdWxlTmFtZXNwYWNlT2JqZWN0Kj4oZXhlYy0+dGhpc1ZhbHVlKCkpOworICAgIGlm ICghb2JqZWN0KQorICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHRocm93VHlwZUVycm9y KGV4ZWMsIEFTQ0lJTGl0ZXJhbCgifHRoaXN8IHNob3VsZCBiZSBhIG1vZHVsZSBuYW1lc3BhY2Ug b2JqZWN0IikpKTsKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTUHJvcGVydHlOYW1lSXRl cmF0b3I6OmNyZWF0ZShleGVjLCBleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCktPnByb3BlcnR5 TmFtZUl0ZXJhdG9yU3RydWN0dXJlKCksIG9iamVjdCkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBK U0MKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggMWM0NjE1OWZjZGFhOWYzNGY3NGYwYmVkOTA2ZjkxOWU5ZjI1YWQ2YS4uMDQwM2FkZmRmYjhm OTU4ODU0ODkzZTBhZGMxZDM0YjdiMmY3NmNmMCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VM b2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0wOC0yMyAg WXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KKworICAgICAgICBbRVM2XSBN b2R1bGUgbmFtZXNwYWNlIG9iamVjdCdzIFN5bWJvbC5pdGVyYXRvciBtZXRob2Qgc2hvdWxkIG9u bHkgYWNjZXB0IG1vZHVsZSBuYW1lc3BhY2Ugb2JqZWN0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYxMDk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0MjYyLnlhbWw6CisKIDIwMTYtMDgtMjIg IFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0VTNl0g TW9kdWxlcycgYGV4cG9ydCBkZWZhdWx0IGZ1bmN0aW9uL2NsYXNzYCBzaG91bGQgYmUgZGVjbGFy YXRpb24KZGlmZiAtLWdpdCBhL0pTVGVzdHMvdGVzdDI2Mi55YW1sIGIvSlNUZXN0cy90ZXN0MjYy LnlhbWwKaW5kZXggZDg4YzgyOWUwNWIyODJlNzNlNmYxYmY5MzE1ZDY4NjVhYzE0YmI3YS4uNjI1 MTMyZWQxOTY3MTM4ZmViYjJiNGY4MzU5YmU5ZjMxYmVjMjU3MCAxMDA2NDQKLS0tIGEvSlNUZXN0 cy90ZXN0MjYyLnlhbWwKKysrIGIvSlNUZXN0cy90ZXN0MjYyLnlhbWwKQEAgLTcxMjU0LDcgKzcx MjU0LDcgQEAKIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2xhbmd1YWdlL21vZHVsZS1jb2RlL25hbWVz cGFjZS9TeW1ib2wuaXRlcmF0b3IvcHJvcC1kZXNjLmpzCiAgIGNtZDogcnVuVGVzdDI2MiA6bm9y bWFsLCAiTm9FeGNlcHRpb24iLCBbIi4uLy4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwg Ii4uLy4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFs6bW9kdWxlXQogLSBwYXRoOiB0ZXN0 MjYyL3Rlc3QvbGFuZ3VhZ2UvbW9kdWxlLWNvZGUvbmFtZXNwYWNlL1N5bWJvbC5pdGVyYXRvci90 aGlzLXZhbC1ub3QtbnMuanMKLSAgY21kOiBydW5UZXN0MjYyIDpmYWlsLCAiTm9FeGNlcHRpb24i LCBbIi4uLy4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0LmpzIiwgIi4uLy4uLy4uLy4uLy4uL2hh cm5lc3Mvc3RhLmpzIl0sIFs6bW9kdWxlXQorICBjbWQ6IHJ1blRlc3QyNjIgOm5vcm1hbCwgIk5v RXhjZXB0aW9uIiwgWyIuLi8uLi8uLi8uLi8uLi9oYXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8u Li8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbOm1vZHVsZV0KIC0gcGF0aDogdGVzdDI2Mi90ZXN0 L2xhbmd1YWdlL21vZHVsZS1jb2RlL25hbWVzcGFjZS9TeW1ib2wuaXRlcmF0b3IvdmFsdWVzLWJp bmRpbmctdHlwZXMuanMKICAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4Y2VwdGlvbiIs IFsiLi4vLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vLi4vaGFy bmVzcy9zdGEuanMiXSwgWzptb2R1bGVdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9sYW5ndWFnZS9t b2R1bGUtY29kZS9uYW1lc3BhY2UvU3ltYm9sLml0ZXJhdG9yL3ZhbHVlcy1iaW5kaW5nLXR5cGVz Xy5qcwo=