161075 2016-08-22 23:47:27 -0700 Use Messages::XXX...::Reply explicitly 2016-08-23 00:18:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki andersca cgarcia clopez ggaren mrobinson oldest_to_newest 1222149 0 ysuzuki 2016-08-22 23:47:27 -0700 Use Messages::XXX...::Reply explicitly 1222150 1 286682 ysuzuki 2016-08-22 23:51:54 -0700 Created attachment 286682 Patch 1222151 2 286682 ysuzuki 2016-08-22 23:54:31 -0700 Comment on attachment 286682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286682&action=review > Source/WebKit2/ChangeLog:12 > + Looking throught the other code, they use ::Reply explicitly. Typo. Will fix. 1222152 3 286683 ysuzuki 2016-08-22 23:55:21 -0700 Created attachment 286683 Patch 1222154 4 286683 cgarcia 2016-08-22 23:56:28 -0700 Comment on attachment 286683 Patch Thanks! 1222155 5 ysuzuki 2016-08-23 00:11:23 -0700 Committed r204772: <http://trac.webkit.org/changeset/204772> 1222158 6 ysuzuki 2016-08-23 00:18:38 -0700 OK, GTK has just been recovered! 286682 2016-08-22 23:51:54 -0700 2016-08-22 23:55:17 -0700 Patch bug-161075-20160823154956.patch text/plain 3016 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODFiMGU4ZmI0NDVjMjhk YzgwYzhlYzczNWIxYmZhMDEyNzIwNzIyYS4uNDM5YmQ3ODJkZGIwY2YzMTdhYTU5NDIyODI4Y2Vj ODYzYTE0YzNhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA4LTIyICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFVzZSBNZXNzYWdl czo6WFhYLi4uOjpSZXBseSBleHBsaWNpdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjEwNzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBzdGQ6OnR1cGxlJ3MgY29uc3RydWN0b3IgaXMgYW5ub3RhdGVk IGFzIGBleHBsaWNpdGAuCisgICAgICAgIFNvIHdlIGNhbm5vdCB1c2UgdGhlIGltcGxpY2l0IGNv bnZlcnNpb24gaGVyZS4KKyAgICAgICAgVGhpcyBjYXVzZXMgdGhlIGJ1aWxkIGZhaWx1cmUgaW4g RUZMIGFuZCBHVEsuCisKKyAgICAgICAgTG9va2luZyB0aHJvdWdodCB0aGUgb3RoZXIgY29kZSwg dGhleSB1c2UgOjpSZXBseSBleHBsaWNpdGx5LgorICAgICAgICBTbyBpbiB0aGlzIHBhdGNoLCB3 ZSBmb2xsb3cgdGhhdC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvRGF0YWJhc2VzL0luZGV4ZWRE Qi9XZWJJREJDb25uZWN0aW9uVG9TZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJD b25uZWN0aW9uVG9TZXJ2ZXI6OldlYklEQkNvbm5lY3Rpb25Ub1NlcnZlcik6CisgICAgICAgICog V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2VGdWxsU2NyZWVuQ2xp ZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGVQYWdlRnVsbFNjcmVlbkNs aWVudDo6c3VwcG9ydHNGdWxsU2NyZWVuKToKKwogMjAxNi0wOC0yMiAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBBcmd1bWVudHMuaApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9EYXRhYmFzZXMvSW5kZXhlZERCL1dl YklEQkNvbm5lY3Rpb25Ub1NlcnZlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rh dGFiYXNlcy9JbmRleGVkREIvV2ViSURCQ29ubmVjdGlvblRvU2VydmVyLmNwcAppbmRleCAxYmQ4 ZmZlYWM3ZWEwYTIyZDlhNGFjN2MzZmU5ZDM1NDM5OTAwY2MxLi4xOGMxYmFjZTM5YWEzNDkyZDI3 YmRhZjlkODNhMzc2NDE4ZWE0NjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL0RhdGFiYXNlcy9JbmRleGVkREIvV2ViSURCQ29ubmVjdGlvblRvU2VydmVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0RhdGFiYXNlcy9JbmRleGVkREIvV2ViSURCQ29u bmVjdGlvblRvU2VydmVyLmNwcApAQCAtNjMsNyArNjMsNyBAQCBXZWJJREJDb25uZWN0aW9uVG9T ZXJ2ZXI6OldlYklEQkNvbm5lY3Rpb25Ub1NlcnZlcigpCiB7CiAgICAgcmVsYXhBZG9wdGlvblJl cXVpcmVtZW50KCk7CiAKLSAgICBtX2lzT3BlbkluU2VydmVyID0gc2VuZFN5bmMoTWVzc2FnZXM6 OkRhdGFiYXNlVG9XZWJQcm9jZXNzQ29ubmVjdGlvbjo6RXN0YWJsaXNoSURCQ29ubmVjdGlvblRv U2VydmVyKCksIG1faWRlbnRpZmllcik7CisgICAgbV9pc09wZW5JblNlcnZlciA9IHNlbmRTeW5j KE1lc3NhZ2VzOjpEYXRhYmFzZVRvV2ViUHJvY2Vzc0Nvbm5lY3Rpb246OkVzdGFibGlzaElEQkNv bm5lY3Rpb25Ub1NlcnZlcigpLCBNZXNzYWdlczo6RGF0YWJhc2VUb1dlYlByb2Nlc3NDb25uZWN0 aW9uOjpFc3RhYmxpc2hJREJDb25uZWN0aW9uVG9TZXJ2ZXI6OlJlcGx5KG1faWRlbnRpZmllcikp OwogICAgIG1fY29ubmVjdGlvblRvU2VydmVyID0gSURCQ2xpZW50OjpJREJDb25uZWN0aW9uVG9T ZXJ2ZXI6OmNyZWF0ZSgqdGhpcyk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlRnVsbFNjcmVlbkNsaWVu dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVk QnVuZGxlUGFnZUZ1bGxTY3JlZW5DbGllbnQuY3BwCmluZGV4IDk2YjlhMTg0ZmFhMzAzNWY4NGFh YzdlZmU3ZTlkYThkZTRiYzRkNWQuLjIzOWFlZTFjOTc2N2YyMjBjYzk1MzhhOTEyODU3NDRjZTk1 YzBlMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5k bGUvSW5qZWN0ZWRCdW5kbGVQYWdlRnVsbFNjcmVlbkNsaWVudC5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZVBhZ2VGdWxsU2Ny ZWVuQ2xpZW50LmNwcApAQCAtNDgsNyArNDgsNyBAQCBib29sIEluamVjdGVkQnVuZGxlUGFnZUZ1 bGxTY3JlZW5DbGllbnQ6OnN1cHBvcnRzRnVsbFNjcmVlbihXZWJQYWdlICpwYWdlLCBib29sCiAg ICAgICAgIHJldHVybiBtX2NsaWVudC5zdXBwb3J0c0Z1bGxTY3JlZW4odG9BUEkocGFnZSksIHdp dGhLZXlib2FyZCk7CiAKICAgICBib29sIHN1cHBvcnRzID0gdHJ1ZTsKLSAgICBwYWdlLT5zZW5k U3luYyhNZXNzYWdlczo6V2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eTo6U3VwcG9ydHNGdWxsU2Ny ZWVuKHdpdGhLZXlib2FyZCksIHN1cHBvcnRzKTsKKyAgICBwYWdlLT5zZW5kU3luYyhNZXNzYWdl czo6V2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eTo6U3VwcG9ydHNGdWxsU2NyZWVuKHdpdGhLZXli b2FyZCksIE1lc3NhZ2VzOjpXZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5OjpTdXBwb3J0c0Z1bGxT Y3JlZW46OlJlcGx5KHN1cHBvcnRzKSk7CiAgICAgcmV0dXJuIHN1cHBvcnRzOwogfQogCg== 286683 2016-08-22 23:55:21 -0700 2016-08-22 23:56:28 -0700 Patch bug-161075-20160823155323.patch text/plain 3017 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODFiMGU4ZmI0NDVjMjhk YzgwYzhlYzczNWIxYmZhMDEyNzIwNzIyYS4uZjkxMGMyYTdmMWM5MjM2YTc0Yjg3NDAyNzczNzg2 ZDdmYjUyYTAyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA4LTIyICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFVzZSBNZXNzYWdl czo6WFhYLi4uOjpSZXBseSBleHBsaWNpdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjEwNzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBzdGQ6OnR1cGxlJ3MgY29uc3RydWN0b3IgaXMgYW5ub3RhdGVk IGFzIGBleHBsaWNpdGAuCisgICAgICAgIFNvIHdlIGNhbm5vdCB1c2UgdGhlIGltcGxpY2l0IGNv bnZlcnNpb24gaGVyZS4KKyAgICAgICAgVGhpcyBjYXVzZXMgdGhlIGJ1aWxkIGZhaWx1cmUgaW4g RUZMIGFuZCBHVEsuCisKKyAgICAgICAgTG9va2luZyB0aHJvdWdoIGNvZGUsIHRoZSBvdGhlciBw bGFjZXMgdXNlIDo6UmVwbHkgZXhwbGljaXRseS4KKyAgICAgICAgU28gaW4gdGhpcyBwYXRjaCwg d2UgZm9sbG93IHRoYXQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0RhdGFiYXNlcy9JbmRleGVk REIvV2ViSURCQ29ubmVjdGlvblRvU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSURC Q29ubmVjdGlvblRvU2VydmVyOjpXZWJJREJDb25uZWN0aW9uVG9TZXJ2ZXIpOgorICAgICAgICAq IFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlRnVsbFNjcmVlbkNs aWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkluamVjdGVkQnVuZGxlUGFnZUZ1bGxTY3JlZW5D bGllbnQ6OnN1cHBvcnRzRnVsbFNjcmVlbik6CisKIDIwMTYtMDgtMjIgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgQXJndW1lbnRzLmgKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRGF0YWJhc2VzL0luZGV4ZWREQi9X ZWJJREJDb25uZWN0aW9uVG9TZXJ2ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9E YXRhYmFzZXMvSW5kZXhlZERCL1dlYklEQkNvbm5lY3Rpb25Ub1NlcnZlci5jcHAKaW5kZXggMWJk OGZmZWFjN2VhMGEyMmQ5YTRhYzdjM2ZlOWQzNTQzOTkwMGNjMS4uMThjMWJhY2UzOWFhMzQ5MmQy N2JkYWY5ZDgzYTM3NjQxOGVhNDYzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9EYXRhYmFzZXMvSW5kZXhlZERCL1dlYklEQkNvbm5lY3Rpb25Ub1NlcnZlci5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9EYXRhYmFzZXMvSW5kZXhlZERCL1dlYklEQkNv bm5lY3Rpb25Ub1NlcnZlci5jcHAKQEAgLTYzLDcgKzYzLDcgQEAgV2ViSURCQ29ubmVjdGlvblRv U2VydmVyOjpXZWJJREJDb25uZWN0aW9uVG9TZXJ2ZXIoKQogewogICAgIHJlbGF4QWRvcHRpb25S ZXF1aXJlbWVudCgpOwogCi0gICAgbV9pc09wZW5JblNlcnZlciA9IHNlbmRTeW5jKE1lc3NhZ2Vz OjpEYXRhYmFzZVRvV2ViUHJvY2Vzc0Nvbm5lY3Rpb246OkVzdGFibGlzaElEQkNvbm5lY3Rpb25U b1NlcnZlcigpLCBtX2lkZW50aWZpZXIpOworICAgIG1faXNPcGVuSW5TZXJ2ZXIgPSBzZW5kU3lu YyhNZXNzYWdlczo6RGF0YWJhc2VUb1dlYlByb2Nlc3NDb25uZWN0aW9uOjpFc3RhYmxpc2hJREJD b25uZWN0aW9uVG9TZXJ2ZXIoKSwgTWVzc2FnZXM6OkRhdGFiYXNlVG9XZWJQcm9jZXNzQ29ubmVj dGlvbjo6RXN0YWJsaXNoSURCQ29ubmVjdGlvblRvU2VydmVyOjpSZXBseShtX2lkZW50aWZpZXIp KTsKICAgICBtX2Nvbm5lY3Rpb25Ub1NlcnZlciA9IElEQkNsaWVudDo6SURCQ29ubmVjdGlvblRv U2VydmVyOjpjcmVhdGUoKnRoaXMpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZUZ1bGxTY3JlZW5DbGll bnQuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3Rl ZEJ1bmRsZVBhZ2VGdWxsU2NyZWVuQ2xpZW50LmNwcAppbmRleCA5NmI5YTE4NGZhYTMwMzVmODRh YWM3ZWZlN2U5ZGE4ZGU0YmM0ZDVkLi4yMzlhZWUxYzk3NjdmMjIwY2M5NTM4YTkxMjg1NzQ0Y2U5 NWMwZTM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0luamVjdGVkQnVuZGxlUGFnZUZ1bGxTY3JlZW5DbGllbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlRnVsbFNj cmVlbkNsaWVudC5jcHAKQEAgLTQ4LDcgKzQ4LDcgQEAgYm9vbCBJbmplY3RlZEJ1bmRsZVBhZ2VG dWxsU2NyZWVuQ2xpZW50OjpzdXBwb3J0c0Z1bGxTY3JlZW4oV2ViUGFnZSAqcGFnZSwgYm9vbAog ICAgICAgICByZXR1cm4gbV9jbGllbnQuc3VwcG9ydHNGdWxsU2NyZWVuKHRvQVBJKHBhZ2UpLCB3 aXRoS2V5Ym9hcmQpOwogCiAgICAgYm9vbCBzdXBwb3J0cyA9IHRydWU7Ci0gICAgcGFnZS0+c2Vu ZFN5bmMoTWVzc2FnZXM6OldlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHk6OlN1cHBvcnRzRnVsbFNj cmVlbih3aXRoS2V5Ym9hcmQpLCBzdXBwb3J0cyk7CisgICAgcGFnZS0+c2VuZFN5bmMoTWVzc2Fn ZXM6OldlYkZ1bGxTY3JlZW5NYW5hZ2VyUHJveHk6OlN1cHBvcnRzRnVsbFNjcmVlbih3aXRoS2V5 Ym9hcmQpLCBNZXNzYWdlczo6V2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eTo6U3VwcG9ydHNGdWxs U2NyZWVuOjpSZXBseShzdXBwb3J0cykpOwogICAgIHJldHVybiBzdXBwb3J0czsKIH0KIAo=