161057 2016-08-22 14:11:22 -0700 Simplify the generated message structs 2016-08-22 14:33:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1221970 0 andersca 2016-08-22 14:11:22 -0700 Simplify the generated message structs 1221972 1 286621 andersca 2016-08-22 14:15:36 -0700 Created attachment 286621 Patch 1221976 2 286621 ggaren 2016-08-22 14:29:43 -0700 Comment on attachment 286621 Patch r=me with build fix ../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp: In member function 'bool WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen(WebKit::WebPage*, bool)': ../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:51:99: error: no matching function for call to 'WebKit::WebPage::sendSync(Messages::WebFullScreenManagerProxy::SupportsFullScreen, bool&)' 1221978 3 andersca 2016-08-22 14:33:42 -0700 Committed r204739: <http://trac.webkit.org/changeset/204739> 286621 2016-08-22 14:15:36 -0700 2016-08-22 14:29:43 -0700 Patch bug-161057-20160822141339.patch text/plain 6452 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDUyN2I0M2ZjNzFiNmQ2 OTI1MjJmZTk3M2YzZmI3ODM5ZGQzYzkxNy4uMjM2MjA3ODY3MWFjOWQ5MmVkZDdjMTU2MDMyN2M2 YTYxOThmMzRjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA4LTIyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgdGhl IGdlbmVyYXRlZCBtZXNzYWdlIHN0cnVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MTA1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVzZSBhIGNsYXNzIHRlbXBsYXRlIHRvIHRyYW5zZm9ybSB0aGUg UmVwbHkgYW5kIEFyZ3VtZW50IHR1cGxlIHR5cGVzIGZvciBlbmNvZGluZy9kZWNvZGluZworICAg ICAgICBpbnN0ZWFkIG9mIGdlbmVyYXRpbmcgdGhlbSBmb3IgZWFjaCBtZXNzYWdlLgorCisgICAg ICAgICogUGxhdGZvcm0vSVBDL0hhbmRsZU1lc3NhZ2UuaDoKKyAgICAgICAgKElQQzo6aGFuZGxl TWVzc2FnZSk6CisgICAgICAgIChJUEM6OmhhbmRsZU1lc3NhZ2VEZWxheWVkKToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weToKKyAgICAgICAgKHJlcGx5X3R5cGUpOgorICAg ICAgICAobWVzc2FnZV90b19zdHJ1Y3RfZGVjbGFyYXRpb24pOgorICAgICAgICAoZGVjb2RlX3R5 cGUpOiBEZWxldGVkLgorCiAyMDE2LTA4LTE5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIE1lc3NhZ2VSZWNvcmRlcgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL0hhbmRsZU1lc3NhZ2UuaCBiL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtL0lQQy9IYW5kbGVNZXNzYWdlLmgKaW5kZXggZWNlNDFkYjU4YjVmODdlMzli MmNmMDc0MzUxNDIyNmU5ZjJmZmNmOS4uNDA4ZGEyYTY1YzI2MDNiYTIwMjFmY2ZmMTAzODE0NGM0 NTBjNWM2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL0hhbmRsZU1l c3NhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvSGFuZGxlTWVzc2FnZS5o CkBAIC04MCwxMCArODAsMjAgQEAgdm9pZCBjYWxsTWVtYmVyRnVuY3Rpb24oQ29ubmVjdGlvbiYg Y29ubmVjdGlvbiwgQXJnc1R1cGxlJiYgYXJncywgUmVwbHlBcmdzVHVwbGUKIAogLy8gTWFpbiBk aXNwYXRjaCBmdW5jdGlvbnMKIAordGVtcGxhdGU8dHlwZW5hbWUgVD4KK3N0cnVjdCBDb2RpbmdU eXBlIHsKKyAgICB0eXBlZGVmIHN0ZDo6cmVtb3ZlX2NvbnN0X3Q8c3RkOjpyZW1vdmVfcmVmZXJl bmNlX3Q8VD4+IFR5cGU7Cit9OworCit0ZW1wbGF0ZTx0eXBlbmFtZS4uLiBUcz4KK3N0cnVjdCBD b2RpbmdUeXBlPHN0ZDo6dHVwbGU8VHMuLi4+PiB7CisgICAgdHlwZWRlZiBzdGQ6OnR1cGxlPHR5 cGVuYW1lIENvZGluZ1R5cGU8VHM+OjpUeXBlLi4uPiBUeXBlOworfTsKKwogdGVtcGxhdGU8dHlw ZW5hbWUgVCwgdHlwZW5hbWUgQywgdHlwZW5hbWUgTUY+CiB2b2lkIGhhbmRsZU1lc3NhZ2UoRGVj b2RlciYgZGVjb2RlciwgQyogb2JqZWN0LCBNRiBmdW5jdGlvbikKIHsKLSAgICB0eXBlbmFtZSBU OjpEZWNvZGVUeXBlIGFyZ3VtZW50czsKKyAgICB0eXBlbmFtZSBDb2RpbmdUeXBlPHR5cGVuYW1l IFQ6OkFyZ3VtZW50cz46OlR5cGUgYXJndW1lbnRzOwogICAgIGlmICghZGVjb2Rlci5kZWNvZGUo YXJndW1lbnRzKSkgewogICAgICAgICBBU1NFUlQoZGVjb2Rlci5pc0ludmFsaWQoKSk7CiAgICAg ICAgIHJldHVybjsKQEAgLTk1LDEzICsxMDUsMTMgQEAgdm9pZCBoYW5kbGVNZXNzYWdlKERlY29k ZXImIGRlY29kZXIsIEMqIG9iamVjdCwgTUYgZnVuY3Rpb24pCiB0ZW1wbGF0ZTx0eXBlbmFtZSBU LCB0eXBlbmFtZSBDLCB0eXBlbmFtZSBNRj4KIHZvaWQgaGFuZGxlTWVzc2FnZShEZWNvZGVyJiBk ZWNvZGVyLCBFbmNvZGVyJiByZXBseUVuY29kZXIsIEMqIG9iamVjdCwgTUYgZnVuY3Rpb24pCiB7 Ci0gICAgdHlwZW5hbWUgVDo6RGVjb2RlVHlwZSBhcmd1bWVudHM7CisgICAgdHlwZW5hbWUgQ29k aW5nVHlwZTx0eXBlbmFtZSBUOjpBcmd1bWVudHM+OjpUeXBlIGFyZ3VtZW50czsKICAgICBpZiAo IWRlY29kZXIuZGVjb2RlKGFyZ3VtZW50cykpIHsKICAgICAgICAgQVNTRVJUKGRlY29kZXIuaXNJ bnZhbGlkKCkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgdHlwZW5hbWUgVDo6UmVw bHk6OlZhbHVlVHlwZSByZXBseUFyZ3VtZW50czsKKyAgICB0eXBlbmFtZSBDb2RpbmdUeXBlPHR5 cGVuYW1lIFQ6OlJlcGx5Pjo6VHlwZSByZXBseUFyZ3VtZW50czsKICAgICBjYWxsTWVtYmVyRnVu Y3Rpb24oV1RGTW92ZShhcmd1bWVudHMpLCByZXBseUFyZ3VtZW50cywgb2JqZWN0LCBmdW5jdGlv bik7CiAgICAgcmVwbHlFbmNvZGVyIDw8IHJlcGx5QXJndW1lbnRzOwogfQpAQCAtMTA5LDEzICsx MTksMTMgQEAgdm9pZCBoYW5kbGVNZXNzYWdlKERlY29kZXImIGRlY29kZXIsIEVuY29kZXImIHJl cGx5RW5jb2RlciwgQyogb2JqZWN0LCBNRiBmdW5jdGkKIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5 cGVuYW1lIEMsIHR5cGVuYW1lIE1GPgogdm9pZCBoYW5kbGVNZXNzYWdlKENvbm5lY3Rpb24mIGNv bm5lY3Rpb24sIERlY29kZXImIGRlY29kZXIsIEVuY29kZXImIHJlcGx5RW5jb2RlciwgQyogb2Jq ZWN0LCBNRiBmdW5jdGlvbikKIHsKLSAgICB0eXBlbmFtZSBUOjpEZWNvZGVUeXBlIGFyZ3VtZW50 czsKKyAgICB0eXBlbmFtZSBDb2RpbmdUeXBlPHR5cGVuYW1lIFQ6OkFyZ3VtZW50cz46OlR5cGUg YXJndW1lbnRzOwogICAgIGlmICghZGVjb2Rlci5kZWNvZGUoYXJndW1lbnRzKSkgewogICAgICAg ICBBU1NFUlQoZGVjb2Rlci5pc0ludmFsaWQoKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAK LSAgICB0eXBlbmFtZSBUOjpSZXBseTo6VmFsdWVUeXBlIHJlcGx5QXJndW1lbnRzOworICAgIHR5 cGVuYW1lIENvZGluZ1R5cGU8dHlwZW5hbWUgVDo6UmVwbHk+OjpUeXBlIHJlcGx5QXJndW1lbnRz OwogICAgIGNhbGxNZW1iZXJGdW5jdGlvbihjb25uZWN0aW9uLCBXVEZNb3ZlKGFyZ3VtZW50cyks IHJlcGx5QXJndW1lbnRzLCBvYmplY3QsIGZ1bmN0aW9uKTsKICAgICByZXBseUVuY29kZXIgPDwg cmVwbHlBcmd1bWVudHM7CiB9CkBAIC0xMjMsNyArMTMzLDcgQEAgdm9pZCBoYW5kbGVNZXNzYWdl KENvbm5lY3Rpb24mIGNvbm5lY3Rpb24sIERlY29kZXImIGRlY29kZXIsIEVuY29kZXImIHJlcGx5 RW5jb2QKIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIEMsIHR5cGVuYW1lIE1GPgogdm9p ZCBoYW5kbGVNZXNzYWdlKENvbm5lY3Rpb24mIGNvbm5lY3Rpb24sIERlY29kZXImIGRlY29kZXIs IEMqIG9iamVjdCwgTUYgZnVuY3Rpb24pCiB7Ci0gICAgdHlwZW5hbWUgVDo6RGVjb2RlVHlwZSBh cmd1bWVudHM7CisgICAgdHlwZW5hbWUgQ29kaW5nVHlwZTx0eXBlbmFtZSBUOjpBcmd1bWVudHM+ OjpUeXBlIGFyZ3VtZW50czsKICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGFyZ3VtZW50cykpIHsK ICAgICAgICAgQVNTRVJUKGRlY29kZXIuaXNJbnZhbGlkKCkpOwogICAgICAgICByZXR1cm47CkBA IC0xMzQsNyArMTQ0LDcgQEAgdm9pZCBoYW5kbGVNZXNzYWdlKENvbm5lY3Rpb24mIGNvbm5lY3Rp b24sIERlY29kZXImIGRlY29kZXIsIEMqIG9iamVjdCwgTUYgZnVuY3QKIHRlbXBsYXRlPHR5cGVu YW1lIFQsIHR5cGVuYW1lIEMsIHR5cGVuYW1lIE1GPgogdm9pZCBoYW5kbGVNZXNzYWdlRGVsYXll ZChDb25uZWN0aW9uJiBjb25uZWN0aW9uLCBEZWNvZGVyJiBkZWNvZGVyLCBzdGQ6OnVuaXF1ZV9w dHI8RW5jb2Rlcj4mIHJlcGx5RW5jb2RlciwgQyogb2JqZWN0LCBNRiBmdW5jdGlvbikKIHsKLSAg ICB0eXBlbmFtZSBUOjpEZWNvZGVUeXBlIGFyZ3VtZW50czsKKyAgICB0eXBlbmFtZSBDb2RpbmdU eXBlPHR5cGVuYW1lIFQ6OkFyZ3VtZW50cz46OlR5cGUgYXJndW1lbnRzOwogICAgIGlmICghZGVj b2Rlci5kZWNvZGUoYXJndW1lbnRzKSkgewogICAgICAgICBBU1NFUlQoZGVjb2Rlci5pc0ludmFs aWQoKSk7CiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1Njcmlw dHMvd2Via2l0L21lc3NhZ2VzLnB5IGIvU291cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQvbWVz c2FnZXMucHkKaW5kZXggY2IxNmExYTBmNTAxMDhkMDI1NzMyMmJmNDU1NTdkNGVjMzJlYWMyYy4u Mzg4YmE2YmEzYTY1N2VlYWI2YWJiZDIyY2EwZTMzOTA3MmY3ZTQxZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkKKysrIGIvU291cmNlL1dlYktp dDIvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkKQEAgLTk3LDExICs5Nyw3IEBAIGRlZiBhcmd1 bWVudHNfdHlwZShtZXNzYWdlKToKIAogCiBkZWYgcmVwbHlfdHlwZShtZXNzYWdlKToKLSAgICBy ZXR1cm4gJ0lQQzo6QXJndW1lbnRzPCVzPicgJSAoJywgJy5qb2luKHJlcGx5X3BhcmFtZXRlcl90 eXBlKHBhcmFtZXRlci50eXBlKSBmb3IgcGFyYW1ldGVyIGluIG1lc3NhZ2UucmVwbHlfcGFyYW1l dGVycykpCi0KLQotZGVmIGRlY29kZV90eXBlKG1lc3NhZ2UpOgotICAgIHJldHVybiAnc3RkOjp0 dXBsZTwlcz4nICUgJywgJy5qb2luKHBhcmFtZXRlci50eXBlIGZvciBwYXJhbWV0ZXIgaW4gbWVz c2FnZS5wYXJhbWV0ZXJzKQorICAgIHJldHVybiAnc3RkOjp0dXBsZTwlcz4nICUgKCcsICcuam9p bihyZXBseV9wYXJhbWV0ZXJfdHlwZShwYXJhbWV0ZXIudHlwZSkgZm9yIHBhcmFtZXRlciBpbiBt ZXNzYWdlLnJlcGx5X3BhcmFtZXRlcnMpKQogCiAKIGRlZiBtZXNzYWdlX3RvX3N0cnVjdF9kZWNs YXJhdGlvbihtZXNzYWdlKToKQEAgLTEwOSw3ICsxMDUsNyBAQCBkZWYgbWVzc2FnZV90b19zdHJ1 Y3RfZGVjbGFyYXRpb24obWVzc2FnZSk6CiAgICAgZnVuY3Rpb25fcGFyYW1ldGVycyA9IFsoZnVu Y3Rpb25fcGFyYW1ldGVyX3R5cGUoeC50eXBlKSwgeC5uYW1lKSBmb3IgeCBpbiBtZXNzYWdlLnBh cmFtZXRlcnNdCiAgICAgcmVzdWx0LmFwcGVuZCgnY2xhc3MgJXMge1xuJyAlIG1lc3NhZ2UubmFt ZSkKICAgICByZXN1bHQuYXBwZW5kKCdwdWJsaWM6XG4nKQotICAgIHJlc3VsdC5hcHBlbmQoJyAg ICB0eXBlZGVmICVzIERlY29kZVR5cGU7XG4nICUgZGVjb2RlX3R5cGUobWVzc2FnZSkpCisgICAg cmVzdWx0LmFwcGVuZCgnICAgIHR5cGVkZWYgJXMgQXJndW1lbnRzO1xuJyAlIGFyZ3VtZW50c190 eXBlKG1lc3NhZ2UpKQogICAgIHJlc3VsdC5hcHBlbmQoJ1xuJykKICAgICByZXN1bHQuYXBwZW5k KCcgICAgc3RhdGljIElQQzo6U3RyaW5nUmVmZXJlbmNlIHJlY2VpdmVyTmFtZSgpIHsgcmV0dXJu IG1lc3NhZ2VSZWNlaXZlck5hbWUoKTsgfVxuJykKICAgICByZXN1bHQuYXBwZW5kKCcgICAgc3Rh dGljIElQQzo6U3RyaW5nUmVmZXJlbmNlIG5hbWUoKSB7IHJldHVybiBJUEM6OlN0cmluZ1JlZmVy ZW5jZSgiJXMiKTsgfVxuJyAlIG1lc3NhZ2UubmFtZSkKQEAgLTEzNiwxMyArMTMyLDEzIEBAIGRl ZiBtZXNzYWdlX3RvX3N0cnVjdF9kZWNsYXJhdGlvbihtZXNzYWdlKToKICAgICAgICAgcmVzdWx0 LmFwcGVuZCgnXG4gICAgICAgIDogbV9hcmd1bWVudHMoJXMpXG4nICUgJywgJy5qb2luKFt4WzFd IGZvciB4IGluIGZ1bmN0aW9uX3BhcmFtZXRlcnNdKSkKICAgICAgICAgcmVzdWx0LmFwcGVuZCgn ICAgIHtcbicpCiAgICAgICAgIHJlc3VsdC5hcHBlbmQoJyAgICB9XG5cbicpCi0gICAgcmVzdWx0 LmFwcGVuZCgnICAgIGNvbnN0ICVzJiBhcmd1bWVudHMoKSBjb25zdFxuJyAlIGFyZ3VtZW50c190 eXBlKG1lc3NhZ2UpKQorICAgIHJlc3VsdC5hcHBlbmQoJyAgICBjb25zdCBBcmd1bWVudHMmIGFy Z3VtZW50cygpIGNvbnN0XG4nKQogICAgIHJlc3VsdC5hcHBlbmQoJyAgICB7XG4nKQogICAgIHJl c3VsdC5hcHBlbmQoJyAgICAgICAgcmV0dXJuIG1fYXJndW1lbnRzO1xuJykKICAgICByZXN1bHQu YXBwZW5kKCcgICAgfVxuJykKICAgICByZXN1bHQuYXBwZW5kKCdcbicpCiAgICAgcmVzdWx0LmFw cGVuZCgncHJpdmF0ZTpcbicpCi0gICAgcmVzdWx0LmFwcGVuZCgnICAgICVzIG1fYXJndW1lbnRz O1xuJyAlIGFyZ3VtZW50c190eXBlKG1lc3NhZ2UpKQorICAgIHJlc3VsdC5hcHBlbmQoJyAgICBB cmd1bWVudHMgbV9hcmd1bWVudHM7XG4nKQogICAgIHJlc3VsdC5hcHBlbmQoJ307XG4nKQogICAg IHJldHVybiBzdXJyb3VuZF9pbl9jb25kaXRpb24oJycuam9pbihyZXN1bHQpLCBtZXNzYWdlLmNv bmRpdGlvbikKIAo=