161043 2016-08-22 06:03:08 -0700 [Win] Warning fix. 2016-08-23 00:15:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1221842 0 pvollan 2016-08-22 06:03:08 -0700 MSVC gives the following warning in PCToCodeOriginMap.cpp, line 55: warning C4333: '>>': right shift by too large amount, data loss 1221844 1 286594 pvollan 2016-08-22 06:12:05 -0700 Created attachment 286594 Patch 1221856 2 286594 bfulgham 2016-08-22 07:53:50 -0700 Comment on attachment 286594 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286594&action=review > Source/JavaScriptCore/PlatformWin.cmake:47 > +set_source_files_properties(jit/PCToCodeOriginMap.cpp PROPERTIES COMPILE_FLAGS /Wd"4333") This seems to break the JSC build: cl : Command line error D8021: invalid numeric argument '/Wd4333' 1221860 3 286597 pvollan 2016-08-22 08:27:54 -0700 Created attachment 286597 Patch 1221862 4 achristensen 2016-08-22 08:39:40 -0700 Wouldn't this be better done by a pragma? 1221870 5 286599 pvollan 2016-08-22 09:08:14 -0700 Created attachment 286599 Patch 1221871 6 pvollan 2016-08-22 09:09:53 -0700 (In reply to comment #4) > Wouldn't this be better done by a pragma? Thanks! Updated patch. 1221880 7 286599 mark.lam 2016-08-22 09:27:16 -0700 Comment on attachment 286599 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286599&action=review r=me > Source/JavaScriptCore/jit/PCToCodeOriginMap.cpp:37 > +#if COMPILER(MSVC) > +#pragma warning(disable: 4333) > +#endif It would be good to include https://msdn.microsoft.com/en-us/library/4wz07268.aspx in a comment here so that the reader can easily look up what the 4333 means in the future. 1222156 8 pvollan 2016-08-23 00:12:58 -0700 (In reply to comment #7) > Comment on attachment 286599 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286599&action=review > > r=me > > > Source/JavaScriptCore/jit/PCToCodeOriginMap.cpp:37 > > +#if COMPILER(MSVC) > > +#pragma warning(disable: 4333) > > +#endif > > It would be good to include > https://msdn.microsoft.com/en-us/library/4wz07268.aspx in a comment here so > that the reader can easily look up what the 4333 means in the future. Thanks for reviewing :) I will add the link. 1222157 9 pvollan 2016-08-23 00:15:31 -0700 Committed r204769: <http://trac.webkit.org/changeset/204769> 286594 2016-08-22 06:12:05 -0700 2016-08-22 08:27:48 -0700 Patch bug-161043-20160822061013.patch text/plain 1333 pvollan SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0NzA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE2LTA4LTIyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAg ICAgICBbV2luXSBXYXJuaW5nIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MTA0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIElnbm9yZSB3YXJuaW5nIGFib3V0IGJpdCBzaGlmdCBieSB0b28gbGFy Z2UgYW1vdW50LgorCisgICAgICAgICogUGxhdGZvcm1XaW4uY21ha2U6CisKIDIwMTYtMDgtMjEg IFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0RGR10g U2hvdWxkIG5vdCBmaXh1cCBBbnlJbnRVc2UgaW4gMzJfNjQKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9QbGF0Zm9ybVdpbi5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvUGxhdGZvcm1XaW4uY21ha2UJKHJldmlzaW9uIDIwNDU5MikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9QbGF0Zm9ybVdpbi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtNDIsMyArNDIs NiBAQCBmaWxlKFdSSVRFICIke0phdmFTY3JpcHRDb3JlX1BPU1RfQlVJTERfCiBmaWxlKEFQUEVO RCAiJHtKYXZhU2NyaXB0Q29yZV9QT1NUX0JVSUxEX0NPTU1BTkR9IiAiQHhjb3B5IC95IC9kIC9m IFwiJHtERVJJVkVEX1NPVVJDRVNfRElSfS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvKi5oXCIg XCIke0RFUklWRURfU09VUkNFU19ESVJ9L0ZvcndhcmRpbmdIZWFkZXJzL0phdmFTY3JpcHRDb3Jl XCIgPm51bCAyPm51bFxuIikKIAogc2V0KEphdmFTY3JpcHRDb3JlX09VVFBVVF9OQU1FIEphdmFT Y3JpcHRDb3JlJHtERUJVR19TVUZGSVh9KQorCisjIElnbm9yZSB3YXJuaW5nIEM0MzMzOiAnPj4n OiByaWdodCBzaGlmdCBieSB0b28gbGFyZ2UgYW1vdW50LCBkYXRhIGxvc3MKK3NldF9zb3VyY2Vf ZmlsZXNfcHJvcGVydGllcyhqaXQvUENUb0NvZGVPcmlnaW5NYXAuY3BwIFBST1BFUlRJRVMgQ09N UElMRV9GTEFHUyAvV2QiNDMzMyIpCg== 286597 2016-08-22 08:27:54 -0700 2016-08-22 09:08:08 -0700 Patch bug-161043-20160822082601.patch text/plain 1383 pvollan SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0NzE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE2LTA4LTIyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAg ICAgICBbV2luXSBXYXJuaW5nIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MTA0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIElnbm9yZSB3YXJuaW5nIGFib3V0IGJpdCBzaGlmdCBieSB0b28gbGFy Z2UgYW1vdW50LgorCisgICAgICAgICogUGxhdGZvcm1XaW4uY21ha2U6CisKIDIwMTYtMDgtMjIg IFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0VTNl0g TW9kdWxlIHNob3VsZCBub3QgYWxsb3cgSFRNTCBjb21tZW50cwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL1BsYXRmb3JtV2luLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9QbGF0Zm9ybVdpbi5jbWFrZQkocmV2aXNpb24gMjA0NTkyKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL1BsYXRmb3JtV2luLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC00MiwzICs0 Miw3IEBAIGZpbGUoV1JJVEUgIiR7SmF2YVNjcmlwdENvcmVfUE9TVF9CVUlMRF8KIGZpbGUoQVBQ RU5EICIke0phdmFTY3JpcHRDb3JlX1BPU1RfQlVJTERfQ09NTUFORH0iICJAeGNvcHkgL3kgL2Qg L2YgXCIke0RFUklWRURfU09VUkNFU19ESVJ9L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci8qLmhc IiBcIiR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vRm9yd2FyZGluZ0hlYWRlcnMvSmF2YVNjcmlwdENv cmVcIiA+bnVsIDI+bnVsXG4iKQogCiBzZXQoSmF2YVNjcmlwdENvcmVfT1VUUFVUX05BTUUgSmF2 YVNjcmlwdENvcmUke0RFQlVHX1NVRkZJWH0pCisKKyMgSWdub3JlIHdhcm5pbmcgQzQzMzM6ICc+ Pic6IHJpZ2h0IHNoaWZ0IGJ5IHRvbyBsYXJnZSBhbW91bnQsIGRhdGEgbG9zcworc2V0KERJU0FC TEVfV0FSTklORywgIi93ZFwiNDMzM1wiIikKK3NldF9zb3VyY2VfZmlsZXNfcHJvcGVydGllcyhq aXQvUENUb0NvZGVPcmlnaW5NYXAuY3BwIFBST1BFUlRJRVMgQ09NUElMRV9GTEFHUyAiJHtESVNB QkxFX1dBUk5JTkd9IikK 286599 2016-08-22 09:08:14 -0700 2016-08-22 09:27:16 -0700 Patch bug-161043-20160822090621.patch text/plain 1038 pvollan SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0NzE0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE2LTA4LTIyICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAg ICAgICBbV2luXSBXYXJuaW5nIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2MTA0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIElnbm9yZSB3YXJuaW5nIGFib3V0IGJpdCBzaGlmdCBieSB0b28gbGFy Z2UgYW1vdW50LgorCisgICAgICAgICogaml0L1BDVG9Db2RlT3JpZ2luTWFwLmNwcDoKKwogMjAx Ni0wOC0yMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAg ICBbRVM2XSBNb2R1bGUgc2hvdWxkIG5vdCBhbGxvdyBIVE1MIGNvbW1lbnRzCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L1BDVG9Db2RlT3JpZ2luTWFwLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1BDVG9Db2RlT3JpZ2luTWFwLmNwcAkocmV2aXNp b24gMjA0NTkyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9QQ1RvQ29kZU9yaWdpbk1h cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDEwIEBACiAjaW5jbHVkZSAiREZHTm9k ZS5oIgogI2luY2x1ZGUgIkxpbmtCdWZmZXIuaCIKIAorI2lmIENPTVBJTEVSKE1TVkMpCisjcHJh Z21hIHdhcm5pbmcoZGlzYWJsZTogNDMzMykKKyNlbmRpZgorCiBuYW1lc3BhY2UgSlNDIHsKIAog bmFtZXNwYWNlIHsK