16104 2007-11-23 14:14:09 -0800 [GTK] There is no way to retrieve the frame source 2009-04-19 01:18:50 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Other Linux RESOLVED DUPLICATE 24758 P2 Normal --- 0 christian webkit-unassigned jmalonzo oldest_to_newest 62116 0 christian 2007-11-23 14:14:09 -0800 There is no way to retrieve the source of a website as a string. 62117 1 17471 christian 2007-11-23 14:16:05 -0800 Created attachment 17471 Implement webkit_frame_get_string I went with _string instead of _markup because this has nothing to do with GMarkup. 62131 2 17471 alp 2007-11-23 18:14:39 -0800 Comment on attachment 17471 Implement webkit_frame_get_string We need to figure out what to do about string lifecycle first. There is no indication of how long the buffer will be valid here, if at all. Looks wrong to me. 62285 3 17508 christian 2007-11-25 08:54:53 -0800 Created attachment 17508 Implement webkit_frame_copy_source I changed the name to avoid some confusion. As _copy suggests the function now allocates a new string because we don't know how long the buffer is valid. And caching behind the scenes doesn't seem to be a good idea here. 62319 4 17508 alp 2007-11-25 14:43:01 -0800 Comment on attachment 17508 Implement webkit_frame_copy_source The trouble here is that the frame source may be in different formats, and copying is not great either. Not sure that returning a const gchar* is a good general way of representing this in a way that we can stick to in the long term. We should try to do something more like the ObjC API now that we're following it more closely. 62320 5 alp 2007-11-25 14:43:45 -0800 (In reply to comment #4) > (From update of attachment 17508 [edit]) > The trouble here is that the frame source may be in different formats, and > copying is not great either. Not sure that returning a const gchar* is a good > general way of representing this in a way that we can stick to in the long > term. s/const// 74615 6 jmalonzo 2008-03-21 01:31:13 -0700 Is the proposed patch here the same as webkit_web_frame_get_name? If so can we close this? 74619 7 christian 2008-03-21 05:50:17 -0700 (In reply to comment #6) > Is the proposed patch here the same as webkit_web_frame_get_name? If so can we > close this? Not at all. This is about the source code of the frame in text form. Maybe you confused bugs here? 118056 8 jmalonzo 2009-04-19 01:18:50 -0700 Bug #24758 implements a WebDataSource which we can use to get the source of a frame. Though, it also uses const gchar* to return the source, feedback would be appreciated on what is best to represent the source in that bug report. Thanks. *** This bug has been marked as a duplicate of 24758 *** 17471 2007-11-23 14:16:05 -0800 2007-11-25 08:54:53 -0800 Implement webkit_frame_get_string source.diff text/plain 1347 christian SW5kZXg6IFdlYktpdC9ndGsvQXBpL3dlYmtpdGd0a2ZyYW1lLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtmcmFtZS5jcHAJKFJldmlzaW9uIDI3OTg5KQorKysgV2Vi S2l0L2d0ay9BcGkvd2Via2l0Z3RrZnJhbWUuY3BwCShBcmJlaXRza29waWUpCkBAIC0zNSw2ICsz NSw3IEBACiAjaW5jbHVkZSAiRnJhbWVMb2FkZXJDbGllbnRHdGsuaCIKICNpbmNsdWRlICJGcmFt ZVZpZXcuaCIKICNpbmNsdWRlICJIVE1MRnJhbWVPd25lckVsZW1lbnQuaCIKKyNpbmNsdWRlICJD U3RyaW5nLmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC0xODcsNiArMTg4LDE2 IEBACiAgICAgcmV0dXJuIGZyYW1lRGF0YS0+cGFnZTsKIH0KIAorY29uc3QgZ2NoYXIqCit3ZWJr aXRfZnJhbWVfZ2V0X3N0cmluZyhXZWJLaXRGcmFtZSogZnJhbWUpCit7CisgICAgV2ViS2l0RnJh bWVQcml2YXRlKiBmcmFtZURhdGEgPSBXRUJLSVRfRlJBTUVfR0VUX1BSSVZBVEUoZnJhbWUpOwor ICAgIFdlYkNvcmU6OkRvY3VtZW50KiBkb2MgPSBmcmFtZURhdGEtPmZyYW1lLT5kb2N1bWVudCgp OworICAgIGlmIChkb2MpCisgICAgICAgIHJldHVybiBkb2MtPnRvU3RyaW5nKCkudXRmOCgpLmRh dGEoKTsKKyAgICByZXR1cm4gTlVMTDsKK30KKwogZ2NoYXIqIHdlYmtpdF9mcmFtZV9nZXRfdGl0 bGUoV2ViS2l0RnJhbWUqIGZyYW1lKQogewogICAgIFdlYktpdEZyYW1lUHJpdmF0ZSogZnJhbWVE YXRhID0gV0VCS0lUX0ZSQU1FX0dFVF9QUklWQVRFKGZyYW1lKTsKSW5kZXg6IFdlYktpdC9ndGsv QXBpL3dlYmtpdGd0a2ZyYW1lLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9BcGkvd2Via2l0 Z3RrZnJhbWUuaAkoUmV2aXNpb24gMjc5ODkpCisrKyBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtm cmFtZS5oCShBcmJlaXRza29waWUpCkBAIC03Miw4ICs3Miw4IEBACiBXRUJLSVRfQVBJIFdlYktp dFBhZ2UqCiB3ZWJraXRfZnJhbWVfZ2V0X3BhZ2UgKFdlYktpdEZyYW1lKiBmcmFtZSk7CiAKLVdF QktJVF9BUEkgZ2NoYXIqCi13ZWJraXRfZnJhbWVfZ2V0X21hcmt1cCAoV2ViS2l0RnJhbWUqIGZy YW1lKTsKK1dFQktJVF9BUEkgY29uc3QgZ2NoYXIqCit3ZWJraXRfZnJhbWVfZ2V0X3N0cmluZyAo V2ViS2l0RnJhbWUqIGZyYW1lKTsKIAogV0VCS0lUX0FQSSBnY2hhcioKIHdlYmtpdF9mcmFtZV9n ZXRfaW5uZXJfdGV4dCAoV2ViS2l0RnJhbWUqIGZyYW1lKTsK 17508 2007-11-25 08:54:53 -0800 2007-11-25 14:43:01 -0800 Implement webkit_frame_copy_source source.diff text/plain 1771 christian SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShSZXZpc2lvbiAyODAxNikKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCShBcmJlaXRz a29waWUpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMTEtMjUgIENocmlzdGlhbiBEeXdhbiAgPGNo cmlzdGlhbkB0d290b2FzdHMuZGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYx MDQKKyAgICAgICAgW0dUS10gVGhlcmUgaXMgbm8gd2F5IHRvIHJldHJpZXZlIHRoZSBmcmFtZSBz b3VyY2UKKworICAgICAgICBJbXBsZW1lbnQgd2Via2l0X2ZyYW1lX2NvcHlfc291cmNlKCkuCisK KyAgICAgICAgKiBBcGkvd2Via2l0Z3RrZnJhbWUuY3BwOgorICAgICAgICAqIEFwaS93ZWJraXRn dGtmcmFtZS5oOgorCiAyMDA3LTExLTI0ICBBbHAgVG9rZXIgIDxhbHBAYXRva2VyLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBXZWJLaXQvZ3RrL0FwaS93ZWJr aXRndGtmcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9BcGkvd2Via2l0Z3RrZnJh bWUuY3BwCShSZXZpc2lvbiAyODAxNikKKysrIFdlYktpdC9ndGsvQXBpL3dlYmtpdGd0a2ZyYW1l LmNwcAkoQXJiZWl0c2tvcGllKQpAQCAtMjEwLDYgKzIxMCwxNyBAQAogICAgIHJldHVybiBmcmFt ZURhdGEtPnRpdGxlOwogfQogCitnY2hhciogd2Via2l0X2ZyYW1lX2NvcHlfc291cmNlKFdlYktp dEZyYW1lKiBmcmFtZSkKK3sKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJLSVRfSVNfRlJB TUUoZnJhbWUpLCBOVUxMKTsKKworICAgIFdlYktpdEZyYW1lUHJpdmF0ZSogZnJhbWVEYXRhID0g V0VCS0lUX0ZSQU1FX0dFVF9QUklWQVRFKGZyYW1lKTsKKyAgICBXZWJDb3JlOjpEb2N1bWVudCog ZG9jID0gZnJhbWVEYXRhLT5mcmFtZS0+ZG9jdW1lbnQoKTsKKyAgICBpZiAoZG9jKQorICAgICAg ICByZXR1cm4gZ19zdHJkdXAoZG9jLT50b1N0cmluZygpLnV0ZjgoKS5kYXRhKCkpOworICAgIHJl dHVybiAwOworfQorCiBjb25zdCBnY2hhciogd2Via2l0X2ZyYW1lX2dldF9sb2NhdGlvbihXZWJL aXRGcmFtZSogZnJhbWUpCiB7CiAgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX0ZS QU1FKGZyYW1lKSwgTlVMTCk7CkluZGV4OiBXZWJLaXQvZ3RrL0FwaS93ZWJraXRndGtmcmFtZS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQXBpL3dlYmtpdGd0a2ZyYW1lLmgJKFJldmlzaW9u IDI4MDE2KQorKysgV2ViS2l0L2d0ay9BcGkvd2Via2l0Z3RrZnJhbWUuaAkoQXJiZWl0c2tvcGll KQpAQCAtNzcsNiArNzcsOSBAQAogV0VCS0lUX0FQSSBXZWJLaXRQYWdlKgogd2Via2l0X2ZyYW1l X2dldF9wYWdlIChXZWJLaXRGcmFtZSogZnJhbWUpOwogCitXRUJLSVRfQVBJIGdjaGFyKgord2Vi a2l0X2ZyYW1lX2NvcHlfc291cmNlIChXZWJLaXRGcmFtZSogZnJhbWUpOworCiBXRUJLSVRfQVBJ IGNvbnN0IGdjaGFyKgogd2Via2l0X2ZyYW1lX2dldF9uYW1lIChXZWJLaXRGcmFtZSogZnJhbWUp OwogCg==