161005 2016-08-19 12:05:49 -0700 Migrate RenderText::stringView() to unsigneds 2016-08-19 14:41:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue dino esprehn+autocc glenn jonlee kondapallykalyan simon.fraser thorton oldest_to_newest 1221418 0 mmaxfield 2016-08-19 12:05:49 -0700 Migrate RenderText::stringView() to unsigneds 1221419 1 286466 mmaxfield 2016-08-19 12:06:47 -0700 Created attachment 286466 Patch 1221473 2 286466 dino 2016-08-19 14:20:20 -0700 Comment on attachment 286466 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286466&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:886 > + ASSERT(run->m_stop != -1); Isn't this unsigned now in your other patch? 1221486 3 mmaxfield 2016-08-19 14:41:53 -0700 Committed r204653: <http://trac.webkit.org/changeset/204653> 286466 2016-08-19 12:06:47 -0700 2016-08-19 14:14:29 -0700 Patch bug-161005-20160819120455.patch text/plain 3900 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYyYTVmN2NiNDAxOTky YmRhMWM4NjgwMGIzMjhkMjU2OGU1ZjY4MC4uYWMxNTg2NWUxOGVkZDQyZDBjZTc2YjU2NzlkNjEw MDJiNmQxZGU5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA4LTE5ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgTWlncmF0ZSBS ZW5kZXJUZXh0OjpzdHJpbmdWaWV3KCkgdG8gdW5zaWduZWRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjEwMDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBp cyBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tM aW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6Y29tcHV0 ZUlubGluZURpcmVjdGlvblBvc2l0aW9uc0ZvclNlZ21lbnQpOgorICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJUZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHQ6OnN0cmluZ1Zp ZXcpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0Lmg6CisKIDIwMTYtMDgtMTkgIEVy aWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gZml4 IFBpUCBjb250ZXh0IG1lbnUgdHlwb3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKaW5kZXggMjZhODcxZWU3ZjE4Nzk5OGQwMmFiY2E3 YjIzZTU3MjU0ZTAzY2NiYy4uOGQxNDVmNWFmYjdkMmQzZDA2NzhjZWY4ZmMxZmZiYmEwOTA3MjY3 YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxh eW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxh eW91dC5jcHAKQEAgLTg4Myw2ICs4ODMsNyBAQCBCaWRpUnVuKiBSZW5kZXJCbG9ja0Zsb3c6OmNv bXB1dGVJbmxpbmVEaXJlY3Rpb25Qb3NpdGlvbnNGb3JTZWdtZW50KFJvb3RJbmxpbmVCbwogICAg ICAgICAgICAgICAgIEV4cGFuc2lvbkJlaGF2aW9yIGV4cGFuc2lvbkJlaGF2aW9yID0gZXhwYW5z aW9uQmVoYXZpb3JGb3JJbmxpbmVUZXh0Qm94KCp0aGlzLCB0ZXh0Qm94LCBwcmV2aW91c1J1biwg cnVuLT5uZXh0KCksIHRleHRBbGlnbiwgaXNBZnRlckV4cGFuc2lvbik7CiAgICAgICAgICAgICAg ICAgYXBwbHlFeHBhbnNpb25CZWhhdmlvcih0ZXh0Qm94LCBleHBhbnNpb25CZWhhdmlvcik7CiAg ICAgICAgICAgICAgICAgdW5zaWduZWQgb3Bwb3J0dW5pdGllc0luUnVuOworICAgICAgICAgICAg ICAgIEFTU0VSVChydW4tPm1fc3RvcCAhPSAtMSk7CiAgICAgICAgICAgICAgICAgc3RkOjp0aWUo b3Bwb3J0dW5pdGllc0luUnVuLCBpc0FmdGVyRXhwYW5zaW9uKSA9IEZvbnRDYXNjYWRlOjpleHBh bnNpb25PcHBvcnR1bml0eUNvdW50KHJlbmRlclRleHQuc3RyaW5nVmlldyhydW4tPm1fc3RhcnQs IHJ1bi0+bV9zdG9wKSwgcnVuLT5ib3goKS0+ZGlyZWN0aW9uKCksIGV4cGFuc2lvbkJlaGF2aW9y KTsKICAgICAgICAgICAgICAgICBleHBhbnNpb25PcHBvcnR1bml0aWVzLmFwcGVuZChvcHBvcnR1 bml0aWVzSW5SdW4pOwogICAgICAgICAgICAgICAgIGV4cGFuc2lvbk9wcG9ydHVuaXR5Q291bnQg Kz0gb3Bwb3J0dW5pdGllc0luUnVuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQu Y3BwCmluZGV4IGFiZWJmZjBiZGM5NTk5OTFhMDBjMGFkYjIwZjNlMGRhMTk4ZGU1NWMuLmIwMzdm ODJmNTdjNmJjYTZmNGQ4ZTJiYjYxYzViZTRiZWQ2ZTY0NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGV4dC5jcHAKQEAgLTE2NzYsMTggKzE2NzYsMTUgQEAgdm9pZCBSZW5kZXJU ZXh0Ojptb21lbnRhcmlseVJldmVhbExhc3RUeXBlZENoYXJhY3Rlcih1bnNpZ25lZCBvZmZzZXRB ZnRlckxhc3RUeXAKICAgICBzZWN1cmVUZXh0VGltZXItPnJlc3RhcnQob2Zmc2V0QWZ0ZXJMYXN0 VHlwZWRDaGFyYWN0ZXIpOwogfQogCi1TdHJpbmdWaWV3IFJlbmRlclRleHQ6OnN0cmluZ1ZpZXco aW50IHN0YXJ0LCBpbnQgc3RvcCkgY29uc3QKLXsKLSAgICBpZiAoc3RvcCA9PSAtMSkKLSAgICAg ICAgc3RvcCA9IHRleHRMZW5ndGgoKTsKLSAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8dW5zaWduZWQ+ KHN0YXJ0KSA8PSBsZW5ndGgoKSk7Ci0gICAgQVNTRVJUKHN0YXRpY19jYXN0PHVuc2lnbmVkPihz dG9wKSA8PSBsZW5ndGgoKSk7Ci0gICAgQVNTRVJUKHN0YXJ0IDw9IHN0b3ApOwotICAgIEFTU0VS VChzdGFydCA+PSAwKTsKLSAgICBBU1NFUlQoc3RvcCA+PSAwKTsKK1N0cmluZ1ZpZXcgUmVuZGVy VGV4dDo6c3RyaW5nVmlldyh1bnNpZ25lZCBzdGFydCwgT3B0aW9uYWw8dW5zaWduZWQ+IHN0b3Ap IGNvbnN0Cit7CisgICAgdW5zaWduZWQgZGVzdGluYXRpb24gPSBzdG9wLnZhbHVlT3IodGV4dExl bmd0aCgpKTsKKyAgICBBU1NFUlQoc3RhcnQgPD0gbGVuZ3RoKCkpOworICAgIEFTU0VSVChkZXN0 aW5hdGlvbiA8PSBsZW5ndGgoKSk7CisgICAgQVNTRVJUKHN0YXJ0IDw9IGRlc3RpbmF0aW9uKTsK ICAgICBpZiAoaXM4Qml0KCkpCi0gICAgICAgIHJldHVybiBTdHJpbmdWaWV3KGNoYXJhY3RlcnM4 KCkgKyBzdGFydCwgc3RvcCAtIHN0YXJ0KTsKLSAgICByZXR1cm4gU3RyaW5nVmlldyhjaGFyYWN0 ZXJzMTYoKSArIHN0YXJ0LCBzdG9wIC0gc3RhcnQpOworICAgICAgICByZXR1cm4gU3RyaW5nVmll dyhjaGFyYWN0ZXJzOCgpICsgc3RhcnQsIGRlc3RpbmF0aW9uIC0gc3RhcnQpOworICAgIHJldHVy biBTdHJpbmdWaWV3KGNoYXJhY3RlcnMxNigpICsgc3RhcnQsIGRlc3RpbmF0aW9uIC0gc3RhcnQp OwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRleHQuaAppbmRleCAxZmM4ZGMzOTlmYzM2MjAxZDdjZTU1ZTAyNjAzYjIyMmEwODZjOTI1Li5l YjAzMzBmZTE1Zjc3ZmM1NzI2Y2U4NGExYTYwYjQxYzRlMWJiNzZmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUZXh0LmgKQEAgLTE2Nyw3ICsxNjcsNyBAQCBwdWJsaWM6CiAgICAgdm9p ZCBkZWxldGVMaW5lQm94ZXNCZWZvcmVTaW1wbGVMaW5lTGF5b3V0KCk7CiAgICAgY29uc3QgU2lt cGxlTGluZUxheW91dDo6TGF5b3V0KiBzaW1wbGVMaW5lTGF5b3V0KCkgY29uc3Q7CiAKLSAgICBT dHJpbmdWaWV3IHN0cmluZ1ZpZXcoaW50IHN0YXJ0ID0gMCwgaW50IHN0b3AgPSAtMSkgY29uc3Q7 CisgICAgU3RyaW5nVmlldyBzdHJpbmdWaWV3KHVuc2lnbmVkIHN0YXJ0ID0gMCwgT3B0aW9uYWw8 dW5zaWduZWQ+IHN0b3AgPSBOdWxsb3B0KSBjb25zdDsKIAogICAgIExheW91dFVuaXQgdG9wT2ZG aXJzdFRleHQoKSBjb25zdDsKICAgICAK