160994 2016-08-19 02:02:29 -0700 [Win] Warning fix. 2016-08-19 10:12:42 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue lforschler oldest_to_newest 1221343 0 pvollan 2016-08-19 02:02:29 -0700 I believe the following warning can safely be ignored: C:\Projects\WebKit\OpenSource\Source\JavaScriptCore\runtime\JSCell.cpp(276): warning C4646: function declared with '__declspec(noreturn)' or '[[noreturn]]' has non-void return type 1221344 1 286444 pvollan 2016-08-19 02:36:09 -0700 Created attachment 286444 Patch 1221376 2 pvollan 2016-08-19 09:23:33 -0700 Thanks for reviewing! 1221384 3 286444 commit-queue 2016-08-19 10:12:38 -0700 Comment on attachment 286444 Patch Clearing flags on attachment: 286444 Committed r204635: <http://trac.webkit.org/changeset/204635> 1221385 4 commit-queue 2016-08-19 10:12:42 -0700 All reviewed patches have been landed. Closing bug. 286444 2016-08-19 02:36:09 -0700 2016-08-19 10:12:38 -0700 Patch bug-160994-20160819023419.patch text/plain 1530 pvollan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDYy OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA4 LTE5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2lu XSBXYXJuaW5nIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MDk5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIElnbm9yZSB3YXJuaW5nIHdoZW4gZnVuY3Rpb24gZGVjbGFyZWQgd2l0aCBfX2RlY2xz cGVjKG5vcmV0dXJuKSBoYXMgbm9uIHZvaWQgcmV0dXJuIHR5cGUuCisKKyAgICAgICAgKiBTb3Vy Y2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZToKKwogMjAxNi0wOC0xNyAgRG9uIE9sbXN0ZWFkICA8 ZG9uLm9sbXN0ZWFkQGFtLnNvbnkuY29tPgogCiAgICAgICAgIFVzZSBmaW5kX2xpYnJhcnkgd2l0 aGluIFdpbmRvd3MgYnVpbGQKSW5kZXg6IFNvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCShyZXZpc2lvbiAyMDQ1 OTIpCisrKyBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAt MTI0LDkgKzEyNCw5IEBAIGlmIChNU1ZDKQogICAgICAgICAvd2Q0MDE4IC93ZDQwNjggL3dkNDA5 OSAvd2Q0MTAwIC93ZDQxMjcgL3dkNDEzOCAvd2Q0MTQ2IC93ZDQxODAgL3dkNDE4OQogICAgICAg ICAvd2Q0MjAxIC93ZDQyNDQgL3dkNDI1MSAvd2Q0MjY3IC93ZDQyNzUgL3dkNDI4OCAvd2Q0Mjkx IC93ZDQzMDUgL3dkNDMwOQogICAgICAgICAvd2Q0MzQ0IC93ZDQzNTUgL3dkNDM4OSAvd2Q0Mzk2 IC93ZDQ0NTYgL3dkNDQ1NyAvd2Q0NDU4IC93ZDQ0NTkgL3dkNDQ4MQotICAgICAgICAvd2Q0NTAz IC93ZDQ1MDUgL3dkNDUxMCAvd2Q0NTEyIC93ZDQ1MzAgL3dkNDYxMCAvd2Q0NjExIC93ZDQ3MDIg L3dkNDcwNgotICAgICAgICAvd2Q0ODAwIC93ZDQ4MTkgL3dkNDk1MSAvd2Q0OTUyIC93ZDQ5OTYg L3dkNjAxMSAvd2Q2MDMxIC93ZDYyMTEgL3dkNjI0NgotICAgICAgICAvd2Q2MjU1IC93ZDYzODcK KyAgICAgICAgL3dkNDUwMyAvd2Q0NTA1IC93ZDQ1MTAgL3dkNDUxMiAvd2Q0NTMwIC93ZDQ2MTAg L3dkNDYxMSAvd2Q0NjQ2IC93ZDQ3MDIKKyAgICAgICAgL3dkNDcwNiAvd2Q0ODAwIC93ZDQ4MTkg L3dkNDk1MSAvd2Q0OTUyIC93ZDQ5OTYgL3dkNjAxMSAvd2Q2MDMxIC93ZDYyMTEKKyAgICAgICAg L3dkNjI0NiAvd2Q2MjU1IC93ZDYzODcKICAgICApCiAKICAgICAjIENyZWF0ZSBwZGIgZmlsZXMg Zm9yIGRlYnVnZ2luZyBwdXJwb3NlcywgYWxzbyBmb3IgUmVsZWFzZSBidWlsZHMK