160976 2016-08-18 14:45:03 -0700 ScopedArguments is using the wrong owner object for a write barrier. 2016-08-18 15:57:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin commit-queue fpizlo ggaren jfbastien keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1221198 0 mark.lam 2016-08-18 14:45:03 -0700 Will fix. 1221200 1 mark.lam 2016-08-18 14:47:23 -0700 <rdar://problem/27328506> 1221201 2 286401 mark.lam 2016-08-18 14:52:28 -0700 Created attachment 286401 proposed patch. 1221204 3 286401 keith_miller 2016-08-18 15:05:56 -0700 Comment on attachment 286401 proposed patch. r=me. 1221213 4 286401 mark.lam 2016-08-18 15:24:12 -0700 Comment on attachment 286401 proposed patch. Cancelling commit for now while I investigate an issue. 1221229 5 286401 mark.lam 2016-08-18 15:54:44 -0700 Comment on attachment 286401 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286401&action=review > JSTests/stress/scoped-arguments-write-barrier-should-be-on-scope-object.js:1 > +//@ runDefault. Turns out that the test harness doesn't like the period at the end of this line. I will remove it locally and I land this patch manually. 1221231 6 mark.lam 2016-08-18 15:57:20 -0700 Landed in r204612: <http://trac.webkit.org/r204612>. 286401 2016-08-18 14:52:28 -0700 2016-08-18 15:24:12 -0700 proposed patch. bug-160976.patch text/plain 3465 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDQ2MTApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTA4LTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBTY29wZWRBcmd1bWVudHMgaXMgdXNpbmcgdGhlIHdyb25nIG93bmVyIG9i amVjdCBmb3IgYSB3cml0ZSBiYXJyaWVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYwOTc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzMyODUw Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0 cmVzcy9zY29wZWQtYXJndW1lbnRzLXdyaXRlLWJhcnJpZXItc2hvdWxkLWJlLW9uLXNjb3BlLW9i amVjdC5qczogQWRkZWQuCisKIDIwMTYtMDgtMTcgIEpGIEJhc3RpZW4gIDxqZmJhc3RpZW5AYXBw bGUuY29tPgogCiAgICAgICAgIFdlIGFsbG93IGFzc2lnbm1lbnRzIHRvIGNvbnN0IHZhcmlhYmxl cyB3aGVuIGluIGEgZm9yLWluL2Zvci1vZiBsb29wCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9zY29w ZWQtYXJndW1lbnRzLXdyaXRlLWJhcnJpZXItc2hvdWxkLWJlLW9uLXNjb3BlLW9iamVjdC5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9zY29wZWQtYXJndW1lbnRzLXdyaXRlLWJhcnJp ZXItc2hvdWxkLWJlLW9uLXNjb3BlLW9iamVjdC5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3Rz L3N0cmVzcy9zY29wZWQtYXJndW1lbnRzLXdyaXRlLWJhcnJpZXItc2hvdWxkLWJlLW9uLXNjb3Bl LW9iamVjdC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDM1IEBACisvL0AgcnVuRGVmYXVs dC4KKy8vIFRoaXMgdGVzdCBzaG91bGQgbm90IGNyYXNoLgorCit2YXIgYXJyID0gW107CitsZXQg bnVtYmVyT2ZJdGVyYXRpb25zID0gMTAwMDsKKworZnVuY3Rpb24gY2FwdHVyZVNjb3BlZEFyZ3Vt ZW50cyhpKSB7CisgICAgdHJ5IHsKKyAgICAgICAgZXZhbCgiYXJyWyIgKyBpICsgIl0gPSBhcmd1 bWVudHMiKTsKKyAgICB9IGNhdGNoKGUpIHsKKyAgICB9Cit9CisKK2Z1bmN0aW9uIGFkZFBvaW50 ZXJzVG9FZGVuR2VuT2JqZWN0cyhpKSB7CisgICAgQXJyYXkucHJvdG90eXBlLnB1c2guY2FsbChh cnJbaV0sIFssLF0pOworCisgICAgdHJ5IHsKKyAgICAgICAgQXJyYXkucHJvdG90eXBlLnJldmVy c2UuY2FsbChhcnJbaV0pCisgICAgfSBjYXRjaCAoZSkgeworICAgIH0KK30KKworZm9yICh2YXIg aSA9IDA7IGkgPCBudW1iZXJPZkl0ZXJhdGlvbnM7IGkrKykgeworICAgIGNhcHR1cmVTY29wZWRB cmd1bWVudHMoaSk7Cit9CisKK2djKCk7IC8vIFByb21vdGUgdGhvc2UgU2NvcGVBcmd1bWVudHMg dG8gdGhlIG9sZCBnZW5lcmF0aW9uLgorCitmb3IgKHZhciBpID0gMDsgaSA8IG51bWJlck9mSXRl cmF0aW9uczsgaSsrKSB7CisgICAgYWRkUG9pbnRlcnNUb0VkZW5HZW5PYmplY3RzKGkpOworfQor CitlZGVuR0MoKTsgLy8gRG8gZWRlbiBHQyB0byBzY2FuIHRoZSByZW1lbWJlcmVkIHNldCB3aGlj aCBzaG91bGQgaW5jbHVkZSB0aGUgU2NvcGVkQXJndW1lbnRzLgorCitnYygpOyAvLyBTY2FuIHRo ZSBTY29wZWRBcmd1bWVudHMgYWdhaW4uIFRoZXkgYmV0dGVyIG5vdCBwb2ludCB0byBjb2xsZWN0 ZWQgb2JqZWN0cy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0NjA4 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE0IEBACisyMDE2LTA4LTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K KworICAgICAgICBTY29wZWRBcmd1bWVudHMgaXMgdXNpbmcgdGhlIHdyb25nIG93bmVyIG9iamVj dCBmb3IgYSB3cml0ZSBiYXJyaWVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYwOTc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzMyODUwNj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRp bWUvU2NvcGVkQXJndW1lbnRzLmg6CisgICAgICAgIChKU0M6OlNjb3BlZEFyZ3VtZW50czo6c2V0 SW5kZXhRdWlja2x5KToKKwogMjAxNi0wOC0xOCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkIExMSU5UIHByb2JlKCkgbWFjcm8gZm9yIFg4Nl82NC4KSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Njb3BlZEFyZ3VtZW50cy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Njb3BlZEFyZ3VtZW50cy5oCShy ZXZpc2lvbiAyMDQ2MDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TY29wZWRB cmd1bWVudHMuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmln aHQgKEMpIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0 IChDKSAyMDE1LTIwMTYgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhl IGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xMDAsNyArMTAwLDcgQEAgcHVibGljOgogICAgICAg ICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihjYW5BY2Nlc3NJbmRleFF1aWNrbHko aSkpOwogICAgICAgICB1bnNpZ25lZCBuYW1lZExlbmd0aCA9IG1fdGFibGUtPmxlbmd0aCgpOwog ICAgICAgICBpZiAoaSA8IG5hbWVkTGVuZ3RoKQotICAgICAgICAgICAgbV9zY29wZS0+dmFyaWFi bGVBdChtX3RhYmxlLT5nZXQoaSkpLnNldCh2bSwgdGhpcywgdmFsdWUpOworICAgICAgICAgICAg bV9zY29wZS0+dmFyaWFibGVBdChtX3RhYmxlLT5nZXQoaSkpLnNldCh2bSwgbV9zY29wZS5nZXQo KSwgdmFsdWUpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBvdmVyZmxvd1N0b3JhZ2UoKVtp IC0gbmFtZWRMZW5ndGhdLnNldCh2bSwgdGhpcywgdmFsdWUpOwogICAgIH0K