160968 2016-08-18 12:06:13 -0700 Add LLINT probe() macro for X86_64. 2016-08-18 13:27:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1221143 0 mark.lam 2016-08-18 12:06:13 -0700 Patch coming. 1221147 1 286384 mark.lam 2016-08-18 12:09:42 -0700 Created attachment 286384 proposed patch. 1221161 2 286384 ggaren 2016-08-18 12:55:52 -0700 Comment on attachment 286384 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286384&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:466 > + push a0, a1 > + push a2, a3 > + push t0, t1 > + push t2, t3 > + push t4, t5 This looks unaligned. Please fix. 1221167 3 286384 mark.lam 2016-08-18 13:10:20 -0700 Comment on attachment 286384 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286384&action=review Thanks for the review. Will land shortly. >> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:466 >> + push t4, t5 > > This looks unaligned. Please fix. These are pushing 5 pairs of registers. Since the alignment requirement is 16 bytes (i.e. the size of 2 registers), the required alignment is preserved. 1221168 4 mark.lam 2016-08-18 13:27:53 -0700 Landed in r204607: <http://trac.webkit.org/r204607>. 286384 2016-08-18 12:09:42 -0700 2016-08-18 12:55:52 -0700 proposed patch. bug-160968.patch text/plain 2292 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0NjAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE2LTA4LTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgTExJTlQgcHJvYmUoKSBtYWNybyBmb3IgWDg2XzY0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwOTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFz bToKKwogMjAxNi0wOC0xOCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3ZlIHVudXNlZCBTbG90VmlzaXRvcjo6YXBwZW5kKCkgdmFyaWFudC4KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5h c20JKHJldmlzaW9uIDIwNDU5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dM ZXZlbEludGVycHJldGVyLmFzbQkod29ya2luZyBjb3B5KQpAQCAtNDM3LDYgKzQzNyw0NSBAQCBt YWNybyBhc3NlcnQoYXNzZXJ0aW9uKQogICAgIGVuZAogZW5kCiAKKyMgVGhlIHByb2JlIG1hY3Jv IGNhbiBiZSB1c2VkIHRvIGluc2VydCBzb21lIGRlYnVnZ2luZyBjb2RlIHdpdGhvdXQgcGVydHVy YmluZyBzY2FsYXIKKyMgcmVnaXN0ZXJzLiBQcmVzZW50bHksIHRoZSBwcm9iZSBtYWNybyBvbmx5 IHByZXNlcnZlcyBzY2FsYXIgcmVnaXN0ZXJzLiBIZW5jZSwgdGhlCisjIEMgcHJvYmUgY2FsbGJh Y2sgZnVuY3Rpb24gc2hvdWxkIG5vdCB0cmFzaCBmbG9hdGluZyBwb2ludCByZWdpc3RlcnMuCisj CisjIFRoZSBtYWNybyB5b3UgcGFzcyB0byBwcm9iZSgpIGNhbiBwYXNzIHdoYXRldmVyIHJlZ2lz dGVycyB5b3UgbGlrZSB0byB5b3VyIHByb2JlCisjIGNhbGxiYWNrIGZ1bmN0aW9uLiBIb3dldmVy LCB5b3UgbmVlZCB0byBiZSBtaW5kZnVsIG9mIHdoaWNoIG9mIHRoZSByZWdpc3RlcnMgYXJlCisj IGFsc28gdXNlZCBhcyBhcmd1bWVudCByZWdpc3RlcnMsIGFuZCBlbnN1cmUgdGhhdCB5b3UgZG9u J3QgdHJhc2ggdGhlIHJlZ2lzdGVyIHZhbHVlCisjIGJlZm9yZSBzdG9yaW5nIGl0IGluIHRoZSBw cm9iZSBjYWxsYmFjayBhcmd1bWVudCByZWdpc3RlciB0aGF0IHlvdSBkZXNpcmUuCisjCisjIEhl cmUncyBhbiBleGFtcGxlIG9mIGhvdyBpdCdzIHVzZWQ6CisjCisjICAgICBwcm9iZSgKKyMgICAg ICAgICBtYWNybygpCisjICAgICAgICAgICAgIG1vdmUgY2ZyLCBhMCAjIHBhc3MgdGhlIEV4ZWNT dGF0ZSogYXMgYXJnMC4KKyMgICAgICAgICAgICAgbW92ZSB0MCwgYTEgIyBwYXNzIHRoZSB2YWx1 ZSBvZiByZWdpc3RlciB0MCBhcyBhcmcxLgorIyAgICAgICAgICAgICBjYWxsIF9jUHJvYmVDYWxs YmFja0Z1bmN0aW9uICMgdG8gZG8gd2hhdGV2ZXIgeW91IHdhbnQuCisjICAgICAgICAgZW5kCisj ICAgICApCisjCitpZiBYODZfNjQKKyAgICBtYWNybyBwcm9iZShhY3Rpb24pCisgICAgICAgICMg c2F2ZSBhbGwgdGhlIHJlZ2lzdGVycyB0aGF0IHRoZSBMTEludCBtYXkgdXNlLgorICAgICAgICBw dXNoIGEwLCBhMQorICAgICAgICBwdXNoIGEyLCBhMworICAgICAgICBwdXNoIHQwLCB0MQorICAg ICAgICBwdXNoIHQyLCB0MworICAgICAgICBwdXNoIHQ0LCB0NQorCisgICAgICAgIGFjdGlvbigp CisKKyAgICAgICAgIyByZXN0b3JlIGFsbCB0aGUgcmVnaXN0ZXJzIHdlIHNhdmVkIHByZXZpb3Vz bHkuCisgICAgICAgIHBvcCB0NSwgdDQKKyAgICAgICAgcG9wIHQzLCB0MgorICAgICAgICBwb3Ag dDEsIHQwCisgICAgICAgIHBvcCBhMywgYTIKKyAgICAgICAgcG9wIGExLCBhMAorICAgIGVuZAor ZW5kCisKIG1hY3JvIGNoZWNrU3RhY2tQb2ludGVyQWxpZ25tZW50KHRlbXBSZWcsIGxvY2F0aW9u KQogICAgIGlmIEFSTTY0IG9yIENfTE9PUCBvciBTSDQKICAgICAgICAgIyBBUk02NCB3aWxsIGNo ZWNrIGZvciB1cyEK