160935 2016-08-16 21:42:42 -0700 [iOS WK2] Don't throw touchMove events on the floor 2016-08-17 11:53:10 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser benjamin commit-queue simon.fraser thorton oldest_to_newest 1220775 0 simon.fraser 2016-08-16 21:42:42 -0700 [iOS WK2] Don't throw touchMove events on the floor 1220779 1 286273 simon.fraser 2016-08-16 21:46:18 -0700 Created attachment 286273 Patch 1220786 2 286273 commit-queue 2016-08-16 22:50:07 -0700 Comment on attachment 286273 Patch Clearing flags on attachment: 286273 Committed r204554: <http://trac.webkit.org/changeset/204554> 1220787 3 commit-queue 2016-08-16 22:50:12 -0700 All reviewed patches have been landed. Closing bug. 1220909 4 benjamin 2016-08-17 11:53:10 -0700 Wouldn't it make more sense to fix SliderThumbElement to update its last position based on the changedTouch on touchEnd? Outside testing, you can't guarantee the position of TouchMove and TouchEnd are the same. 286273 2016-08-16 21:46:18 -0700 2016-08-16 22:50:07 -0700 Patch bug-160935-20160816214431.patch text/plain 5647 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWZkYTA1YzE3ZWQ3OWZh MzJmYzA5NTliZTkxYmVmOThlNjliNGFiYy4uNGQwZDIwNDBlZTlkYjdlNzM2ODNlMDcxNzhjYzVm NTc3ZDEwMjU4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE2LTA4LTE2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFtpT1MgV0syXSBE b24ndCB0aHJvdyB0b3VjaE1vdmUgZXZlbnRzIG9uIHRoZSBmbG9vcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwOTM1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBFdmVudERpc3BhdGNoZXIg Y2xhaW1lZCB0byBjb2FsZXNjZSB0b3VjaE1vdmUgZXZlbnRzLCBidXQgYWN0dWFsbHkgdGhyZXcg YXdheSBhbnkKKyAgICAgICAgdG91Y2hNb3ZlIGlmIHRoZXJlIHdhcyBvbmUgaW4gdGhlIHF1ZXVl IHdoZW4gdGhlIG5leHQgbm9uLW1vdmUgZXZlbnQgY2FtZSBhbG9uZy4KKyAgICAgICAgCisgICAg ICAgIEZpeCB0byBzdHJpY3RseSBjb2FsZXNjZSB0b3VjaE1vdmUgZXZlbnRzLCBzbyBhIHN0YXJ0 L21vdmUvZW5kIHN0cmVhbSBhbHdheXMgZmlyZXMKKyAgICAgICAgYSBtb3ZlIGV2ZW50LiBUaGlz IGlzIG5lY2Vzc2FyeSBmb3IgbW92ZS1iYXNlZCBpbnRlcmFjdGlvbiB0byB3b3JrIGluIHRlc3Rp bmcsCisgICAgICAgIGZvciBleGFtcGxlIHRoZSBhZGRlZCByYW5nZSBzbGlkZXIgdGVzdC4KKyAg ICAgICAgCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvaW9zL2RyYWctcmFuZ2UtdGh1bWIuaHRt bAorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0V2ZW50RGlzcGF0Y2hlci5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OkV2ZW50RGlzcGF0Y2hlcjo6dG91Y2hFdmVudCk6CisKKzIwMTYtMDgt MTYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgW2lP UyBXSzJdIENsZWFuIHVwIGZvcm0gc2VsZWN0IGNvZGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDkxNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRXZlbnREaXNwYXRjaGVyLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3BwCmluZGV4IDQ0OTI5ZDFl Y2YyOWNhMmE2NzU5NjFlMTFhODJkODRkYWE2NWZiODYuLjVjOTM1MmFkMTdjZmExNjc2ZDhjYjAx OTg5MGUxOTczMGViNWY1NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3BwCkBAIC0xODAsOCArMTgwLDcgQEAgdm9pZCBF dmVudERpc3BhdGNoZXI6OnRvdWNoRXZlbnQodWludDY0X3QgcGFnZUlELCBjb25zdCBXZWJLaXQ6 OldlYlRvdWNoRXZlbnQmIHQKICAgICAgICAgICAgIGNvbnN0IFdlYlRvdWNoRXZlbnQmIGxhc3RU b3VjaEV2ZW50ID0gcXVldWVkRXZlbnRzLmxhc3QoKTsKIAogICAgICAgICAgICAgLy8gQ29hbGVz Y2UgdG91Y2ggbW92ZSBldmVudHMuCi0gICAgICAgICAgICBXZWJFdmVudDo6VHlwZSB0eXBlID0g bGFzdFRvdWNoRXZlbnQudHlwZSgpOwotICAgICAgICAgICAgaWYgKHR5cGUgPT0gV2ViRXZlbnQ6 OlRvdWNoTW92ZSkKKyAgICAgICAgICAgIGlmICh0b3VjaEV2ZW50LnR5cGUoKSA9PSBXZWJFdmVu dDo6VG91Y2hNb3ZlICYmIGxhc3RUb3VjaEV2ZW50LnR5cGUoKSA9PSBXZWJFdmVudDo6VG91Y2hN b3ZlKQogICAgICAgICAgICAgICAgIHF1ZXVlZEV2ZW50cy5sYXN0KCkgPSB0b3VjaEV2ZW50Owog ICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHF1ZXVlZEV2ZW50cy5hcHBlbmQodG91 Y2hFdmVudCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNTNjMmI2YzAyYTI3ZDYwMTY0NzQzYmFjNGRjZTI3MmJmY2E0NjI1 Yi4uMDRiODM1NDBkNGYyMTMwOTM0NGE4ZmVmN2JkNmUxODJlNTEzYjQ5OCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA4LTE2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgorCisgICAgICAgIFtpT1MgV0syXSBEb24ndCB0aHJvdyB0b3VjaE1vdmUgZXZlbnRzIG9u IHRoZSBmbG9vcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTYwOTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IAorICAgICAgICBUZXN0IGZvciByYW5nZSBzbGlkZXIgaW50ZXJhY3Rpb24gd2l0aCBzeW50aGVz aXplZCB0b3VjaCBldmVudHMuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL2lvcy9kcmFnLXJhbmdl LXRodW1iLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9pb3MvZHJh Zy1yYW5nZS10aHVtYi5odG1sOiBBZGRlZC4KKwogMjAxNi0wOC0xNiAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFsaWduIGlzRGVmYXVsdE5hbWVzcGFjZSgpIC8g bG9va3VwUHJlZml4KCkgLyBsb29rdXBOYW1lc3BhY2VVUkkoKSB3aXRoIHRoZSBzcGVjaWZpY2F0 aW9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lvcy9kcmFnLXJhbmdlLXRo dW1iLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2RyYWctcmFuZ2Ut dGh1bWItZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjFjOWQyNTNmYWFhMTY0ZjYwMmI1YTA5ODFh YzIwNzdiZWUwNzkyNTUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2lvcy9kcmFnLXJhbmdlLXRodW1iLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK1Rlc3Rz IHRoYXQgYSBiYXNpYyByYW5nZSBzbGlkZXIgd29ya3MKKworCitTdWNjZXNzZnVsbHkgaGFuZGxl ZCBvbmlucHV0LCB2YWx1ZSBpcyBub3cgIjQ1NiIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvaW9zL2RyYWctcmFuZ2UtdGh1bWIuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvaW9zL2RyYWctcmFuZ2UtdGh1bWIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kZDVjOTg0NDc1NTM3NmRj OTU3MzBmNTBkZmE1ZGI0MjkwZDc1NTJmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9pb3MvZHJhZy1yYW5nZS10aHVtYi5odG1sCkBAIC0wLDAgKzEsNzEgQEAKKzwh RE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIHVzZUZsZXhpYmxlVmlld3Bv cnQ9dHJ1ZSBdIC0tPgorCis8aHRtbD4KKzxoZWFkPgorICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0 IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgiPgorICAgIDxzdHlsZT4KKyAgICAgICAgaW5w dXRbdHlwZT0icmFuZ2UiXSB7CisgICAgICAgICAgICB3aWR0aDogMzAwcHg7CisgICAgICAgIH0K KyAgICA8L3N0eWxlPgorICAgIAorICAgIDxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvem9vbWluZy10 ZXN0LXV0aWxzLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgIGlmICh3aW5kb3cudGVz dFJ1bm5lcikgeworICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgdGVz dFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAgdmFyIHVpU2NyaXB0SGFzQ29t cGxldGVkID0gZmFsc2U7CisgICAgdmFyIG9uaW5wdXRIYXNCZWVuSGFuZGxlZCA9IGZhbHNlOwor CisgICAgZnVuY3Rpb24gZ2V0VUlTY3JpcHQoc3RhcnRYLCBzdGFydFksIGVuZFgsIGVuZFksIGR1 cmF0aW9uKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGAKKyAgICAgICAgICAgIChmdW5jdGlvbigp IHsKKyAgICAgICAgICAgICAgICB1aUNvbnRyb2xsZXIuZHJhZ0Zyb21Qb2ludFRvUG9pbnQoJHtz dGFydFh9LCAke3N0YXJ0WX0sICR7ZW5kWH0sICR7ZW5kWX0sICR7ZHVyYXRpb259LCBmdW5jdGlv bigpIHsKKyAgICAgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLnVpU2NyaXB0Q29tcGxldGUo KTsKKyAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIH0pKCk7YAorICAgIH0KKworICAg IGZ1bmN0aW9uIGNoZWNrRG9uZSgpCisgICAgeworICAgICAgICBpZiAob25pbnB1dEhhc0JlZW5I YW5kbGVkICYmIHVpU2NyaXB0SGFzQ29tcGxldGVkKQorICAgICAgICAgICAgdGVzdFJ1bm5lci5u b3RpZnlEb25lKCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gaGFuZGxlVmFsdWVDaGFuZ2VkKHZh bHVlKQorICAgIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS50 ZXh0Q29udGVudCA9ICJTdWNjZXNzZnVsbHkgaGFuZGxlZCBvbmlucHV0LCB2YWx1ZSBpcyBub3cg XCIiICsgdmFsdWUudG9Mb3dlckNhc2UoKSArICJcIiI7CisgICAgICAgIG9uaW5wdXRIYXNCZWVu SGFuZGxlZCA9IHRydWU7CisgICAgICAgIGNoZWNrRG9uZSgpOworICAgIH0KKyAgICAKKyAgICBm dW5jdGlvbiBkb1Rlc3QoKQorICAgIHsKKyAgICAgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lciB8 fCAhdGVzdFJ1bm5lci5ydW5VSVNjcmlwdCkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAg ICB2YXIgdGFyZ2V0RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCdpbnB1 dCcpWzBdOworICAgICAgICB2YXIgcG9pbnQgPSBnZXRQb2ludEluc2lkZUVsZW1lbnQodGFyZ2V0 RWxlbWVudCwgMTAsIDEwKTsKKworICAgICAgICB0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KGdldFVJ U2NyaXB0KHBvaW50LngsIHBvaW50LnksIHBvaW50LnggKyAyMDAsIHBvaW50LnksIDAuMDUpLCBm dW5jdGlvbigpIHsKKyAgICAgICAgICAgIHVpU2NyaXB0SGFzQ29tcGxldGVkID0gdHJ1ZTsKKyAg ICAgICAgICAgIGNoZWNrRG9uZSgpOworICAgICAgICB9KTsKKyAgICB9CisKKyAgICB3aW5kb3cu YWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGRvVGVzdCwgZmFsc2UpOworICAgIDwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+CisKKzxwPlRlc3RzIHRoYXQgYSBiYXNpYyByYW5nZSBzbGlkZXIgd29y a3M8L3A+CisKKzxpbnB1dCB0eXBlPSJyYW5nZSIgbWluPSIxMDAiIG1heD0iNjAwIiB2YWx1ZT0i MTAwIiBvbmlucHV0PSJoYW5kbGVWYWx1ZUNoYW5nZWQodGhpcy52YWx1ZSkiPgorCis8ZGl2IGlk PSJjb25zb2xlIj5GYWlsZWQgdG8gaGFuZGxlIG9uaW5wdXQ8ZGl2PgorCis8L2JvZHk+Cis8L2h0 bWw+Cg==