160920 2016-08-16 16:51:42 -0700 Web Inspector: Network Tab should not layout if not visible 2016-08-17 16:03:48 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1220654 0 joepeck 2016-08-16 16:51:42 -0700 Summary: Network Tab should not layout if not visible Debugging a page doing lots and lots of XHRs, the Network tab / NetworkDataGrid is constantly doing layouts, but it isn't even visible. 1220655 1 webkit-bug-importer 2016-08-16 16:52:11 -0700 <rdar://problem/27876629> 1220966 2 286331 mattbaker 2016-08-17 14:49:51 -0700 Created attachment 286331 [Patch] Proposed Fix 1220981 3 286331 commit-queue 2016-08-17 16:03:44 -0700 Comment on attachment 286331 [Patch] Proposed Fix Clearing flags on attachment: 286331 Committed r204579: <http://trac.webkit.org/changeset/204579> 1220982 4 commit-queue 2016-08-17 16:03:48 -0700 All reviewed patches have been landed. Closing bug. 286331 2016-08-17 14:49:51 -0700 2016-08-17 16:03:44 -0700 [Patch] Proposed Fix bug-160920-20160817144802.patch text/plain 3505 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 OGIxMjg2Yzg1MmE0M2Q5MTc2ZTliY2FmYjdlYzIwMTIzZGNjODNjLi4yY2I2ZGQ5NzI1YWQ4ODQ1 MWQyNjhhM2UxMmEzMzljYzlhNWNmNTczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0wOC0xNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTmV0d29yayBUYWIgc2hvdWxkIG5vdCBsYXlvdXQg aWYgbm90IHZpc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MDkyMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjc4NzY2Mjk+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWQgdXBkYXRpbmcg dGhlIGN1cnJlbnQgdGltZSB3aGVuIHRoZSBOZXR3b3JrIHRhYiBpcyBoaWRkZW4uCisgICAgICAg IFRoZSB0aW1lciwgYW5kIGFueSBkZWJvdW5jZWQgdGltZXIgY2FuY2VsbGF0aW9ucywgbmVlZCB0 byBiZSBzdG9wcGVkCisgICAgICAgIGFzIHNvb24gYXMgdGhlIHZpZXcgaXMgaGlkZGVuLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrR3JpZENvbnRlbnRWaWV3LmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtHcmlkQ29udGVudFZpZXcucHJvdG90eXBlLmhp ZGRlbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya0dyaWRDb250ZW50Vmlldy5wcm90 b3R5cGUuX25ldHdvcmtUaW1lbGluZVJlY29yZEFkZGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3LnByb3RvdHlwZS5fc3RvcFVwZGF0aW5nQ3VycmVudFRp bWUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtHcmlkQ29udGVudFZpZXcpOgorCiAy MDE2LTA4LTE3ICBEZXZpbiBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IHJhcGlkIHVwZGF0ZXMgdG8gc3RhdHVzIGljb25zIGluIFZp c3VhbCBTdHlsZXMgc2lkZWJhciBjYXVzZXMgZmxpY2tlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50Vmlldy5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtHcmlk Q29udGVudFZpZXcuanMKaW5kZXggZjE5ZjhjMTI5MzExZjYxZTk4OGExZmQzZWNjNjc0YzJmMWJh M2M1ZC4uY2I5OTg2ZWJmOTBlOWQzNWUyNWE2YmRkNmQ0ZGY1OTZkYjA4MTA5MSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRD b250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9OZXR3b3JrR3JpZENvbnRlbnRWaWV3LmpzCkBAIC0xNDksNiArMTQ5LDkgQEAgV2ViSW5z cGVjdG9yLk5ldHdvcmtHcmlkQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3JrR3JpZENvbnRlbnRW aWV3IGV4dGVuZHMgV2ViSW4KICAgICB7CiAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmhpZGRlbigp OwogCisgICAgICAgIGlmICh0aGlzLl9zY2hlZHVsZWRDdXJyZW50VGltZVVwZGF0ZUlkZW50aWZp ZXIpCisgICAgICAgICAgICB0aGlzLl9zdG9wVXBkYXRpbmdDdXJyZW50VGltZSgpOworCiAgICAg ICAgIHN1cGVyLmhpZGRlbigpOwogICAgIH0KIApAQCAtMjM2LDcgKzIzOSw5IEBAIFdlYkluc3Bl Y3Rvci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya0dyaWRDb250ZW50Vmll dyBleHRlbmRzIFdlYkluCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgICAgICB0 aGlzLl9lbmRUaW1lID0gcmVzb3VyY2VUaW1lbGluZVJlY29yZC5lbmRUaW1lOwotICAgICAgICAg ICAgdGhpcy5kZWJvdW5jZSgxNTApLl9zdG9wVXBkYXRpbmdDdXJyZW50VGltZSgpOworCisgICAg ICAgICAgICBpZiAodGhpcy5fc2NoZWR1bGVkQ3VycmVudFRpbWVVcGRhdGVJZGVudGlmaWVyKQor ICAgICAgICAgICAgICAgIHRoaXMuZGVib3VuY2UoMTUwKS5fc3RvcFVwZGF0aW5nQ3VycmVudFRp bWUoKTsKICAgICAgICAgfTsKIAogICAgICAgICB0aGlzLl9wZW5kaW5nUmVjb3Jkcy5wdXNoKHJl c291cmNlVGltZWxpbmVSZWNvcmQpOwpAQCAtMjUyLDEyICsyNTcsMTQgQEAgV2ViSW5zcGVjdG9y Lk5ldHdvcmtHcmlkQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3JrR3JpZENvbnRlbnRWaWV3IGV4 dGVuZHMgV2ViSW4KICAgICAgICAgcmVzb3VyY2UuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0 b3IuUmVzb3VyY2UuRXZlbnQuTG9hZGluZ0RpZEZhaWwsIHVwZGF0ZSwgdGhpcyk7CiAKICAgICAg ICAgdGhpcy5fbG9hZGluZ1Jlc291cmNlQ291bnQrKzsKLSAgICAgICAgaWYgKHRoaXMuX2xvYWRp bmdSZXNvdXJjZUNvdW50ICYmICF0aGlzLl9zY2hlZHVsZWRDdXJyZW50VGltZVVwZGF0ZUlkZW50 aWZpZXIpIHsKLSAgICAgICAgICAgIGlmIChpc05hTih0aGlzLl9zdGFydFRpbWUpKQotICAgICAg ICAgICAgICAgIHRoaXMuX3N0YXJ0VGltZSA9IHJlc291cmNlVGltZWxpbmVSZWNvcmQuc3RhcnRU aW1lOworICAgICAgICBpZiAodGhpcy5fc2NoZWR1bGVkQ3VycmVudFRpbWVVcGRhdGVJZGVudGlm aWVyKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGlmIChpc05hTih0aGlzLl9zdGFy dFRpbWUpKQorICAgICAgICAgICAgdGhpcy5fc3RhcnRUaW1lID0gcmVzb3VyY2VUaW1lbGluZVJl Y29yZC5zdGFydFRpbWU7CiAKKyAgICAgICAgaWYgKHRoaXMudmlzaWJsZSkKICAgICAgICAgICAg IHRoaXMuX3N0YXJ0VXBkYXRpbmdDdXJyZW50VGltZSgpOwotICAgICAgICB9CiAgICAgfQogCiAg ICAgX3RyZWVFbGVtZW50UGF0aENvbXBvbmVudFNlbGVjdGVkKGV2ZW50KQpAQCAtMzMwLDYgKzMz Nyw4IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrR3JpZENvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29y a0dyaWRDb250ZW50VmlldyBleHRlbmRzIFdlYkluCiAgICAgICAgIGlmICghdGhpcy5fc2NoZWR1 bGVkQ3VycmVudFRpbWVVcGRhdGVJZGVudGlmaWVyKQogICAgICAgICAgICAgcmV0dXJuOwogCisg ICAgICAgIHRoaXMuX3N0b3BVcGRhdGluZ0N1cnJlbnRUaW1lLmNhbmNlbERlYm91bmNlKCk7CisK ICAgICAgICAgY2FuY2VsQW5pbWF0aW9uRnJhbWUodGhpcy5fc2NoZWR1bGVkQ3VycmVudFRpbWVV cGRhdGVJZGVudGlmaWVyKTsKICAgICAgICAgdGhpcy5fc2NoZWR1bGVkQ3VycmVudFRpbWVVcGRh dGVJZGVudGlmaWVyID0gdW5kZWZpbmVkOwogCg==