160917 2016-08-16 15:41:35 -0700 Heap::collectAllGarbage() should work with JSC_useImmortalObjects=true. 2016-08-16 17:20:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam benjamin commit-queue fpizlo ggaren keith_miller msaboff saam oldest_to_newest 1220618 0 mark.lam 2016-08-16 15:41:35 -0700 If we do an synchronous GC when JSC_useImmortalObjects=true, we'll get an RELEASE_ASSERT failure: $ JSC_useImmortalObjects=true jsc >>> gc() Trace/BPT trap: 5 We should fix this. 1220625 1 286218 mark.lam 2016-08-16 15:48:13 -0700 Created attachment 286218 proposed patch. 1220626 2 commit-queue 2016-08-16 15:50:06 -0700 Attachment 286218 did not pass style-queue: ERROR: Source/JavaScriptCore/heap/Heap.cpp:1084: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1220629 3 286220 mark.lam 2016-08-16 15:52:13 -0700 Created attachment 286220 proposed patch: fixed style issues. 1220675 4 286220 commit-queue 2016-08-16 17:20:18 -0700 Comment on attachment 286220 proposed patch: fixed style issues. Clearing flags on attachment: 286220 Committed r204542: <http://trac.webkit.org/changeset/204542> 1220676 5 commit-queue 2016-08-16 17:20:22 -0700 All reviewed patches have been landed. Closing bug. 286218 2016-08-16 15:48:13 -0700 2016-08-16 15:52:13 -0700 proposed patch. bug-160917.patch text/plain 1933 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0NTI1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE2LTA4LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBI ZWFwOjpjb2xsZWN0QWxsR2FyYmFnZSgpIHNob3VsZCB3b3JrIHdpdGggSlNDX3VzZUltbW9ydGFs T2JqZWN0cz10cnVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYwOTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSWYgd2UgZG8gYW4gc3luY2hyb25vdXMgR0Mgd2hlbiBKU0NfdXNlSW1tb3J0YWxPYmpl Y3RzPXRydWUsIHdlJ2xsIGdldCBhCisgICAgICAgIFJFTEVBU0VfQVNTRVJUIGZhaWx1cmU6CisK KyAgICAgICAgICAgICQgSlNDX3VzZUltbW9ydGFsT2JqZWN0cz10cnVlIGpzYworICAgICAgICAg ICAgPj4+IGdjKCkKKyAgICAgICAgICAgIFRyYWNlL0JQVCB0cmFwOiA1CisKKyAgICAgICAgVGhp cyBpcyBiZWNhdXNlIEhlYXA6OmNvbGxlY3RBbGxHYXJiYWdlKCkgaXMgZG9pbmcgYW4gZXhwbGlj aXQgc3dlZXAgb2YgdGhlCisgICAgICAgIE1hcmtlZFNwYWNlLCBhbmQgdGhlIHN3ZWVwZXIgaXMg ZXhwZWN0aW5nIHRvIHNlZSBubyBSZXRpcmVkQmxvY2tzLiAgSG93ZXZlciwgd2UKKyAgICAgICAg bWFrZSBvYmplY3RzIGltbW9ydGFsIGJ5IHJldGlyaW5nIHRoZWlyIGJsb2Nrcy4gIEFzIGEgcmVz dWx0LCB0aGVyZSBpcyBhIG1pc21hdGNoCisgICAgICAgIGluIGV4cGVjdGFuY3kuCisKKyAgICAg ICAgVGhlIGZpeCBpcyBzaW1wbHkgdG8gbm90IHJ1biB0aGUgc3dlZXBlciB3aGVuIEpTQ191c2VJ bW1vcnRhbE9iamVjdHM9dHJ1ZS4KKworICAgICAgICAqIGhlYXAvSGVhcC5jcHA6CisgICAgICAg IChKU0M6OkhlYXA6OmNvbGxlY3RBbGxHYXJiYWdlKToKKwogMjAxNi0wOC0xNSAgUnlvc3VrZSBO aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBDb252ZXJzaW9uIHRvIHNlcXVlbmNl PFQ+IGlzIGJyb2tlbiBmb3IgaXRlcmFibGUgb2JqZWN0cwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvSGVhcC5jcHAJKHJldmlzaW9uIDIwNDUyNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL0hlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDc5LDkgKzEwNzksMTMgQEAgdm9p ZCBIZWFwOjpjb2xsZWN0QWxsR2FyYmFnZSgpCiAgICAgY29sbGVjdChGdWxsQ29sbGVjdGlvbik7 CiAKICAgICBEZWZlckdDRm9yQVdoaWxlIGRlZmVyR0MoKnRoaXMpOwotICAgIG1fb2JqZWN0U3Bh Y2Uuc3dlZXAoKTsKLSAgICBtX29iamVjdFNwYWNlLnNocmluaygpOwotICAgIG1fYmxvY2tTbmFw c2hvdC5jbGVhcigpOworICAgIGlmIChVTkxJS0VMWShPcHRpb25zOjp1c2VJbW1vcnRhbE9iamVj dHMoKSkpIHsKKyAgICAgICAgc3dlZXBlcigpLT53aWxsRmluaXNoU3dlZXBpbmcoKTsKKyAgICB9 IGVsc2UgeworICAgICAgICBtX29iamVjdFNwYWNlLnN3ZWVwKCk7CisgICAgICAgIG1fb2JqZWN0 U3BhY2Uuc2hyaW5rKCk7CisgICAgfQorICAgIEFTU0VSVChtX2Jsb2NrU25hcHNob3QuaXNFbXB0 eSgpKTsKIAogICAgIHN3ZWVwQWxsTG9naWNhbGx5RW1wdHlXZWFrQmxvY2tzKCk7CiB9Cg== 286220 2016-08-16 15:52:13 -0700 2016-08-16 17:20:18 -0700 proposed patch: fixed style issues. bug-160917.patch text/plain 1929 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0NTI1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE2LTA4LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBI ZWFwOjpjb2xsZWN0QWxsR2FyYmFnZSgpIHNob3VsZCB3b3JrIHdpdGggSlNDX3VzZUltbW9ydGFs T2JqZWN0cz10cnVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYwOTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSWYgd2UgZG8gYW4gc3luY2hyb25vdXMgR0Mgd2hlbiBKU0NfdXNlSW1tb3J0YWxPYmpl Y3RzPXRydWUsIHdlJ2xsIGdldCBhCisgICAgICAgIFJFTEVBU0VfQVNTRVJUIGZhaWx1cmU6CisK KyAgICAgICAgICAgICQgSlNDX3VzZUltbW9ydGFsT2JqZWN0cz10cnVlIGpzYworICAgICAgICAg ICAgPj4+IGdjKCkKKyAgICAgICAgICAgIFRyYWNlL0JQVCB0cmFwOiA1CisKKyAgICAgICAgVGhp cyBpcyBiZWNhdXNlIEhlYXA6OmNvbGxlY3RBbGxHYXJiYWdlKCkgaXMgZG9pbmcgYW4gZXhwbGlj aXQgc3dlZXAgb2YgdGhlCisgICAgICAgIE1hcmtlZFNwYWNlLCBhbmQgdGhlIHN3ZWVwZXIgaXMg ZXhwZWN0aW5nIHRvIHNlZSBubyBSZXRpcmVkQmxvY2tzLiAgSG93ZXZlciwgd2UKKyAgICAgICAg bWFrZSBvYmplY3RzIGltbW9ydGFsIGJ5IHJldGlyaW5nIHRoZWlyIGJsb2Nrcy4gIEFzIGEgcmVz dWx0LCB0aGVyZSBpcyBhIG1pc21hdGNoCisgICAgICAgIGluIGV4cGVjdGFuY3kuCisKKyAgICAg ICAgVGhlIGZpeCBpcyBzaW1wbHkgdG8gbm90IHJ1biB0aGUgc3dlZXBlciB3aGVuIEpTQ191c2VJ bW1vcnRhbE9iamVjdHM9dHJ1ZS4KKworICAgICAgICAqIGhlYXAvSGVhcC5jcHA6CisgICAgICAg IChKU0M6OkhlYXA6OmNvbGxlY3RBbGxHYXJiYWdlKToKKwogMjAxNi0wOC0xNSAgUnlvc3VrZSBO aXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBDb252ZXJzaW9uIHRvIHNlcXVlbmNl PFQ+IGlzIGJyb2tlbiBmb3IgaXRlcmFibGUgb2JqZWN0cwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2hlYXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvSGVhcC5jcHAJKHJldmlzaW9uIDIwNDUyNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL0hlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDc5LDkgKzEwNzksMTMgQEAgdm9p ZCBIZWFwOjpjb2xsZWN0QWxsR2FyYmFnZSgpCiAgICAgY29sbGVjdChGdWxsQ29sbGVjdGlvbik7 CiAKICAgICBEZWZlckdDRm9yQVdoaWxlIGRlZmVyR0MoKnRoaXMpOwotICAgIG1fb2JqZWN0U3Bh Y2Uuc3dlZXAoKTsKLSAgICBtX29iamVjdFNwYWNlLnNocmluaygpOwotICAgIG1fYmxvY2tTbmFw c2hvdC5jbGVhcigpOworICAgIGlmIChVTkxJS0VMWShPcHRpb25zOjp1c2VJbW1vcnRhbE9iamVj dHMoKSkpCisgICAgICAgIHN3ZWVwZXIoKS0+d2lsbEZpbmlzaFN3ZWVwaW5nKCk7CisgICAgZWxz ZSB7CisgICAgICAgIG1fb2JqZWN0U3BhY2Uuc3dlZXAoKTsKKyAgICAgICAgbV9vYmplY3RTcGFj ZS5zaHJpbmsoKTsKKyAgICB9CisgICAgQVNTRVJUKG1fYmxvY2tTbmFwc2hvdC5pc0VtcHR5KCkp OwogCiAgICAgc3dlZXBBbGxMb2dpY2FsbHlFbXB0eVdlYWtCbG9ja3MoKTsKIH0K