160916 2016-08-16 15:13:42 -0700 Enable WebAssembly in the build. 2016-12-19 08:45:50 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller benjamin cdumez cgarcia cmarcelo commit-queue gyuyoung.kim ossy oldest_to_newest 1220593 0 keith_miller 2016-08-16 15:13:42 -0700 Enable WebAssembly in the build. 1220599 1 286215 keith_miller 2016-08-16 15:20:07 -0700 Created attachment 286215 Patch 1220634 2 286222 keith_miller 2016-08-16 15:59:26 -0700 Created attachment 286222 Patch 1220635 3 286223 keith_miller 2016-08-16 16:05:29 -0700 Created attachment 286223 Patch 1220665 4 286223 commit-queue 2016-08-16 17:00:54 -0700 Comment on attachment 286223 Patch Clearing flags on attachment: 286223 Committed r204541: <http://trac.webkit.org/changeset/204541> 1220666 5 commit-queue 2016-08-16 17:00:58 -0700 All reviewed patches have been landed. Closing bug. 1260565 6 286223 ossy 2016-12-16 03:20:36 -0800 Comment on attachment 286223 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286223&action=review > Source/WTF/ChangeLog:10 > + This patch turns on WebAssembly on all the platforms that support B3. > + Turning on WebAssembly by default lets us check the build on every > + platform. This comment isn't true, it enabled wasm only on iOS and Mac platforms. 1260596 7 keith_miller 2016-12-16 09:25:17 -0800 (In reply to comment #6) > Comment on attachment 286223 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286223&action=review > > > Source/WTF/ChangeLog:10 > > + This patch turns on WebAssembly on all the platforms that support B3. > > + Turning on WebAssembly by default lets us check the build on every > > + platform. > > This comment isn't true, it enabled wasm only on iOS and Mac platforms. I suppose the comment should say it is enabled on every platform that supports B3. Since we don't have any way to generate Wasm without B3 it wouldn't do any good to build WebAssembly on those platforms. 1261123 8 ossy 2016-12-19 08:45:27 -0800 (In reply to comment #7) > (In reply to comment #6) > > Comment on attachment 286223 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=286223&action=review > > > > > Source/WTF/ChangeLog:10 > > > + This patch turns on WebAssembly on all the platforms that support B3. > > > + Turning on WebAssembly by default lets us check the build on every > > > + platform. > > > > This comment isn't true, it enabled wasm only on iOS and Mac platforms. > > I suppose the comment should say it is enabled on every platform that > supports B3. Since we don't have any way to generate Wasm without B3 it > wouldn't do any good to build WebAssembly on those platforms. It's not true. B3-FTL JIT is enabled on X86_64 Linux (not on ARM64 Linux), but WebAssembly is still disabled on all Linux platforms: GTK, EFL and JSCOnly. 286215 2016-08-16 15:20:07 -0700 2016-08-16 15:59:22 -0700 Patch bug-160916-20160816151820.patch text/plain 1525 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ5NjA1MWEzZGJjMjE3Y2ExN2ZkZjE0 YzczYmU5YTRlNGMxZWJjOWYuLjZmNTA3OGNjMzJmMzVmOTdjZmJkZDE3YzNjODdkMjcxNWMyNjQ2 NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDgtMTYgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIFdlYkFzc2VtYmx5IGluIHRoZSBi dWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 MDkxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggdHVybnMgb24gV2ViQXNzZW1ibHkgb24gYWxsIHRoZSBwbGF0Zm9ybXMgdGhhdCBz dXBwb3J0IEIzLgorICAgICAgICBUdXJuaW5nIG9uIFdlYkFzc2VtYmx5IGJ5IGRlZmF1bHQgbGV0 cyB1cyBjaGVjayB0aGUgYnVpbGQgb24gZXZlcnkKKyAgICAgICAgcGxhdGZvcm0uCisKKyAgICAg ICAgKiB3dGYvRmVhdHVyZURlZmluZXMuaDoKKwogMjAxNi0wOC0xNSAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBhZGRyZXNzLW9mIG9wZXJh dG9yIHRvIFJldGFpblB0cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmlu ZXMuaCBiL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKaW5kZXggNjc5MDNiOGNjMjgy NjhiZGZjYTZlMDIwMWYyYzc2MDYyOGNhMTA1YS4uNDFjODc0ZTk1ZDE2OGZiNTk4ZjRkYjk3YjZi MzAyZjM2ZjZjZmIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCkBAIC0xNTcsNyArMTU3LDcg QEAgdGhlIHB1YmxpYyBpT1MgU0RLLiBXZSB3aWxsIGFsc28gbmVlZCB0byB1cGRhdGUgdGhlIEZl YXR1cmVEZWZpbmVzLnhjY29uZmlnIGZpbGUKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoRU5BQkxF X1dFQkFTU0VNQkxZKQotI2RlZmluZSBFTkFCTEVfV0VCQVNTRU1CTFkgMAorI2RlZmluZSBFTkFC TEVfV0VCQVNTRU1CTFkgRU5BQkxFX0IzX0pJVAogI2VuZGlmCiAKICNpZiAhZGVmaW5lZChFTkFC TEVfV0VCR0wpCkBAIC0yMjMsNyArMjIzLDcgQEAgdGhlIHB1YmxpYyBpT1MgU0RLLiBXZSB3aWxs IGFsc28gbmVlZCB0byB1cGRhdGUgdGhlIEZlYXR1cmVEZWZpbmVzLnhjY29uZmlnIGZpbGUKICNl bmRpZgogCiAjaWYgIWRlZmluZWQoRU5BQkxFX1dFQkFTU0VNQkxZKQotI2RlZmluZSBFTkFCTEVf V0VCQVNTRU1CTFkgMAorI2RlZmluZSBFTkFCTEVfV0VCQVNTRU1CTFkgRU5BQkxFX0IzX0pJVAog I2VuZGlmCiAKICNpZiAhZGVmaW5lZChFTkFCTEVfV0VCX0FSQ0hJVkUpCg== 286222 2016-08-16 15:59:26 -0700 2016-08-16 16:05:25 -0700 Patch bug-160916-20160816155739.patch text/plain 1511 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ5NjA1MWEzZGJjMjE3Y2ExN2ZkZjE0 YzczYmU5YTRlNGMxZWJjOWYuLjZmNTA3OGNjMzJmMzVmOTdjZmJkZDE3YzNjODdkMjcxNWMyNjQ2 NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDgtMTYgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIFdlYkFzc2VtYmx5IGluIHRoZSBi dWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 MDkxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggdHVybnMgb24gV2ViQXNzZW1ibHkgb24gYWxsIHRoZSBwbGF0Zm9ybXMgdGhhdCBz dXBwb3J0IEIzLgorICAgICAgICBUdXJuaW5nIG9uIFdlYkFzc2VtYmx5IGJ5IGRlZmF1bHQgbGV0 cyB1cyBjaGVjayB0aGUgYnVpbGQgb24gZXZlcnkKKyAgICAgICAgcGxhdGZvcm0uCisKKyAgICAg ICAgKiB3dGYvRmVhdHVyZURlZmluZXMuaDoKKwogMjAxNi0wOC0xNSAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBhZGRyZXNzLW9mIG9wZXJh dG9yIHRvIFJldGFpblB0cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmlu ZXMuaCBiL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKaW5kZXggNjc5MDNiOGNjMjgy NjhiZGZjYTZlMDIwMWYyYzc2MDYyOGNhMTA1YS4uN2M4Yzc4Njk1MmVlYTA1YWU0MzY4NGQyNWUx MGZjOTFiZmRlY2VjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCkBAIC0xNTcsNyArMTU3LDcg QEAgdGhlIHB1YmxpYyBpT1MgU0RLLiBXZSB3aWxsIGFsc28gbmVlZCB0byB1cGRhdGUgdGhlIEZl YXR1cmVEZWZpbmVzLnhjY29uZmlnIGZpbGUKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoRU5BQkxF X1dFQkFTU0VNQkxZKQotI2RlZmluZSBFTkFCTEVfV0VCQVNTRU1CTFkgMAorI2RlZmluZSBFTkFC TEVfV0VCQVNTRU1CTFkgQjNfSklUCiAjZW5kaWYKIAogI2lmICFkZWZpbmVkKEVOQUJMRV9XRUJH TCkKQEAgLTIyMyw3ICsyMjMsNyBAQCB0aGUgcHVibGljIGlPUyBTREsuIFdlIHdpbGwgYWxzbyBu ZWVkIHRvIHVwZGF0ZSB0aGUgRmVhdHVyZURlZmluZXMueGNjb25maWcgZmlsZQogI2VuZGlmCiAK ICNpZiAhZGVmaW5lZChFTkFCTEVfV0VCQVNTRU1CTFkpCi0jZGVmaW5lIEVOQUJMRV9XRUJBU1NF TUJMWSAwCisjZGVmaW5lIEVOQUJMRV9XRUJBU1NFTUJMWSBCM19KSVQKICNlbmRpZgogCiAjaWYg IWRlZmluZWQoRU5BQkxFX1dFQl9BUkNISVZFKQo= 286223 2016-08-16 16:05:29 -0700 2016-08-16 17:00:54 -0700 Patch bug-160916-20160816160343.patch text/plain 1667 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDQ5NjA1MWEzZGJjMjE3Y2ExN2ZkZjE0 YzczYmU5YTRlNGMxZWJjOWYuLjZmNTA3OGNjMzJmMzVmOTdjZmJkZDE3YzNjODdkMjcxNWMyNjQ2 NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDgtMTYgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgRW5hYmxlIFdlYkFzc2VtYmx5IGluIHRoZSBi dWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 MDkxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggdHVybnMgb24gV2ViQXNzZW1ibHkgb24gYWxsIHRoZSBwbGF0Zm9ybXMgdGhhdCBz dXBwb3J0IEIzLgorICAgICAgICBUdXJuaW5nIG9uIFdlYkFzc2VtYmx5IGJ5IGRlZmF1bHQgbGV0 cyB1cyBjaGVjayB0aGUgYnVpbGQgb24gZXZlcnkKKyAgICAgICAgcGxhdGZvcm0uCisKKyAgICAg ICAgKiB3dGYvRmVhdHVyZURlZmluZXMuaDoKKwogMjAxNi0wOC0xNSAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBhZGRyZXNzLW9mIG9wZXJh dG9yIHRvIFJldGFpblB0cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmlu ZXMuaCBiL1NvdXJjZS9XVEYvd3RmL0ZlYXR1cmVEZWZpbmVzLmgKaW5kZXggNjc5MDNiOGNjMjgy NjhiZGZjYTZlMDIwMWYyYzc2MDYyOGNhMTA1YS4uYjY2ZGZiMWRlMTY1Y2JjMWY2OGU0OWEwMjM3 M2U2N2I2ZjYyOWUyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRmVhdHVyZURlZmluZXMu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GZWF0dXJlRGVmaW5lcy5oCkBAIC0xNTcsOCArMTU3LDEy IEBAIHRoZSBwdWJsaWMgaU9TIFNESy4gV2Ugd2lsbCBhbHNvIG5lZWQgdG8gdXBkYXRlIHRoZSBG ZWF0dXJlRGVmaW5lcy54Y2NvbmZpZyBmaWxlCiAjZW5kaWYKIAogI2lmICFkZWZpbmVkKEVOQUJM RV9XRUJBU1NFTUJMWSkKKyNpZiBkZWZpbmVkKEVOQUJMRV9CM19KSVQpCisjZGVmaW5lIEVOQUJM RV9XRUJBU1NFTUJMWSBFTkFCTEVfQjNfSklUCisjZWxzZQogI2RlZmluZSBFTkFCTEVfV0VCQVNT RU1CTFkgMAogI2VuZGlmCisjZW5kaWYKIAogI2lmICFkZWZpbmVkKEVOQUJMRV9XRUJHTCkKICNk ZWZpbmUgRU5BQkxFX1dFQkdMIDEKQEAgLTIyMyw4ICsyMjcsMTIgQEAgdGhlIHB1YmxpYyBpT1Mg U0RLLiBXZSB3aWxsIGFsc28gbmVlZCB0byB1cGRhdGUgdGhlIEZlYXR1cmVEZWZpbmVzLnhjY29u ZmlnIGZpbGUKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoRU5BQkxFX1dFQkFTU0VNQkxZKQorI2lm IGRlZmluZWQoRU5BQkxFX0IzX0pJVCkKKyNkZWZpbmUgRU5BQkxFX1dFQkFTU0VNQkxZIEVOQUJM RV9CM19KSVQKKyNlbHNlCiAjZGVmaW5lIEVOQUJMRV9XRUJBU1NFTUJMWSAwCiAjZW5kaWYKKyNl bmRpZgogCiAjaWYgIWRlZmluZWQoRU5BQkxFX1dFQl9BUkNISVZFKQogI2RlZmluZSBFTkFCTEVf V0VCX0FSQ0hJVkUgMQo=