160912 2016-08-16 14:43:58 -0700 [JSC] Update the documentation of B3's Return opcode 2016-08-16 19:02:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue fpizlo oldest_to_newest 1220576 0 benjamin 2016-08-16 14:43:58 -0700 [JSC] Update the documentation of B3's Return opcode 1220578 1 286206 benjamin 2016-08-16 14:44:43 -0700 Created attachment 286206 Patch 1220586 2 286206 fpizlo 2016-08-16 15:06:47 -0700 Comment on attachment 286206 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286206&action=review > Websites/webkit.org/docs/b3/intermediate-representation.html:598 > <dt>Void Return(T)</dt> Can you do something here to hint that the value is optional? Maybe: Void Return(T?) or: Void Return(T <i>(optional)</i>) 1220589 3 286211 benjamin 2016-08-16 15:10:28 -0700 Created attachment 286211 Patch 1220715 4 286211 commit-queue 2016-08-16 19:02:43 -0700 Comment on attachment 286211 Patch Clearing flags on attachment: 286211 Committed r204546: <http://trac.webkit.org/changeset/204546> 1220716 5 commit-queue 2016-08-16 19:02:47 -0700 All reviewed patches have been landed. Closing bug. 286206 2016-08-16 14:44:43 -0700 2016-08-16 15:10:25 -0700 Patch bug-160912-20160816144256.patch text/plain 1846 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NTIzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDI3MTMw NTFmNjA3ODE2MjFjYmM3YmU2MDEyMzVmODczM2U1ZDg2N2MuLmI5MTZhZGRmOTAxNTYyYjhlZDk0 NTQ2MzZlNmUxZjUwY2FkNzE4ZDkgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTYtMDgtMTYgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisK KyAgICAgICAgW0pTQ10gVXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uIG9mIEIzJ3MgUmV0dXJuIG9w Y29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYw OTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBk b2NzL2IzL2ludGVybWVkaWF0ZS1yZXByZXNlbnRhdGlvbi5odG1sOgorCiAyMDE2LTA4LTA0ICBE YW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc29tZSBmaWxl cyBmb3IgYSBDb250ZW50IFNlY3VyaXR5IFBvbGljeSBibG9nIHBvc3QKZGlmZiAtLWdpdCBhL1dl YnNpdGVzL3dlYmtpdC5vcmcvZG9jcy9iMy9pbnRlcm1lZGlhdGUtcmVwcmVzZW50YXRpb24uaHRt bCBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvZG9jcy9iMy9pbnRlcm1lZGlhdGUtcmVwcmVzZW50YXRp b24uaHRtbAppbmRleCBmYTgzODVjODIwNmY0Y2Y1NTM5MzI5YmVmMmE4NWRiNzdkNjIwNGE0Li5l YWQzMzJkODJhMDJhZDRhZjMwMzAyN2IzYzkxODY0ODkyZmRiY2JlIDEwMDY0NAotLS0gYS9XZWJz aXRlcy93ZWJraXQub3JnL2RvY3MvYjMvaW50ZXJtZWRpYXRlLXJlcHJlc2VudGF0aW9uLmh0bWwK KysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9kb2NzL2IzL2ludGVybWVkaWF0ZS1yZXByZXNlbnRh dGlvbi5odG1sCkBAIC01OTYsOCArNTk2LDE1IEBAIHJvb3QtPmFwcGVuZFN1Y2Nlc3Nvcih0aGly ZEVudHJ5cG9pbnQpOzwvY29kZT48L3ByZT4KICAgICAgIDwvZGQ+CiAKICAgICAgIDxkdD5Wb2lk IFJldHVybihUKTwvZHQ+Ci0gICAgICA8ZGQ+V29ya3MgZm9yIGFueSB0eXBlIGV4Y2VwdCBWb2lk LiAgUmV0dXJucyB0aGUgZ2l2ZW4gdmFsdWUgYW5kIHRlcm1pbmF0ZXMgdGhlIHByb2NlZHVyZS4K LSAgICAgICAgTXVzdCBhcHBlYXIgYXQgdGhlIGVuZCBvZiB0aGUgYmFzaWMgYmxvY2suIFRoZSBi bG9jayBtdXN0IGhhdmUgemVybyBzdWNjZXNzb3JzLjwvZGQ+CisgICAgICA8ZGQ+CisgICAgICAg ICAgPHA+CisgICAgICAgICAgICBSZXR1cm5zIHRoZSBjb250cm9sIGZsb3cgdG8gdGhlIGNhbGxl ciBhbmQgdGVybWluYXRlcyB0aGUgcHJvY2VkdXJlLgorICAgICAgICAgICAgTXVzdCBhcHBlYXIg YXQgdGhlIGVuZCBvZiB0aGUgYmFzaWMgYmxvY2suIFRoZSBibG9jayBtdXN0IGhhdmUgemVybyBz dWNjZXNzb3JzLgorICAgICAgICAgIDwvcD4KKyAgICAgICAgICA8cD4KKyAgICAgICAgICAgIElm IHRoZSBub2RlIGhhcyBhIGNoaWxkLCBpdHMgdmFsdWUgaXMgcmV0dXJuZWQuIFRoZSB0eXBlIG9m IHRoZSBjaGlsZCBjYW4gYmUgYW55IHR5cGUgZXhjZXB0IFZvaWQuCisgICAgICAgICAgPC9wPgor ICAgICAgPC9kZD4KIAogICAgICAgPGR0PlZvaWQgT29wcygpPC9kdD4KICAgICAgIDxkZD5JbmRp Y2F0ZXMgdW5yZWFjaGFibGUgY29kZS4gIFRoaXMgbWF5IGJlIGltcGxlbWVudGVkIGFzIGVpdGhl ciBhIHRyYXAgb3IgYXMgYSBiYXJlCg== 286211 2016-08-16 15:10:28 -0700 2016-08-16 19:02:43 -0700 Patch bug-160912-20160816150841.patch text/plain 1967 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NTIzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDI3MTMw NTFmNjA3ODE2MjFjYmM3YmU2MDEyMzVmODczM2U1ZDg2N2MuLmI5MTZhZGRmOTAxNTYyYjhlZDk0 NTQ2MzZlNmUxZjUwY2FkNzE4ZDkgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTYtMDgtMTYgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisK KyAgICAgICAgW0pTQ10gVXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uIG9mIEIzJ3MgUmV0dXJuIG9w Y29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYw OTEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBk b2NzL2IzL2ludGVybWVkaWF0ZS1yZXByZXNlbnRhdGlvbi5odG1sOgorCiAyMDE2LTA4LTA0ICBE YW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc29tZSBmaWxl cyBmb3IgYSBDb250ZW50IFNlY3VyaXR5IFBvbGljeSBibG9nIHBvc3QKZGlmZiAtLWdpdCBhL1dl YnNpdGVzL3dlYmtpdC5vcmcvZG9jcy9iMy9pbnRlcm1lZGlhdGUtcmVwcmVzZW50YXRpb24uaHRt bCBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvZG9jcy9iMy9pbnRlcm1lZGlhdGUtcmVwcmVzZW50YXRp b24uaHRtbAppbmRleCBmYTgzODVjODIwNmY0Y2Y1NTM5MzI5YmVmMmE4NWRiNzdkNjIwNGE0Li5m ZjlkZTVkZGIxNjEyYTUxZDJmOGY4ZGMxMmM0ZDUyZWY1MGUzYTJhIDEwMDY0NAotLS0gYS9XZWJz aXRlcy93ZWJraXQub3JnL2RvY3MvYjMvaW50ZXJtZWRpYXRlLXJlcHJlc2VudGF0aW9uLmh0bWwK KysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9kb2NzL2IzL2ludGVybWVkaWF0ZS1yZXByZXNlbnRh dGlvbi5odG1sCkBAIC01OTUsOSArNTk1LDE2IEBAIHJvb3QtPmFwcGVuZFN1Y2Nlc3Nvcih0aGly ZEVudHJ5cG9pbnQpOzwvY29kZT48L3ByZT4KICAgICAgICAgICBsZWFkcyB0byBvbmx5IGEgc21h bGwgYW1vdW50IG9mIGNsb25lZCBjb2RlIGluIHByYWN0aWNlLjwvcD4KICAgICAgIDwvZGQ+CiAK LSAgICAgIDxkdD5Wb2lkIFJldHVybihUKTwvZHQ+Ci0gICAgICA8ZGQ+V29ya3MgZm9yIGFueSB0 eXBlIGV4Y2VwdCBWb2lkLiAgUmV0dXJucyB0aGUgZ2l2ZW4gdmFsdWUgYW5kIHRlcm1pbmF0ZXMg dGhlIHByb2NlZHVyZS4KLSAgICAgICAgTXVzdCBhcHBlYXIgYXQgdGhlIGVuZCBvZiB0aGUgYmFz aWMgYmxvY2suIFRoZSBibG9jayBtdXN0IGhhdmUgemVybyBzdWNjZXNzb3JzLjwvZGQ+CisgICAg ICA8ZHQ+Vm9pZCBSZXR1cm4oVCA8aT4ob3B0aW9uYWwpPC9pPik8L2R0PgorICAgICAgPGRkPgor ICAgICAgICAgIDxwPgorICAgICAgICAgICAgUmV0dXJucyB0aGUgY29udHJvbCBmbG93IHRvIHRo ZSBjYWxsZXIgYW5kIHRlcm1pbmF0ZXMgdGhlIHByb2NlZHVyZS4KKyAgICAgICAgICAgIE11c3Qg YXBwZWFyIGF0IHRoZSBlbmQgb2YgdGhlIGJhc2ljIGJsb2NrLiBUaGUgYmxvY2sgbXVzdCBoYXZl IHplcm8gc3VjY2Vzc29ycy4KKyAgICAgICAgICA8L3A+CisgICAgICAgICAgPHA+CisgICAgICAg ICAgICBJZiB0aGUgbm9kZSBoYXMgYSBjaGlsZCwgaXRzIHZhbHVlIGlzIHJldHVybmVkLiBUaGUg dHlwZSBvZiB0aGUgY2hpbGQgY2FuIGJlIGFueSB0eXBlIGV4Y2VwdCBWb2lkLgorICAgICAgICAg IDwvcD4KKyAgICAgIDwvZGQ+CiAKICAgICAgIDxkdD5Wb2lkIE9vcHMoKTwvZHQ+CiAgICAgICA8 ZGQ+SW5kaWNhdGVzIHVucmVhY2hhYmxlIGNvZGUuICBUaGlzIG1heSBiZSBpbXBsZW1lbnRlZCBh cyBlaXRoZXIgYSB0cmFwIG9yIGFzIGEgYmFyZQo=