160910 2016-08-16 14:11:41 -0700 check-webkit-style does not work with Lambda functions in C++ 2016-08-26 09:13:51 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=125616 https://bugs.webkit.org/show_bug.cgi?id=161247 P2 Normal --- 1 jbedard webkit-unassigned achristensen ap beidson commit-queue dbates glenn lforschler oldest_to_newest 1220564 0 jbedard 2016-08-16 14:11:41 -0700 The check-webkit-style script treats lambda functions as regular C++ functions from a style perspective, which is incorrect. 1220570 1 286204 jbedard 2016-08-16 14:31:29 -0700 Created attachment 286204 Patch 1220651 2 286204 achristensen 2016-08-16 16:36:25 -0700 Comment on attachment 286204 Patch hooray! 1220653 3 beidson 2016-08-16 16:49:30 -0700 Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ? 1220669 4 jbedard 2016-08-16 17:08:32 -0700 (In reply to comment #3) > Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ? Looks like they are addressing the same issue. This change was made in more places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616, it's following the same pattern as if, else and while, among others. It also flags cases such as: [var1 , var2], [ & ] and [ ]. https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be interested how it does with the tests in this patch. 1220672 5 beidson 2016-08-16 17:11:30 -0700 (In reply to comment #4) > (In reply to comment #3) > > Is this the same issue as https://bugs.webkit.org/show_bug.cgi?id=125616 ? > > Looks like they are addressing the same issue. This change was made in more > places than the change in https://bugs.webkit.org/show_bug.cgi?id=125616, > it's following the same pattern as if, else and while, among others. > > It also flags cases such as: [var1 , var2], [ & ] and [ ]. > > https://bugs.webkit.org/show_bug.cgi?id=125616 is certainly simpler, I'd be > interested how it does with the tests in this patch. I didn't really mean is that patch the same as this patch - That patch was long ago abandoned. I meant that this bug is a dupe of that bug. 1220673 6 jbedard 2016-08-16 17:14:29 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > ... > > > > ... > > I didn't really mean is that patch the same as this patch - That patch was > long ago abandoned. > > I meant that this bug is a dupe of that bug. Yeah, I just looked at the date on that. Somehow I missed it. And yes, this would be a duplicate of that. 1221882 7 286204 commit-queue 2016-08-22 09:42:31 -0700 Comment on attachment 286204 Patch Clearing flags on attachment: 286204 Committed r204723: <http://trac.webkit.org/changeset/204723> 1221883 8 commit-queue 2016-08-22 09:42:35 -0700 All reviewed patches have been landed. Closing bug. 1223528 9 jbedard 2016-08-26 09:13:03 -0700 *** Bug 125616 has been marked as a duplicate of this bug. *** 286204 2016-08-16 14:31:29 -0700 2016-08-22 09:42:31 -0700 Patch bug-160910-20160816142943.patch text/plain 5332 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNDUyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE2LTA4LTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgZG9lcyBub3Qgd29yayB3aXRoIExhbWJk YSBmdW5jdGlvbnMgaW4gQysrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjA5MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGNoYW5nZSBlbGltaW5hdGVzIGZhbHNlIHBvc2l0aXZlcyBvbiBjb3Jy ZWN0bHkgc3R5bGVkIGxhbWJkYSBmdW5jdGlvbnMgYW5kIGluY2x1ZGVzIGEgZmV3IGJhc2ljIGNo ZWNrcyBvbiBjYXB0dXJlIGxpc3QuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKHJlZ2V4X2Zvcl9sYW1iZGFfZnVuY3Rpb25zKTog QWRkZWQgZnVuY3Rpb24gd2hpY2ggY2hlY2tzIGlmIGEgc3RyaW5nIGlzIHRoZSBzdGFydCBvZiBh IGxhbWJkYSBmdW5jdGlvbi4KKyAgICAgICAgKGNoZWNrX2Zvcl9ub25fc3RhbmRhcmRfY29uc3Ry dWN0cyk6IEFkZGVkIGxhbWJkYSBmdW5jdGlvbiBjaGVjay4KKyAgICAgICAgKGNoZWNrX3NwYWNp bmdfZm9yX2Z1bmN0aW9uX2NhbGwpOiBBZGRlZCBsYW1iZGEgZnVuY3Rpb24gY2hlY2suCisgICAg ICAgIChjaGVja19icmFjZXMpOiBBZGRlZCBsYW1iZGEgZnVuY3Rpb24gY2hlY2suCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAg ICAgIChDcHBTdHlsZVRlc3QudGVzdF9sYW1iZGFfZnVuY3Rpb25zKTogQWRkZWQgdGVzdCBmdW5j dGlvbiBmb3IgbGFtYmRhIGZ1bmN0aW9uIHN0eWxlIGNoZWNrcy4KKwogMjAxNi0wOC0xNSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBhZGRy ZXNzLW9mIG9wZXJhdG9yIHRvIFJldGFpblB0cgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkJKHJldmlzaW9uIDIwNDUyMSkKKysrIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0x MjgxLDYgKzEyODEsMjYgQEAgY2xhc3MgX0VudW1TdGF0ZShvYmplY3QpOgogICAgICAgICByZXR1 cm4gVHJ1ZQogCiAKK2RlZiByZWdleF9mb3JfbGFtYmRhX2Z1bmN0aW9ucyhsaW5lLCBsaW5lX251 bWJlciwgZXJyb3IpOgorICAgIHJlc3VsdCA9IHNlYXJjaChyJ1xzXFsuKj9cXVxzJywgbGluZSkK KyAgICBpZiByZXN1bHQ6CisgICAgICAgIGdyb3VwID0gcmVzdWx0Lmdyb3VwKCkKKworICAgICAg ICB0YXJnX2Vycm9yID0gTm9uZQorCisgICAgICAgIGlmIHNlYXJjaChyJyhcW1xzfFxzXF18XHMs KScsIGdyb3VwKToKKyAgICAgICAgICAgIHRhcmdfZXJyb3IgPSBbbGluZV9udW1iZXIsICd3aGl0 ZXNwYWNlL2JyYWNrZXRzJywgNCwKKyAgICAgICAgICAgICAgJ0V4dHJhIHNwYWNlIGluIGNhcHR1 cmUgbGlzdC4nXQorCisgICAgICAgIGlmIHRhcmdfZXJyb3IgYW5kIHJlZ2V4X2Zvcl9sYW1iZGFf ZnVuY3Rpb25zLl9fbGFzdF9lcnJvciAhPSB0YXJnX2Vycm9yOgorICAgICAgICAgICAgZXJyb3Io dGFyZ19lcnJvclswXSwgdGFyZ19lcnJvclsxXSwgdGFyZ19lcnJvclsyXSwgdGFyZ19lcnJvclsz XSkKKyAgICAgICAgcmVnZXhfZm9yX2xhbWJkYV9mdW5jdGlvbnMuX19sYXN0X2Vycm9yID0gdGFy Z19lcnJvcgorICAgICAgICByZXR1cm4gVHJ1ZQorICAgIHJldHVybiBGYWxzZQorCityZWdleF9m b3JfbGFtYmRhX2Z1bmN0aW9ucy5fX2xhc3RfZXJyb3IgPSBOb25lCisKKwogZGVmIGNoZWNrX2Zv cl9ub25fc3RhbmRhcmRfY29uc3RydWN0cyhjbGVhbl9saW5lcywgbGluZV9udW1iZXIsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNsYXNzX3N0YXRlLCBlcnJvcik6CiAg ICAgIiIiTG9ncyBhbiBlcnJvciBpZiB3ZSBzZWUgY2VydGFpbiBub24tQU5TSSBjb25zdHJ1Y3Rz IGlnbm9yZWQgYnkgZ2NjLTIuCkBAIC0xNDY5LDYgKzE0ODksOCBAQCBkZWYgY2hlY2tfc3BhY2lu Z19mb3JfZnVuY3Rpb25fY2FsbChsaW5lCiAgICAgIyB0aGV5J2xsIG5ldmVyIG5lZWQgdG8gd3Jh cC4KICAgICBpZiAoICAjIElnbm9yZSBjb250cm9sIHN0cnVjdHVyZXMuCiAgICAgICAgIG5vdCBz ZWFyY2gocidcYihpZnxmb3J8d2hpbGV8c3dpdGNofHJldHVybnxuZXd8ZGVsZXRlKVxiJywgZnVu Y3Rpb25fY2FsbCkKKyAgICAgICAgIyBJZ25vcmUgbGFtYmRhIGZ1bmN0aW9ucworICAgICAgICBh bmQgbm90IHJlZ2V4X2Zvcl9sYW1iZGFfZnVuY3Rpb25zKGZ1bmN0aW9uX2NhbGwsIGxpbmVfbnVt YmVyLCBlcnJvcikKICAgICAgICAgIyBJZ25vcmUgcG9pbnRlcnMvcmVmZXJlbmNlcyB0byBmdW5j dGlvbnMuCiAgICAgICAgIGFuZCBub3Qgc2VhcmNoKHInIFwoW14pXStcKVwoW14pXSooXCl8LCQp JywgZnVuY3Rpb25fY2FsbCkKICAgICAgICAgIyBJZ25vcmUgcG9pbnRlcnMvcmVmZXJlbmNlcyB0 byBhcnJheXMuCkBAIC0yNDMxLDcgKzI0NTMsOCBAQCBkZWYgY2hlY2tfYnJhY2VzKGNsZWFuX2xp bmVzLCBsaW5lX251bWJlCiAgICAgICAgICMgYW5kICctICgnIGFuZCAnKyAoJyBmb3IgT2JqZWN0 aXZlLUMgbWV0aG9kcy4KICAgICAgICAgcHJldmlvdXNfbGluZSA9IGdldF9wcmV2aW91c19ub25f YmxhbmtfbGluZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIpWzBdCiAgICAgICAgIGlmICgobm90 IHNlYXJjaChyJ1s7On17KT1dXHMqJHxcKVxzKigoY29uc3R8b3ZlcnJpZGV8Y29uc3Qgb3ZlcnJp ZGUpXHMqKT8oLT5ccypcUyspP1xzKiQnLCBwcmV2aW91c19saW5lKQotICAgICAgICAgICAgIG9y IHNlYXJjaChyJ1xiKGlmfGZvcnx3aGlsZXxzd2l0Y2h8ZWxzZXxOU19FTlVNKVxiJywgcHJldmlv dXNfbGluZSkpCisgICAgICAgICAgICAgb3Igc2VhcmNoKHInXGIoaWZ8Zm9yfHdoaWxlfHN3aXRj aHxlbHNlfE5TX0VOVU0pXGInLCBwcmV2aW91c19saW5lKQorICAgICAgICAgICAgIG9yIHJlZ2V4 X2Zvcl9sYW1iZGFfZnVuY3Rpb25zKHByZXZpb3VzX2xpbmUsIGxpbmVfbnVtYmVyLCBlcnJvcikp CiAgICAgICAgICAgICBhbmQgcHJldmlvdXNfbGluZS5maW5kKCcjJykgPCAwCiAgICAgICAgICAg ICBhbmQgcHJldmlvdXNfbGluZS5maW5kKCctICgnKSAhPSAwCiAgICAgICAgICAgICBhbmQgcHJl dmlvdXNfbGluZS5maW5kKCcrICgnKSAhPSAwKToKQEAgLTI0NDAsNiArMjQ2Myw3IEBAIGRlZiBj aGVja19icmFjZXMoY2xlYW5fbGluZXMsIGxpbmVfbnVtYmUKICAgICBlbGlmIChzZWFyY2gocidc KVxzKigoKGNvbnN0fG92ZXJyaWRlKVxzKikqXHMqKT97XHMqJCcsIGxpbmUpCiAgICAgICAgICAg YW5kIGxpbmUuY291bnQoJygnKSA9PSBsaW5lLmNvdW50KCcpJykKICAgICAgICAgICBhbmQgbm90 IHNlYXJjaChyJyhccyooaWZ8Zm9yfHdoaWxlfHN3aXRjaHxOU19FTlVNfEBzeW5jaHJvbml6ZWQp fH0gQGNhdGNoKVxiJywgbGluZSkKKyAgICAgICAgICBhbmQgbm90IHJlZ2V4X2Zvcl9sYW1iZGFf ZnVuY3Rpb25zKGxpbmUsIGxpbmVfbnVtYmVyLCBlcnJvcikKICAgICAgICAgICBhbmQgbGluZS5m aW5kKCJdKCIpIDwgMAogICAgICAgICAgIGFuZCBub3QgbWF0Y2gocidccytbQS1aX11bQS1aXzAt OV0rXGInLCBsaW5lKSk6CiAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9i cmFjZXMnLCA0LApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHBfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkJKHJldmlzaW9uIDIwNDUyMSkKKysrIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNv cHkpCkBAIC0xODgyLDYgKzE4ODIsMTQgQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVz dEJhc2UpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCdpbnQgbWFpbihpbnQgYXJnYywgY2hh ciogYWdydiBbXSknLCAnRXh0cmEgc3BhY2UgYmVmb3JlIFsuICBbd2hpdGVzcGFjZS9icmFja2V0 c10gWzVdJykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgIHN0ciBbc3RyTGVuZ3RoXSA9 IFwnXFwwXCc7JywgJ0V4dHJhIHNwYWNlIGJlZm9yZSBbLiAgW3doaXRlc3BhY2UvYnJhY2tldHNd IFs1XScpCiAKKyAgICBkZWYgdGVzdF9sYW1iZGFfZnVuY3Rpb25zKHNlbGYpOgorICAgICAgICBz ZWxmLmFzc2VydF9saW50KCcgICAgICAgIFsmXSAoVHlwZSBhcmd1bWVudCkgeycsICcnKQorICAg ICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgICAgIFtdIHsnLCAnJykKKyAgICAgICAgc2VsZi5h c3NlcnRfbGludCgnICAgICAgICBbID1dIChUeXBlIGFyZ3VtZW50KSB7JywgJ0V4dHJhIHNwYWNl IGluIGNhcHR1cmUgbGlzdC4gIFt3aGl0ZXNwYWNlL2JyYWNrZXRzXSBbNF0nKQorICAgICAgICBz ZWxmLmFzc2VydF9saW50KCcgICAgICAgIFt2YXIsIHZhcl9yZWYmXSB7JywgJycpCisgICAgICAg IHNlbGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgW3ZhciAsIHZhcl9yZWYmXSB7JywgJ0V4dHJhIHNw YWNlIGluIGNhcHR1cmUgbGlzdC4gIFt3aGl0ZXNwYWNlL2JyYWNrZXRzXSBbNF0nKQorICAgICAg ICBzZWxmLmFzc2VydF9saW50KCcgICAgICAgIFt2YXIsdmFyX3JlZiZdIHsnLCAnTWlzc2luZyBz cGFjZSBhZnRlciAsICBbd2hpdGVzcGFjZS9jb21tYV0gWzNdJykKKwogICAgIGRlZiB0ZXN0X3Nw YWNpbmdfYXJvdW5kX2Vsc2Uoc2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ31lbHNl IHsnLCAnTWlzc2luZyBzcGFjZSBiZWZvcmUgZWxzZScKICAgICAgICAgICAgICAgICAgICAgICAg ICAnICBbd2hpdGVzcGFjZS9icmFjZXNdIFs1XScpCg==