<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>160853</bug_id>
          
          <creation_ts>2016-08-15 09:43:28 -0700</creation_ts>
          <short_desc>WebKit should unset event propagation flags after dispatch</short_desc>
          <delta_ts>2016-08-19 08:38:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>https://github.com/whatwg/dom/commit/806d4aab584f6fc38c21f8e088b51b8ba3e27e20</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>WebExposed</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>160980</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>kangil.han</cc>
    
    <cc>rniwa</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1220045</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-08-15 09:43:28 -0700</bug_when>
    <thetext>WebKit should unset event propagation flags after dispatch to reflect the latest DOM specification:
- https://github.com/whatwg/dom/commit/806d4aab584f6fc38c21f8e088b51b8ba3e27e20</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1220285</commentid>
    <comment_count>1</comment_count>
      <attachid>286132</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-08-15 18:33:23 -0700</bug_when>
    <thetext>Created attachment 286132
WIP patch

Looks like some web-platform-tests need to be fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1220303</commentid>
    <comment_count>2</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-08-15 19:17:36 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Created attachment 286132 [details]
&gt; WIP patch
&gt; 
&gt; Looks like some web-platform-tests need to be fixed.

https://github.com/w3c/web-platform-tests/pull/3469</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221302</commentid>
    <comment_count>3</comment_count>
      <attachid>286431</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-08-18 19:52:28 -0700</bug_when>
    <thetext>Created attachment 286431
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221304</commentid>
    <comment_count>4</comment_count>
      <attachid>286431</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2016-08-18 20:02:40 -0700</bug_when>
    <thetext>Comment on attachment 286431
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286431&amp;action=review

&gt; Source/WebCore/dom/EventDispatcher.cpp:190
&gt; -    event.setEventPhase(0);
&gt; +    event.resetPropagationFlags();
&gt; +    event.setEventPhase(Event::NONE);

Should we combine these two functions? e.g. resetEventPhaseAndPropagationFlags?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221305</commentid>
    <comment_count>5</comment_count>
      <attachid>286431</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-08-18 20:03:56 -0700</bug_when>
    <thetext>Comment on attachment 286431
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286431&amp;action=review

&gt;&gt; Source/WebCore/dom/EventDispatcher.cpp:190
&gt;&gt; +    event.setEventPhase(Event::NONE);
&gt; 
&gt; Should we combine these two functions? e.g. resetEventPhaseAndPropagationFlags?

I don&apos;t know if it is worth it. We anyway need to keep the setEventPhase() setter.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221306</commentid>
    <comment_count>6</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2016-08-18 20:04:56 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Comment on attachment 286431 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=286431&amp;action=review
&gt; 
&gt; &gt;&gt; Source/WebCore/dom/EventDispatcher.cpp:190
&gt; &gt;&gt; +    event.setEventPhase(Event::NONE);
&gt; &gt; 
&gt; &gt; Should we combine these two functions? e.g. resetEventPhaseAndPropagationFlags?
&gt; 
&gt; I don&apos;t know if it is worth it. We anyway need to keep the setEventPhase()
&gt; setter.

But whenever we call resetPropagationFlags, we should be also resetting the phase, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221307</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-08-18 20:08:01 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #5)
&gt; &gt; Comment on attachment 286431 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; https://bugs.webkit.org/attachment.cgi?id=286431&amp;action=review
&gt; &gt; 
&gt; &gt; &gt;&gt; Source/WebCore/dom/EventDispatcher.cpp:190
&gt; &gt; &gt;&gt; +    event.setEventPhase(Event::NONE);
&gt; &gt; &gt; 
&gt; &gt; &gt; Should we combine these two functions? e.g. resetEventPhaseAndPropagationFlags?
&gt; &gt; 
&gt; &gt; I don&apos;t know if it is worth it. We anyway need to keep the setEventPhase()
&gt; &gt; setter.
&gt; 
&gt; But whenever we call resetPropagationFlags, we should be also resetting the
&gt; phase, right?

Yes, among other things, like clearing the event path and the currentTarget. Yet I don&apos;t feel they are strictly related.

From the spec:
[...]
- Unset event’s dispatch flag, stop propagation flag, and stop immediate propagation flag.
- Set event’s eventPhase attribute to NONE.
- Set event’s currentTarget attribute to null.
- Set event’s path to the empty list.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221310</commentid>
    <comment_count>8</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2016-08-18 20:11:58 -0700</bug_when>
    <thetext>FWIW, I don’t feel strongly about so you can go ahead &amp; land it. It was just a suggestion.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221321</commentid>
    <comment_count>9</comment_count>
      <attachid>286431</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-08-18 21:35:54 -0700</bug_when>
    <thetext>Comment on attachment 286431
Patch

Rejecting attachment 286431 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-03&apos;, &apos;land-attachment&apos;, &apos;--force-clean&apos;, &apos;--non-interactive&apos;, &apos;--parent-command=commit-queue&apos;, 286431, &apos;--port=mac&apos;]&quot; exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
org/repository/webkit/trunk ...
RA layer request failed: Unable to connect to a repository at URL &apos;http://svn.webkit.org/repository/webkit/trunk&apos;: OPTIONS of &apos;http://svn.webkit.org/repository/webkit/trunk&apos;: could not connect to server (http://svn.webkit.org) at /Applications/Xcode.app/Contents/Developer/usr/libexec/git-core/git-svn line 1032.


Failed to run &quot;[&apos;git&apos;, &apos;svn&apos;, &apos;dcommit&apos;, &apos;--rmdir&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/1896706</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221363</commentid>
    <comment_count>10</comment_count>
      <attachid>286431</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-08-19 08:38:34 -0700</bug_when>
    <thetext>Comment on attachment 286431
Patch

Clearing flags on attachment: 286431

Committed r204630: &lt;http://trac.webkit.org/changeset/204630&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1221364</commentid>
    <comment_count>11</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-08-19 08:38:39 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>286132</attachid>
            <date>2016-08-15 18:33:23 -0700</date>
            <delta_ts>2016-08-18 19:52:24 -0700</delta_ts>
            <desc>WIP patch</desc>
            <filename>160853_dispatch_resetFlags_wip.patch</filename>
            <type>text/plain</type>
            <size>4335</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv
ZG9tL2V2ZW50cy9FdmVudC1kaXNwYXRjaC1tdWx0aXBsZS1zdG9wUHJvcGFnYXRpb24tZXhwZWN0
ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20v
ZXZlbnRzL0V2ZW50LWRpc3BhdGNoLW11bHRpcGxlLXN0b3BQcm9wYWdhdGlvbi1leHBlY3RlZC50
eHQKaW5kZXggYTBkOGI4My4uMWZjZWJmMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0
ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2ZW50LWRpc3BhdGNoLW11bHRp
cGxlLXN0b3BQcm9wYWdhdGlvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0
ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2ZW50LWRpc3BhdGNoLW11bHRp
cGxlLXN0b3BQcm9wYWdhdGlvbi1leHBlY3RlZC50eHQKQEAgLTEsMyArMSwzIEBACiAKLUZBSUwg
IE11bHRpcGxlIGRpc3BhdGNoRXZlbnQoKSBhbmQgc3RvcFByb3BhZ2F0aW9uKCkgIGFzc2VydF9h
cnJheV9lcXVhbHM6IGxlbmd0aHMgZGlmZmVyLCBleHBlY3RlZCAxIGdvdCAwCitQQVNTICBNdWx0
aXBsZSBkaXNwYXRjaEV2ZW50KCkgYW5kIHN0b3BQcm9wYWdhdGlvbigpICAKIApkaWZmIC0tZ2l0
IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRz
L0V2ZW50LWluaXRFdmVudC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv
d2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ldmVudHMvRXZlbnQtaW5pdEV2ZW50LWV4cGVjdGVkLnR4
dAppbmRleCBmM2Y0YmYxLi40NDNhOGM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRl
ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ldmVudHMvRXZlbnQtaW5pdEV2ZW50LWV4cGVj
dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz
L2RvbS9ldmVudHMvRXZlbnQtaW5pdEV2ZW50LWV4cGVjdGVkLnR4dApAQCAtNiw2ICs2LDYgQEAg
UEFTUyBQcm9wZXJ0aWVzIG9mIGluaXRFdmVudCh0eXBlLCBmYWxzZSwgZmFsc2UpCiBQQVNTIENh
bGxpbmcgaW5pdEV2ZW50IG11bHRpcGxlIHRpbWVzIChnZXR0aW5nIHR5cGUpLiAKIFBBU1MgQ2Fs
bGluZyBpbml0RXZlbnQgbXVsdGlwbGUgdGltZXMgKG5vdCBnZXR0aW5nIHR5cGUpLiAKIFBBU1Mg
Q2FsbGluZyBpbml0RXZlbnQgbXVzdCBub3QgaGF2ZSBhbiBlZmZlY3QgZHVyaW5nIGRpc3BhdGNo
aW5nLiAKLVBBU1MgQ2FsbGluZyBpbml0RXZlbnQgbXVzdCB1bnNldCB0aGUgc3RvcCBwcm9wYWdh
dGlvbiBmbGFnLiAKK0ZBSUwgQ2FsbGluZyBpbml0RXZlbnQgbXVzdCB1bnNldCB0aGUgc3RvcCBw
cm9wYWdhdGlvbiBmbGFnLiBhc3NlcnRfdW5yZWFjaGVkOiBSZWFjaGVkIHVucmVhY2hhYmxlIGNv
ZGUKIFBBU1MgQ2FsbGluZyBpbml0RXZlbnQgZHVyaW5nIHByb3BhZ2F0aW9uLiAKIApkaWZmIC0t
Z2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZl
bnRzL0V2ZW50LXByb3BhZ2F0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVk
L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2V2ZW50cy9FdmVudC1wcm9wYWdhdGlvbi1leHBl
Y3RlZC50eHQKaW5kZXggYWYwNDI0Ny4uNGVkOTk0MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv
aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2ZW50LXByb3BhZ2F0
aW9uLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRm
b3JtLXRlc3RzL2RvbS9ldmVudHMvRXZlbnQtcHJvcGFnYXRpb24tZXhwZWN0ZWQudHh0CkBAIC0x
LDcgKzEsNyBAQAogCiBQQVNTIE5ld2x5LWNyZWF0ZWQgRXZlbnQgCi1QQVNTIEFmdGVyIHN0b3BQ
cm9wYWdhdGlvbigpIAorRkFJTCBBZnRlciBzdG9wUHJvcGFnYXRpb24oKSBhc3NlcnRfZXF1YWxz
OiBQcm9wYWdhdGlvbiBmbGFnIGV4cGVjdGVkIGZhbHNlIGJ1dCBnb3QgdHJ1ZQogUEFTUyBSZWlu
aXRpYWxpemVkIGFmdGVyIHN0b3BQcm9wYWdhdGlvbigpIAotUEFTUyBBZnRlciBzdG9wSW1tZWRp
YXRlUHJvcGFnYXRpb24oKSAKK0ZBSUwgQWZ0ZXIgc3RvcEltbWVkaWF0ZVByb3BhZ2F0aW9uKCkg
YXNzZXJ0X2VxdWFsczogUHJvcGFnYXRpb24gZmxhZyBleHBlY3RlZCBmYWxzZSBidXQgZ290IHRy
dWUKIFBBU1MgUmVpbml0aWFsaXplZCBhZnRlciBzdG9wSW1tZWRpYXRlUHJvcGFnYXRpb24oKSAK
IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmggYi9Tb3VyY2UvV2ViQ29y
ZS9kb20vRXZlbnQuaAppbmRleCAwNTRiYTM1Li5lOTlkYTUwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViQ29yZS9kb20vRXZlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaApAQCAt
MTY2LDYgKzE2Niw4IEBAIHB1YmxpYzoKICAgICBib29sIHByb3BhZ2F0aW9uU3RvcHBlZCgpIGNv
bnN0IHsgcmV0dXJuIG1fcHJvcGFnYXRpb25TdG9wcGVkIHx8IG1faW1tZWRpYXRlUHJvcGFnYXRp
b25TdG9wcGVkOyB9CiAgICAgYm9vbCBpbW1lZGlhdGVQcm9wYWdhdGlvblN0b3BwZWQoKSBjb25z
dCB7IHJldHVybiBtX2ltbWVkaWF0ZVByb3BhZ2F0aW9uU3RvcHBlZDsgfQogCisgICAgdm9pZCBy
ZXNldFByb3BhZ2F0aW9uRmxhZ3MoKTsKKwogICAgIGJvb2wgZGVmYXVsdFByZXZlbnRlZCgpIGNv
bnN0IHsgcmV0dXJuIG1fZGVmYXVsdFByZXZlbnRlZDsgfQogICAgIHZvaWQgcHJldmVudERlZmF1
bHQoKQogICAgIHsKQEAgLTIyNyw2ICsyMjksMTIgQEAgcHJpdmF0ZToKICAgICBSZWZQdHI8RXZl
bnQ+IG1fdW5kZXJseWluZ0V2ZW50OwogfTsKIAoraW5saW5lIHZvaWQgRXZlbnQ6OnJlc2V0UHJv
cGFnYXRpb25GbGFncygpCit7CisgICAgbV9wcm9wYWdhdGlvblN0b3BwZWQgPSBmYWxzZTsKKyAg
ICBtX2ltbWVkaWF0ZVByb3BhZ2F0aW9uU3RvcHBlZCA9IGZhbHNlOworfQorCiB9IC8vIG5hbWVz
cGFjZSBXZWJDb3JlCiAKICNkZWZpbmUgU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19FVkVOVChUb1Zh
bHVlVHlwZU5hbWUpIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3Bh
dGNoZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAKaW5kZXgg
NzA4ODAxNy4uNWQwNmEwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlz
cGF0Y2hlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAK
QEAgLTE4Niw3ICsxODYsOCBAQCBib29sIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudChO
b2RlKiBvcmlnaW4sIEV2ZW50JiBldmVudCkKIAogICAgIGV2ZW50LnNldFRhcmdldChFdmVudFBh
dGg6OmV2ZW50VGFyZ2V0UmVzcGVjdGluZ1RhcmdldFJ1bGVzKCpub2RlKSk7CiAgICAgZXZlbnQu
c2V0Q3VycmVudFRhcmdldChudWxscHRyKTsKLSAgICBldmVudC5zZXRFdmVudFBoYXNlKDApOwor
ICAgIGV2ZW50LnJlc2V0UHJvcGFnYXRpb25GbGFncygpOworICAgIGV2ZW50LnNldEV2ZW50UGhh
c2UoRXZlbnQ6Ok5PTkUpOwogCiAgICAgaWYgKGNsaWNrSGFuZGxpbmdTdGF0ZS5zdGF0ZWZ1bCkK
ICAgICAgICAgZG93bmNhc3Q8SFRNTElucHV0RWxlbWVudD4oKm5vZGUpLmRpZERpc3BhdGNoQ2xp
Y2tFdmVudChldmVudCwgY2xpY2tIYW5kbGluZ1N0YXRlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X
ZWJDb3JlL2RvbS9FdmVudFRhcmdldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRUYXJn
ZXQuY3BwCmluZGV4IGI3YTMyZDQuLjE5NmU4NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L2RvbS9FdmVudFRhcmdldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0
LmNwcApAQCAtMTYyLDcgKzE2Miw4IEBAIGJvb2wgRXZlbnRUYXJnZXQ6OmRpc3BhdGNoRXZlbnQo
RXZlbnQmIGV2ZW50KQogICAgIGV2ZW50LnNldEN1cnJlbnRUYXJnZXQodGhpcyk7CiAgICAgZXZl
bnQuc2V0RXZlbnRQaGFzZShFdmVudDo6QVRfVEFSR0VUKTsKICAgICBib29sIGRlZmF1bHRQcmV2
ZW50ZWQgPSBmaXJlRXZlbnRMaXN0ZW5lcnMoZXZlbnQpOwotICAgIGV2ZW50LnNldEV2ZW50UGhh
c2UoMCk7CisgICAgZXZlbnQucmVzZXRQcm9wYWdhdGlvbkZsYWdzKCk7CisgICAgZXZlbnQuc2V0
RXZlbnRQaGFzZShFdmVudDo6Tk9ORSk7CiAgICAgcmV0dXJuIGRlZmF1bHRQcmV2ZW50ZWQ7CiB9
CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>286431</attachid>
            <date>2016-08-18 19:52:28 -0700</date>
            <delta_ts>2016-08-19 08:38:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-160853-20160818195038.patch</filename>
            <type>text/plain</type>
            <size>5921</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGM0ZGYwNmUwYmM1ZmQ5
NDVmMzA0YzY4YmE1M2NkZTBiNGJhMTE0OS4uNzhjNjUxNjQyZjRlNDE3ODcyZTI5NWQ1YTUxOWI0
MjI2MzZhYzA0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA4LTE4ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0IHNob3VsZCB1bnNl
dCBldmVudCBwcm9wYWdhdGlvbiBmbGFncyBhZnRlciBkaXNwYXRjaAorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwODUzCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0IHNob3VsZCB1bnNldCBldmVu
dCBwcm9wYWdhdGlvbiBmbGFncyBhZnRlciBkaXNwYXRjaCB0byByZWZsZWN0CisgICAgICAgIHRo
ZSBsYXRlc3QgRE9NIHNwZWNpZmljYXRpb246CisgICAgICAgIC0gaHR0cHM6Ly9naXRodWIuY29t
L3doYXR3Zy9kb20vY29tbWl0LzgwNmQ0YWFiNTg0ZjZmYzM4YzIxZjhlMDg4YjUxYjhiYTNlMjdl
MjAKKworICAgICAgICBObyBuZXcgdGVzdHMsIHJlYmFzZWxpbmVkIGV4aXN0aW5nIHRlc3RzLgor
CisgICAgICAgICogZG9tL0V2ZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpFdmVudDo6cmVzZXRQ
cm9wYWdhdGlvbkZsYWdzKToKKyAgICAgICAgKiBkb20vRXZlbnREaXNwYXRjaGVyLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OkV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudCk6CisgICAgICAg
ICogZG9tL0V2ZW50VGFyZ2V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50VGFyZ2V0Ojpk
aXNwYXRjaEV2ZW50KToKKwogMjAxNi0wOC0xOCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBh
cHBsZS5jb20+CiAKICAgICAgICAgQmluZGluZyBOVUxMIHBvaW50ZXIgdG8gcmVmZXJlbmNlIGlu
IFdlYkNvcmU6OlJlbmRlck9iamVjdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2
ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaAppbmRleCAwNTRiYTM1OWE3NDZhOWEw
Njg2Zjg2OTkwOGVkNDFiMzIzMmQyZTgzLi5lOTlkYTUwZmZhYzFkNmM0NWNlODgyZmY1NjliODZi
MmJkNTUzYzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaAorKysgYi9T
b3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaApAQCAtMTY2LDYgKzE2Niw4IEBAIHB1YmxpYzoKICAg
ICBib29sIHByb3BhZ2F0aW9uU3RvcHBlZCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJvcGFnYXRpb25T
dG9wcGVkIHx8IG1faW1tZWRpYXRlUHJvcGFnYXRpb25TdG9wcGVkOyB9CiAgICAgYm9vbCBpbW1l
ZGlhdGVQcm9wYWdhdGlvblN0b3BwZWQoKSBjb25zdCB7IHJldHVybiBtX2ltbWVkaWF0ZVByb3Bh
Z2F0aW9uU3RvcHBlZDsgfQogCisgICAgdm9pZCByZXNldFByb3BhZ2F0aW9uRmxhZ3MoKTsKKwog
ICAgIGJvb2wgZGVmYXVsdFByZXZlbnRlZCgpIGNvbnN0IHsgcmV0dXJuIG1fZGVmYXVsdFByZXZl
bnRlZDsgfQogICAgIHZvaWQgcHJldmVudERlZmF1bHQoKQogICAgIHsKQEAgLTIyNyw2ICsyMjks
MTIgQEAgcHJpdmF0ZToKICAgICBSZWZQdHI8RXZlbnQ+IG1fdW5kZXJseWluZ0V2ZW50OwogfTsK
IAoraW5saW5lIHZvaWQgRXZlbnQ6OnJlc2V0UHJvcGFnYXRpb25GbGFncygpCit7CisgICAgbV9w
cm9wYWdhdGlvblN0b3BwZWQgPSBmYWxzZTsKKyAgICBtX2ltbWVkaWF0ZVByb3BhZ2F0aW9uU3Rv
cHBlZCA9IGZhbHNlOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNkZWZpbmUgU1BF
Q0lBTElaRV9UWVBFX1RSQUlUU19FVkVOVChUb1ZhbHVlVHlwZU5hbWUpIFwKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudERpc3BhdGNoZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv
ZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAKaW5kZXggNzA4ODAxN2IwMTg2MjI0OWQxMTI5YzRjMGQ2
MTA2MDg2MTA2MmIwMy4uNWQwNmEwMGIzODJlMGZkMzY2MTdkMTg1ZDNlMjcxZTMwMDg1MjA5NyAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAKKysrIGIv
U291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHAKQEAgLTE4Niw3ICsxODYsOCBA
QCBib29sIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudChOb2RlKiBvcmlnaW4sIEV2ZW50
JiBldmVudCkKIAogICAgIGV2ZW50LnNldFRhcmdldChFdmVudFBhdGg6OmV2ZW50VGFyZ2V0UmVz
cGVjdGluZ1RhcmdldFJ1bGVzKCpub2RlKSk7CiAgICAgZXZlbnQuc2V0Q3VycmVudFRhcmdldChu
dWxscHRyKTsKLSAgICBldmVudC5zZXRFdmVudFBoYXNlKDApOworICAgIGV2ZW50LnJlc2V0UHJv
cGFnYXRpb25GbGFncygpOworICAgIGV2ZW50LnNldEV2ZW50UGhhc2UoRXZlbnQ6Ok5PTkUpOwog
CiAgICAgaWYgKGNsaWNrSGFuZGxpbmdTdGF0ZS5zdGF0ZWZ1bCkKICAgICAgICAgZG93bmNhc3Q8
SFRNTElucHV0RWxlbWVudD4oKm5vZGUpLmRpZERpc3BhdGNoQ2xpY2tFdmVudChldmVudCwgY2xp
Y2tIYW5kbGluZ1N0YXRlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudFRh
cmdldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRUYXJnZXQuY3BwCmluZGV4IGJhZTNl
YzJiNDM3MTcwMzE0YzU3NzFkNTU4MmYyMWJhZGJlZjQ4ODUuLmY2NTU1ZWUzODM5NDU5NTU4ZDBl
NDk2ZmY5OGE2ODU5YzkxNWNiYTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVu
dFRhcmdldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50VGFyZ2V0LmNwcApAQCAt
MTYyLDcgKzE2Miw4IEBAIGJvb2wgRXZlbnRUYXJnZXQ6OmRpc3BhdGNoRXZlbnQoRXZlbnQmIGV2
ZW50KQogICAgIGV2ZW50LnNldEN1cnJlbnRUYXJnZXQodGhpcyk7CiAgICAgZXZlbnQuc2V0RXZl
bnRQaGFzZShFdmVudDo6QVRfVEFSR0VUKTsKICAgICBib29sIGRlZmF1bHRQcmV2ZW50ZWQgPSBm
aXJlRXZlbnRMaXN0ZW5lcnMoZXZlbnQpOwotICAgIGV2ZW50LnNldEV2ZW50UGhhc2UoMCk7Cisg
ICAgZXZlbnQucmVzZXRQcm9wYWdhdGlvbkZsYWdzKCk7CisgICAgZXZlbnQuc2V0RXZlbnRQaGFz
ZShFdmVudDo6Tk9ORSk7CiAgICAgcmV0dXJuIGRlZmF1bHRQcmV2ZW50ZWQ7CiB9CiAKZGlmZiAt
LWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9p
bXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDk2NjBmMjM0MjJmMDc1MTU2OTEwMmI1OTgzOWFj
NTAzOTViOTIwZWYuLjFjMjEyZmZhZjQ4ZDQ4MmRkOWFlNTkzYjU3NTcwNjdhNGM3MWY1MWMgMTAw
NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0
VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTA4LTE4
ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViS2l0IHNob3Vs
ZCB1bnNldCBldmVudCBwcm9wYWdhdGlvbiBmbGFncyBhZnRlciBkaXNwYXRjaAorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwODUzCisKKyAgICAgICAg
UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBzZXZlcmFs
IFczQyB0ZXN0cyBub3cgdGhhdCBtb3JlIGNoZWNrcyBhcmUgcGFzc2luZy4KKworICAgICAgICAq
IHdlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2ZW50LWRpc3BhdGNoLW11bHRpcGxlLXN0
b3BQcm9wYWdhdGlvbi1leHBlY3RlZC50eHQ6CisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3Rz
L2RvbS9ldmVudHMvRXZlbnQtaW5pdEV2ZW50LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB3ZWIt
cGxhdGZvcm0tdGVzdHMvZG9tL2V2ZW50cy9FdmVudC1wcm9wYWdhdGlvbi1leHBlY3RlZC50eHQ6
CisKKzIwMTYtMDgtMTggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAg
ICBSZS1zeW5jIERPTSB3ZWIgcGxhdGZvcm0gdGVzdHMgZnJvbSB1cHN0cmVhbQogICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwOTgwCiAKZGlmZiAtLWdp
dCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2V2ZW50
cy9FdmVudC1kaXNwYXRjaC1tdWx0aXBsZS1zdG9wUHJvcGFnYXRpb24tZXhwZWN0ZWQudHh0IGIv
TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2
ZW50LWRpc3BhdGNoLW11bHRpcGxlLXN0b3BQcm9wYWdhdGlvbi1leHBlY3RlZC50eHQKaW5kZXgg
YTBkOGI4Mzk3MGI5NDM2OTY2YzQ5MTA0Mjk3N2YzODg2NTYyNTEzNS4uMWZjZWJmMTk0ZGVkZTA1
NDI5ZjA3NTZjNjFlM2JiN2Y2N2U4YzRlNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0
ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2ZW50LWRpc3BhdGNoLW11bHRp
cGxlLXN0b3BQcm9wYWdhdGlvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0
ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2ZW50LWRpc3BhdGNoLW11bHRp
cGxlLXN0b3BQcm9wYWdhdGlvbi1leHBlY3RlZC50eHQKQEAgLTEsMyArMSwzIEBACiAKLUZBSUwg
IE11bHRpcGxlIGRpc3BhdGNoRXZlbnQoKSBhbmQgc3RvcFByb3BhZ2F0aW9uKCkgIGFzc2VydF9h
cnJheV9lcXVhbHM6IGxlbmd0aHMgZGlmZmVyLCBleHBlY3RlZCAxIGdvdCAwCitQQVNTICBNdWx0
aXBsZSBkaXNwYXRjaEV2ZW50KCkgYW5kIHN0b3BQcm9wYWdhdGlvbigpICAKIApkaWZmIC0tZ2l0
IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRz
L0V2ZW50LXByb3BhZ2F0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz
Yy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2V2ZW50cy9FdmVudC1wcm9wYWdhdGlvbi1leHBlY3Rl
ZC50eHQKaW5kZXggOGNjZWNkMGJiMmE0MGVjMjQ0M2I4MDcxOTliODAwNzk5YmE3ZDYxMi4uYWYw
NDI0NzA1NDc5ZWZjZWI3NTM5NjYzNTc0NTBlOTlhODkxMzYyNyAxMDA2NDQKLS0tIGEvTGF5b3V0
VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vZXZlbnRzL0V2ZW50LXBy
b3BhZ2F0aW9uLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi
LXBsYXRmb3JtLXRlc3RzL2RvbS9ldmVudHMvRXZlbnQtcHJvcGFnYXRpb24tZXhwZWN0ZWQudHh0
CkBAIC0xLDcgKzEsNyBAQAogCiBQQVNTIE5ld2x5LWNyZWF0ZWQgRXZlbnQgCi1GQUlMIEFmdGVy
IHN0b3BQcm9wYWdhdGlvbigpIGFzc2VydF9lcXVhbHM6IFByb3BhZ2F0aW9uIGZsYWcgYWZ0ZXIg
Zmlyc3QgZGlzcGF0Y2ggZXhwZWN0ZWQgdHJ1ZSBidXQgZ290IGZhbHNlCitQQVNTIEFmdGVyIHN0
b3BQcm9wYWdhdGlvbigpIAogUEFTUyBSZWluaXRpYWxpemVkIGFmdGVyIHN0b3BQcm9wYWdhdGlv
bigpIAotRkFJTCBBZnRlciBzdG9wSW1tZWRpYXRlUHJvcGFnYXRpb24oKSBhc3NlcnRfZXF1YWxz
OiBQcm9wYWdhdGlvbiBmbGFnIGFmdGVyIGZpcnN0IGRpc3BhdGNoIGV4cGVjdGVkIHRydWUgYnV0
IGdvdCBmYWxzZQorUEFTUyBBZnRlciBzdG9wSW1tZWRpYXRlUHJvcGFnYXRpb24oKSAKIFBBU1Mg
UmVpbml0aWFsaXplZCBhZnRlciBzdG9wSW1tZWRpYXRlUHJvcGFnYXRpb24oKSAKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>