160850 2016-08-15 07:35:42 -0700 [Win] Hardening of getLinkedFonts function. 2016-08-16 02:48:56 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue mmaxfield webkit-bug-importer oldest_to_newest 1220021 0 pvollan 2016-08-15 07:35:42 -0700 The SUCCEEDED macro should only be used for functions returning a HRESULT type. Also, make sure a string array index will not exceed the string length. 1220022 1 286053 pvollan 2016-08-15 08:03:05 -0700 Created attachment 286053 Patch 1220028 2 286053 bfulgham 2016-08-15 08:43:02 -0700 Comment on attachment 286053 Patch Interesting! I didn't know that SUCCEEDED was inappropriate here. Are there return values from RegQueryValueEx that might fool SUCCEEDED? It also makes me wonder if we should be using the FAILED macro a few lines above this one, since it also returns a LONG instead of an HRESULT. I also wonder if we should call "family.charactersWithNullTermination().data()" so many times -- I think (but didn't look) that it creates a new string each time we call that. r=me! :-) 1220042 3 pvollan 2016-08-15 09:39:20 -0700 (In reply to comment #2) > Comment on attachment 286053 [details] > Patch Thanks for reviewing :-) > > Interesting! I didn't know that SUCCEEDED was inappropriate here. Are there > return values from RegQueryValueEx that might fool SUCCEEDED? > Yes I believe there are. > It also makes me wonder if we should be using the FAILED macro a few lines > above this one, since it also returns a LONG instead of an HRESULT. > > I also wonder if we should call > "family.charactersWithNullTermination().data()" so many times -- I think > (but didn't look) that it creates a new string each time we call that. > Yes I believe you're right. I can look into that :-) 1220044 4 pvollan 2016-08-15 09:41:22 -0700 rdar://problem/17471209 1220049 5 286053 commit-queue 2016-08-15 09:45:52 -0700 Comment on attachment 286053 Patch Rejecting attachment 286053 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 286053, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/1875986 1220145 6 mmaxfield 2016-08-15 13:58:18 -0700 Please write a test for the comma change. 1220424 7 pvollan 2016-08-16 02:48:56 -0700 Committed r204502: <https://trac.webkit.org/changeset/204502> 286053 2016-08-15 08:03:05 -0700 2016-08-15 09:45:52 -0700 Patch bug-160850-20160815080124.patch text/plain 1967 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDQ2MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA4LTE1ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBIYXJkZW5pbmcg b2YgZ2V0TGlua2VkRm9udHMgZnVuY3Rpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA4NTAKKworICAgICAgICBUaGUgU1VDQ0VFREVEIG1hY3Jv IHNob3VsZCBvbmx5IGJlIHVzZWQgZm9yIGZ1bmN0aW9ucyByZXR1cm5pbmcgYSBIUkVTVUxUIHR5 cGUuCisgICAgICAgIEFsc28sIG1ha2Ugc3VyZSBhIHN0cmluZyBhcnJheSBpbmRleCB3aWxsIG5v dCBleGNlZWQgdGhlIHN0cmluZyBsZW5ndGguCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy93aW4vRm9udENhY2hlV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldExpbmtlZEZvbnRz KToKKwogMjAxNi0wOC0xNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAg ICAgIEFsaWduIHRoZSBldmVudCBsaXN0ZW5lciBmaXJpbmcgY29kZSB3aXRoIHRoZSBsYXRlc3Qg RE9NIFNwZWNpZmljYXRpb24gYW5kIHNpbXBsaWZ5IGl0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENhY2hlV2luLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRm9udENhY2hlV2luLmNwcAkocmV2aXNp b24gMjA0NDA3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ZvbnRD YWNoZVdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNiwxMiArMTE2LDE1IEBAIHN0YXRpYyBj b25zdCBWZWN0b3I8U3RyaW5nPiogZ2V0TGlua2VkRm8KICAgICB9CiAKICAgICBXQ0hBUiogbGlu a2VkRm9udHMgPSByZWludGVycHJldF9jYXN0PFdDSEFSKj4obWFsbG9jKGxpbmtlZEZvbnRzQnVm ZmVyU2l6ZSkpOwotICAgIGlmIChTVUNDRUVERUQoUmVnUXVlcnlWYWx1ZUV4KGZvbnRMaW5rS2V5 LCBmYW1pbHkuY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKS5kYXRhKCksIDAsIE5VTEws IHJlaW50ZXJwcmV0X2Nhc3Q8QllURSo+KGxpbmtlZEZvbnRzKSwgJmxpbmtlZEZvbnRzQnVmZmVy U2l6ZSkpKSB7CisgICAgaWYgKDo6UmVnUXVlcnlWYWx1ZUV4KGZvbnRMaW5rS2V5LCBmYW1pbHku Y2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKS5kYXRhKCksIDAsIG51bGxwdHIsIHJlaW50 ZXJwcmV0X2Nhc3Q8QllURSo+KGxpbmtlZEZvbnRzKSwgJmxpbmtlZEZvbnRzQnVmZmVyU2l6ZSkg PT0gRVJST1JfU1VDQ0VTUykgewogICAgICAgICB1bnNpZ25lZCBpID0gMDsKICAgICAgICAgdW5z aWduZWQgbGVuZ3RoID0gbGlua2VkRm9udHNCdWZmZXJTaXplIC8gc2l6ZW9mKCpsaW5rZWRGb250 cyk7CiAgICAgICAgIHdoaWxlIChpIDwgbGVuZ3RoKSB7CiAgICAgICAgICAgICB3aGlsZSAoaSA8 IGxlbmd0aCAmJiBsaW5rZWRGb250c1tpXSAhPSAnLCcpCiAgICAgICAgICAgICAgICAgaSsrOwor ICAgICAgICAgICAgLy8gQnJlYWsgaWYgd2UgZGlkIG5vdCBmaW5kIGEgY29tbWEuCisgICAgICAg ICAgICBpZiAoaSA9PSBsZW5ndGgpCisgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAg ICBpKys7CiAgICAgICAgICAgICB1bnNpZ25lZCBqID0gaTsKICAgICAgICAgICAgIHdoaWxlIChq IDwgbGVuZ3RoICYmIGxpbmtlZEZvbnRzW2pdKQo=