160842 2016-08-13 13:32:31 -0700 Allow using make-dist with non-GTK ports 2016-08-15 02:57:58 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen cgarcia commit-queue gyuyoung.kim lforschler mcatanzaro mrobinson oldest_to_newest 1219881 0 annulen 2016-08-13 13:32:31 -0700 We are successfully using make-dist.py in Qt port, and from IRC discussion with Gyuyoung Kim I've learned that EFl port is also interested in trying out this tool. This patch adds support for setting base name of tarball and argument passed to cmake's -DPORT= via command line arguments. 1219884 1 286005 annulen 2016-08-13 13:47:04 -0700 Created attachment 286005 Patch 1220007 2 286005 mcatanzaro 2016-08-15 01:36:27 -0700 Comment on attachment 286005 Patch Please move it out of the gtk subdirectory, to Tools/Scripts, get rid of the gtk defaults, and update whatever it is in the GTK build that calls these scripts to pass in the GTK-specific paths. 1220011 3 annulen 2016-08-15 02:36:00 -0700 I'll do it in a separate patch 1220013 4 286005 commit-queue 2016-08-15 02:57:52 -0700 Comment on attachment 286005 Patch Clearing flags on attachment: 286005 Committed r204460: <http://trac.webkit.org/changeset/204460> 1220014 5 commit-queue 2016-08-15 02:57:58 -0700 All reviewed patches have been landed. Closing bug. 286005 2016-08-13 13:47:04 -0700 2016-08-15 02:57:52 -0700 Patch bug-160842-20160813234522.patch text/plain 4083 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NDQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTQxOTFlMWE2YTA2ZWQ3YWZjZmZlMWNhODczYTdlMmIw ODU1MjYxNS4uNWE0YjgwZmNjOGU2YTRkN2UzNzAyYjc4MzhkYmU1ZDNhMDNkOTg5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTA4LTEzICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4K KworICAgICAgICBBbGxvdyB1c2luZyBtYWtlLWRpc3Qgd2l0aCBub24tR1RLIHBvcnRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA4NDIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFk ZHMgc3VwcG9ydCBmb3Igc2V0dGluZyBiYXNlIG5hbWUgb2YgdGFyYmFsbCBhbmQgYXJndW1lbnQK KyAgICAgICAgcGFzc2VkIHRvIGNtYWtlJ3MgLURQT1JUPSB2aWEgY29tbWFuZCBsaW5lIGFyZ3Vt ZW50cy4KKworICAgICAgICAqIGd0ay9tYWtlLWRpc3QucHk6CisgICAgICAgIChEaXN0Y2hlY2su Y29uZmlndXJlKToKKyAgICAgICAgKERpc3RjaGVjay5jaGVjayk6CisgICAgICAgIChnZXRfdGFy YmFsbF9yb290X2FuZF9vdXRwdXRfZmlsZW5hbWVfZnJvbV9hcmd1bWVudHMpOgorCiAyMDE2LTA4 LTEzICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIEluc3RhbGwgc2NyaXB0IGxhY2tzIGdzdHJlYW1lciByZWxhdGVkIGRlcGVu ZGVuY2llcwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL21ha2UtZGlzdC5weSBiL1Rvb2xzL2d0ay9t YWtlLWRpc3QucHkKaW5kZXggYjdmZWUyZTAwMmZhOWE1ODkyNDQwMDE5NmNlZmFlNTc2MzhkMzUw ZS4uNGYwYzRkNTg5MDUxODhhZmI2NDQ1MzcxNDZhYTg3NWNlZjdmMzk2ZCAxMDA3NTUKLS0tIGEv VG9vbHMvZ3RrL21ha2UtZGlzdC5weQorKysgYi9Ub29scy9ndGsvbWFrZS1kaXN0LnB5CkBAIC0y MzMsNyArMjMzLDcgQEAgY2xhc3MgRGlzdGNoZWNrKG9iamVjdCk6CiAgICAgICAgIHdpdGggY2xv c2luZyh0YXJmaWxlLm9wZW4odGFyYmFsbF9wYXRoLCAncicpKSBhcyB0YXJiYWxsOgogICAgICAg ICAgICAgdGFyYmFsbC5leHRyYWN0YWxsKHNlbGYuYnVpbGRfcm9vdCkKIAotICAgIGRlZiBjb25m aWd1cmUoc2VsZiwgZGlzdF9kaXIsIGJ1aWxkX2RpciwgaW5zdGFsbF9kaXIpOgorICAgIGRlZiBj b25maWd1cmUoc2VsZiwgZGlzdF9kaXIsIGJ1aWxkX2RpciwgaW5zdGFsbF9kaXIsIHBvcnQpOgog ICAgICAgICBkZWYgY3JlYXRlX2RpcihkaXJlY3RvcnksIGRpcmVjdG9yeV90eXBlKToKICAgICAg ICAgICAgIHRyeToKICAgICAgICAgICAgICAgICBvcy5ta2RpcihkaXJlY3RvcnkpCkBAIC0yNDQs NyArMjQ0LDcgQEAgY2xhc3MgRGlzdGNoZWNrKG9iamVjdCk6CiAgICAgICAgIGNyZWF0ZV9kaXIo YnVpbGRfZGlyLCAiYnVpbGQiKQogICAgICAgICBjcmVhdGVfZGlyKGluc3RhbGxfZGlyLCAiaW5z dGFsbCIpCiAKLSAgICAgICAgY29tbWFuZCA9IFsnY21ha2UnLCAnLURQT1JUPUdUSycsICctRENN QUtFX0lOU1RBTExfUFJFRklYPSVzJyAlIGluc3RhbGxfZGlyLCAnLURDTUFLRV9CVUlMRF9UWVBF PVJlbGVhc2UnLCBkaXN0X2Rpcl0KKyAgICAgICAgY29tbWFuZCA9IFsnY21ha2UnLCAnLURQT1JU PSVzJyAlIHBvcnQsICctRENNQUtFX0lOU1RBTExfUFJFRklYPSVzJyAlIGluc3RhbGxfZGlyLCAn LURDTUFLRV9CVUlMRF9UWVBFPVJlbGVhc2UnLCBkaXN0X2Rpcl0KICAgICAgICAgc3VicHJvY2Vz cy5jaGVja19jYWxsKGNvbW1hbmQsIGN3ZD1idWlsZF9kaXIpCiAKICAgICBkZWYgYnVpbGQoc2Vs ZiwgYnVpbGRfZGlyKToKQEAgLTI2MiwxNCArMjYyLDE0IEBAIGNsYXNzIERpc3RjaGVjayhvYmpl Y3QpOgogICAgIGRlZiBjbGVhbihzZWxmLCBkaXN0X2Rpcik6CiAgICAgICAgIHNodXRpbC5ybXRy ZWUoZGlzdF9kaXIpCiAKLSAgICBkZWYgY2hlY2soc2VsZiwgdGFyYmFsbCk6CisgICAgZGVmIGNo ZWNrKHNlbGYsIHRhcmJhbGwsIHBvcnQpOgogICAgICAgICB0YXJiYWxsX25hbWUsIGV4dCA9IG9z LnBhdGguc3BsaXRleHQob3MucGF0aC5iYXNlbmFtZSh0YXJiYWxsKSkKICAgICAgICAgZGlzdF9k aXIgPSBvcy5wYXRoLmpvaW4oc2VsZi5idWlsZF9yb290LCB0YXJiYWxsX25hbWUpCiAgICAgICAg IGJ1aWxkX2RpciA9IG9zLnBhdGguam9pbihkaXN0X2Rpciwgc2VsZi5CVUlMRF9ESVJFQ1RPUllf TkFNRSkKICAgICAgICAgaW5zdGFsbF9kaXIgPSBvcy5wYXRoLmpvaW4oZGlzdF9kaXIsIHNlbGYu SU5TVEFMTF9ESVJFQ1RPUllfTkFNRSkKIAogICAgICAgICBzZWxmLmV4dHJhY3RfdGFyYmFsbCh0 YXJiYWxsKQotICAgICAgICBzZWxmLmNvbmZpZ3VyZShkaXN0X2RpciwgYnVpbGRfZGlyLCBpbnN0 YWxsX2RpcikKKyAgICAgICAgc2VsZi5jb25maWd1cmUoZGlzdF9kaXIsIGJ1aWxkX2RpciwgaW5z dGFsbF9kaXIsIHBvcnQpCiAgICAgICAgIHNlbGYuYnVpbGQoYnVpbGRfZGlyKQogICAgICAgICBz ZWxmLmluc3RhbGwoYnVpbGRfZGlyKQogICAgICAgICBzZWxmLmNsZWFuKGRpc3RfZGlyKQpAQCAt MjkyLDcgKzI5Miw3IEBAIGlmIF9fbmFtZV9fID09ICJfX21haW5fXyI6CiAKIAogICAgIGRlZiBn ZXRfdGFyYmFsbF9yb290X2FuZF9vdXRwdXRfZmlsZW5hbWVfZnJvbV9hcmd1bWVudHMoYXJndW1l bnRzKToKLSAgICAgICAgdGFyYmFsbF9yb290ID0gIndlYmtpdGd0ayIKKyAgICAgICAgdGFyYmFs bF9yb290ID0gYXJndW1lbnRzLnRhcmJhbGxfbmFtZQogICAgICAgICBpZiBhcmd1bWVudHMudmVy c2lvbiBpcyBub3QgTm9uZToKICAgICAgICAgICAgIHRhcmJhbGxfcm9vdCArPSAnLScgKyBhcmd1 bWVudHMudmVyc2lvbgogCkBAIC0zMTAsNiArMzEwLDEwIEBAIGlmIF9fbmFtZV9fID09ICJfX21h aW5fXyI6CiAgICAgcGFyc2VyLmFkZF9hcmd1bWVudCgnLWInLCAnLS1idWlsZC1kaXInLCB0eXBl PXN0ciwgYWN0aW9uPUZpbGVQYXRoQWN0aW9uLCBkZWZhdWx0PW9zLmdldGN3ZCgpLAogICAgICAg ICAgICAgICAgICAgICAgICAgaGVscD0nVGhlIHRvcC1sZXZlbCBwYXRoIG9mIGRpcmVjdG9yeSBv ZiB0aGUgYnVpbGQgcm9vdC4gJyArIFwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdC eSBkZWZhdWx0IGlzIHRoZSBjdXJyZW50IGRpcmVjdG9yeS4nKQorICAgIHBhcnNlci5hZGRfYXJn dW1lbnQoJy10JywgJy0tdGFyYmFsbC1uYW1lJywgdHlwZT1zdHIsIGRlZmF1bHQ9J3dlYmtpdGd0 aycsCisgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSdCYXNlIG5hbWUgb2YgdGFyYmFsbC4g RGVmYXVsdHMgdG8gIndlYmtpdGd0ayIuJykKKyAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCctcCcs ICctLXBvcnQnLCB0eXBlPXN0ciwgZGVmYXVsdD0nR1RLJywKKyAgICAgICAgICAgICAgICAgICAg ICAgIGhlbHA9J1BvcnQgdG8gYmUgYnVpbHQgaW4gdGFyYmFsbCBjaGVjay4gRGVmYXVsdHMgdG8g IkdUSyIuJykKICAgICBwYXJzZXIuYWRkX2FyZ3VtZW50KCdtYW5pZmVzdF9maWxlbmFtZScsIG1l dGF2YXI9Im1hbmlmZXN0IiwgdHlwZT1zdHIsIGFjdGlvbj1GaWxlUGF0aEFjdGlvbiwgaGVscD0n VGhlIHBhdGggdG8gdGhlIG1hbmlmZXN0IGZpbGUuJykKIAogICAgIGFyZ3VtZW50cyA9IHBhcnNl ci5wYXJzZV9hcmdzKCkKQEAgLTMyNiw0ICszMzAsNCBAQCBpZiBfX25hbWVfXyA9PSAiX19tYWlu X18iOgogICAgIG1hbmlmZXN0LmNyZWF0ZV90YXJmaWxlKG91dHB1dF9maWxlbmFtZSkKIAogICAg IGlmIGFyZ3VtZW50cy5jaGVjazoKLSAgICAgICAgRGlzdGNoZWNrKGFyZ3VtZW50cy5zb3VyY2Vf ZGlyLCBhcmd1bWVudHMuYnVpbGRfZGlyKS5jaGVjayhvdXRwdXRfZmlsZW5hbWUpCisgICAgICAg IERpc3RjaGVjayhhcmd1bWVudHMuc291cmNlX2RpciwgYXJndW1lbnRzLmJ1aWxkX2RpcikuY2hl Y2sob3V0cHV0X2ZpbGVuYW1lLCBhcmd1bWVudHMucG9ydCkK