160814 2016-08-12 12:59:58 -0700 [GTK] Install script lacks gstreamer related dependencies 2016-08-16 07:54:12 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez annulen bugs-noreply cgarcia lforschler mcatanzaro pnormand oldest_to_newest 1219665 0 clopez 2016-08-12 12:59:58 -0700 Trying to build webkitgtk+ on a debian testing chroot after running the install dependencies script (but without building the jhbuild) results on this: -- Checking for module 'gstreamer-1.0 >= 1.0.3' -- -- Checking for module 'gstreamer-base-1.0 >= 1.0.3' -- -- Checking for module 'gstreamer-app-1.0 >= 1.0.3' -- -- Checking for module 'gstreamer-audio-1.0 >= 1.0.3' -- -- Checking for module 'gstreamer-fft-1.0 >= 1.0.3' -- -- Checking for module 'gstreamer-gl-1.0>=1.8.0' -- -- Checking for module 'gstreamer-mpegts-1.0>=1.4.0' -- -- Checking for module 'gstreamer-pbutils-1.0 >= 1.0.3' -- -- Checking for module 'gstreamer-tag-1.0 >= 1.0.3' -- -- Checking for module 'gstreamer-video-1.0 >= 1.0.3' -- -- Found GStreamer: GSTREAMER_INCLUDE_DIRS;GSTREAMER_LIBRARIES;GSTREAMER_VERSION;GSTREAMER_BASE_INCLUDE_DIRS;GSTREAMER_BASE_LIBRARIES;GSTREAMER_APP_INCLUDE_DIRS;GSTREAMER_APP_LIBRARIES;GSTREAMER_PBUTILS_INCLUDE_DIRS;GSTREAMER_PBUTILS_LIBRARIES;GSTREAMER_VIDEO_INCLUDE_DIRS;GSTREAMER_VIDEO_LIBRARIES;GSTREAMER_MPEGTS_INCLUDE_DIRS;GSTREAMER_MPEGTS_LIBRARIES;GSTREAMER_TAG_INCLUDE_DIRS;GSTREAMER_TAG_LIBRARIES;GSTREAMER_GL_INCLUDE_DIRS;GSTREAMER_GL_LIBRARIES;GSTREAMER_AUDIO_INCLUDE_DIRS;GSTREAMER_AUDIO_LIBRARIES;GSTREAMER_FFT_INCLUDE_DIRS;GSTREAMER_FFT_LIBRARIES (Required is at least version "1.0.3") CMake Error at Source/cmake/OptionsGTK.cmake:339 (message): WebAudio requires the audio and fft GStreamer libraries. Please check your gst-plugins-base installation. Call Stack (most recent call first): Source/cmake/WebKitCommon.cmake:47 (include) CMakeLists.txt:126 (include) 1219673 1 285937 clopez 2016-08-12 13:11:17 -0700 Created attachment 285937 Patch 1219863 2 pnormand 2016-08-13 01:12:19 -0700 I thought the install-dependencies script was meant to be used in combination with JHBuild, meaning that it shouldn't install libs built by JHBuild already... 1219866 3 clopez 2016-08-13 08:10:48 -0700 (In reply to comment #2) > I thought the install-dependencies script was meant to be used in > combination with JHBuild, meaning that it shouldn't install libs built by > JHBuild already... I also thought this, but then I saw listed several dependencies that we build on the JHBuild, like atk, gtk+, cairo ... So, then I thought that it actually made sense to also included the dependencies to build WebKitGTK+ without using the JHBuild (which is something that you want to do sometimes). this makes sense to you also? 1219869 4 cgarcia 2016-08-13 09:25:06 -0700 (In reply to comment #3) > (In reply to comment #2) > > I thought the install-dependencies script was meant to be used in > > combination with JHBuild, meaning that it shouldn't install libs built by > > JHBuild already... > > I also thought this, but then I saw listed several dependencies that we > build on the JHBuild, like atk, gtk+, cairo ... > > So, then I thought that it actually made sense to also included the > dependencies to build WebKitGTK+ without using the JHBuild (which is > something that you want to do sometimes). > > this makes sense to you also? yes 1219880 5 285937 clopez 2016-08-13 13:32:25 -0700 Comment on attachment 285937 Patch Clearing flags on attachment: 285937 Committed r204448: <http://trac.webkit.org/changeset/204448> 1219882 6 clopez 2016-08-13 13:32:33 -0700 All reviewed patches have been landed. Closing bug. 1219883 7 annulen 2016-08-13 13:39:57 -0700 (In reply to comment #3) > (In reply to comment #2) > > I thought the install-dependencies script was meant to be used in > > combination with JHBuild, meaning that it shouldn't install libs built by > > JHBuild already... > > I also thought this, but then I saw listed several dependencies that we > build on the JHBuild, like atk, gtk+, cairo ... I even was cleaning up such cases, following advise of Michael Catanzaro, see https://bugs.webkit.org/show_bug.cgi?id=159628 1219889 8 clopez 2016-08-13 15:08:02 -0700 (In reply to comment #7) > (In reply to comment #3) > > (In reply to comment #2) > > > I thought the install-dependencies script was meant to be used in > > > combination with JHBuild, meaning that it shouldn't install libs built by > > > JHBuild already... > > > > I also thought this, but then I saw listed several dependencies that we > > build on the JHBuild, like atk, gtk+, cairo ... > > I even was cleaning up such cases, following advise of Michael Catanzaro, > see https://bugs.webkit.org/show_bug.cgi?id=159628 Well... I guess we need to add some comment on the script clarifying which kind of dependency is ok or not. Personally, I see value on having listed the dependencies that allow to build WebKitGTK+ without using the internal jhbuild. Perhaps an idea is to add a --nojhbuild parameter that installs the dependencies which are only needed when no using the jhbuild ? 1220008 9 mcatanzaro 2016-08-15 01:52:03 -0700 (In reply to comment #2) > I thought the install-dependencies script was meant to be used in > combination with JHBuild, meaning that it shouldn't install libs built by > JHBuild already... I agree; why should it install extra stuff? FYI: I'm planning to delete this script and replace it with jhbuild sysdeps. 1220012 10 annulen 2016-08-15 02:39:39 -0700 As for jhbuild sysdeps: AFAIU installation of system packages would require running jhbuild as root, but we should run main jhbuild as root for obvious reasons. Also, jhbuild itself is installed as a part of update-webkit-libs-jhbuild which is normally run after install-dependencies. 1220015 11 mcatanzaro 2016-08-15 03:56:21 -0700 (In reply to comment #10) > As for jhbuild sysdeps: AFAIU installation of system packages would require > running jhbuild as root That's a Debian-specific problem. PackageKit allows package installation without authentication by default, and PackageKit is the default, cross-platform jhbuild sysdeps backend. (And it uses polkit, so it works without any root account.) But on Debian, jhbuild defaults to a Debian-specific sysdeps backend that uses apt-cache; I'm not completely sure why, but I think it's because Debian's PackageKit backend doesn't support searching for files? It's slower and does not use polkit, so we really do have to run it as root, but that is not any problem because the existing install-dependencies script already requires root. So the change is actually that root will no longer be required on other distros. > but we should run main jhbuild as root for obvious > reasons. Of course not, only the sysdeps --install portion would need to be run as root (I guess with sudo), and *only* on Debian/Ubuntu. (We would need to check /etc/os-release before deciding to use sudo.) Actually building stuff should obviously not be done as root. > Also, jhbuild itself is installed as a part of > update-webkit-libs-jhbuild which is normally run after install-dependencies. We would have to change that. The order would be: * Install jhbuild * jhbuild sysdeps --install * jhbuild build 1220430 12 clopez 2016-08-16 06:58:04 -0700 (In reply to comment #9) > (In reply to comment #2) > > I thought the install-dependencies script was meant to be used in > > combination with JHBuild, meaning that it shouldn't install libs built by > > JHBuild already... > > I agree; why should it install extra stuff? > Because sometimes I want to build WebKit without the JHBuild???? And sometimes I want to build it on distros that are not my usual distro (like Fedora). And I find it handy to just execute an script that installs all the deps. > FYI: I'm planning to delete this script and replace it with jhbuild sysdeps. In this case, rather than deleting it, please rename it to install-dependencies-nojhbuild 1220432 13 annulen 2016-08-16 07:04:12 -0700 1. Package lists for these 2 cases are going to be different 2. Sysdeps of jhbuild can be used for "non-jhbuild" set up as well, it's not very productive to maintain parallel package lists for different distros. 1220433 14 annulen 2016-08-16 07:04:51 -0700 (though it will have to be different jhbuild sysdeps module) 1220434 15 mcatanzaro 2016-08-16 07:24:22 -0700 You could just run 'jhbuild sysdeps --install' to install the dependencies, you don't need to build the full jhbuild environment if you don't want to. The point of switching to jhbuild sysdeps is to be able to remove this script, so we don't have to maintain three different sets of dependencies for each distro, there's no value in doing it otherwise. 1220436 16 clopez 2016-08-16 07:39:45 -0700 (In reply to comment #15) > You could just run 'jhbuild sysdeps --install' to install the dependencies, > you don't need to build the full jhbuild environment if you don't want to. > The point of switching to jhbuild sysdeps is to be able to remove this > script, so we don't have to maintain three different sets of dependencies > for each distro, there's no value in doing it otherwise. That won't work. For example, I want the cairo-devel from the system in order to be able to built WebKit without the JHBuild. And jhbuild sysdeps --install should not install Cairo because we want to build our own very specific version of Cairo in order to have reliable test results for the layout tests. 1220437 17 annulen 2016-08-16 07:40:59 -0700 Solution is separate modulesets for 2 use cases. 1220438 18 annulen 2016-08-16 07:54:12 -0700 (In reply to comment #11) > That's a Debian-specific problem. PackageKit allows package installation > without authentication by default, and PackageKit is the default, > cross-platform jhbuild sysdeps backend. (And it uses polkit, so it works > without any root account.) But on Debian, jhbuild defaults to a > Debian-specific sysdeps backend that uses apt-cache; I'm not completely sure > why, but I think it's because Debian's PackageKit backend doesn't support > searching for files? FWIW, apt-cache does not require root access, and pkexec could be used to run apt-get 285937 2016-08-12 13:11:17 -0700 2016-08-13 13:32:25 -0700 Patch bug-160814-20160812220937.patch text/plain 1448 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0NDExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTFmZDdhMjI3MTIxMzBlMzJhN2RhMjE3MDI2MDZkOTYx YzNkZWZhNi4uOTUyOGU2ZmViODI1ZjBjOTg3Y2M5NTM5MmQ3YTY3YjhmNGVkMjA5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTA4LTEyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIEluc3RhbGwgc2NyaXB0IGxhY2tzIGdzdHJlYW1lciBy ZWxhdGVkIGRlcGVuZGVuY2llcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTYwODE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXM6IEZlZG9yYSBjYXNlIGhhZCBh bHJlYWR5IGxpc3RlZCB0aGlzIGRlcGVuZGVuY2llcywKKyAgICAgICAgYnV0IGJvdGggQXJjaCBh bmQgRGViaWFuL1VidW50dSB3ZXJlIG1pc3NpbmcgdGhlbS4KKwogMjAxNi0wOC0xMiAgQnJhZHkg RWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHRoZSAzMi1iaXQgTWFj IGJ1aWxkIGFmdGVyOgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVz IGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmluZGV4IGQ4NWVmZjg5NTE3M2RiZjI1 Zjk4MDhjMzZmMjQ5MDY0MWJmNDI3NjcuLmJkZjdhMzkwMTA4MTg2MGQ5NTg3Mzg4MWY1NGY3Njcy ZGFhMzI3YzYgMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcworKysg Yi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAgLTEwMiw2ICsxMDIsOCBAQCBmdW5j dGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAgICAgIGxpYmdudXRsczI4LWRl diBcCiAgICAgICAgIGxpYmd0azIuMC1kZXYgXAogICAgICAgICBsaWJndGstMy1kZXYgXAorICAg ICAgICBsaWJnc3RyZWFtZXIxLjAtZGV2IFwKKyAgICAgICAgbGliZ3N0cmVhbWVyLXBsdWdpbnMt YmFzZTEuMC1kZXYgXAogICAgICAgICBsaWJndWRldi0xLjAtZGV2IFwKICAgICAgICAgbGliaHlw aGVuLWRldiBcCiAgICAgICAgIGxpYmpwZWctZGV2IFwKQEAgLTIyNiw2ICsyMjgsOCBAQCBmdW5j dGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aFBhY21hbiB7CiAgICAgICAgIGdwZXJmIFwKICAg ICAgICAgZ3JlcCBcCiAgICAgICAgIGdyb2ZmIFwKKyAgICAgICAgZ3N0cmVhbWVyIFwKKyAgICAg ICAgZ3N0LXBsdWdpbnMtYmFzZS1saWJzIFwKICAgICAgICAgZ3ppcCBcCiAgICAgICAgIGh5cGhl biBcCiAgICAgICAgIGxpYnRvb2wgXAo=