160781 2016-08-11 13:31:23 -0700 REGRESSION (r204264): Web Inspector: Uncaught Exception in Network tab when reloading a web page 2016-08-11 17:06:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://webkit.org/nightly/start/trunk/204373/ InRadar P2 Critical --- 1 nvasilyev nvasilyev bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1219395 0 nvasilyev 2016-08-11 13:31:23 -0700 ------- Inspected URL: https://webkit.org/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/603.1.3+ (KHTML, like Gecko) Uncaught Exceptions: - this._dataGrid.closed is not a function. (In 'this._dataGrid.closed()', 'this._dataGrid.closed' is undefined) (at NetworkGridContentView.js:157:30) closed @ NetworkGridContentView.js:157:30 _disassociateFromContentView @ ContentViewContainer.js:476:27 closeAllContentViews @ ContentViewContainer.js:339:46 _networkTimelineReset @ NetworkSidebarPanel.js:183:70 dispatch @ Object.js:162:30 dispatchEventToListeners @ Object.js:169:17 reset @ Timeline.js:80:42 reset @ NetworkTimeline.js:41:20 _mainResourceDidChange @ TimelineManager.js:807:50 dispatch @ Object.js:162:30 dispatchEventToListeners @ Object.js:177:21 _dispatchMainResourceDidChangeEvent @ Frame.js:498:38 commitProvisionalLoad @ Frame.js:140:53 frameDidNavigate @ FrameResourceManager.js:105:40 frameNavigated @ PageObserver.js:42:59 dispatchEvent @ InspectorBackend.js:464:42 _dispatchEvent @ InspectorBackend.js:358:32 dispatch @ InspectorBackend.js:159:32 dispatchNextQueuedMessageFromBackend @ MessageDispatcher.js:42:34 Additional Details: cause --> An uncaught exception was thrown while handling event: Page.frameNavigated ------- * STEPS TO REPRODUCE 1. Open https://webkit.org/ 2. Open Network tab. 3. Reload the page. 1219396 1 webkit-bug-importer 2016-08-11 13:31:48 -0700 <rdar://problem/27810452> 1219405 2 nvasilyev 2016-08-11 13:50:53 -0700 WebInspector.TimelineDataGrid.prototype.closed method was removed in https://trac.webkit.org/changeset/204264 Joe, please take a look. 1219411 3 mattbaker 2016-08-11 14:14:11 -0700 "closed" gets implemented in a few class hierarchies, but never in DataGrid or View. I would just add an "implemented by subclasses" stub to DataGrid. 1219444 4 285864 nvasilyev 2016-08-11 16:30:16 -0700 Created attachment 285864 Patch 1219446 5 mattbaker 2016-08-11 16:33:28 -0700 r=me 1219454 6 285864 commit-queue 2016-08-11 17:06:38 -0700 Comment on attachment 285864 Patch Clearing flags on attachment: 285864 Committed r204391: <http://trac.webkit.org/changeset/204391> 1219455 7 commit-queue 2016-08-11 17:06:42 -0700 All reviewed patches have been landed. Closing bug. 285864 2016-08-11 16:30:16 -0700 2016-08-11 17:06:38 -0700 Patch patch.txt text/plain 1413 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ4MWExMDQuLmEzMjE1ZDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA4LTExICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDQyNjQp OiBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb24gaW4gTmV0d29yayB0YWIgd2hlbiBy ZWxvYWRpbmcgYSB3ZWIgcGFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTYwNzgxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNzgxMDQ1Mj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJJbnNwZWN0 b3IuVGltZWxpbmVEYXRhR3JpZC5wcm90b3R5cGUuY2xvc2VkIHdhcyByZW1vdmVkIGluIHIyMDQy NjQuCisgICAgICAgIERlZmluZSBhIHN0dWIgbWV0aG9kIG9uIERhdGFHcmlkIHNvIGl0J3MgYXZh aWxhYmxlIHRvIGFsbCBpdHMgc3ViY2xhc3Nlcy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvRGF0YUdyaWQuanM6CisgICAgICAgIHRoaXMuX2RhdGFHcmlkLmNsb3NlZCgpCisKIDIw MTYtMDgtMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBTaG91bGQgYmUgYWJsZSB0byBFZGl0IE5vZGUgQXR0cmlidXRlcyBh bmQgU3R5bGVzIGZvciBub24tVXNlckFnZW50IFNoYWRvdyBET00gbm9kZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKaW5k ZXggMDIwMWNjMi4uZWIxMjFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKQEAgLTE0MTUsNiArMTQxNSwxMSBAQCBX ZWJJbnNwZWN0b3IuRGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBleHRlbmRzIFdlYkluc3BlY3Rv ci5WaWV3CiAgICAgICAgIH0KICAgICB9CiAKKyAgICBjbG9zZWQoKQorICAgIHsKKyAgICAgICAg Ly8gSW1wbGVtZW50ZWQgYnkgc3ViY2xhc3Nlcy4KKyAgICB9CisKICAgICBleHBhbmQoKQogICAg IHsKICAgICAgICAgLy8gVGhpcyBpcyB0aGUgcm9vdCwgZG8gbm90aGluZy4K