160773 2016-08-11 11:46:09 -0700 The jsc shell's Element host constructor should throw if it fails to construct an object. 2016-08-11 14:24:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1219353 0 mark.lam 2016-08-11 11:46:09 -0700 The Element object is a test object provided in the jsc shell for testing use only. JavaScriptCore expects host constructors to either throw an error or return a constructed object. Element has a host constructor that did not obey this contract. As a result, the following statement will fail a RELEASE_ASSERT: new (Element.bind()) We should fix this. 1219355 1 mark.lam 2016-08-11 11:46:29 -0700 <rdar://problem/27328608> 1219359 2 285840 mark.lam 2016-08-11 12:04:41 -0700 Created attachment 285840 proposed patch. 1219360 3 commit-queue 2016-08-11 12:05:33 -0700 Attachment 285840 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] ERROR: Source/JavaScriptCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1219361 4 285841 mark.lam 2016-08-11 12:07:35 -0700 Created attachment 285841 Fixed tabs. 1219415 5 mark.lam 2016-08-11 14:24:26 -0700 Thanks for the review. Landed in r204388: <http://trac.webkit.org/r204388>. 285840 2016-08-11 12:04:41 -0700 2016-08-11 12:07:35 -0700 proposed patch. bug-160773.patch text/plain 2883 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDQzNzkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE2LTA4LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBUaGUganNjIHNoZWxsJ3MgRWxlbWVudCBob3N0IGNvbnN0cnVjdG9yIHNo b3VsZCB0aHJvdyBpZiBpdCBmYWlscyB0byBjb25zdHJ1Y3QgYW4gb2JqZWN0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzczCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZ2VuZXJhdGlv bmFsLW9wYXF1ZS1yb290cy5qczoKKwogMjAxNi0wOC0xMCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fi b2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBCYXNlbGluZSBHZXRCeVZhbCBhbmQgUHV0QnlWYWwg Zm9yIGNhY2hlIElEIHN0dWJzIG5lZWQgdG8gaGFuZGxlIGV4Y2VwdGlvbnMKSW5kZXg6IEpTVGVz dHMvc3RyZXNzL2dlbmVyYXRpb25hbC1vcGFxdWUtcm9vdHMuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNU ZXN0cy9zdHJlc3MvZ2VuZXJhdGlvbmFsLW9wYXF1ZS1yb290cy5qcwkocmV2aXNpb24gMjA0Mzc1 KQorKysgSlNUZXN0cy9zdHJlc3MvZ2VuZXJhdGlvbmFsLW9wYXF1ZS1yb290cy5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMSw1ICsxLDExIEBACiAvLyBUZXN0cyB0aGF0IG9wYXF1ZSByb290cyBiZWhh dmUgY29ycmVjdGx5IGR1cmluZyB5b3VuZyBnZW5lcmF0aW9uIGNvbGxlY3Rpb25zCiAKK3RyeSB7 CisgICAgLy8gcmVncmVzc2lvbiB0ZXN0IGZvciBidWcgMTYwNzczLiAgVGhpcyBzaG91bGQgbm90 IGNyYXNoLgorICAgIG5ldyAoRWxlbWVudC5iaW5kKCkpOworfSBjYXRjaChlKSB7Cit9CisKIC8v IENyZWF0ZSB0aGUgcHJpbWFyeSBSb290LgogdmFyIHJvb3QgPSBuZXcgUm9vdCgpOwogLy8gVGhp cyBzZWNvbmRhcnkgcm9vdCBpcyBmb3IgYWxsb2NhdGluZyBhIHNlY29uZCBFbGVtZW50IHdpdGhv dXQgb3ZlcnJpZGluZyAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0 Mzc1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDIyIEBACisyMDE2LTA4LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBUaGUganNjIHNoZWxsJ3MgRWxlbWVudCBob3N0IGNvbnN0cnVjdG9yIHNo b3VsZCB0aHJvdyBpZiBpdCBmYWlscyB0byBjb25zdHJ1Y3QgYW4gb2JqZWN0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzczCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEVsZW1lbnQgb2JqZWN0 IGlzIGEgdGVzdCBvYmplY3QgcHJvdmlkZWQgaW4gdGhlIGpzYyBzaGVsbCBmb3IgdGVzdGluZyB1 c2Ugb25seS4KKyAgICAgICAgSmF2YVNjcmlwdENvcmUgZXhwZWN0cyBob3N0IGNvbnN0cnVjdG9y cyB0byBlaXRoZXIgdGhyb3cgYW4gZXJyb3Igb3IgcmV0dXJuIGEKKyAgICAgICAgY29uc3RydWN0 ZWQgb2JqZWN0LiAgRWxlbWVudCBoYXMgYSBob3N0IGNvbnN0cnVjdG9yIHRoYXQgZGlkIG5vdCBv YmV5IHRoaXMgY29udHJhY3QuCisgICAgICAgIEFzIGEgcmVzdWx0LCB0aGUgZm9sbG93aW5nIHN0 YXRlbWVudCB3aWxsIGZhaWwgYSBSRUxFQVNFX0FTU0VSVDoKKworCSAgICAJbmV3IChFbGVtZW50 LmJpbmQoKSkKKworCQlUaGlzIGlzIG5vdyBmaXhlZC4KKworICAgICAgICAqIGpzYy5jcHA6Cisg ICAgICAgIChmdW5jdGlvbkNyZWF0ZUVsZW1lbnQpOgorCiAyMDE2LTA4LTExICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBXYXJuaW5nIGZpeC4K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCShyZXZpc2lvbiAyMDQzNzUpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIzMSw3ICsxMjMxLDcgQEAg RW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkNyZQogICAgIEpTTG9ja0hvbGRl ciBsb2NrKGV4ZWMpOwogICAgIFJvb3QqIHJvb3QgPSBqc0R5bmFtaWNDYXN0PFJvb3QqPihleGVj LT5hcmd1bWVudCgwKSk7CiAgICAgaWYgKCFyb290KQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6 ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOworICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGV4 ZWMtPnZtKCkudGhyb3dFeGNlcHRpb24oZXhlYywgY3JlYXRlRXJyb3IoZXhlYywgQVNDSUlMaXRl cmFsKCJDYW5ub3QgY3JlYXRlIEVsZW1lbnQgd2l0aG91dCBhIFJvb3QuIikpKSk7CiAgICAgcmV0 dXJuIEpTVmFsdWU6OmVuY29kZShFbGVtZW50OjpjcmVhdGUoZXhlYy0+dm0oKSwgZXhlYy0+bGV4 aWNhbEdsb2JhbE9iamVjdCgpLCByb290KSk7CiB9CiAK 285841 2016-08-11 12:07:35 -0700 2016-08-11 13:52:02 -0700 Fixed tabs. bug-160773.patch text/plain 2895 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDQzNzkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDE2LTA4LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBUaGUganNjIHNoZWxsJ3MgRWxlbWVudCBob3N0IGNvbnN0cnVjdG9yIHNo b3VsZCB0aHJvdyBpZiBpdCBmYWlscyB0byBjb25zdHJ1Y3QgYW4gb2JqZWN0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzczCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZ2VuZXJhdGlv bmFsLW9wYXF1ZS1yb290cy5qczoKKwogMjAxNi0wOC0xMCAgTWljaGFlbCBTYWJvZmYgIDxtc2Fi b2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBCYXNlbGluZSBHZXRCeVZhbCBhbmQgUHV0QnlWYWwg Zm9yIGNhY2hlIElEIHN0dWJzIG5lZWQgdG8gaGFuZGxlIGV4Y2VwdGlvbnMKSW5kZXg6IEpTVGVz dHMvc3RyZXNzL2dlbmVyYXRpb25hbC1vcGFxdWUtcm9vdHMuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNU ZXN0cy9zdHJlc3MvZ2VuZXJhdGlvbmFsLW9wYXF1ZS1yb290cy5qcwkocmV2aXNpb24gMjA0Mzc1 KQorKysgSlNUZXN0cy9zdHJlc3MvZ2VuZXJhdGlvbmFsLW9wYXF1ZS1yb290cy5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMSw1ICsxLDExIEBACiAvLyBUZXN0cyB0aGF0IG9wYXF1ZSByb290cyBiZWhh dmUgY29ycmVjdGx5IGR1cmluZyB5b3VuZyBnZW5lcmF0aW9uIGNvbGxlY3Rpb25zCiAKK3RyeSB7 CisgICAgLy8gcmVncmVzc2lvbiB0ZXN0IGZvciBidWcgMTYwNzczLiAgVGhpcyBzaG91bGQgbm90 IGNyYXNoLgorICAgIG5ldyAoRWxlbWVudC5iaW5kKCkpOworfSBjYXRjaChlKSB7Cit9CisKIC8v IENyZWF0ZSB0aGUgcHJpbWFyeSBSb290LgogdmFyIHJvb3QgPSBuZXcgUm9vdCgpOwogLy8gVGhp cyBzZWNvbmRhcnkgcm9vdCBpcyBmb3IgYWxsb2NhdGluZyBhIHNlY29uZCBFbGVtZW50IHdpdGhv dXQgb3ZlcnJpZGluZyAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0 Mzc1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDIyIEBACisyMDE2LTA4LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBUaGUganNjIHNoZWxsJ3MgRWxlbWVudCBob3N0IGNvbnN0cnVjdG9yIHNo b3VsZCB0aHJvdyBpZiBpdCBmYWlscyB0byBjb25zdHJ1Y3QgYW4gb2JqZWN0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzczCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEVsZW1lbnQgb2JqZWN0 IGlzIGEgdGVzdCBvYmplY3QgcHJvdmlkZWQgaW4gdGhlIGpzYyBzaGVsbCBmb3IgdGVzdGluZyB1 c2Ugb25seS4KKyAgICAgICAgSmF2YVNjcmlwdENvcmUgZXhwZWN0cyBob3N0IGNvbnN0cnVjdG9y cyB0byBlaXRoZXIgdGhyb3cgYW4gZXJyb3Igb3IgcmV0dXJuIGEKKyAgICAgICAgY29uc3RydWN0 ZWQgb2JqZWN0LiAgRWxlbWVudCBoYXMgYSBob3N0IGNvbnN0cnVjdG9yIHRoYXQgZGlkIG5vdCBv YmV5IHRoaXMgY29udHJhY3QuCisgICAgICAgIEFzIGEgcmVzdWx0LCB0aGUgZm9sbG93aW5nIHN0 YXRlbWVudCB3aWxsIGZhaWwgYSBSRUxFQVNFX0FTU0VSVDoKKworICAgICAgICAgICAgbmV3IChF bGVtZW50LmJpbmQoKSkKKworICAgICAgICBUaGlzIGlzIG5vdyBmaXhlZC4KKworICAgICAgICAq IGpzYy5jcHA6CisgICAgICAgIChmdW5jdGlvbkNyZWF0ZUVsZW1lbnQpOgorCiAyMDE2LTA4LTEx ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBX YXJuaW5nIGZpeC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCShyZXZpc2lvbiAyMDQzNzUpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIzMSw3 ICsxMjMxLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkNyZQogICAg IEpTTG9ja0hvbGRlciBsb2NrKGV4ZWMpOwogICAgIFJvb3QqIHJvb3QgPSBqc0R5bmFtaWNDYXN0 PFJvb3QqPihleGVjLT5hcmd1bWVudCgwKSk7CiAgICAgaWYgKCFyb290KQotICAgICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOworICAgICAgICByZXR1cm4gSlNWYWx1 ZTo6ZW5jb2RlKGV4ZWMtPnZtKCkudGhyb3dFeGNlcHRpb24oZXhlYywgY3JlYXRlRXJyb3IoZXhl YywgQVNDSUlMaXRlcmFsKCJDYW5ub3QgY3JlYXRlIEVsZW1lbnQgd2l0aG91dCBhIFJvb3QuIikp KSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShFbGVtZW50OjpjcmVhdGUoZXhlYy0+dm0o KSwgZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLCByb290KSk7CiB9CiAK