160767 2016-08-11 09:56:52 -0700 Add NSButtonType to AppKitCompatibilityDeclarations.h 2016-08-11 11:41:00 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 1 mdaum webkit-unassigned benjamin cdumez cmarcelo commit-queue mdaum mitz oldest_to_newest 1219326 0 mdaum 2016-08-11 09:56:52 -0700 Add NSButtonType to AppKitCompatibilityDeclarations.h so that we can use the new NSButtonType enums even on older OS versions. 1219327 1 mdaum 2016-08-11 10:05:57 -0700 I have a patch coming soon. 1219342 2 285835 mdaum 2016-08-11 10:59:28 -0700 Created attachment 285835 Patch for adding NSButtonType to AppKitCompatibilityDeclarations.h. 1219350 3 285835 commit-queue 2016-08-11 11:40:55 -0700 Comment on attachment 285835 Patch for adding NSButtonType to AppKitCompatibilityDeclarations.h. Clearing flags on attachment: 285835 Committed r204379: <http://trac.webkit.org/changeset/204379> 1219351 4 commit-queue 2016-08-11 11:41:00 -0700 All reviewed patches have been landed. Closing bug. 285835 2016-08-11 10:59:28 -0700 2016-08-11 11:40:55 -0700 Patch for adding NSButtonType to AppKitCompatibilityDeclarations.h. AddNSButtonTypeToAppKitCompatibilityDeclarations.txt text/plain 2273 mdaum ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNTZhZjdlMC4uODMxMzJmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNi0wOC0xMSAg TWF1cmVlbiBEYXVtICA8bWRhdW1AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBOU0J1dHRvblR5 cGUgdG8gQXBwS2l0Q29tcGF0aWJpbGl0eURlY2xhcmF0aW9ucy5oLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzY3LgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBOU0J1dHRvblR5cGUgdG8gQXBw S2l0Q29tcGF0aWJpbGl0eURlY2xhcmF0aW9ucy5oIHNvIHRoYXQgd2UgY2FuIHVzZSB0aGUgbmV3 CisgICAgICAgIG5hbWVzIGJ1dCBzdGlsbCBidWlsZCBzdWNjZXNzZnVsbHkgb24gb2xkZXIgT1Mg dmVyc2lvbnMuCisKKyAgICAgICAgKiB3dGYvbWFjL0FwcEtpdENvbXBhdGliaWxpdHlEZWNsYXJh dGlvbnMuaDoKKwogMjAxNi0wOC0xMCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KIAogICAgICAgICBbSlNDXSBUaW55UHRyU2V0OjpkZWxldGVMaXN0SWZOZWNlc3Nhcnko KSBubyBsb25nZXIgbmVlZHMgdG8gdGVzdCBmb3IgcmVzZXJ2ZWRWYWx1ZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvbWFjL0FwcEtpdENvbXBhdGliaWxpdHlEZWNsYXJhdGlvbnMuaCBiL1Nv dXJjZS9XVEYvd3RmL21hYy9BcHBLaXRDb21wYXRpYmlsaXR5RGVjbGFyYXRpb25zLmgKaW5kZXgg OWM0YTg1NS4uZTExM2U4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvbWFjL0FwcEtpdENv bXBhdGliaWxpdHlEZWNsYXJhdGlvbnMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9tYWMvQXBwS2l0 Q29tcGF0aWJpbGl0eURlY2xhcmF0aW9ucy5oCkBAIC0zNiw2ICszNiwxNyBAQCBzdGF0aWMgY29u c3QgTlNBbGVydFN0eWxlIE5TQWxlcnRTdHlsZUNyaXRpY2FsID0gTlNDcml0aWNhbEFsZXJ0U3R5 bGU7CiBzdGF0aWMgY29uc3QgTlNBbGVydFN0eWxlIE5TQWxlcnRTdHlsZUluZm9ybWF0aW9uYWwg PSBOU0luZm9ybWF0aW9uYWxBbGVydFN0eWxlOwogc3RhdGljIGNvbnN0IE5TQWxlcnRTdHlsZSBO U0FsZXJ0U3R5bGVXYXJuaW5nID0gTlNXYXJuaW5nQWxlcnRTdHlsZTsKIAorc3RhdGljIGNvbnN0 IE5TQnV0dG9uVHlwZSBOU0J1dHRvblR5cGVNb21lbnRhcnlMaWdodCA9IE5TTW9tZW50YXJ5TGln aHRCdXR0b247CitzdGF0aWMgY29uc3QgTlNCdXR0b25UeXBlIE5TQnV0dG9uVHlwZVB1c2hPblB1 c2hPZmYgPSBOU1B1c2hPblB1c2hPZmZCdXR0b247CitzdGF0aWMgY29uc3QgTlNCdXR0b25UeXBl IE5TQnV0dG9uVHlwZVRvZ2dsZSA9IE5TVG9nZ2xlQnV0dG9uOworc3RhdGljIGNvbnN0IE5TQnV0 dG9uVHlwZSBOU0J1dHRvblR5cGVTd2l0Y2ggPSBOU1N3aXRjaEJ1dHRvbjsKK3N0YXRpYyBjb25z dCBOU0J1dHRvblR5cGUgTlNCdXR0b25UeXBlUmFkaW8gPSBOU1JhZGlvQnV0dG9uOworc3RhdGlj IGNvbnN0IE5TQnV0dG9uVHlwZSBOU0J1dHRvblR5cGVNb21lbnRhcnlDaGFuZ2UgPSBOU01vbWVu dGFyeUNoYW5nZUJ1dHRvbjsKK3N0YXRpYyBjb25zdCBOU0J1dHRvblR5cGUgTlNCdXR0b25UeXBl T25PZmYgPSBOU09uT2ZmQnV0dG9uOworc3RhdGljIGNvbnN0IE5TQnV0dG9uVHlwZSBOU0J1dHRv blR5cGVNb21lbnRhcnlQdXNoSW4gPSBOU01vbWVudGFyeVB1c2hJbkJ1dHRvbjsKK3N0YXRpYyBj b25zdCBOU0J1dHRvblR5cGUgTlNCdXR0b25UeXBlQWNjZWxlcmF0b3IgPSBOU0FjY2VsZXJhdG9y QnV0dG9uOworc3RhdGljIGNvbnN0IE5TQnV0dG9uVHlwZSBOU0J1dHRvblR5cGVNdWx0aUxldmVs QWNjZWxlcmF0b3IgPSBOU011bHRpTGV2ZWxBY2NlbGVyYXRvckJ1dHRvbjsKKwogc3RhdGljIGNv bnN0IE5TQ29tcG9zaXRpbmdPcGVyYXRpb24gTlNDb21wb3NpdGluZ09wZXJhdGlvbkNvcHkgPSBO U0NvbXBvc2l0ZUNvcHk7CiBzdGF0aWMgY29uc3QgTlNDb21wb3NpdGluZ09wZXJhdGlvbiBOU0Nv bXBvc2l0aW5nT3BlcmF0aW9uRGVzdGluYXRpb25JbiA9IE5TQ29tcG9zaXRlRGVzdGluYXRpb25J bjsKIHN0YXRpYyBjb25zdCBOU0NvbXBvc2l0aW5nT3BlcmF0aW9uIE5TQ29tcG9zaXRpbmdPcGVy YXRpb25EZXN0aW5hdGlvbk91dCA9ICBOU0NvbXBvc2l0ZURlc3RpbmF0aW9uT3V0Owo=