160766 2016-08-11 08:59:16 -0700 Move dataset attribute from Element to HTMLElement / SVGElement 2016-08-11 10:50:44 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez achristensen cdumez commit-queue darin dbates rniwa sam webkit oldest_to_newest 1219316 0 cdumez 2016-08-11 08:59:16 -0700 Move dataset attribute from Element to HTMLElement / SVGElement as per the specifications: - https://html.spec.whatwg.org/multipage/dom.html#htmlelement - https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement Firefox and Chrome seem to have dataset on HTMLElement but not on SVGElement. 1219321 1 cdumez 2016-08-11 09:23:17 -0700 See also discussion at https://github.com/whatwg/dom/issues/280 1219323 2 285830 cdumez 2016-08-11 09:35:23 -0700 Created attachment 285830 Patch 1219340 3 285830 commit-queue 2016-08-11 10:50:27 -0700 Comment on attachment 285830 Patch Clearing flags on attachment: 285830 Committed r204377: <http://trac.webkit.org/changeset/204377> 1219341 4 commit-queue 2016-08-11 10:50:44 -0700 All reviewed patches have been landed. Closing bug. 285830 2016-08-11 09:35:23 -0700 2016-08-11 10:50:27 -0700 Patch bug-160766-20160811093346.patch text/plain 6468 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0Mzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ0NDc1ZjcwM2EwMmIz YTYwN2VlZWU2NTI4MjAxOTc0NzY2NTU4OC4uMTViYmU5YzE4M2M2ZmQ3NzM4OTZiMGY4NTIxOTJh YWE4NDNhZGRiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA4LTExICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSBkYXRhc2V0IGF0dHJp YnV0ZSBmcm9tIEVsZW1lbnQgdG8gSFRNTEVsZW1lbnQgLyBTVkdFbGVtZW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA3NjYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIGRhdGFzZXQgYXR0cmli dXRlIGZyb20gRWxlbWVudCB0byBIVE1MRWxlbWVudCAvIFNWR0VsZW1lbnQgYXMgcGVyCisgICAg ICAgIHRoZSBzcGVjaWZpY2F0aW9uczoKKyAgICAgICAgLSBodHRwczovL2h0bWwuc3BlYy53aGF0 d2cub3JnL211bHRpcGFnZS9kb20uaHRtbCNodG1sZWxlbWVudAorICAgICAgICAtIGh0dHBzOi8v c3Znd2cub3JnL3N2ZzItZHJhZnQvdHlwZXMuaHRtbCNJbnRlcmZhY2VTVkdFbGVtZW50CisKKyAg ICAgICAgRmlyZWZveCBhbmQgQ2hyb21lIHNlZW0gdG8gaGF2ZSBkYXRhc2V0IG9uIEhUTUxFbGVt ZW50IGJ1dCBub3Qgb24KKyAgICAgICAgU1ZHRWxlbWVudCAoeWV0KS4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIHJlYmFzZWxpbmVkIGV4aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBkb20vRWxl bWVudC5pZGw6CisgICAgICAgICogaHRtbC9IVE1MRWxlbWVudC5pZGw6CisgICAgICAgICogc3Zn L1NWR0VsZW1lbnQuaWRsOgorCiAyMDE2LTA4LTEwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2hvdWxkIGJlIGFibGUgdG8g RWRpdCBOb2RlIEF0dHJpYnV0ZXMgYW5kIFN0eWxlcyBmb3Igbm9uLVVzZXJBZ2VudCBTaGFkb3cg RE9NIG5vZGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5pZGwgYi9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5pZGwKaW5kZXggMzQyOTU5OTdmNTdkZWFlMDMwNzZl YzYzNTBiMzVkODU4OGViM2IwYS4uZDJhODdkZWUzNDk2YzQ5ZTM3NGFiODUzMzI5YzI0N2Y2ZjMy NTNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaWRsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmlkbApAQCAtMTExLDEwICsxMTEsNiBAQAogICAgIFtS ZWZsZWN0PWNsYXNzXSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGNsYXNzTmFtZTsKICAgICBbUHV0Rm9y d2FyZHM9dmFsdWVdIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01Ub2tlbkxpc3QgY2xhc3NMaXN0Owog Ci0jaWYgZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBUKSAmJiBMQU5HVUFHRV9KQVZBU0NSSVBU Ci0gICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZ01hcCBkYXRhc2V0OwotI2VuZGlmCi0K ICAgICBbUmFpc2VzRXhjZXB0aW9uXSBib29sZWFuIG1hdGNoZXMoRE9NU3RyaW5nIHNlbGVjdG9y cyk7CiAgICAgW1JhaXNlc0V4Y2VwdGlvbl0gRWxlbWVudCBjbG9zZXN0KERPTVN0cmluZyBzZWxl Y3RvcnMpOyAgICAKICAgICBbSW1wbGVtZW50ZWRBcz1tYXRjaGVzLCBSYWlzZXNFeGNlcHRpb25d IGJvb2xlYW4gd2Via2l0TWF0Y2hlc1NlbGVjdG9yKERPTVN0cmluZyBzZWxlY3RvcnMpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5pZGwgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxFbGVtZW50LmlkbAppbmRleCA2NmU4ODJlNGFkZmI4YWM0MDBhZGRmZWUw OTkzODA2MTNmNTE5NzIzLi4zYmRmNGI1NjkyMWQ2Nzg4ZTc3YWUxNDFmNDhlMzYwZDAyZDI4NWI0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmlkbAorKysgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmlkbApAQCAtNTQsNiArNTQsOCBAQAogI2lm IGRlZmluZWQoTEFOR1VBR0VfSkFWQVNDUklQVCkgJiYgTEFOR1VBR0VfSkFWQVNDUklQVAogICAg IHZvaWQgZm9jdXMoKTsKICAgICB2b2lkIGJsdXIoKTsKKworICAgIHJlYWRvbmx5IGF0dHJpYnV0 ZSBET01TdHJpbmdNYXAgZGF0YXNldDsKICNlbmRpZgogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0VsZW1l bnQuaWRsCmluZGV4IDllYjQ0NmVjNDRmYzAzNWJjNzhjYTBkMmU4YTY0ZTE0YmRjNmNhZmYuLjA4 NWZmNzc4NjNhNDE0MTIwZGRmMmZkNjE0ZTkyMjczNzBkYTI5ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZH RWxlbWVudC5pZGwKQEAgLTQwLDYgKzQwLDggQEAKICNpZiBkZWZpbmVkKExBTkdVQUdFX0pBVkFT Q1JJUFQpICYmIExBTkdVQUdFX0pBVkFTQ1JJUFQKICAgICB2b2lkIGZvY3VzKCk7CiAgICAgdm9p ZCBibHVyKCk7CisKKyAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nTWFwIGRhdGFzZXQ7 CiAjZW5kaWYKIH07CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkNTVkYjA4Yjg5ZTc2ZTJlMWUzZTg0ZWZkNTdkMmQ2ZDcw NjdkM2M2Li5lY2M3Y2E3YjU4MGZjNDA4MGUxZjBmZjNhZjNkYjE2NGFlYzlkNzdjIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTYtMDgtMTEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KKworICAgICAgICBNb3ZlIGRhdGFzZXQgYXR0cmlidXRlIGZyb20gRWxlbWVudCB0byBIVE1M RWxlbWVudCAvIFNWR0VsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MDc2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlYmFzZWxpbmUgZXhpc3RpbmcgdGVzdHMgbm93IHRoYXQgcHJvcGVydGll cyBhcmUgaW4gZGlmZmVyZW50IG9yZGVyCisgICAgICAgIHdoZW4gaXRlcmF0aW5nLgorCisgICAg ICAgICoganMvZG9tL2RvbS1zdGF0aWMtcHJvcGVydHktZm9yLWluLWl0ZXJhdGlvbi1leHBlY3Rl ZC50eHQ6CisKIDIwMTYtMDgtMTEgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4K IAogICAgICAgICBVbnNraXAgMmQuZ3JhZGllbnQuaW50ZXJwb2xhdGUuY29sb3VyYWxwaGEgb24g bWFjT1MgU2llcnJhCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBkZmJiZTAxOTUw YTI5ZjRmNmE3ZmQyZTBmZWUxNjFjNDU3NDM1MTIwLi4xOGJhMjYwZTMwNjVhZjRkNjhiMTUwNDk2 MTFlYzFhZTc5Njg4OTczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxNi0wOC0xMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisg ICAgICAgIE1vdmUgZGF0YXNldCBhdHRyaWJ1dGUgZnJvbSBFbGVtZW50IHRvIEhUTUxFbGVtZW50 IC8gU1ZHRWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYwNzY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmViYXNlbGluZSBXM0MgdGVzdCBub3cgdGhhdCBvbmUgbW9yZSBjaGVjayBpcyBwYXNz aW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9tL2ludGVyZmFjZXMt ZXhwZWN0ZWQudHh0OgorCiAyMDE2LTA4LTExICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBs ZS5jb20+CiAKICAgICAgICAgVGVzdCAyZC5ncmFkaWVudC5pbnRlcnBvbGF0ZS5jb2xvdXJhbHBo YS5odG1sIGlzIGJyb2tlbiBvbiBtYWNPUyBTaWVycmEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vaW50ZXJmYWNlcy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0 bWwvZG9tL2ludGVyZmFjZXMtZXhwZWN0ZWQudHh0CmluZGV4IDg4NzAzYTYwNDcyNTc4ODU2MWU1 YzdmODhhOWVlOTU3NTExOGI2NDguLjQ5MTg1YThmNjQ1YTljNWE5ZDFlZWEwOWQ0YWE3YTA0NzE1 Y2Y3YjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvaHRtbC9kb20vaW50ZXJmYWNlcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9pbnRlcmZhY2VzLWV4cGVj dGVkLnR4dApAQCAtOTY2LDcgKzk2Niw3IEBAIFBBU1MgSFRNTEVsZW1lbnQgaW50ZXJmYWNlOiBh dHRyaWJ1dGUgdGl0bGUKIFBBU1MgSFRNTEVsZW1lbnQgaW50ZXJmYWNlOiBhdHRyaWJ1dGUgbGFu ZyAKIFBBU1MgSFRNTEVsZW1lbnQgaW50ZXJmYWNlOiBhdHRyaWJ1dGUgdHJhbnNsYXRlIAogUEFT UyBIVE1MRWxlbWVudCBpbnRlcmZhY2U6IGF0dHJpYnV0ZSBkaXIgCi1GQUlMIEhUTUxFbGVtZW50 IGludGVyZmFjZTogYXR0cmlidXRlIGRhdGFzZXQgYXNzZXJ0X293bl9wcm9wZXJ0eTogZXhwZWN0 ZWQgcHJvcGVydHkgImRhdGFzZXQiIG1pc3NpbmcKK1BBU1MgSFRNTEVsZW1lbnQgaW50ZXJmYWNl OiBhdHRyaWJ1dGUgZGF0YXNldCAKIFBBU1MgSFRNTEVsZW1lbnQgaW50ZXJmYWNlOiBhdHRyaWJ1 dGUgaGlkZGVuIAogUEFTUyBIVE1MRWxlbWVudCBpbnRlcmZhY2U6IG9wZXJhdGlvbiBjbGljaygp IAogUEFTUyBIVE1MRWxlbWVudCBpbnRlcmZhY2U6IGF0dHJpYnV0ZSB0YWJJbmRleCAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2pzL2RvbS9kb20tc3RhdGljLXByb3BlcnR5LWZvci1pbi1pdGVy YXRpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvanMvZG9tL2RvbS1zdGF0aWMtcHJvcGVy dHktZm9yLWluLWl0ZXJhdGlvbi1leHBlY3RlZC50eHQKaW5kZXggMmI3Y2JiNzI0ZDE5MTgwMWE5 MDExMGVhZTQxYWYyNmNlZTBhNGE3ZS4uYTZmYWNiZGE4YzJjZjUyMTBkNTE4OGQ0YTY2ZTdiYmJi OGNkNzc3NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvanMvZG9tL2RvbS1zdGF0aWMtcHJvcGVy dHktZm9yLWluLWl0ZXJhdGlvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvanMvZG9t L2RvbS1zdGF0aWMtcHJvcGVydHktZm9yLWluLWl0ZXJhdGlvbi1leHBlY3RlZC50eHQKQEAgLTQ1 LDYgKzQ1LDcgQEAgUEFTUyBhWyJvdXRlclRleHQiXSBpcyBuZXJnZXQKIFBBU1MgYVsiY29udGVu dEVkaXRhYmxlIl0gaXMgaW5oZXJpdAogUEFTUyBhWyJpc0NvbnRlbnRFZGl0YWJsZSJdIGlzIGZh bHNlCiBQQVNTIGFbInNwZWxsY2hlY2siXSBpcyB0cnVlCitQQVNTIGFbImRhdGFzZXQiXSBpcyBb b2JqZWN0IERPTVN0cmluZ01hcF0KIFBBU1MgYVsib25hYm9ydCJdIGlzIG51bGwKIFBBU1MgYVsi b25ibHVyIl0gaXMgbnVsbAogUEFTUyBhWyJvbmNhbnBsYXkiXSBpcyBudWxsCkBAIC0xMDQsNyAr MTA1LDcgQEAgUEFTUyBhWyJhdHRyaWJ1dGVzIl0gaXMgW29iamVjdCBOYW1lZE5vZGVNYXBdCiBQ QVNTIGFbInN0eWxlIl0gaXMgW29iamVjdCBDU1NTdHlsZURlY2xhcmF0aW9uXQogUEFTUyBhWyJp ZCJdIGlzIGZvbwogUEFTUyBhWyJvZmZzZXRMZWZ0Il0gaXMgOAotUEFTUyBhWyJvZmZzZXRUb3Ai XSBpcyAxNTk5CitQQVNTIGFbIm9mZnNldFRvcCJdIGlzIDE2MTQKIFBBU1MgYVsib2Zmc2V0V2lk dGgiXSBpcyA0MAogUEFTUyBhWyJvZmZzZXRIZWlnaHQiXSBpcyAxOAogUEFTUyBhWyJjbGllbnRM ZWZ0Il0gaXMgMApAQCAtMTIwLDcgKzEyMSw2IEBAIFBBU1MgYVsiaW5uZXJIVE1MIl0gaXMgbmVy Z2V0CiBQQVNTIGFbIm91dGVySFRNTCJdIGlzIDxhIGlkPSJmb28iIGhyZWY9ImJhciI+bmVyZ2V0 PC9hPgogUEFTUyBhWyJjbGFzc05hbWUiXSBpcyAKIFBBU1MgYVsiY2xhc3NMaXN0Il0gaXMgCi1Q QVNTIGFbImRhdGFzZXQiXSBpcyBbb2JqZWN0IERPTVN0cmluZ01hcF0KIFBBU1MgYVsidWlhY3Rp b25zIl0gaXMgCiBQQVNTIGFbIndlYmtpdFJlZ2lvbk92ZXJzZXQiXSBpcyB1bmRlZmluZWQKIFBB U1MgYVsic2hhZG93Um9vdCJdIGlzIG51bGwK