160746 2016-08-10 13:39:02 -0700 Optimization in Node.insertBefore() is not spec-compliant 2017-01-20 20:38:46 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 1 cdumez cdumez cdumez commit-queue ddkilzer esprehn+autocc kangil.han rniwa oldest_to_newest 1219111 0 cdumez 2016-08-10 13:39:02 -0700 We have an optimization in Node.insertBefore(newNode, refChild) to avoid doing any work when newNode == refChild or newNode.nextSibling == refChild. This optimization is not in the specification: - https://dom.spec.whatwg.org/#concept-node-replace The issue is that this optimization is observable with DOM mutation observers / listeners or DOM ranges. 1219158 1 285768 cdumez 2016-08-10 15:06:40 -0700 Created attachment 285768 Patch 1219245 2 285768 commit-queue 2016-08-10 19:23:11 -0700 Comment on attachment 285768 Patch Clearing flags on attachment: 285768 Committed r204368: <http://trac.webkit.org/changeset/204368> 1219246 3 commit-queue 2016-08-10 19:23:20 -0700 All reviewed patches have been landed. Closing bug. 1268712 4 ddkilzer 2017-01-20 20:38:46 -0800 <rdar://problem/29393697> 285768 2016-08-10 15:06:40 -0700 2016-08-10 19:23:11 -0700 Patch bug-160746-20160810150504.patch text/plain 15137 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmEyYmFjNjAzMjE0OTEx ZWM5Y2E5NWFlYTA4NTI3ZmE1MGRjZjZjNS4uNTVmYTQwM2U3NWM4M2M0ZTYzY2Q4ODZkMTUxNDYw YzBkOTI3ZmZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDQyIEBACiAyMDE2LTA4LTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgT3B0aW1pemF0aW9uIGluIE5v ZGUuaW5zZXJ0QmVmb3JlKCkgaXMgbm90IHNwZWMtY29tcGxpYW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA3NDYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIGFuIG9wdGltaXphdGlvbiBp biBOb2RlLmluc2VydEJlZm9yZShuZXdOb2RlLCByZWZDaGlsZCkgdG8gYXZvaWQKKyAgICAgICAg ZG9pbmcgYW55IHdvcmsgd2hlbiBuZXdOb2RlID09IHJlZkNoaWxkIG9yIG5ld05vZGUubmV4dFNp YmxpbmcgPT0gcmVmQ2hpbGQuCisKKyAgICAgICAgVGhpcyBvcHRpbWl6YXRpb24gaXMgbm90IGlu IHRoZSBzcGVjaWZpY2F0aW9uOgorICAgICAgICAtIGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9y Zy8jY29uY2VwdC1ub2RlLXJlcGxhY2UKKworICAgICAgICBUaGUgaXNzdWUgaXMgdGhhdCB0aGlz IG9wdGltaXphdGlvbiBpcyBvYnNlcnZhYmxlIHdpdGggRE9NIG11dGF0aW9uCisgICAgICAgIG9i c2VydmVycyAvIGxpc3RlbmVycyBvciBET00gcmFuZ2VzLgorCisgICAgICAgIFRoaXMgcGF0Y2gg YWRkcmVzc2VzIHRoZSBpc3N1ZSBieSBkcm9wcGluZyB0aGUgb3B0aW1pemF0aW9uLiBUaGlzIGNh c2UKKyAgICAgICAgZG9lcyBub3Qgc2VlbSBjb21tb24gZW5vdWdoIHRvIGJlIHdvcnRoIG9wdGlt aXppbmcgZm9yLiBIb3dldmVyLCBpZiBpdAorICAgICAgICB0dXJucyBvdXQgdG8gcmVncmVzcyB0 aGUgcGVyZm9ybWFuY2Ugb2YgdGhpbmdzIHdlIGNhcmUgYWJvdXQsIHdlIGNvdWxkCisgICAgICAg IGZhbGxiYWNrIHRvIGRvaW5nIHRoZSBvcHRpbWl6YXRpb24gb25seSB3aGVuIGl0IGlzIG5vdCBv YnNlcnZhYmxlLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZG9tL05vZGUvaW5zZXJ0QmVmb3JlLW5v LW9wLW11dGF0aW9ub2JzZXJ2ZXIuaHRtbAorCisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2hlY2tBY2NlcHRDaGlsZCk6CisgICAgICAgIE1vdmUg cmVmQ2hpbGQtPnBhcmVudCgpID09IHBhcmVudCBjaGVjayBmcm9tIGluc2VydEJlZm9yZSgpIHRv IG91cgorICAgICAgICBwcmUtaW5zZXJ0aW9uIGNoZWNrIGZ1bmN0aW9uLCByaWdodCBhZnRlciBj aGVja2luZyBpZiBuZXdOb2RlIGNvbnRhaW5zCisgICAgICAgIHBhcmVudC4gVGhpcyB3YXMgZG9u ZSBpbiBvcmRlciB0byBtYXRjaCBtb3JlIGNsb3NlbHkgdGhlIHNwZWNpZmljYXRpb24KKyAgICAg ICAgYW5kIHRvIG1ha2Ugc3VyZSB0aGF0IGV4Y2VwdGlvbiBhcmUgdGhyb3duIGluIHRoZSBjb3Jy ZWN0IG9yZGVyOgorICAgICAgICAtIGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jY29uY2Vw dC1ub2RlLWVuc3VyZS1wcmUtaW5zZXJ0aW9uLXZhbGlkaXR5IChzdGVwcyAyIGFuZCAzKQorCisg ICAgICAgIChXZWJDb3JlOjpDb250YWluZXJOb2RlOjppbnNlcnRCZWZvcmUpOgorICAgICAgICAx LiBEcm9wIHRoZSAocmVmQ2hpbGQtPnByZXZpb3VzU2libGluZygpID09ICZuZXdDaGlsZCB8fCBy ZWZDaGlsZCA9PSAmbmV3Q2hpbGQpCisgICAgICAgICAgIG9wdGltaXphdGlvbiBhcyBpdCBpcyBu b3Qgc3BjLWNvbXBsaWFudC4KKyAgICAgICAgMi4gSWYgcmVmQ2hpbGQgaXMgbmV3Tm9kZSwgdGhl biBzZXQgcmVmQ2hpbGQgdG8gbmV3Q2hpbGQubmV4dFNpYmxpbmcgYXMgcGVyOgorICAgICAgICAg ICAtIGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jY29uY2VwdC1ub2RlLXByZS1pbnNlcnQg KHN0ZXAgMykKKworMjAxNi0wOC0xMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CiAgICAgICAgIEl0IHNob3VsZCBiZSBwb3NzaWJsZSB0byByZS1pbml0aWFsaXplIGEgTXV0YXRp b25FdmVudCBhZnRlciBpdCdzIGJlZW4gZGlzcGF0Y2hlZAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzAzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWlu ZXJOb2RlLmNwcAppbmRleCA0ZDJlMWQ0Mzc1NGY3MGNiY2I0MTVjNGYzYzBjZmVhNDExMWQ2NWVi Li41ZTk3ZWU3NjA1NjUxZTQzMTE5MmZjOWM1YjBkYTY4ODJkNTBjOTFhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL0NvbnRhaW5lck5vZGUuY3BwCkBAIC0xODMsNiArMTgzLDggQEAgc3RhdGljIGlubGluZSBF eGNlcHRpb25Db2RlIGNoZWNrQWNjZXB0Q2hpbGQoQ29udGFpbmVyTm9kZSYgbmV3UGFyZW50LCBO b2RlJiBuZXcKICAgICAgICAgQVNTRVJUKGlzQ2hpbGRUeXBlQWxsb3dlZChuZXdQYXJlbnQsIG5l d0NoaWxkKSk7CiAgICAgICAgIGlmIChjb250YWluc0NvbnNpZGVyaW5nSG9zdEVsZW1lbnRzKG5l d0NoaWxkLCBuZXdQYXJlbnQpKQogICAgICAgICAgICAgcmV0dXJuIEhJRVJBUkNIWV9SRVFVRVNU X0VSUjsKKyAgICAgICAgaWYgKG9wZXJhdGlvbiA9PSBEb2N1bWVudDo6QWNjZXB0Q2hpbGRPcGVy YXRpb246Okluc2VydE9yQWRkICYmIHJlZkNoaWxkICYmIHJlZkNoaWxkLT5wYXJlbnROb2RlKCkg IT0gJm5ld1BhcmVudCkKKyAgICAgICAgICAgIHJldHVybiBOT1RfRk9VTkRfRVJSOwogICAgICAg ICByZXR1cm4gMDsKICAgICB9CiAKQEAgLTE5NCw2ICsxOTYsOSBAQCBzdGF0aWMgaW5saW5lIEV4 Y2VwdGlvbkNvZGUgY2hlY2tBY2NlcHRDaGlsZChDb250YWluZXJOb2RlJiBuZXdQYXJlbnQsIE5v ZGUmIG5ldwogICAgIGlmIChjb250YWluc0NvbnNpZGVyaW5nSG9zdEVsZW1lbnRzKG5ld0NoaWxk LCBuZXdQYXJlbnQpKQogICAgICAgICByZXR1cm4gSElFUkFSQ0hZX1JFUVVFU1RfRVJSOwogCisg ICAgaWYgKG9wZXJhdGlvbiA9PSBEb2N1bWVudDo6QWNjZXB0Q2hpbGRPcGVyYXRpb246Okluc2Vy dE9yQWRkICYmIHJlZkNoaWxkICYmIHJlZkNoaWxkLT5wYXJlbnROb2RlKCkgIT0gJm5ld1BhcmVu dCkKKyAgICAgICAgcmV0dXJuIE5PVF9GT1VORF9FUlI7CisKICAgICBpZiAoaXM8RG9jdW1lbnQ+ KG5ld1BhcmVudCkpIHsKICAgICAgICAgaWYgKCFkb3duY2FzdDxEb2N1bWVudD4obmV3UGFyZW50 KS5jYW5BY2NlcHRDaGlsZChuZXdDaGlsZCwgcmVmQ2hpbGQsIG9wZXJhdGlvbikpCiAgICAgICAg ICAgICByZXR1cm4gSElFUkFSQ0hZX1JFUVVFU1RfRVJSOwpAQCAtMjM1LDI3ICsyNDAsMjAgQEAg Ym9vbCBDb250YWluZXJOb2RlOjppbnNlcnRCZWZvcmUoTm9kZSYgbmV3Q2hpbGQsIE5vZGUqIHJl ZkNoaWxkLCBFeGNlcHRpb25Db2RlJgogICAgIC8vIElmIGl0IGlzLCBpdCBjYW4gYmUgZGVsZXRl ZCBhcyBhIHNpZGUgZWZmZWN0IG9mIHNlbmRpbmcgbXV0YXRpb24gZXZlbnRzLgogICAgIEFTU0VS VChyZWZDb3VudCgpIHx8IHBhcmVudE9yU2hhZG93SG9zdE5vZGUoKSk7CiAKLSAgICBSZWY8Q29u dGFpbmVyTm9kZT4gcHJvdGVjdGVkVGhpcygqdGhpcyk7Ci0KICAgICBlYyA9IDA7CiAKLSAgICAv LyBpbnNlcnRCZWZvcmUobm9kZSwgMCkgaXMgZXF1aXZhbGVudCB0byBhcHBlbmRDaGlsZChub2Rl KQotICAgIGlmICghcmVmQ2hpbGQpCi0gICAgICAgIHJldHVybiBhcHBlbmRDaGlsZChuZXdDaGls ZCwgZWMpOwotCiAgICAgLy8gTWFrZSBzdXJlIGFkZGluZyB0aGUgbmV3IGNoaWxkIGlzIE9LLgog ICAgIGlmICghZW5zdXJlUHJlSW5zZXJ0aW9uVmFsaWRpdHkobmV3Q2hpbGQsIHJlZkNoaWxkLCBl YykpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIC8vIE5PVF9GT1VORF9FUlI6IFJhaXNl ZCBpZiByZWZDaGlsZCBpcyBub3QgYSBjaGlsZCBvZiB0aGlzIG5vZGUKLSAgICBpZiAocmVmQ2hp bGQtPnBhcmVudE5vZGUoKSAhPSB0aGlzKSB7Ci0gICAgICAgIGVjID0gTk9UX0ZPVU5EX0VSUjsK LSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KKyAgICBpZiAocmVmQ2hpbGQgPT0gJm5ld0No aWxkKQorICAgICAgICByZWZDaGlsZCA9IG5ld0NoaWxkLm5leHRTaWJsaW5nKCk7CiAKLSAgICBp ZiAocmVmQ2hpbGQtPnByZXZpb3VzU2libGluZygpID09ICZuZXdDaGlsZCB8fCByZWZDaGlsZCA9 PSAmbmV3Q2hpbGQpIC8vIG5vdGhpbmcgdG8gZG8KLSAgICAgICAgcmV0dXJuIHRydWU7CisgICAg Ly8gaW5zZXJ0QmVmb3JlKG5vZGUsIG51bGwpIGlzIGVxdWl2YWxlbnQgdG8gYXBwZW5kQ2hpbGQo bm9kZSkKKyAgICBpZiAoIXJlZkNoaWxkKQorICAgICAgICByZXR1cm4gYXBwZW5kQ2hpbGRXaXRo b3V0UHJlSW5zZXJ0aW9uVmFsaWRpdHlDaGVjayhuZXdDaGlsZCwgZWMpOwogCisgICAgUmVmPENv bnRhaW5lck5vZGU+IHByb3RlY3RlZFRoaXMoKnRoaXMpOwogICAgIFJlZjxOb2RlPiBuZXh0KCpy ZWZDaGlsZCk7CiAKICAgICBOb2RlVmVjdG9yIHRhcmdldHM7CkBAIC02NDAsOCArNjM4LDYgQEAg dm9pZCBDb250YWluZXJOb2RlOjpyZW1vdmVDaGlsZHJlbigpCiAKIGJvb2wgQ29udGFpbmVyTm9k ZTo6YXBwZW5kQ2hpbGQoTm9kZSYgbmV3Q2hpbGQsIEV4Y2VwdGlvbkNvZGUmIGVjKQogewotICAg IFJlZjxDb250YWluZXJOb2RlPiBwcm90ZWN0ZWRUaGlzKCp0aGlzKTsKLQogICAgIC8vIENoZWNr IHRoYXQgdGhpcyBub2RlIGlzIG5vdCAiZmxvYXRpbmciLgogICAgIC8vIElmIGl0IGlzLCBpdCBj YW4gYmUgZGVsZXRlZCBhcyBhIHNpZGUgZWZmZWN0IG9mIHNlbmRpbmcgbXV0YXRpb24gZXZlbnRz LgogICAgIEFTU0VSVChyZWZDb3VudCgpIHx8IHBhcmVudE9yU2hhZG93SG9zdE5vZGUoKSk7CkBA IC02NTIsNiArNjQ4LDEzIEBAIGJvb2wgQ29udGFpbmVyTm9kZTo6YXBwZW5kQ2hpbGQoTm9kZSYg bmV3Q2hpbGQsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIGlmICghZW5zdXJlUHJlSW5zZXJ0aW9u VmFsaWRpdHkobmV3Q2hpbGQsIG51bGxwdHIsIGVjKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CisgICAgcmV0dXJuIGFwcGVuZENoaWxkV2l0aG91dFByZUluc2VydGlvblZhbGlkaXR5Q2hlY2so bmV3Q2hpbGQsIGVjKTsKK30KKworYm9vbCBDb250YWluZXJOb2RlOjphcHBlbmRDaGlsZFdpdGhv dXRQcmVJbnNlcnRpb25WYWxpZGl0eUNoZWNrKE5vZGUmIG5ld0NoaWxkLCBFeGNlcHRpb25Db2Rl JiBlYykKK3sKKyAgICBSZWY8Q29udGFpbmVyTm9kZT4gcHJvdGVjdGVkVGhpcygqdGhpcyk7CisK ICAgICBOb2RlVmVjdG9yIHRhcmdldHM7CiAgICAgY29sbGVjdENoaWxkcmVuQW5kUmVtb3ZlRnJv bU9sZFBhcmVudChuZXdDaGlsZCwgdGFyZ2V0cywgZWMpOwogICAgIGlmIChlYykKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9k b20vQ29udGFpbmVyTm9kZS5oCmluZGV4IDlkYTc5NWNjYTg0ZjZiZGM3OGE5NGVkNTc1MmU0Mzll NmYyMTI3YzIuLjE5MWU1Njk0N2Q5ZjEzNzNlNjBjNTYyODA1MjE1MGJkODYwOTk4NGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmgKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuaApAQCAtMTE3LDYgKzExNyw3IEBAIHByb3RlY3RlZDoK IAogcHJpdmF0ZToKICAgICB2b2lkIHJlbW92ZUJldHdlZW4oTm9kZSogcHJldmlvdXNDaGlsZCwg Tm9kZSogbmV4dENoaWxkLCBOb2RlJiBvbGRDaGlsZCk7CisgICAgYm9vbCBhcHBlbmRDaGlsZFdp dGhvdXRQcmVJbnNlcnRpb25WYWxpZGl0eUNoZWNrKE5vZGUmLCBFeGNlcHRpb25Db2RlJik7CiAg ICAgdm9pZCBpbnNlcnRCZWZvcmVDb21tb24oTm9kZSYgbmV4dENoaWxkLCBOb2RlJiBvbGRDaGls ZCk7CiAgICAgdm9pZCBhcHBlbmRDaGlsZENvbW1vbihOb2RlJik7CiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiMTA3MGZh ZmZmZDAzNWNlY2I2MDNjYmNkYjU0MzkwOTQxNTgxYWRlLi4xMzBhYzI4ODQyZWYwM2FmZDA3NzNh NmI1NjhjN2UzZmM0M2RmNjIxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTYtMDgtMTAgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAorICAgICAgICBPcHRpbWl6YXRpb24gaW4g Tm9kZS5pbnNlcnRCZWZvcmUoKSBpcyBub3Qgc3BlYy1jb21wbGlhbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDc0NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsYXlvdXQgdGVzdCB0byBtYWtl IHN1cmUgbXV0YXRpb24gb2JzZXJ2ZXJzIC8gbGlzdGVuZXJzIGFyZSBhbHdheXMKKyAgICAgICAg bm90aWZpZWQgd2hlbiBOb2RlLmluc2VydEJlZm9yZSgpIGlzIGNhbGxlZC4KKworICAgICAgICAq IGZhc3QvZG9tL05vZGUvaW5zZXJ0QmVmb3JlLW5vLW9wLW11dGF0aW9ub2JzZXJ2ZXItZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9Ob2RlL2luc2VydEJlZm9yZS1uby1v cC1tdXRhdGlvbm9ic2VydmVyLmh0bWw6IEFkZGVkLgorCisyMDE2LTA4LTEwICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRv IHJlLWluaXRpYWxpemUgYSBNdXRhdGlvbkV2ZW50IGFmdGVyIGl0J3MgYmVlbiBkaXNwYXRjaGVk CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjA3MDMK IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggY2JiYzdkMzFiNGUyZGM1NjRiNjIz Y2I1ZDM5ZDcwNjNiYzQ3YTRhYy4uZTk2ZmE5M2U2NjE4OTIyNTVlMmMyMWY4ZDk4YTBjMmQ1MzE2 ZWJmNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIw MTYtMDgtMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBPcHRp bWl6YXRpb24gaW4gTm9kZS5pbnNlcnRCZWZvcmUoKSBpcyBub3Qgc3BlYy1jb21wbGlhbnQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDc0NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFzZWxpbmUg VzNDIHRlc3Qgbm93IHRoYXQgbW9yZSBjaGVja3MgYXJlIHBhc3NpbmcuCisKKyAgICAgICAgKiB3 ZWItcGxhdGZvcm0tdGVzdHMvZG9tL3Jhbmdlcy9SYW5nZS1tdXRhdGlvbnMtZXhwZWN0ZWQudHh0 OgorCiAyMDE2LTA4LTA5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgT3B0aW1pemF0aW9uIGluIE5vZGUucmVwbGFjZUNoaWxkKCkgaXMgbm90IHNwZWMtY29tcGxp YW50CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL2luc2VydEJlZm9yZS1u by1vcC1tdXRhdGlvbm9ic2VydmVyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L05vZGUvaW5zZXJ0QmVmb3JlLW5vLW9wLW11dGF0aW9ub2JzZXJ2ZXItZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjc1YzBlOTcwN2E2YWZiY2E0NDdmMWNhMzZkN2Q3ODExN2E0ZDk4NWQKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL2luc2VydEJlZm9yZS1uby1v cC1tdXRhdGlvbm9ic2VydmVyLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEzIEBACitUZXN0cyB0 aGF0IGNhbGxzIG9mIGluc2VydEJlZm9yZSgpIGxlYWQgdG8gbXV0YXRpb24gZXZlbnRzIGV2ZW4g aWYgdGhleSBhcmUgbm8tb3BzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFT UyBNdXRhdGlvbiBvYnNlcnZlciB3YXMgbm90aWZpZWQKK1BBU1Mgd2FzTXV0YXRpb25FdmVudExp c3RlbmVyQ2FsbGVkIGlzIHRydWUKK1BBU1MgTXV0YXRpb24gb2JzZXJ2ZXIgd2FzIG5vdGlmaWVk CitQQVNTIHdhc011dGF0aW9uRXZlbnRMaXN0ZW5lckNhbGxlZCBpcyB0cnVlCitQQVNTIHN1Y2Nl c3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vTm9kZS9pbnNlcnRCZWZvcmUtbm8tb3AtbXV0YXRpb25vYnNlcnZl ci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vTm9kZS9pbnNlcnRCZWZvcmUtbm8tb3AtbXV0 YXRpb25vYnNlcnZlci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjlhZTU3YTAzMjVhOTQyYmYwZGRhNGViZmFj YmZhZDE3YWM5YjFlMTYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9O b2RlL2luc2VydEJlZm9yZS1uby1vcC1tdXRhdGlvbm9ic2VydmVyLmh0bWwKQEAgLTAsMCArMSw1 NyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uLy4u Ly4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8ZGl2IGlkPSJ0ZXN0RGl2 Ij48cD48L3A+PHA+PC9wPjwvZGl2PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUZXN0cyB0aGF0 IGNhbGxzIG9mIGluc2VydEJlZm9yZSgpIGxlYWQgdG8gbXV0YXRpb24gZXZlbnRzIGV2ZW4gaWYg dGhleSBhcmUgbm8tb3BzLiIpOworanNUZXN0SXNBc3luYyA9IHRydWU7CisKK3ZhciB0ZXN0RGl2 ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3REaXYiKTsKK3ZhciBwMSA9IHRlc3REaXYu Zmlyc3RDaGlsZDsKK3ZhciBwMiA9IHRlc3REaXYubGFzdENoaWxkOworCit2YXIgb3BlcmF0aW9u cyA9IFsKKyAgICBmdW5jdGlvbigpIHsgdGVzdERpdi5pbnNlcnRCZWZvcmUocDEsIHAxKTsgfSwK KyAgICBmdW5jdGlvbigpIHsgdGVzdERpdi5pbnNlcnRCZWZvcmUocDEsIHAyKTsgfQorXTsKK3Zh ciBjdXJyZW50T3BlcmF0aW9uID0gMDsKKworZnVuY3Rpb24gdGVzdE11dGF0aW9uT2JzZXJ2ZXIo KQoreworICAgIHZhciBjb25maWcgPSB7IGNoaWxkTGlzdDogdHJ1ZSB9OworICAgIHZhciBvYnNl cnZlciA9IG5ldyBNdXRhdGlvbk9ic2VydmVyKGZ1bmN0aW9uKG11dGF0aW9ucykgeworICAgICAg ICB0ZXN0UGFzc2VkKCJNdXRhdGlvbiBvYnNlcnZlciB3YXMgbm90aWZpZWQiKTsKKyAgICAgICAg b2JzZXJ2ZXIuZGlzY29ubmVjdCgpOworICAgICAgICB0ZXN0TXV0YXRpb25FdmVudExpc3RlbmVy KCk7CisgICAgfSk7CisKKyAgICBvYnNlcnZlci5vYnNlcnZlKHRlc3REaXYsIGNvbmZpZyk7Cisg ICAgb3BlcmF0aW9uc1tjdXJyZW50T3BlcmF0aW9uXSgpOworfQorCitmdW5jdGlvbiBzdWJ0cmVl TW9kaWZpZWRIYW5kbGVyKCkKK3sKKyAgICB3YXNNdXRhdGlvbkV2ZW50TGlzdGVuZXJDYWxsZWQg PSB0cnVlOworfQorCitmdW5jdGlvbiB0ZXN0TXV0YXRpb25FdmVudExpc3RlbmVyKCkKK3sKKyAg ICB3YXNNdXRhdGlvbkV2ZW50TGlzdGVuZXJDYWxsZWQgPSBmYWxzZTsKKyAgICB0ZXN0RGl2LmFk ZEV2ZW50TGlzdGVuZXIoIkRPTVN1YnRyZWVNb2RpZmllZCIsIHN1YnRyZWVNb2RpZmllZEhhbmRs ZXIpOworICAgIG9wZXJhdGlvbnNbY3VycmVudE9wZXJhdGlvbl0oKTsKKyAgICBzaG91bGRCZVRy dWUoIndhc011dGF0aW9uRXZlbnRMaXN0ZW5lckNhbGxlZCIpOworICAgIHRlc3REaXYucmVtb3Zl RXZlbnRMaXN0ZW5lcigiRE9NU3VidHJlZU1vZGlmaWVkIiwgc3VidHJlZU1vZGlmaWVkSGFuZGxl cik7CisKKyAgICBjdXJyZW50T3BlcmF0aW9uKys7CisgICAgaWYgKGN1cnJlbnRPcGVyYXRpb24g PCBvcGVyYXRpb25zLmxlbmd0aCkKKyAgICAgICAgdGVzdE11dGF0aW9uT2JzZXJ2ZXIoKTsKKyAg ICBlbHNlCisgICAgICAgIGZpbmlzaEpTVGVzdCgpOworfQorCit0ZXN0TXV0YXRpb25PYnNlcnZl cigpOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3Qt cG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9yYW5nZXMvUmFuZ2UtbXV0 YXRpb25zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvZG9tL3Jhbmdlcy9SYW5nZS1tdXRhdGlvbnMtZXhwZWN0ZWQudHh0CmluZGV4IDc4 ZmIzOWY2Mzc5YzhjMzI4NGRkZjEzZGZjOWZiOGVhNGNmNGFkNDYuLjQyNzQ2NTUwMjEyNGE1MDI4 YjE5ZDk2MjI1YjQ3MjViOGRkMThlYWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL3Jhbmdlcy9SYW5nZS1tdXRhdGlvbnMtZXhwZWN0 ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv ZG9tL3Jhbmdlcy9SYW5nZS1tdXRhdGlvbnMtZXhwZWN0ZWQudHh0CkBAIC01NTA3LDE4ICs1NTA3 LDEyIEBAIFBBU1MgZGV0YWNoZWRYbWxDb21tZW50Lm5vZGVWYWx1ZSArPSAiZm9vIiwgd2l0aCB1 bnNlbGVjdGVkIHJhbmdlIGNvbGxhcHNlZCBhdCAoCiBGQUlMIGRldGFjaGVkWG1sQ29tbWVudC5u b2RlVmFsdWUgKz0gImZvbyIsIHdpdGggc2VsZWN0ZWQgcmFuZ2UgY29sbGFwc2VkIGF0IChkZXRh Y2hlZFhtbENvbW1lbnQsIGRldGFjaGVkWG1sQ29tbWVudC5sZW5ndGgpIGFzc2VydF9lcXVhbHM6 IFNhbml0eSBjaGVjazogc2VsZWN0aW9uIG11c3QgaGF2ZSBleGFjdGx5IG9uZSByYW5nZSBhZnRl ciBhZGRpbmcgdGhlIHJhbmdlIGV4cGVjdGVkIDEgYnV0IGdvdCAwCiBQQVNTIGRldGFjaGVkWG1s Q29tbWVudC5ub2RlVmFsdWUgKz0gZGV0YWNoZWRYbWxDb21tZW50Lm5vZGVWYWx1ZSwgd2l0aCB1 bnNlbGVjdGVkIHJhbmdlIGNvbGxhcHNlZCBhdCAoZGV0YWNoZWRYbWxDb21tZW50LCBkZXRhY2hl ZFhtbENvbW1lbnQubGVuZ3RoKSAKIEZBSUwgZGV0YWNoZWRYbWxDb21tZW50Lm5vZGVWYWx1ZSAr PSBkZXRhY2hlZFhtbENvbW1lbnQubm9kZVZhbHVlLCB3aXRoIHNlbGVjdGVkIHJhbmdlIGNvbGxh cHNlZCBhdCAoZGV0YWNoZWRYbWxDb21tZW50LCBkZXRhY2hlZFhtbENvbW1lbnQubGVuZ3RoKSBh c3NlcnRfZXF1YWxzOiBTYW5pdHkgY2hlY2s6IHNlbGVjdGlvbiBtdXN0IGhhdmUgZXhhY3RseSBv bmUgcmFuZ2UgYWZ0ZXIgYWRkaW5nIHRoZSByYW5nZSBleHBlY3RlZCAxIGJ1dCBnb3QgMAotRkFJ TCB0ZXN0RGl2Lmluc2VydEJlZm9yZShwYXJhc1swXSwgcGFyYXNbMV0pLCB3aXRoIHVuc2VsZWN0 ZWQgcmFuZ2UgY29sbGFwc2VkIGF0IChwYXJhc1swXSwgMCkgYXNzZXJ0X2VxdWFsczogV3Jvbmcg c3RhcnQgY29udGFpbmVyIGV4cGVjdGVkIEVsZW1lbnQgbm9kZSA8ZGl2IGlkPSJ0ZXN0Ij48cCBp ZD0iYSI+QcyIYsyIY8yIZMyIZcyIZsyIZ8yIaMyICi08L3A+PHAgaWQ9ImIiIHMuLi4gYnV0IGdv dCBFbGVtZW50IG5vZGUgPHAgaWQ9ImEiPkHMiGLMiGPMiGTMiGXMiGbMiGfMiGjMiAotPC9wPgor UEFTUyB0ZXN0RGl2Lmluc2VydEJlZm9yZShwYXJhc1swXSwgcGFyYXNbMV0pLCB3aXRoIHVuc2Vs ZWN0ZWQgcmFuZ2UgY29sbGFwc2VkIGF0IChwYXJhc1swXSwgMCkgCiBGQUlMIHRlc3REaXYuaW5z ZXJ0QmVmb3JlKHBhcmFzWzBdLCBwYXJhc1sxXSksIHdpdGggc2VsZWN0ZWQgcmFuZ2UgY29sbGFw c2VkIGF0IChwYXJhc1swXSwgMCkgYXNzZXJ0X2VxdWFsczogU2FuaXR5IGNoZWNrOiBzZWxlY3Rp b24ncyByYW5nZSBtdXN0IGluaXRpYWxseSBiZSB0aGUgc2FtZSBhcyB0aGUgcmFuZ2Ugd2UgYWRk ZWQgZXhwZWN0ZWQgb2JqZWN0ICIiIGJ1dCBnb3Qgb2JqZWN0ICIiCi1GQUlMIHRlc3REaXYuaW5z ZXJ0QmVmb3JlKHBhcmFzWzBdLCBwYXJhc1sxXSksIHdpdGggdW5zZWxlY3RlZCByYW5nZSBvbiBw YXJhc1swXSBmcm9tIDAgdG8gMSBhc3NlcnRfZXF1YWxzOiBXcm9uZyBzdGFydCBjb250YWluZXIg ZXhwZWN0ZWQgRWxlbWVudCBub2RlIDxkaXYgaWQ9InRlc3QiPjxwIGlkPSJhIj5BzIhizIhjzIhk zIhlzIhmzIhnzIhozIgKLTwvcD48cCBpZD0iYiIgcy4uLiBidXQgZ290IEVsZW1lbnQgbm9kZSA8 cCBpZD0iYSI+QcyIYsyIY8yIZMyIZcyIZsyIZ8yIaMyICi08L3A+CitQQVNTIHRlc3REaXYuaW5z ZXJ0QmVmb3JlKHBhcmFzWzBdLCBwYXJhc1sxXSksIHdpdGggdW5zZWxlY3RlZCByYW5nZSBvbiBw YXJhc1swXSBmcm9tIDAgdG8gMSAKIEZBSUwgdGVzdERpdi5pbnNlcnRCZWZvcmUocGFyYXNbMF0s IHBhcmFzWzFdKSwgd2l0aCBzZWxlY3RlZCByYW5nZSBvbiBwYXJhc1swXSBmcm9tIDAgdG8gMSBh c3NlcnRfZXF1YWxzOiBTYW5pdHkgY2hlY2s6IHNlbGVjdGlvbidzIHJhbmdlIG11c3QgaW5pdGlh bGx5IGJlIHRoZSBzYW1lIGFzIHRoZSByYW5nZSB3ZSBhZGRlZCBleHBlY3RlZCBvYmplY3QgIkHM iGLMiGPMiGTMiGXMiGbMiGfMiGjMiAogIiBidXQgZ290IG9iamVjdCAiQcyIYsyIY8yIZMyIZcyI ZsyIZ8yIaMyIIgotRkFJTCB0ZXN0RGl2Lmluc2VydEJlZm9yZShwYXJhc1swXSwgcGFyYXNbMV0p LCB3aXRoIHVuc2VsZWN0ZWQgcmFuZ2UgY29sbGFwc2VkIGF0IChwYXJhc1swXSwgMSkgYXNzZXJ0 X2VxdWFsczogV3Jvbmcgc3RhcnQgY29udGFpbmVyIGV4cGVjdGVkIEVsZW1lbnQgbm9kZSA8ZGl2 IGlkPSJ0ZXN0Ij48cCBpZD0iYSI+QcyIYsyIY8yIZMyIZcyIZsyIZ8yIaMyICi08L3A+PHAgaWQ9 ImIiIHMuLi4gYnV0IGdvdCBFbGVtZW50IG5vZGUgPHAgaWQ9ImEiPkHMiGLMiGPMiGTMiGXMiGbM iGfMiGjMiAotPC9wPgorUEFTUyB0ZXN0RGl2Lmluc2VydEJlZm9yZShwYXJhc1swXSwgcGFyYXNb MV0pLCB3aXRoIHVuc2VsZWN0ZWQgcmFuZ2UgY29sbGFwc2VkIGF0IChwYXJhc1swXSwgMSkgCiBG QUlMIHRlc3REaXYuaW5zZXJ0QmVmb3JlKHBhcmFzWzBdLCBwYXJhc1sxXSksIHdpdGggc2VsZWN0 ZWQgcmFuZ2UgY29sbGFwc2VkIGF0IChwYXJhc1swXSwgMSkgYXNzZXJ0X2VxdWFsczogU2FuaXR5 IGNoZWNrOiBzZWxlY3Rpb24ncyByYW5nZSBtdXN0IGluaXRpYWxseSBiZSB0aGUgc2FtZSBhcyB0 aGUgcmFuZ2Ugd2UgYWRkZWQgZXhwZWN0ZWQgb2JqZWN0ICIiIGJ1dCBnb3Qgb2JqZWN0ICIiCiBQ QVNTIHRlc3REaXYuaW5zZXJ0QmVmb3JlKHBhcmFzWzBdLCBwYXJhc1sxXSksIHdpdGggdW5zZWxl Y3RlZCByYW5nZSBvbiB0ZXN0RGl2IGZyb20gMCB0byAyIAogRkFJTCB0ZXN0RGl2Lmluc2VydEJl Zm9yZShwYXJhc1swXSwgcGFyYXNbMV0pLCB3aXRoIHNlbGVjdGVkIHJhbmdlIG9uIHRlc3REaXYg ZnJvbSAwIHRvIDIgYXNzZXJ0X2VxdWFsczogU2FuaXR5IGNoZWNrOiBzZWxlY3Rpb24ncyByYW5n ZSBtdXN0IGluaXRpYWxseSBiZSB0aGUgc2FtZSBhcyB0aGUgcmFuZ2Ugd2UgYWRkZWQgZXhwZWN0 ZWQgb2JqZWN0ICJBzIhizIhjzIhkzIhlzIhmzIhnzIhozIgKQEAgLTU1MjYsOSArNTUyMCw5IEBA IElqa2xtbm9wCiAiIGJ1dCBnb3Qgb2JqZWN0ICJBzIhizIhjzIhkzIhlzIhmzIhnzIhozIgKIElq a2xtbm9wCiAiCi1GQUlMIHRlc3REaXYuaW5zZXJ0QmVmb3JlKHBhcmFzWzBdLCBwYXJhc1sxXSks IHdpdGggdW5zZWxlY3RlZCByYW5nZSBjb2xsYXBzZWQgYXQgKHRlc3REaXYsIDEpIGFzc2VydF9l cXVhbHM6IFdyb25nIHN0YXJ0IG9mZnNldCBleHBlY3RlZCAwIGJ1dCBnb3QgMQorUEFTUyB0ZXN0 RGl2Lmluc2VydEJlZm9yZShwYXJhc1swXSwgcGFyYXNbMV0pLCB3aXRoIHVuc2VsZWN0ZWQgcmFu Z2UgY29sbGFwc2VkIGF0ICh0ZXN0RGl2LCAxKSAKIEZBSUwgdGVzdERpdi5pbnNlcnRCZWZvcmUo cGFyYXNbMF0sIHBhcmFzWzFdKSwgd2l0aCBzZWxlY3RlZCByYW5nZSBjb2xsYXBzZWQgYXQgKHRl c3REaXYsIDEpIGFzc2VydF9lcXVhbHM6IFNhbml0eSBjaGVjazogc2VsZWN0aW9uJ3MgcmFuZ2Ug bXVzdCBpbml0aWFsbHkgYmUgdGhlIHNhbWUgYXMgdGhlIHJhbmdlIHdlIGFkZGVkIGV4cGVjdGVk IG9iamVjdCAiIiBidXQgZ290IG9iamVjdCAiIgotRkFJTCB0ZXN0RGl2Lmluc2VydEJlZm9yZShw YXJhc1swXSwgcGFyYXNbMV0pLCB3aXRoIHVuc2VsZWN0ZWQgcmFuZ2Ugb24gdGVzdERpdiBmcm9t IDEgdG8gMiBhc3NlcnRfZXF1YWxzOiBXcm9uZyBzdGFydCBvZmZzZXQgZXhwZWN0ZWQgMCBidXQg Z290IDEKK1BBU1MgdGVzdERpdi5pbnNlcnRCZWZvcmUocGFyYXNbMF0sIHBhcmFzWzFdKSwgd2l0 aCB1bnNlbGVjdGVkIHJhbmdlIG9uIHRlc3REaXYgZnJvbSAxIHRvIDIgCiBGQUlMIHRlc3REaXYu aW5zZXJ0QmVmb3JlKHBhcmFzWzBdLCBwYXJhc1sxXSksIHdpdGggc2VsZWN0ZWQgcmFuZ2Ugb24g dGVzdERpdiBmcm9tIDEgdG8gMiBhc3NlcnRfZXF1YWxzOiBTYW5pdHkgY2hlY2s6IHNlbGVjdGlv bidzIHJhbmdlIG11c3QgaW5pdGlhbGx5IGJlIHRoZSBzYW1lIGFzIHRoZSByYW5nZSB3ZSBhZGRl ZCBleHBlY3RlZCBvYmplY3QgIklqa2xtbm9wCiAiIGJ1dCBnb3Qgb2JqZWN0ICIiCiBQQVNTIHRl c3REaXYuaW5zZXJ0QmVmb3JlKHBhcmFzWzBdLCBwYXJhc1sxXSksIHdpdGggdW5zZWxlY3RlZCBy YW5nZSBjb2xsYXBzZWQgYXQgKHRlc3REaXYsIDIpIAo=