16074 2007-11-20 12:35:55 -0800 execCommand("InsertHorizontalRule", false, "") results in id="" being inserted 2007-11-20 13:36:45 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED http://bdash.net.nz/files/arguments-combinations.html P2 Trivial --- 1 mrowe webkit-unassigned oldest_to_newest 61817 0 mrowe 2007-11-20 12:35:55 -0800 http://bdash.net.nz/files/arguments-combinations.html is a test case using InsertOrderedList rather than InsertHorizontalRule. You'll notice that a test is failing as InsertOrderedList does not insert id="" when the empty string is passed as the value argument. According to the HTML 5 specification an empty id attribute is not valid. I believe that InsertHorizontalRule should match InsertOrderedList/InsertUnorderedList on this point. 61819 1 17419 mrowe 2007-11-20 12:41:03 -0800 Created attachment 17419 Patch 61827 2 17419 sam 2007-11-20 13:20:33 -0800 Comment on attachment 17419 Patch I think a test of InsertOrderedList and InsertUnorderedList with an empty string 3rd parameter would be nice if it doesn't already exist. r=me. 61831 3 mrowe 2007-11-20 13:36:45 -0800 Landed in r27931. 17419 2007-11-20 12:41:03 -0800 2007-11-20 13:20:33 -0800 Patch webkit-bug-16074-v1.patch text/plain 3794 mrowe ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiODE2OTc5Li5lOTExMmRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTEt MjAgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0cyBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzQKKyAgICAgICAgQnVnIDE2MDc0OiBleGVjQ29tbWFuZCgi SW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCBmYWxzZSwgIiIpIHJlc3VsdHMgaW4gaWQ9IiIgYmVpbmcg aW5zZXJ0ZWQKKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvYXJndW1lbnRzLWNvbWJp bmF0aW9ucy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9hcmd1 bWVudHMtY29tYmluYXRpb25zLmh0bWw6CisKIDIwMDctMTEtMjAgIExhcnMgS25vbGwgIDxsYXJz QHRyb2xsdGVjaC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24uCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2FyZ3VtZW50cy1jb21iaW5hdGlvbnMt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9hcmd1bWVudHMt Y29tYmluYXRpb25zLWV4cGVjdGVkLnR4dAppbmRleCA1MjU1MWQyLi45NzdmN2I4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2FyZ3VtZW50cy1jb21iaW5hdGlv bnMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvYXJn dW1lbnRzLWNvbWJpbmF0aW9ucy1leHBlY3RlZC50eHQKQEAgLTYsNyArNiw3IEBAIFBBU1MgPGhy PjwvaHI+IGlzIDxocj48L2hyPgogUEFTUyA8aHI+PC9ocj4gaXMgPGhyPjwvaHI+CiBQQVNTIDxo ciBpZD0iZm9vIj48L2hyPiBpcyA8aHIgaWQ9ImZvbyI+PC9ocj4KIFBBU1MgPGhyIGlkPSJmb28i PjwvaHI+IGlzIDxociBpZD0iZm9vIj48L2hyPgotUEFTUyA8aHIgaWQ9IiI+PC9ocj4gaXMgPGhy IGlkPSIiPjwvaHI+CitQQVNTIDxocj48L2hyPiBpcyA8aHI+PC9ocj4KIFBBU1MgPGhyPjwvaHI+ IGlzIDxocj48L2hyPgogUEFTUyA8aHI+PC9ocj4gaXMgPGhyPjwvaHI+CiBQQVNTIDxociBpZD0i MCI+PC9ocj4gaXMgPGhyIGlkPSIwIj48L2hyPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRp dGluZy9leGVjQ29tbWFuZC9hcmd1bWVudHMtY29tYmluYXRpb25zLmh0bWwgYi9MYXlvdXRUZXN0 cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2FyZ3VtZW50cy1jb21iaW5hdGlvbnMuaHRtbAppbmRleCAw Y2YyZmQyLi5kZWMxYzRkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21t YW5kL2FyZ3VtZW50cy1jb21iaW5hdGlvbnMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5n L2V4ZWNDb21tYW5kL2FyZ3VtZW50cy1jb21iaW5hdGlvbnMuaHRtbApAQCAtNjYsOCArNjYsOCBA QAogICAgICAgICAgICAgICAgIC8vIFRlc3Qgd2l0aCA0IGFyZ3VtZW50cy4gKHNob3VsZCBpZ25v cmUgdGhlIGZvdXJ0aCBhcmd1bWVudCBzaWxlbnRseSkKICAgICAgICAgICAgICAgICB0ZXN0KCdk b2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCBmYWxzZSwgImZvbyIs ICJiYXIiKScsICc8aHIgaWQ9ImZvbyI+PC9ocj4nKTsKIAotICAgICAgICAgICAgICAgIC8vIFRl c3QgZW1wdHkgU3RyaW5nIDNyZCBwYXJhbWV0ZXIuIChhZGRzIGVtcHJ0eSBpZCB2YWx1ZSkKLSAg ICAgICAgICAgICAgICB0ZXN0KCdkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0SG9yaXpvbnRh bFJ1bGUiLCBmYWxzZSwgIiIpJywgJzxociBpZD0iIj48L2hyPicpOworICAgICAgICAgICAgICAg IC8vIFRlc3QgZW1wdHkgU3RyaW5nIDNyZCBwYXJhbWV0ZXIuIChzaG91bGQgbm90IGFkZCBhbiBl bXB0eSBpZCB2YWx1ZSkKKyAgICAgICAgICAgICAgICB0ZXN0KCdkb2N1bWVudC5leGVjQ29tbWFu ZCgiSW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCBmYWxzZSwgIiIpJywgJzxocj48L2hyPicpOwogCiAg ICAgICAgICAgICAgICAgLy8gVGVzdCBudWxsIDNyZCBwYXJhbWV0ZXIuIChzaG91bGQgdHJlYXQg YXMgaWYgb25seSB0d28gYXJndW1lbnRzIHdlcmUgcGFzc2VkLCBzYW1lIGFzIHVuZGVmaW5lZCkK ICAgICAgICAgICAgICAgICB0ZXN0KCdkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0SG9yaXpv bnRhbFJ1bGUiLCBmYWxzZSwgbnVsbCknLCAnPGhyPjwvaHI+Jyk7CmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBjMWFlYmEuLjM2N2NhYjQg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTcgQEAKIDIwMDctMTEtMjAgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4K IAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggaHR0 cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNzQKKyAgICAgICAgQnVnIDE2 MDc0OiBleGVjQ29tbWFuZCgiSW5zZXJ0SG9yaXpvbnRhbFJ1bGUiLCBmYWxzZSwgIiIpIHJlc3Vs dHMgaW4gaWQ9IiIgYmVpbmcgaW5zZXJ0ZWQKKworICAgICAgICBGb3IgY29uc2lzdGVuY3kgd2l0 aCBJbnNlcnRPcmRlcmVkTGlzdCBhbmQgSW5zZXJ0VW5vcmRlcmVkTGlzdCBhIHZhbHVlIHBhcmFt ZXRlciBvZiAiIiBzaG91bGQKKyAgICAgICAgbm90IHJlc3VsdCBpbiBhbiBpZCBiZWluZyBzZXQu CisKKyAgICAgICAgKiBlZGl0aW5nL0pTRWRpdG9yLmNwcDogRG9uJ3Qgc2V0IHRoZSBpZCBhdHRy aWJ1dGUgaWYgdmFsdWUgaXMgZW1wdHkuCisKKzIwMDctMTEtMjAgIE1hcmsgUm93ZSAgPG1yb3dl QGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBBbHAgVG9rZXIuCiAKICAgICAgICAg KiBjb25maWcuaDogQ2hhbmdlICNpZiB0byAjaWZkZWYgdG8gc2lsZW5jZSB3YXJuaW5ncyBvbiBu b24tQXBwbGUgcGxhdGZvcm1zLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9lZGl0aW5nL0pTRWRpdG9y LmNwcCBiL1dlYkNvcmUvZWRpdGluZy9KU0VkaXRvci5jcHAKaW5kZXggNjE3OGVlYy4uOTMyZTUz NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9lZGl0aW5nL0pTRWRpdG9yLmNwcAorKysgYi9XZWJDb3Jl L2VkaXRpbmcvSlNFZGl0b3IuY3BwCkBAIC0yODYsNyArMjg2LDggQEAgYm9vbCBleGVjRm9ybWF0 QmxvY2soRnJhbWUqIGZyYW1lLCBib29sLCBjb25zdCBTdHJpbmcmIHZhbHVlKQogYm9vbCBleGVj SW5zZXJ0SG9yaXpvbnRhbFJ1bGUoRnJhbWUqIGZyYW1lLCBib29sIHVzZXJJbnRlcmZhY2UsIGNv bnN0IFN0cmluZyYgdmFsdWUpCiB7CiAgICAgUmVmUHRyPEhUTUxFbGVtZW50PiBociA9IG5ldyBI VE1MRWxlbWVudChoclRhZywgZnJhbWUtPmRvY3VtZW50KCkpOwotICAgIGhyLT5zZXRJZCh2YWx1 ZSk7CisgICAgaWYgKCF2YWx1ZS5pc0VtcHR5KCkpCisgICAgICAgIGhyLT5zZXRJZCh2YWx1ZSk7 CiAgICAgUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGZyYWdtZW50ID0gbmV3IERvY3VtZW50RnJh Z21lbnQoZnJhbWUtPmRvY3VtZW50KCkpOwogICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwogICAg IGZyYWdtZW50LT5hcHBlbmRDaGlsZChociwgZWMpOwo=