160720 2016-08-09 17:09:37 -0700 [JSC] Remove some useless code I left when rewriting CSE's large maps 2016-08-10 14:20:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1218910 0 benjamin 2016-08-09 17:09:37 -0700 [JSC] Remove some useless code I left when rewriting CSE's large maps 1218912 1 285695 benjamin 2016-08-09 17:11:54 -0700 Created attachment 285695 Patch 1218915 2 285695 msaboff 2016-08-09 17:16:03 -0700 Comment on attachment 285695 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285695&action=review r=me > Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:273 > What is the purpose of the empty line? 1218917 3 benjamin 2016-08-09 17:17:39 -0700 (In reply to comment #2) > > Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:273 > > > > What is the purpose of the empty line? The comment above only applies to the 2 attributes that follow. The empty line is there to show this attribute does not follow the comment. 1219123 4 285695 benjamin 2016-08-10 14:20:30 -0700 Comment on attachment 285695 Patch Clearing flags on attachment: 285695 Committed r204352: <http://trac.webkit.org/changeset/204352> 1219124 5 benjamin 2016-08-10 14:20:34 -0700 All reviewed patches have been landed. Closing bug. 285695 2016-08-09 17:11:54 -0700 2016-08-10 14:20:30 -0700 Patch bug-160720-20160809171019.patch text/plain 2467 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MTRlOTU3OGM2OGI1M2NhNmU3ZDAwNzAwYTUxYmYwYmZhYzZmMzYwLi43YmYyOTYzZGJjMTE4N2Jk MmE3NGVjZjRkYWU2YWZjNTkyYTAyMzFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNi0wOC0wOSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXSBSZW1vdmUgc29tZSB1c2VsZXNzIGNvZGUgSSBsZWZ0IHdo ZW4gcmV3cml0aW5nIENTRSdzIGxhcmdlIG1hcHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDcyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0NTRVBoYXNlLmNwcDoKKyAgICAgICAgVGhl IG1hcHMgbV93b3JsZE1hcCAmJiBtX3NpZGVTdGF0ZU1hcCBhcmUgdXNlbGVzcy4gVGhleSBjb21l IGZyb20gdGhlIHByZXZpb3VzCisgICAgICAgIGl0ZXJhdGlvbiB0aGF0IGhhZCB3ZWFrZXIgY29u c3RyYWludHMuCisKKyAgICAgICAgQWxzbyBtb3ZlIG1faGVhcE1hcCBhZnRlciBtX2ZhbGxiYWNr U3RhY2tNYXAgc2luY2UgdGhhdCBpcyB0aGUgb3JkZXIKKyAgICAgICAgaW4gd2hpY2ggdGhleSBh cmUgdXNlZCBpbiB0aGUgYWxnb3JpdGhtLgorCiAyMDE2LTA4LTA5ICBHZW9yZ2UgUnVhbiAgPGdy dWFuQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgZnVuY3Rpb25hbGl0eSBvZiBtZWRp YSBjYXB0dXJlIG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdDU0VQaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0NTRVBoYXNlLmNw cAppbmRleCBlOWQ5YzMzMzBmOWI2NmYyNTliYjU2ODg3NTM4ZGE2ZTlmYmI4OWU3Li5hZjg2ZjUy YWZmYmFiODJhNmQyMWE2OTQyNDQ1ZGI2OTk1OGFkMWEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0NTRVBoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR0NTRVBoYXNlLmNwcApAQCAtMTA4LDkgKzEwOCw5IEBAIHB1YmxpYzoKIAogICAg IEltcHVyZU1hcChJbXB1cmVNYXAmJiBvdGhlcikKICAgICB7Ci0gICAgICAgIG1faGVhcE1hcC5z d2FwKG90aGVyLm1faGVhcE1hcCk7CiAgICAgICAgIG1fYWJzdHJhY3RIZWFwU3RhY2tNYXAuc3dh cChvdGhlci5tX2Fic3RyYWN0SGVhcFN0YWNrTWFwKTsKICAgICAgICAgbV9mYWxsYmFja1N0YWNr TWFwLnN3YXAob3RoZXIubV9mYWxsYmFja1N0YWNrTWFwKTsKKyAgICAgICAgbV9oZWFwTWFwLnN3 YXAob3RoZXIubV9oZWFwTWFwKTsKICNpZiAhZGVmaW5lZChOREVCVUcpCiAgICAgICAgIG1fZGVi dWdJbXB1cmVEYXRhLnN3YXAob3RoZXIubV9kZWJ1Z0ltcHVyZURhdGEpOwogI2VuZGlmCkBAIC0x NzUsOSArMTc1LDkgQEAgcHVibGljOgogCiAgICAgdm9pZCBjbGVhcigpCiAgICAgewotICAgICAg ICBtX2hlYXBNYXAuY2xlYXIoKTsKICAgICAgICAgbV9hYnN0cmFjdEhlYXBTdGFja01hcC5jbGVh cigpOwogICAgICAgICBtX2ZhbGxiYWNrU3RhY2tNYXAuY2xlYXIoKTsKKyAgICAgICAgbV9oZWFw TWFwLmNsZWFyKCk7CiAjaWYgIWRlZmluZWQoTkRFQlVHKQogICAgICAgICBtX2RlYnVnSW1wdXJl RGF0YS5jbGVhcigpOwogI2VuZGlmCkBAIC0yNTcsMTAgKzI1Nyw2IEBAIHByaXZhdGU6CiAgICAg ICAgIH0pOwogICAgIH0KIAotICAgIE1hcCBtX3dvcmxkTWFwOwotICAgIE1hcCBtX2hlYXBNYXA7 Ci0gICAgTWFwIG1fc2lkZVN0YXRlTWFwOwotCiAgICAgLy8gVGhlIG1ham9yaXR5IG9mIEltcHVy ZSBTdGFjayBTbG90c2FyZSB1bmlxdWUgcGVyIHZhbHVlLgogICAgIC8vIFRoaXMgaXMgdmVyeSB1 c2VmdWwgZm9yIGZhc3QgY2xvYmJlcigpLCB3ZSBjYW4ganVzdCByZW1vdmUgdGhlIHNsb3QgYWRk cmVzc2VkIGJ5IEFic3RyYWN0SGVhcAogICAgIC8vIGluIE8oMSkuCkBAIC0yNzUsNiArMjcxLDgg QEAgcHJpdmF0ZToKICAgICBIYXNoTWFwPGludDMyX3QsIHN0ZDo6dW5pcXVlX3B0cjxJbXB1cmVE YXRhU2xvdD4sIERlZmF1bHRIYXNoPGludDMyX3Q+OjpIYXNoLCBXVEY6OlNpZ25lZFdpdGhaZXJv S2V5SGFzaFRyYWl0czxpbnQzMl90Pj4gbV9hYnN0cmFjdEhlYXBTdGFja01hcDsKICAgICBNYXAg bV9mYWxsYmFja1N0YWNrTWFwOwogCisgICAgTWFwIG1faGVhcE1hcDsKKwogI2lmICFkZWZpbmVk KE5ERUJVRykKICAgICBIYXNoTWFwPEhlYXBMb2NhdGlvbiwgTGF6eU5vZGU+IG1fZGVidWdJbXB1 cmVEYXRhOwogI2VuZGlmCg==