160714 2016-08-09 16:02:22 -0700 Don't filter out the latest data point in chart data sampling 2016-08-09 16:23:32 -0700 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa barraclough cdumez rniwa slewis oldest_to_newest 1218881 0 rniwa 2016-08-09 16:02:22 -0700 4/21/16, 4:30 PM Gavin Barraclough: The dashboard page and the charts pages sample, and don’t show all datapoint. Sometimes that means they don’t include the latest datapoint, which means you can be looking at a chart page seeing a regression, when the newest datapoint would show it to be fixed! Sampling is fine but it would be really nice if we could find a way to always include the single most recent result. 1218889 1 285687 rniwa 2016-08-09 16:20:01 -0700 Created attachment 285687 Patch 1218890 2 285687 cdumez 2016-08-09 16:21:03 -0700 Comment on attachment 285687 Patch r=me 1218891 3 rniwa 2016-08-09 16:23:32 -0700 Committed r204313: <http://trac.webkit.org/changeset/204313> 285687 2016-08-09 16:20:01 -0700 2016-08-09 16:21:03 -0700 Patch bug-160714-20160809161827.patch text/plain 3875 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjA0MzEyKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDE2LTA4LTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIERvbid0IGZpbHRlciBvdXQgdGhlIGxhdGVzdCBkYXRhIHBvaW50IGluIGNoYXJ0 IGRhdGEgc2FtcGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MDcxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEV4Y2x1ZGUgdGhlIGxhc3QgZGF0YSBwb2ludCBmcm9tIHNhbXBsaW5nIHNvIHRoYXQg aXQncyBhbHdheXMgaW5jbHVkZWQgaW4gdGhlICJzYW1wbGVkIiBjaGFydHMgZGF0YS4KKyAgICAg ICAgV2l0aG91dCB0aGlzLCB0aGUgbGFzdCBkYXRhIHBvaW50IGNhbiBjaGFuZ2UgYXMgd2Ugem9v bSBvdXQgdGhlIHRpbWUgZG9tYWluLgorCisgICAgICAgIEx1Y2tpbHksIHdlIGFscmVhZHkgaGFk IGEgbWVjaGFuaXNtIHRvIGV4Y2x1ZGUgdGhlIHVzZXIgc2VsZWN0ZWQgcG9pbnQgZnJvbSBzYW1w bGluZy4gRXh0ZW5kIHRoaXMKKyAgICAgICAgZmVhdHVyZSBieSBzdXBwb3J0aW5nIGFuIGFycmF5 IG9mIHBvaW50IElEcyBpbnN0ZWFkIG9mIGEgc2luZ2xlIElEIHRvIGV4Y2x1ZGUgZnJvbSBmaWxl cmluZy4KKworICAgICAgICAqIHB1YmxpYy92My9jb21wb25lbnRzL2ludGVyYWN0aXZlLXRpbWUt c2VyaWVzLWNoYXJ0LmpzOgorICAgICAgICAoSW50ZXJhY3RpdmVUaW1lU2VyaWVzQ2hhcnQucHJv dG90eXBlLl9zYW1wbGVUaW1lU2VyaWVzKTogUmVwbGFjZWQgZXhjbHVzaW9uUG9pbnRJRCBieSBl eGNsdWRlZFBvaW50cy4gCisKKyAgICAgICAgKiBwdWJsaWMvdjMvY29tcG9uZW50cy90aW1lLXNl cmllcy1jaGFydC5qczoKKyAgICAgICAgKFRpbWVTZXJpZXNDaGFydC5wcm90b3R5cGUuX2Vuc3Vy ZVNhbXBsZWRUaW1lU2VyaWVzKTogUHV0IHRoZSBsYXN0IGRhdGEgcG9pbnQgaW4gZXhjbHVkZWRQ b2ludHMuCisgICAgICAgIChUaW1lU2VyaWVzQ2hhcnQucHJvdG90eXBlLl9zYW1wbGVUaW1lU2Vy aWVzKTogQ2hlY2sgcG9pbnQncyBpZCBhZ2FpbnN0IHRoZSBsaXN0IG9mIElEcy4KKwogMjAxNi0w OC0wOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBm aXggYWZ0ZXIgcjIwNDE4Ny4gaW50ZXJ2YWwgaGFzIHRvIGJlIGEgZ2V0dGVyLCBub3QgYSBtZXRo b2QuCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMv aW50ZXJhY3RpdmUtdGltZS1zZXJpZXMtY2hhcnQuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMv cGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9jb21wb25lbnRzL2ludGVyYWN0aXZlLXRpbWUtc2Vy aWVzLWNoYXJ0LmpzCShyZXZpc2lvbiAyMDQyOTQpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5v cmcvcHVibGljL3YzL2NvbXBvbmVudHMvaW50ZXJhY3RpdmUtdGltZS1zZXJpZXMtY2hhcnQuanMJ KHdvcmtpbmcgY29weSkKQEAgLTM4MywxMCArMzgzLDExIEBAIGNsYXNzIEludGVyYWN0aXZlVGlt ZVNlcmllc0NoYXJ0IGV4dGVuZHMKICAgICAgICAgcmV0dXJuIG1ldHJpY3M7CiAgICAgfQogCi0g ICAgX3NhbXBsZVRpbWVTZXJpZXMoZGF0YSwgbWF4aW11bU51bWJlck9mUG9pbnRzLCBleGNsdXNp b25Qb2ludElEKQorICAgIF9zYW1wbGVUaW1lU2VyaWVzKGRhdGEsIG1heGltdW1OdW1iZXJPZlBv aW50cywgZXhjbHVkZWRQb2ludHMpCiAgICAgewotICAgICAgICBjb25zb2xlLmFzc2VydCghZXhj bHVzaW9uUG9pbnRJRCk7Ci0gICAgICAgIHJldHVybiBzdXBlci5fc2FtcGxlVGltZVNlcmllcyhk YXRhLCBtYXhpbXVtTnVtYmVyT2ZQb2ludHMsIHRoaXMuX2luZGljYXRvcklEKTsKKyAgICAgICAg aWYgKHRoaXMuX2luZGljYXRvcklEKQorICAgICAgICAgICAgZXhjbHVkZWRQb2ludHMucHVzaCh0 aGlzLl9pbmRpY2F0b3JJRCk7CisgICAgICAgIHJldHVybiBzdXBlci5fc2FtcGxlVGltZVNlcmll cyhkYXRhLCBtYXhpbXVtTnVtYmVyT2ZQb2ludHMsIGV4Y2x1ZGVkUG9pbnRzKTsKICAgICB9CiAK ICAgICBfcmVuZGVyQ2hhcnRDb250ZW50KGNvbnRleHQsIG1ldHJpY3MpCkluZGV4OiBXZWJzaXRl cy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvdGltZS1zZXJpZXMtY2hhcnQu anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9jb21w b25lbnRzL3RpbWUtc2VyaWVzLWNoYXJ0LmpzCShyZXZpc2lvbiAyMDQzMDMpCisrKyBXZWJzaXRl cy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvdGltZS1zZXJpZXMtY2hhcnQu anMJKHdvcmtpbmcgY29weSkKQEAgLTUzNiw3ICs1MzYsNyBAQCBjbGFzcyBUaW1lU2VyaWVzQ2hh cnQgZXh0ZW5kcyBDb21wb25lbnRCCiAgICAgICAgICAgICBpZiAoIXNvdXJjZS5zYW1wbGVEYXRh KQogICAgICAgICAgICAgICAgIHJldHVybiBmaWx0ZXJlZERhdGE7CiAgICAgICAgICAgICBlbHNl Ci0gICAgICAgICAgICAgICAgcmV0dXJuIHNlbGYuX3NhbXBsZVRpbWVTZXJpZXMoZmlsdGVyZWRE YXRhLCBtYXhpbXVtTnVtYmVyT2ZQb2ludHMpOworICAgICAgICAgICAgICAgIHJldHVybiBzZWxm Ll9zYW1wbGVUaW1lU2VyaWVzKGZpbHRlcmVkRGF0YSwgbWF4aW11bU51bWJlck9mUG9pbnRzLCBm aWx0ZXJlZERhdGEuc2xpY2UoLTEpLm1hcChmdW5jdGlvbiAocG9pbnQpIHsgcmV0dXJuIHBvaW50 LmlkOyB9KSk7CiAgICAgICAgIH0pOwogCiAgICAgICAgIEluc3RydW1lbnRhdGlvbi5lbmRNZWFz dXJpbmdUaW1lKCdUaW1lU2VyaWVzQ2hhcnQnLCAnZW5zdXJlU2FtcGxlZFRpbWVTZXJpZXMnKTsK QEAgLTU0Nyw3ICs1NDcsNyBAQCBjbGFzcyBUaW1lU2VyaWVzQ2hhcnQgZXh0ZW5kcyBDb21wb25l bnRCCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAotICAgIF9zYW1wbGVUaW1lU2VyaWVz KGRhdGEsIG1heGltdW1OdW1iZXJPZlBvaW50cywgZXhjbHVzaW9uUG9pbnRJRCkKKyAgICBfc2Ft cGxlVGltZVNlcmllcyhkYXRhLCBtYXhpbXVtTnVtYmVyT2ZQb2ludHMsIGV4Y2x1ZGVkUG9pbnRz KQogICAgIHsKICAgICAgICAgSW5zdHJ1bWVudGF0aW9uLnN0YXJ0TWVhc3VyaW5nVGltZSgnVGlt ZVNlcmllc0NoYXJ0JywgJ3NhbXBsZVRpbWVTZXJpZXMnKTsKIApAQCAtNTcxLDcgKzU3MSw3IEBA IGNsYXNzIFRpbWVTZXJpZXNDaGFydCBleHRlbmRzIENvbXBvbmVudEIKICAgICAgICAgICAgIHZh ciBqOwogICAgICAgICAgICAgZm9yIChqID0gaTsgaiA8PSBsYXN0SW5kZXg7IGorKykgewogICAg ICAgICAgICAgICAgIHZhciBlbmRQb2ludCA9IGRhdGFbal07Ci0gICAgICAgICAgICAgICAgaWYg KGVuZFBvaW50LmlkID09IGV4Y2x1c2lvblBvaW50SUQpIHsKKyAgICAgICAgICAgICAgICBpZiAo ZXhjbHVkZWRQb2ludHMuaW5jbHVkZXMoZW5kUG9pbnQuaWQpKSB7CiAgICAgICAgICAgICAgICAg ICAgIGotLTsKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgfQo=