160690 2016-08-09 07:01:47 -0700 [Win] Warning fix. 2016-08-10 01:15:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue oldest_to_newest 1218728 0 pvollan 2016-08-09 07:01:47 -0700 We currently have a few warnings like this one: 1>c:\projects\webkit\opensource\source\webcore\platform\network\ProtectionSpaceHash.h(43): warning C4838: conversion from 'WebCore::ProtectionSpaceServerType' to 'unsigned int' requires a narrowing conversion (compiling source file C:\Projects\WebKit\OpenSource\Source\WebCore\platform\network\CredentialStorage.cpp) 1218731 1 285638 pvollan 2016-08-09 07:25:17 -0700 Created attachment 285638 Patch 1218992 2 pvollan 2016-08-10 00:53:38 -0700 Thanks for reviewing :) 1219000 3 285638 commit-queue 2016-08-10 01:15:52 -0700 Comment on attachment 285638 Patch Clearing flags on attachment: 285638 Committed r204328: <http://trac.webkit.org/changeset/204328> 1219001 4 commit-queue 2016-08-10 01:15:55 -0700 All reviewed patches have been landed. Closing bug. 285638 2016-08-09 07:25:17 -0700 2016-08-10 01:15:52 -0700 Patch bug-160690-20160809072347.patch text/plain 1520 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDI3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA4LTA5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBXYXJuaW5nIGZp eC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDY5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBz dGF0aWMgY2FzdCB0byBjb252ZXJ0IGZyb20gZW51bSB0byB1bnNpZ25lZC4KKworICAgICAgICAq IHBsYXRmb3JtL25ldHdvcmsvUHJvdGVjdGlvblNwYWNlSGFzaC5oOgorICAgICAgICAoV2ViQ29y ZTo6UHJvdGVjdGlvblNwYWNlSGFzaDo6aGFzaCk6CisKIDIwMTYtMDgtMDggIE15bGVzIEMuIE1h eGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBFbnN1cmUgU3RyaW5nVmll dyBsaWZldGltZSBpcyBjb3JyZWN0IGluc2lkZSBJbmxpbmVUZXh0Qm94CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZUhhc2guaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Byb3RlY3Rpb25TcGFjZUhhc2gu aAkocmV2aXNpb24gMjA0MTY3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9Q cm90ZWN0aW9uU3BhY2VIYXNoLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3LDggKzM3LDggQEAgc3Ry dWN0IFByb3RlY3Rpb25TcGFjZUhhc2ggewogICAgICAgICB1bnNpZ25lZCBoYXNoQ29kZXNbNV0g PSB7CiAgICAgICAgICAgICBwcm90ZWN0aW9uU3BhY2UuaG9zdCgpLmltcGwoKSA/IHByb3RlY3Rp b25TcGFjZS5ob3N0KCkuaW1wbCgpLT5oYXNoKCkgOiAwLCAKICAgICAgICAgICAgIHN0YXRpY19j YXN0PHVuc2lnbmVkPihwcm90ZWN0aW9uU3BhY2UucG9ydCgpKSwKLSAgICAgICAgICAgIHByb3Rl Y3Rpb25TcGFjZS5zZXJ2ZXJUeXBlKCksCi0gICAgICAgICAgICBwcm90ZWN0aW9uU3BhY2UuYXV0 aGVudGljYXRpb25TY2hlbWUoKSwKKyAgICAgICAgICAgIHN0YXRpY19jYXN0PHVuc2lnbmVkPihw cm90ZWN0aW9uU3BhY2Uuc2VydmVyVHlwZSgpKSwKKyAgICAgICAgICAgIHN0YXRpY19jYXN0PHVu c2lnbmVkPihwcm90ZWN0aW9uU3BhY2UuYXV0aGVudGljYXRpb25TY2hlbWUoKSksCiAgICAgICAg ICAgICBwcm90ZWN0aW9uU3BhY2UucmVhbG0oKS5pbXBsKCkgPyBwcm90ZWN0aW9uU3BhY2UucmVh bG0oKS5pbXBsKCktPmhhc2goKSA6IDAKICAgICAgICAgfTsKIAo=