160687 2016-08-09 05:28:14 -0700 [Win] Warning fix. 2016-08-10 01:19:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue oldest_to_newest 1218720 0 pvollan 2016-08-09 05:28:14 -0700 We currently get many warnings like these: 1>C:\Projects\WebKit\OpenSource\Source\WebCore\platform\spi\cf\CFNetworkSPI.h(174): warning C4273: 'CFURLResponseGetHTTPResponse': inconsistent dll linkage (compiling source file C:\Projects\WebKit\OpenSource\Source\WebCore\bindings\js\JSBindingsAllInOne.cpp) 1> C:\AppleApplicationSupport\AppleInternal\include\CFNetwork/CFURLResponse.h(268): note: see previous definition of 'CFURLResponseGetHTTPResponse' (compiling source file C:\Projects\WebKit\OpenSource\Source\WebCore\bindings\js\JSBindingsAllInOne.cpp) 1218721 1 285635 pvollan 2016-08-09 06:07:22 -0700 Created attachment 285635 Patch 1218994 2 pvollan 2016-08-10 00:56:12 -0700 Thanks for reviewing :-) 1219002 3 285635 commit-queue 2016-08-10 01:19:31 -0700 Comment on attachment 285635 Patch Clearing flags on attachment: 285635 Committed r204329: <http://trac.webkit.org/changeset/204329> 1219003 4 commit-queue 2016-08-10 01:19:35 -0700 All reviewed patches have been landed. Closing bug. 285635 2016-08-09 06:07:22 -0700 2016-08-10 01:19:31 -0700 Patch bug-160687-20160809060552.patch text/plain 2273 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDI3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA4LTA5ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBXYXJuaW5nIGZp eC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDY4 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lk IGZvcndhcmQgZGVjbGFyYXRpb25zIHdpdGggZGlmZmVyZW50IGRsbCBsaW5rYWdlLgorCisgICAg ICAgICogcGxhdGZvcm0vc3BpL2NmL0NGTmV0d29ya1NQSS5oOgorCiAyMDE2LTA4LTA4ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgRW5zdXJlIFN0 cmluZ1ZpZXcgbGlmZXRpbWUgaXMgY29ycmVjdCBpbnNpZGUgSW5saW5lVGV4dEJveApJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL2NmL0NGTmV0d29ya1NQSS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9jZi9DRk5ldHdvcmtTUEkuaAkocmV2aXNp b24gMjA0MTY3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc3BpL2NmL0NGTmV0d29ya1NQ SS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMsNiArMTMzLDcgQEAgdHlwZWRlZiB2b2lkICheQ0ZD YWNoZWRVUkxSZXNwb25zZUNhbGxCYQogCiAjZW5kaWYgLy8gIVBMQVRGT1JNKFdJTikgJiYgIVVT RShBUFBMRV9JTlRFUk5BTF9TREspCiAKKyNpZiAhUExBVEZPUk0oV0lOKQogRVhURVJOX0Mgdm9p ZCBDRlVSTFJlcXVlc3RTZXRTaG91bGRTdGFydFN5bmNocm9ub3VzbHkoQ0ZVUkxSZXF1ZXN0UmVm LCBCb29sZWFuKTsKIAogRVhURVJOX0MgQ0ZVUkxDYWNoZVJlZiBDRlVSTENhY2hlQ29weVNoYXJl ZFVSTENhY2hlKCk7CkBAIC0xNTYsOSArMTU3LDcgQEAgRVhURVJOX0Mgdm9pZCBDRlVSTENvbm5l Y3Rpb25JbnZhbGlkYXRlQwogRVhURVJOX0MgQ0ZTdHJpbmdSZWYgY29uc3Qga0NGSFRUUENvb2tp ZUxvY2FsRmlsZURvbWFpbjsKIEVYVEVSTl9DIGNvbnN0IENGU3RyaW5nUmVmIGtDRlVSTFJlcXVl c3RBbGxvd0FsbFBPU1RDYWNoaW5nOwogCi0jaWYgIVBMQVRGT1JNKFdJTikKIEVYVEVSTl9DIGNv bnN0IENGU3RyaW5nUmVmIF9rQ0ZVUkxDb25uZWN0aW9uUHJvcGVydHlTaG91bGRTbmlmZjsKLSNl bmRpZgogCiBFWFRFUk5fQyBDRkhUVFBDb29raWVTdG9yYWdlUmVmIF9DRkhUVFBDb29raWVTdG9y YWdlR2V0RGVmYXVsdChDRkFsbG9jYXRvclJlZik7CiBFWFRFUk5fQyB2b2lkIENGSFRUUENvb2tp ZVN0b3JhZ2VTZXRDb29raWUoQ0ZIVFRQQ29va2llU3RvcmFnZVJlZiwgQ0ZIVFRQQ29va2llUmVm KTsKQEAgLTE3OSw2ICsxNzgsNyBAQCBFWFRFUk5fQyBDRlVSTFJlZiBDRlVSTFJlc3BvbnNlR2V0 VVJMKENGCiBFWFRFUk5fQyB2b2lkIENGVVJMUmVzcG9uc2VTZXRNSU1FVHlwZShDRlVSTFJlc3Bv bnNlUmVmLCBDRlN0cmluZ1JlZik7CiBFWFRFUk5fQyBDRkhUVFBDb29raWVTdG9yYWdlUmVmIF9D RlVSTFN0b3JhZ2VTZXNzaW9uQ29weUNvb2tpZVN0b3JhZ2UoQ0ZBbGxvY2F0b3JSZWYsIENGVVJM U3RvcmFnZVNlc3Npb25SZWYpOwogRVhURVJOX0MgQ0ZBcnJheVJlZiBfQ0ZIVFRQQ29va2llU3Rv cmFnZUNvcHlDb29raWVzRm9yVVJMV2l0aE1haW5Eb2N1bWVudFVSTChDRkhUVFBDb29raWVTdG9y YWdlUmVmIGluQ29va2llU3RvcmFnZSwgQ0ZVUkxSZWYgaW5VUkwsIENGVVJMUmVmIGluTWFpbkRv Y3VtZW50VVJMLCBCb29sZWFuIHNlbmRTZWN1cmVDb29raWVzKTsKKyNlbmRpZiAvLyAhUExBVEZP Uk0oV0lOKQogCiAvLyBGSVhNRTogV2Ugc2hvdWxkIG9ubHkgZm9yd2FyZCBkZWNsYXJlIHRoaXMg U1BJIHdoZW4gYnVpbGRpbmcgZm9yIGlPUyB3aXRob3V0IHRoZSBBcHBsZSBJbnRlcm5hbCBTREsu CiAvLyBBcyBhIHdvcmthcm91bmQgZm9yIDxyZGFyOi8vcHJvYmxlbS8xOTAyNTAxNj4sIHdlIG11 c3QgZm9yd2FyZCBkZWNsYXJlIHRoaXMgU1BJIHJlZ2FyZGxlc3Mgb2Ygd2hldGhlcgo=