160684 2016-08-08 23:52:41 -0700 webkit-gtk tarball fails to build due to missing files 2016-08-09 09:59:21 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyhu annulen annulen bugs-noreply cgarcia commit-queue jeremyhu mcatanzaro oldest_to_newest 1218701 0 jeremyhu 2016-08-08 23:52:41 -0700 As mentioned on the mailing list, I decided to make the jump from git to tarballs to test out the 2.13.x series. Unfortunately, it looks like tarball creation is dropping files on the floor. CMake Error at Source/cmake/WebKitMacros.cmake:249 (add_library): Cannot find source file: spi/darwin/CommonCryptoSPI.h Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx Call Stack (most recent call first): Source/WTF/wtf/CMakeLists.txt:305 (WEBKIT_FRAMEWORK) CMake Error: Cannot determine link language for target "WTF". CMake Error: CMake can not determine linker language for target: WTF I notice you're missing (at least) these paths: Source/WebCore/platform/spi Source/WebKit2/Platform/spi Source/WTF/wtf/spi I didn't do a deep comparison. I just looked for spi in the tarball and in the repository and came up with those hits. Carlos responded with: This is a regression introduced in r203620, see bug #160094. I guess Konstantin assumed that those spi files are only used by mac builds, but I guess they are also needed to build gtk on mac. 1218703 1 annulen 2016-08-08 23:58:54 -0700 My bad, indeed CommonCryptoSPI.h is needed e.g. for OSRandomSource.cpp 1218704 2 285632 annulen 2016-08-09 00:02:46 -0700 Created attachment 285632 Patch 1218751 3 285632 commit-queue 2016-08-09 09:59:17 -0700 Comment on attachment 285632 Patch Clearing flags on attachment: 285632 Committed r204283: <http://trac.webkit.org/changeset/204283> 1218752 4 commit-queue 2016-08-09 09:59:21 -0700 All reviewed patches have been landed. Closing bug. 285632 2016-08-09 00:02:46 -0700 2016-08-09 09:59:17 -0700 Patch bug-160684-20160809100112.patch text/plain 1239 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MTY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjU4NzU4MGY1OWRhNTIwOTBhMmJiZWZiYWVlY2QxOGU3 OTU2MmFmZi4uNzI0NzJhNDM5Nzk2NjJjNzFhOTE4NTcyMTE2ZDkzNGI1NDVlNmY1YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTA4LTA4ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4K KworICAgICAgICB3ZWJraXQtZ3RrIHRhcmJhbGwgZmFpbHMgdG8gYnVpbGQgZHVlIHRvIG1pc3Np bmcgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2MDY4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZ3RrL21hbmlmZXN0LnR4dC5pbjogQWRkZWQgYmFjayBzcGkgZGlyZWN0b3JpZXMuCisKIDIw MTYtMDgtMDQgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVz dG9yZSBDb2RlQmxvY2sgamV0dGlzb24gY29kZSB0byBqZXR0aXNvbiB3aGVuIGEgQ29kZUJsb2Nr IGhhcyBiZWVuIGFsaXZlIGZvciBhIGxvbmcgdGltZQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL21h bmlmZXN0LnR4dC5pbiBiL1Rvb2xzL2d0ay9tYW5pZmVzdC50eHQuaW4KaW5kZXggNmNhMTIyZDA5 Y2JlODkwMWNjMjE2YThmMTA4M2M3NmIyMjQ3ZTRlZC4uYzQ1YTliZWFiNDRmOGMyZWVjMGNiY2My ZjNmZmJjMTRhMzYwN2Q4ZCAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL21hbmlmZXN0LnR4dC5pbgor KysgYi9Ub29scy9ndGsvbWFuaWZlc3QudHh0LmluCkBAIC00Myw3ICs0Myw3IEBAIGV4Y2x1ZGUg XC54Y2NvbmZpZyQKIGV4Y2x1ZGUgXC54Y29kZXByb2okCiAKICMgRXhjbHVkZSBkaXJlY3Rvcmll cyBmcm9tIG90aGVyIHBvcnRzCi1leGNsdWRlIC4qXC8oQ29uZmlndXJhdGlvbnN8bWFjfGlvc3xz cGl8Y2Z8Y2d8Y29jb2F8Q29jb2F8b2JqY3xhdmZvdW5kYXRpb258Y2F8Y3VybHxlZmx8d2luKVwv LiokCitleGNsdWRlIC4qXC8oQ29uZmlndXJhdGlvbnN8bWFjfGlvc3xjZnxjZ3xjb2NvYXxDb2Nv YXxvYmpjfGF2Zm91bmRhdGlvbnxjYXxjdXJsfGVmbHx3aW4pXC8uKiQKIAogZGlyZWN0b3J5IFNv dXJjZQogZXhjbHVkZSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMK