160665 2016-08-08 11:36:28 -0700 Regression(r204239): Caused flaky crashes under ~Database() 2016-08-08 17:52:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 159965 1 cdumez cdumez achristensen ap beidson darin gyuyoung.kim ryanhaddad webkit-bug-importer oldest_to_newest 1218534 0 cdumez 2016-08-08 11:36:28 -0700 Regression(r204239): Caused flaky crashes under ~Database(): Thread 40 Crashed:: WebCore: Database 0 com.apple.JavaScriptCore 0x000000010ab9d887 WTFCrash + 39 1 com.apple.WebCore 0x000000010fc7bbf5 WebCore::Node::ref() + 69 2 com.apple.WebCore 0x000000011037ff05 WebCore::Document::refScriptExecutionContext() + 21 3 com.apple.WebCore 0x000000011037fffc non-virtual thunk to WebCore::Document::refScriptExecutionContext() + 28 4 com.apple.WebCore 0x000000011028ea79 WebCore::ScriptExecutionContext::ref() + 25 5 com.apple.WebCore 0x000000011028ea51 void WTF::refIfNotNull<WebCore::ScriptExecutionContext>(WebCore::ScriptExecutionContext*) + 49 6 com.apple.WebCore 0x0000000110292316 WTF::RefPtr<WebCore::ScriptExecutionContext>::RefPtr(WTF::RefPtr<WebCore::ScriptExecutionContext> const&) + 38 7 com.apple.WebCore 0x0000000110288e7d WTF::RefPtr<WebCore::ScriptExecutionContext>::RefPtr(WTF::RefPtr<WebCore::ScriptExecutionContext> const&) + 29 8 com.apple.WebCore 0x0000000110281f04 WebCore::Database::~Database() + 148 9 com.apple.WebCore 0x00000001102820b5 WebCore::Database::~Database() + 21 10 com.apple.WebCore 0x00000001102820d9 WebCore::Database::~Database() + 25 11 com.apple.WebCore 0x00000001102927a3 WTF::ThreadSafeRefCounted<WebCore::Database>::deref() + 83 12 com.apple.WebCore 0x000000011029ecaa void WTF::derefIfNotNull<WebCore::Database>(WebCore::Database*) + 58 13 com.apple.WebCore 0x000000011029ec63 WTF::RefPtr<WebCore::Database>::~RefPtr() + 83 14 com.apple.WebCore 0x000000011029b9d5 WTF::RefPtr<WebCore::Database>::~RefPtr() + 21 15 com.apple.WebCore 0x00000001102a4484 WTF::HashTable<WTF::RefPtr<WebCore::Database>, WTF::RefPtr<WebCore::Database>, WTF::IdentityExtractor, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::deallocateTable(WTF::RefPtr<WebCore::Database>*, unsigned int) + 84 16 com.apple.WebCore 0x00000001102a425e WTF::HashTable<WTF::RefPtr<WebCore::Database>, WTF::RefPtr<WebCore::Database>, WTF::IdentityExtractor, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::~HashTable() + 62 17 com.apple.WebCore 0x00000001102a4215 WTF::HashTable<WTF::RefPtr<WebCore::Database>, WTF::RefPtr<WebCore::Database>, WTF::IdentityExtractor, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::~HashTable() + 21 18 com.apple.WebCore 0x00000001102a41f5 WTF::HashSet<WTF::RefPtr<WebCore::Database>, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::~HashSet() + 21 19 com.apple.WebCore 0x00000001102a3975 WTF::HashSet<WTF::RefPtr<WebCore::Database>, WTF::PtrHash<WTF::RefPtr<WebCore::Database> >, WTF::HashTraits<WTF::RefPtr<WebCore::Database> > >::~HashSet() + 21 20 com.apple.WebCore 0x00000001102a2d37 WebCore::DatabaseThread::databaseThread() + 1095 21 com.apple.WebCore 0x00000001102a287d WebCore::DatabaseThread::databaseThreadStart(void*) + 29 22 com.apple.JavaScriptCore 0x000000010ac10629 WTF::createThread(void (*)(void*), void*, char const*)::$_0::operator()() const + 25 23 com.apple.JavaScriptCore 0x000000010ac105fd void std::__1::__invoke_void_return_wrapper<void>::__call<WTF::createThread(void (*)(void*), void*, char const*)::$_0&>(WTF::createThread(void (*)(void*), void*, char const*)::$_0&&&) + 45 24 com.apple.JavaScriptCore 0x000000010ac1059c std::__1::__function::__func<WTF::createThread(void (*)(void*), void*, char const*)::$_0, std::__1::allocator<WTF::createThread(void (*)(void*), void*, char const*)::$_0>, void ()>::operator()() + 44 25 com.apple.JavaScriptCore 0x000000010a21dffa std::__1::function<void ()>::operator()() const + 26 26 com.apple.JavaScriptCore 0x000000010ac0f1fe WTF::threadEntryPoint(void*) + 158 27 com.apple.JavaScriptCore 0x000000010ac10ca1 WTF::wtfThreadEntryPoint(void*) + 289 28 libsystem_pthread.dylib 0x00007fff9660999d _pthread_body + 131 29 libsystem_pthread.dylib 0x00007fff9660991a _pthread_start + 168 30 libsystem_pthread.dylib 0x00007fff96607351 thread_start + 13 1218535 1 cdumez 2016-08-08 11:36:49 -0700 <rdar://problem/27748065> 1218540 2 285576 cdumez 2016-08-08 11:49:48 -0700 Created attachment 285576 Patch 1218552 3 285576 cdumez 2016-08-08 12:41:03 -0700 Comment on attachment 285576 Patch Clearing flags on attachment: 285576 Committed r204262: <http://trac.webkit.org/changeset/204262> 1218554 4 cdumez 2016-08-08 12:41:09 -0700 All reviewed patches have been landed. Closing bug. 1218660 5 gyuyoung.kim 2016-08-08 17:52:36 -0700 (In reply to comment #3) > Comment on attachment 285576 [details] > Patch > > Clearing flags on attachment: 285576 > > Committed r204262: <http://trac.webkit.org/changeset/204262> Thanks for the fix, Chris ! 285576 2016-08-08 11:49:48 -0700 2016-08-08 12:41:03 -0700 Patch bug-160665-20160808114816.patch text/plain 2485 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA0MjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDUyNDU4MDYwNmVkMDM3 NGM4MDcwY2U1MzJhNjIyZTJmNjQwMTBhNC4uMDljMmQ1NDAzZjdmOTg5NGFkYzU5YzZiYTE3ZWM4 NzAxMTc5NzQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA4LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjA0MjM5 KTogQ2F1c2VkIGZsYWt5IGNyYXNoZXMgdW5kZXIgfkRhdGFiYXNlKCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDY2NQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMjc3NDgwNjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFrZSBzdXJlIHRoZSBzY3JpcHRFeGVjdXRpb24gY29udGV4dCBvbmx5IGdl dHMgcmVmJ2QgLyBkZXJlZidkCisgICAgICAgIG9uIHRoZSBjb250ZXh0IHRocmVhZC4gRG9jdW1l bnQgLyBXb3JrZXJHbG9iYWxTY29wZSBhcmUgbm90CisgICAgICAgIFRocmVhZFNhZmVSZWZDb3Vu dGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxyZWFkeSBjb3ZlcmVkIGJ5OgorICAgICAg ICBzdG9yYWdlL3dlYnNxbC9vcGVuLWRhdGFiYXNlLWNyZWF0aW9uLWNhbGxiYWNrLmh0bWwKKwor ICAgICAgICAqIE1vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RGF0YWJhc2U6On5EYXRhYmFzZSk6CisKIDIwMTYtMDgtMDQgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgbW9yZSB1bnVzZWQgYmlu ZGluZ3MgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJkYXRhYmFz ZS9EYXRhYmFzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFi YXNlLmNwcAppbmRleCAxMzE2ZjFkZTdlNjU5MzU1MjhjZGYyZmRhMTU2MzJmYTI0MGE5ZTNhLi5i ODEwM2YxYThmYjAwOWUwN2EyMDBmNDdmMGY3ODRlNzZlOTFmMzBlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlLmNwcApAQCAtMjQzLDEyICsyNDMs MTAgQEAgRGF0YWJhc2U6On5EYXRhYmFzZSgpCiB7CiAgICAgLy8gVGhlIHJlZmVyZW5jZSB0byB0 aGUgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCBuZWVkcyB0byBiZSBjbGVhcmVkIG9uIHRoZSBKYXZh U2NyaXB0IHRocmVhZC4gIElmIHdlJ3JlIG9uIHRoYXQgdGhyZWFkIGFscmVhZHksIHdlIGNhbiBq dXN0IGxldCB0aGUgUmVmUHRyJ3MgZGVzdHJ1Y3Rpb24gZG8gdGhlIGRlcmVmZmluZy4KICAgICBp ZiAoIW1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+aXNDb250ZXh0VGhyZWFkKCkpIHsKLSAgICAg ICAgLy8gR3JhYiBhIHBvaW50ZXIgdG8gdGhlIHNjcmlwdCBleGVjdXRpb24gaGVyZSBiZWNhdXNl IHdlJ3JlIHJlbGVhc2luZyBpdCB3aGVuIHdlIHBhc3MgaXQgdG8KLSAgICAgICAgLy8gRGVyZWZD b250ZXh0VGFzazo6Y3JlYXRlLgotICAgICAgICBSZWZQdHI8U2NyaXB0RXhlY3V0aW9uQ29udGV4 dD4gcGFzc2VkQ29udGV4dCA9IFdURk1vdmUobV9zY3JpcHRFeGVjdXRpb25Db250ZXh0KTsKLSAg ICAgICAgcGFzc2VkQ29udGV4dC0+cG9zdFRhc2soe1NjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRh c2s6OkNsZWFudXBUYXNrLCBbcGFzc2VkQ29udGV4dF0gKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQm IGNvbnRleHQpIHsKLSAgICAgICAgICAgIEFTU0VSVF9VTlVTRUQoY29udGV4dCwgJmNvbnRleHQg PT0gcGFzc2VkQ29udGV4dCk7Ci0gICAgICAgICAgICBSZWZQdHI8U2NyaXB0RXhlY3V0aW9uQ29u dGV4dD4gc2NyaXB0RXhlY3V0aW9uQ29udGV4dChwYXNzZWRDb250ZXh0KTsKKyAgICAgICAgUmVm PFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ+IHBhc3NlZENvbnRleHQgPSBtX3NjcmlwdEV4ZWN1dGlv bkNvbnRleHQucmVsZWFzZU5vbk51bGwoKTsKKyAgICAgICAgYXV0byYgY29udGV4dFJlZiA9IHBh c3NlZENvbnRleHQuZ2V0KCk7CisgICAgICAgIGNvbnRleHRSZWYucG9zdFRhc2soe1NjcmlwdEV4 ZWN1dGlvbkNvbnRleHQ6OlRhc2s6OkNsZWFudXBUYXNrLCBbcGFzc2VkQ29udGV4dCA9IFdURk1v dmUocGFzc2VkQ29udGV4dCldIChTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0KSB7Cisg ICAgICAgICAgICBBU1NFUlRfVU5VU0VEKGNvbnRleHQsICZjb250ZXh0ID09IHBhc3NlZENvbnRl eHQucHRyKCkpOwogICAgICAgICB9fSk7CiAgICAgfQogCg==