160642 2016-08-06 19:23:07 -0700 [Cocoa] Reply block leaks if the remote object doesn’t call it 2017-02-06 09:06:45 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca darin oldest_to_newest 1218322 0 mitz 2016-08-06 19:23:07 -0700 When invoking a method with a reply block on a remote object proxy, if the remote object doesn’t invoke the reply block, it leaks on the sender side. Patch forthcoming. 1218325 1 285516 mitz 2016-08-06 19:32:01 -0700 Created attachment 285516 Release unused reply blocks 1218387 2 285516 sam 2016-08-07 13:50:26 -0700 Comment on attachment 285516 Release unused reply blocks View in context: https://bugs.webkit.org/attachment.cgi?id=285516&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:89 > + class DoneWhenDestroyed : public WTF::RefCounted<DoneWhenDestroyed> { I don't think you need the WTF:: here, but it also doesn't hurt. 1218388 3 mitz 2016-08-07 13:52:19 -0700 Fixed in <https://trac.webkit.org/r204245>. 1273585 4 andersca 2017-02-06 09:06:45 -0800 This is the cause of rdar://problem/30229358. 285516 2016-08-06 19:32:01 -0700 2016-08-07 13:50:26 -0700 Release unused reply blocks bug-160642-20160806193031.patch text/plain 10848 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNDIzMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE2LTA4LTA2ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBSZXBseSBibG9jayBs ZWFrcyBpZiB0aGUgcmVtb3RlIG9iamVjdCBkb2VzbuKAmXQgY2FsbCBpdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwNjQyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL1Jl bW90ZU9iamVjdFJlZ2lzdHJ5Lmg6IERlY2xhcmVkIG5ldyBtZW1iZXIgZnVuY3Rpb25zLgorICAg ICAgICAqIFNoYXJlZC9BUEkvQ29jb2EvUmVtb3RlT2JqZWN0UmVnaXN0cnkubWVzc2FnZXMuaW46 IEFkZGVkIFJlbGVhc2VVbnVzZWRSZXBseUJsb2NrIG1lc3NhZ2UuCisgICAgICAgICogU2hhcmVk L0FQSS9Db2NvYS9SZW1vdGVPYmplY3RSZWdpc3RyeS5tbToKKyAgICAgICAgKFdlYktpdDo6UmVt b3RlT2JqZWN0UmVnaXN0cnk6OnNlbmRVbnVzZWRSZXBseSk6IFNlbmQgdGhlIFJlbGVhc2VVbnVz ZWRSZXBseUJsb2NrIG1lc3NhZ2UuCisgICAgICAgIChXZWJLaXQ6OlJlbW90ZU9iamVjdFJlZ2lz dHJ5OjpyZWxlYXNlVW51c2VkUmVwbHlCbG9jayk6IE1lc3NhZ2UgcmVjZWl2ZXIgdGhhdCBjYWxs IHRocm91Z2gKKyAgICAgICAgICB0byAtX3JlbGVhc2VSZXBseVdpdGhJRDouCisKKyAgICAgICAg KiBTaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1tOgorICAgICAgICAo LVtfV0tSZW1vdGVPYmplY3RSZWdpc3RyeSBfaW52b2tlTWV0aG9kOl0pOiBEZWZpbmUgYSBSZXBs eUJsb2NrQ2FsbENoZWNrZXIgb2JqZWN0IGFuZAorICAgICAgICAgIGNhcHR1cmUgYW4gaW5zdGFu Y2Ugb2YgaXQgaW4gdGhlIHJlcGx5IGJsb2NrIHdlIHBhc3MgdG8gdGhlIGV4cG9ydGVkIG9iamVj dC4gSGF2ZSB0aGF0CisgICAgICAgICAgYmxvY2sgc2V0IGEgZmxhZyBvbiB0aGUgY2hlY2tlciB3 aGVuIGl04oCZcyBjYWxsZWQuIElmIHRoZSBjaGVja2VyIGdldHMgZGVzdHJveWVkIHdpdGhvdXQK KyAgICAgICAgICB0aGUgYmxvY2sgaGF2aW5nIGJlZW4gY2FsbGVkLCB3aGljaCBtZWFucyB0aGF0 IHRoZSBibG9jayBnb3QgZGVzdHJveWVkIHdpdGhvdXQgYmVpbmcKKyAgICAgICAgICBjYWxsZWQs IGNhbGwgc2VuZFVudXNlZFJlcGx5IHRvIGxldCB0aGUgb3RoZXIgc2lkZSBrbm93IHRoYXQgdGhl IGJsb2NrIHdpbGwgbm90IGJlIGludm9rZWQuCisgICAgICAgICgtW19XS1JlbW90ZU9iamVjdFJl Z2lzdHJ5IF9yZWxlYXNlUmVwbHlXaXRoSUQ6XSk6IEFkZGVkLiBSZW1vdmVkIHRoZSBwZW5kaW5n IHJlcGx5IGZyb20gdGhlCisgICAgICAgICAgbWFwLCB3aGljaCByZWxlYXNlIHRoZSBibG9jay4K KyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdFJlZ2lzdHJ5SW50ZXJu YWwuaDoKKwogMjAxNi0wOC0wNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAg ICAgICAgIFtDb2NvYV0gLVtfV0tSZW1vdGVPYmplY3RSZWdpc3RyeSgpIF9pbnZva2VNZXRob2Q6 XSBsZWFrcyBhIGJsb2NrCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1Jl bW90ZU9iamVjdFJlZ2lzdHJ5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVk L0FQSS9Db2NvYS9SZW1vdGVPYmplY3RSZWdpc3RyeS5oCShyZXZpc2lvbiAyMDQyMzEpCisrKyBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1JlbW90ZU9iamVjdFJlZ2lzdHJ5LmgJKHdv cmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZW5kSW52 b2NhdGlvbihjb25zdCBSZW1vdGVPYmplY3RJbnZvY2F0aW9uJik7CiAgICAgdm9pZCBzZW5kUmVw bHlCbG9jayh1aW50NjRfdCByZXBseUlELCBjb25zdCBVc2VyRGF0YSYgYmxvY2tJbnZvY2F0aW9u KTsKKyAgICB2b2lkIHNlbmRVbnVzZWRSZXBseSh1aW50NjRfdCByZXBseUlEKTsKIAogcHJpdmF0 ZToKICAgICAvLyBJUEM6Ok1lc3NhZ2VSZWNlaXZlcgpAQCAtNTQsNiArNTUsNyBAQCBwcml2YXRl OgogICAgIC8vIE1lc3NhZ2UgaGFuZGxlcnMKICAgICB2b2lkIGludm9rZU1ldGhvZChjb25zdCBS ZW1vdGVPYmplY3RJbnZvY2F0aW9uJik7CiAgICAgdm9pZCBjYWxsUmVwbHlCbG9jayh1aW50NjRf dCByZXBseUlELCBjb25zdCBVc2VyRGF0YSYgYmxvY2tJbnZvY2F0aW9uKTsKKyAgICB2b2lkIHJl bGVhc2VVbnVzZWRSZXBseUJsb2NrKHVpbnQ2NF90IHJlcGx5SUQpOwogCiAgICAgX1dLUmVtb3Rl T2JqZWN0UmVnaXN0cnkgKm1fcmVtb3RlT2JqZWN0UmVnaXN0cnk7CiAgICAgSVBDOjpNZXNzYWdl U2VuZGVyJiBtX21lc3NhZ2VTZW5kZXI7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ L0NvY29hL1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1lc3NhZ2VzLmluCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvUmVtb3RlT2JqZWN0UmVnaXN0cnkubWVzc2Fn ZXMuaW4JKHJldmlzaW9uIDIwNDIzMSkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29j b2EvUmVtb3RlT2JqZWN0UmVnaXN0cnkubWVzc2FnZXMuaW4JKHdvcmtpbmcgY29weSkKQEAgLTIz LDQgKzIzLDUgQEAKIG1lc3NhZ2VzIC0+IFJlbW90ZU9iamVjdFJlZ2lzdHJ5IHsKICAgICBJbnZv a2VNZXRob2QoV2ViS2l0OjpSZW1vdGVPYmplY3RJbnZvY2F0aW9uIGludm9jYXRpb24pCiAgICAg Q2FsbFJlcGx5QmxvY2sodWludDY0X3QgcmVwbHlJRCwgV2ViS2l0OjpVc2VyRGF0YSBibG9ja0lu dm9jYXRpb24pOworICAgIFJlbGVhc2VVbnVzZWRSZXBseUJsb2NrKHVpbnQ2NF90IHJlcGx5SUQp OwogfQpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9SZW1vdGVPYmplY3RS ZWdpc3RyeS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29h L1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1tCShyZXZpc2lvbiAyMDQyMzEpCisrKyBTb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQVBJL0NvY29hL1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1tCSh3b3JraW5nIGNv cHkpCkBAIC01NCw2ICs1NCwxMSBAQCB2b2lkIFJlbW90ZU9iamVjdFJlZ2lzdHJ5OjpzZW5kUmVw bHlCbG9jCiAgICAgbV9tZXNzYWdlU2VuZGVyLnNlbmQoTWVzc2FnZXM6OlJlbW90ZU9iamVjdFJl Z2lzdHJ5OjpDYWxsUmVwbHlCbG9jayhyZXBseUlELCBibG9ja0ludm9jYXRpb24pKTsKIH0KIAor dm9pZCBSZW1vdGVPYmplY3RSZWdpc3RyeTo6c2VuZFVudXNlZFJlcGx5KHVpbnQ2NF90IHJlcGx5 SUQpCit7CisgICAgbV9tZXNzYWdlU2VuZGVyLnNlbmQoTWVzc2FnZXM6OlJlbW90ZU9iamVjdFJl Z2lzdHJ5OjpSZWxlYXNlVW51c2VkUmVwbHlCbG9jayhyZXBseUlEKSk7Cit9CisKIHZvaWQgUmVt b3RlT2JqZWN0UmVnaXN0cnk6Omludm9rZU1ldGhvZChjb25zdCBSZW1vdGVPYmplY3RJbnZvY2F0 aW9uJiBpbnZvY2F0aW9uKQogewogI2lmIFdLX0FQSV9FTkFCTEVECkBAIC02OCw0ICs3MywxMCBA QCB2b2lkIFJlbW90ZU9iamVjdFJlZ2lzdHJ5OjpjYWxsUmVwbHlCbG9jCiAjZW5kaWYKIH0KIAor dm9pZCBSZW1vdGVPYmplY3RSZWdpc3RyeTo6cmVsZWFzZVVudXNlZFJlcGx5QmxvY2sodWludDY0 X3QgcmVwbHlJRCkKK3sKKyNpZiBXS19BUElfRU5BQkxFRAorICAgIFttX3JlbW90ZU9iamVjdFJl Z2lzdHJ5IF9yZWxlYXNlUmVwbHlXaXRoSUQ6cmVwbHlJRF07CisjZW5kaWYKK30KIH0gLy8gbmFt ZXNwYWNlIFdlYktpdApJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9fV0tS ZW1vdGVPYmplY3RSZWdpc3RyeS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFy ZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1tCShyZXZpc2lvbiAyMDQyMzIp CisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL19XS1JlbW90ZU9iamVjdFJlZ2lz dHJ5Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMTYsMTEgKzIxNiwzOCBAQCAgICAgYXV0byBkZWNv ZGVyID0gYWRvcHROUyhbW1dLUmVtb3RlT2JqCiAKICAgICAgICAgICAgIFJldGFpblB0cjxfV0tS ZW1vdGVPYmplY3RSZWdpc3RyeT4gcmVtb3RlT2JqZWN0UmVnaXN0cnkgPSBzZWxmOwogICAgICAg ICAgICAgdWludDY0X3QgcmVwbHlJRCA9IHJlcGx5SW5mby0+cmVwbHlJRDsKLSAgICAgICAgICAg IGlkIHJlcGx5QmxvY2sgPSBfX05TTWFrZVNwZWNpYWxGb3J3YXJkaW5nQ2FwdHVyZUJsb2NrKHdp cmVCbG9ja1NpZ25hdHVyZS5fdHlwZVN0cmluZy5VVEY4U3RyaW5nLCBbaW50ZXJmYWNlLCByZW1v dGVPYmplY3RSZWdpc3RyeSwgcmVwbHlJRF0oTlNJbnZvY2F0aW9uICppbnZvY2F0aW9uKSB7CisK KyAgICAgICAgICAgIGNsYXNzIFJlcGx5QmxvY2tDYWxsQ2hlY2tlciA6IHB1YmxpYyBXVEY6OlRo cmVhZFNhZmVSZWZDb3VudGVkPFJlcGx5QmxvY2tDYWxsQ2hlY2tlcj4geworICAgICAgICAgICAg cHVibGljOgorICAgICAgICAgICAgICAgIHN0YXRpYyBSZWY8UmVwbHlCbG9ja0NhbGxDaGVja2Vy PiBjcmVhdGUoX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnkgKnJlZ2lzdHJ5LCB1aW50NjRfdCByZXBs eUlEKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IFJlcGx5QmxvY2tDYWxsQ2hlY2tlcihyZWdpc3Ry eSwgcmVwbHlJRCkpOyB9CisKKyAgICAgICAgICAgICAgICB+UmVwbHlCbG9ja0NhbGxDaGVja2Vy KCkKKyAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgIGlmICghbV9kaWRDYWxs UmVwbHlCbG9jaykKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fcmVtb3RlT2JqZWN0UmVnaXN0 cnktPl9yZW1vdGVPYmplY3RSZWdpc3RyeS0+c2VuZFVudXNlZFJlcGx5KG1fcmVwbHlJRCk7Cisg ICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgdm9pZCBkaWRDYWxsUmVwbHlCbG9j aygpIHsgbV9kaWRDYWxsUmVwbHlCbG9jayA9IHRydWU7IH0KKworICAgICAgICAgICAgcHJpdmF0 ZToKKyAgICAgICAgICAgICAgICBSZXBseUJsb2NrQ2FsbENoZWNrZXIoX1dLUmVtb3RlT2JqZWN0 UmVnaXN0cnkgKnJlZ2lzdHJ5LCB1aW50NjRfdCByZXBseUlEKQorICAgICAgICAgICAgICAgICAg ICA6IG1fcmVtb3RlT2JqZWN0UmVnaXN0cnkocmVnaXN0cnkpCisgICAgICAgICAgICAgICAgICAg ICwgbV9yZXBseUlEKHJlcGx5SUQpCisgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAg IH0KKworICAgICAgICAgICAgICAgIFJldGFpblB0cjxfV0tSZW1vdGVPYmplY3RSZWdpc3RyeT4g bV9yZW1vdGVPYmplY3RSZWdpc3RyeTsKKyAgICAgICAgICAgICAgICB1aW50NjRfdCBtX3JlcGx5 SUQgPSAwOworICAgICAgICAgICAgICAgIGJvb2wgbV9kaWRDYWxsUmVwbHlCbG9jayA9IGZhbHNl OworICAgICAgICAgICAgfTsKKworICAgICAgICAgICAgUmVmUHRyPFJlcGx5QmxvY2tDYWxsQ2hl Y2tlcj4gY2hlY2tlciA9IFJlcGx5QmxvY2tDYWxsQ2hlY2tlcjo6Y3JlYXRlKHNlbGYsIHJlcGx5 SUQpOworICAgICAgICAgICAgaWQgcmVwbHlCbG9jayA9IF9fTlNNYWtlU3BlY2lhbEZvcndhcmRp bmdDYXB0dXJlQmxvY2sod2lyZUJsb2NrU2lnbmF0dXJlLl90eXBlU3RyaW5nLlVURjhTdHJpbmcs IFtpbnRlcmZhY2UsIHJlbW90ZU9iamVjdFJlZ2lzdHJ5LCByZXBseUlELCBjaGVja2VyXShOU0lu dm9jYXRpb24gKmludm9jYXRpb24pIHsKICAgICAgICAgICAgICAgICBhdXRvIGVuY29kZXIgPSBh ZG9wdE5TKFtbV0tSZW1vdGVPYmplY3RFbmNvZGVyIGFsbG9jXSBpbml0XSk7CiAgICAgICAgICAg ICAgICAgW2VuY29kZXIgZW5jb2RlT2JqZWN0Omludm9jYXRpb24gZm9yS2V5Omludm9jYXRpb25L ZXldOwogCiAgICAgICAgICAgICAgICAgcmVtb3RlT2JqZWN0UmVnaXN0cnktPl9yZW1vdGVPYmpl Y3RSZWdpc3RyeS0+c2VuZFJlcGx5QmxvY2socmVwbHlJRCwgVXNlckRhdGEoW2VuY29kZXIgcm9v dE9iamVjdERpY3Rpb25hcnldKSk7CisgICAgICAgICAgICAgICAgY2hlY2tlci0+ZGlkQ2FsbFJl cGx5QmxvY2soKTsKICAgICAgICAgICAgIH0pOwogCiAgICAgICAgICAgICBbaW52b2NhdGlvbiBz ZXRBcmd1bWVudDomcmVwbHlCbG9jayBhdEluZGV4OmldOwpAQCAtMjcwLDYgKzI5NywxMSBAQCAg ICAgYXV0byBkZWNvZGVyID0gYWRvcHROUyhbW1dLUmVtb3RlT2JqCiAgICAgW3JlcGx5SW52b2Nh dGlvbiBpbnZva2VdOwogfQogCistICh2b2lkKV9yZWxlYXNlUmVwbHlXaXRoSUQ6KHVpbnQ2NF90 KXJlcGx5SUQKK3sKKyAgICBfcGVuZGluZ1JlcGxpZXMucmVtb3ZlKHJlcGx5SUQpOworfQorCiBA ZW5kCiAKICNlbmRpZiAvLyBXS19BUElfRU5BQkxFRApJbmRleDogU291cmNlL1dlYktpdDIvU2hh cmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVPYmplY3RSZWdpc3RyeUludGVybmFsLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9fV0tSZW1vdGVPYmplY3RSZWdp c3RyeUludGVybmFsLmgJKHJldmlzaW9uIDIwNDIzMSkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9BUEkvQ29jb2EvX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnlJbnRlcm5hbC5oCSh3b3JraW5nIGNv cHkpCkBAIC00OCw2ICs0OCw3IEBAIGNsYXNzIFVzZXJEYXRhOwogLSAodm9pZClfaW52b2tlTWV0 aG9kOihjb25zdCBXZWJLaXQ6OlJlbW90ZU9iamVjdEludm9jYXRpb24mKWludm9jYXRpb247CiAK IC0gKHZvaWQpX2NhbGxSZXBseVdpdGhJRDoodWludDY0X3QpcmVwbHlJRCBibG9ja0ludm9jYXRp b246KGNvbnN0IFdlYktpdDo6VXNlckRhdGEmKWJsb2NrSW52b2NhdGlvbjsKKy0gKHZvaWQpX3Jl bGVhc2VSZXBseVdpdGhJRDoodWludDY0X3QpcmVwbHlJRDsKIAogQGVuZAogCkluZGV4OiBUb29s cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMDQy MzMpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAor MjAxNi0wOC0wNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIFtD b2NvYV0gUmVwbHkgYmxvY2sgbGVha3MgaWYgdGhlIHJlbW90ZSBvYmplY3QgZG9lc27igJl0IGNh bGwgaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 MDY0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVtb3RlT2JqZWN0UmVnaXN0cnkuaDog RGVjbGFyZWQgYSBuZXcgbWV0aG9kLgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0MkNvY29hL1JlbW90ZU9iamVjdFJlZ2lzdHJ5Lm1tOgorICAgICAgICAoVEVTVCk6IEFkZGVk IGEgdGVzdCBjYXNlIHRoYXQgY2hlY2tzIHRoYXQgdGhlIHJlcGx5IGJsb2NrIGlzIHJlbGVhc2Vk IGV2ZW4gd2hlbiBpdOKAmXMgbm90CisgICAgICAgICAgY2FsbGVkLgorICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1JlbW90ZU9iamVjdFJlZ2lzdHJ5UGx1Z0luLm1t OgorICAgICAgICAoLVtSZW1vdGVPYmplY3RSZWdpc3RyeVBsdWdJbiBkb05vdENhbGxDb21wbGV0 aW9uSGFuZGxlcjpdKTogSW1wbGVtZW50IG5ldyBtZXRob2QgYnkgbm90CisgICAgICAgICAgY2Fs bGluZyB0aGUgY29tcGxldGlvbiBoYW5kbGVyLgorCiAyMDE2LTA4LTA2ICBBYWthc2ggSmFpbiAg PGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBFV1MgU3R5bGUgUXVldWUgZmFpbHMg dG8gcHJvY2VzcyBwYXRjaGVzIHdoaWNoIGZhaWxzIHZhbGlkYXRpb24KSW5kZXg6IFRvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1JlbW90ZU9iamVjdFJlZ2lzdHJ5LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVtb3Rl T2JqZWN0UmVnaXN0cnkuaAkocmV2aXNpb24gMjA0MjMwKQorKysgVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVtb3RlT2JqZWN0UmVnaXN0cnkuaAkod29ya2luZyBjb3B5 KQpAQCAtMzUsNiArMzUsNyBAQAogLSAodm9pZClzYXlIZWxsbzooTlNTdHJpbmcgKiloZWxsbyBj b21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNTdHJpbmcgKikpY29tcGxldGlvbkhhbmRsZXI7 CiAtICh2b2lkKXNlbGVjdGlvbkFuZENsaWNrSW5mb3JtYXRpb25Gb3JDbGlja0F0UG9pbnQ6KE5T VmFsdWUgKilwb2ludFZhbHVlIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShOU0RpY3Rpb25h cnkgKikpY29tcGxldGlvbkhhbmRsZXI7CiAtICh2b2lkKXRha2VSYW5nZTooTlNSYW5nZSlyYW5n ZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNVSW50ZWdlciBsb2NhdGlvbiwgTlNVSW50 ZWdlciBsZW5ndGgpKWNvbXBsZXRpb25IYW5kbGVyOworLSAodm9pZClkb05vdENhbGxDb21wbGV0 aW9uSGFuZGxlcjoodm9pZCAoXikoKSljb21wbGV0aW9uSGFuZGxlcjsKIAogQGVuZAogCkluZGV4 OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9SZW1vdGVPYmplY3RSZWdp c3RyeS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJD b2NvYS9SZW1vdGVPYmplY3RSZWdpc3RyeS5tbQkocmV2aXNpb24gMjA0MjMwKQorKysgVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVtb3RlT2JqZWN0UmVnaXN0cnkubW0J KHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKICNpbXBvcnQgPFdlYktpdC9XS1dlYlZp ZXdQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvX1dLUmVtb3RlT2JqZWN0SW50ZXJmYWNlLmg+ CiAjaW1wb3J0IDxXZWJLaXQvX1dLUmVtb3RlT2JqZWN0UmVnaXN0cnkuaD4KKyNpbXBvcnQgPHd0 Zi9SZWZDb3VudGVkLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CiAKIHN0YXRpYyBib29s IGlzRG9uZTsKQEAgLTgyLDYgKzgzLDIxIEBAICAgICAgICAgaWQgPFJlbW90ZU9iamVjdFByb3Rv Y29sPiBvYmplY3QKICAgICAgICAgICAgIGlzRG9uZSA9IHRydWU7CiAgICAgICAgIH1dOwogICAg ICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmlzRG9uZSk7CisKKyAgICAgICAgaXNEb25l ID0gZmFsc2U7CisKKyAgICAgICAgY2xhc3MgRG9uZVdoZW5EZXN0cm95ZWQgOiBwdWJsaWMgV1RG OjpSZWZDb3VudGVkPERvbmVXaGVuRGVzdHJveWVkPiB7CisgICAgICAgIHB1YmxpYzoKKyAgICAg ICAgICAgIH5Eb25lV2hlbkRlc3Ryb3llZCgpIHsgaXNEb25lID0gdHJ1ZTsgfQorICAgICAgICB9 OworCisgICAgICAgIHsKKyAgICAgICAgICAgIFJlZlB0cjxEb25lV2hlbkRlc3Ryb3llZD4gZG9u ZVdoZW5EZXN0cm95ZWQgPSBhZG9wdFJlZigqbmV3IERvbmVXaGVuRGVzdHJveWVkKTsKKyAgICAg ICAgICAgIFtvYmplY3QgZG9Ob3RDYWxsQ29tcGxldGlvbkhhbmRsZXI6W2RvbmVXaGVuRGVzdHJv eWVkXSgpIHsKKyAgICAgICAgICAgIH1dOworICAgICAgICB9CisKKyAgICAgICAgVGVzdFdlYktp dEFQSTo6VXRpbDo6cnVuKCZpc0RvbmUpOwogICAgIH0KIH0KIApJbmRleDogVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVtb3RlT2JqZWN0UmVnaXN0cnlQbHVnSW4ubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVt b3RlT2JqZWN0UmVnaXN0cnlQbHVnSW4ubW0JKHJldmlzaW9uIDIwNDIzMCkKKysrIFRvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1JlbW90ZU9iamVjdFJlZ2lzdHJ5UGx1Z0lu Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC04MSw2ICs4MSwxMCBAQCAtICh2b2lkKXRha2VSYW5nZToo TlNSYW5nZSlyYW5nZSBjb21wbGV0CiAgICAgY29tcGxldGlvbkhhbmRsZXIocmFuZ2UubG9jYXRp b24sIHJhbmdlLmxlbmd0aCk7CiB9CiAKKy0gKHZvaWQpZG9Ob3RDYWxsQ29tcGxldGlvbkhhbmRs ZXI6KHZvaWQgKF4pKCkpY29tcGxldGlvbkhhbmRsZXIKK3sKK30KKwogQGVuZAogCiAjZW5kaWYg Ly8gV0tfQVBJX0VOQUJMRUQK