160632 2016-08-06 11:32:00 -0700 EWS Style Queue fails to process patches which fails validation 2016-08-06 22:20:47 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159903 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates glenn lforschler oldest_to_newest 1218254 0 aakash_jain 2016-08-06 11:32:00 -0700 Currently EWS Style Queue has 19 pending patches. Looking at the logs on the machine, there is an exception while processing any patch which fails validation. It is because of the change done is https://bugs.webkit.org/show_bug.cgi?id=159903 in PatchIsNotValid class. 1218255 1 285491 aakash_jain 2016-08-06 11:39:37 -0700 Created attachment 285491 Proposed patch, also added a unittest. 1218260 2 285491 commit-queue 2016-08-06 12:34:35 -0700 Comment on attachment 285491 Proposed patch, also added a unittest. Clearing flags on attachment: 285491 Committed r204230: <http://trac.webkit.org/changeset/204230> 1218261 3 commit-queue 2016-08-06 12:34:42 -0700 All reviewed patches have been landed. Closing bug. 1218345 4 aakash_jain 2016-08-06 22:20:47 -0700 Style queue processed all the pending patches after the fix. 285491 2016-08-06 11:39:37 -0700 2016-08-06 12:34:35 -0700 Proposed patch, also added a unittest. ews-error-msg-stylequeue text/plain 3146 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNDIyOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE2LTA4LTA2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1MgU3R5bGUgUXVldWUgZmFpbHMgdG8gcHJvY2VzcyBwYXRjaGVzIHdo aWNoIGZhaWxzIHZhbGlkYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MDYzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zdHlsZXF1ZXVldGFzay5w eToKKyAgICAgICAgKFN0eWxlUXVldWVUYXNrLnZhbGlkYXRlKTogQWRkIG1vcmUgaW5mb3JtYXRp b24gYWJvdXQgdmFsaWRhdGlvbiBmYWlsdXJlLgorICAgICAgICAoU3R5bGVRdWV1ZVRhc2sucnVu KTogUGFzcyB0aGUgZXJyb3IgZGV0YWlscyBpbiB0aGUgUGF0Y2hJc05vdFZhbGlkIGV4Y2VwdGlv bi4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0 ZXN0LnB5OgorICAgICAgICAodGVzdF9ub25fdmFsaWRfcGF0Y2gpOiBBZGQgYSB1bml0IHRlc3Qg dG8gdGVzdCB0aGUgYWJvdmUgY29kZSBwYXRoLgorCiAyMDE2LTA4LTA2ICBTYW0gV2VpbmlnICA8 c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV1RGIG5lZWRzIGEgdmFyaWFudCBpbXBsZW1lbnRh dGlvbgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9zdHlsZXF1ZXVldGFz ay5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3N0eWxl cXVldWV0YXNrLnB5CShyZXZpc2lvbiAyMDQyMjkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvYm90L3N0eWxlcXVldWV0YXNrLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zOCwxMCArMzgs MTMgQEAgY2xhc3MgU3R5bGVRdWV1ZVRhc2soUGF0Y2hBbmFseXNpc1Rhc2spOgogICAgIGRlZiB2 YWxpZGF0ZShzZWxmKToKICAgICAgICAgc2VsZi5fcGF0Y2ggPSBzZWxmLl9kZWxlZ2F0ZS5yZWZl dGNoX3BhdGNoKHNlbGYuX3BhdGNoKQogICAgICAgICBpZiBzZWxmLl9wYXRjaC5pc19vYnNvbGV0 ZSgpOgorICAgICAgICAgICAgc2VsZi5lcnJvciA9ICJQYXRjaCBpcyBvYnNvbGV0ZS4iCiAgICAg ICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgaWYgc2VsZi5fcGF0Y2guYnVnKCkuaXNfY2xv c2VkKCk6CisgICAgICAgICAgICBzZWxmLmVycm9yID0gIkJ1ZyBpcyBhbHJlYWR5IGNsb3NlZC4i CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgaWYgc2VsZi5fcGF0Y2gucmV2aWV3 KCkgPT0gIi0iOgorICAgICAgICAgICAgc2VsZi5lcnJvciA9ICJQYXRjaCBpcyBtYXJrZWQgci0u IgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAgICAgICAgIHJldHVybiBUcnVlCiAKQEAgLTY0 LDcgKzY3LDcgQEAgY2xhc3MgU3R5bGVRdWV1ZVRhc2soUGF0Y2hBbmFseXNpc1Rhc2spOgogCiAg ICAgZGVmIHJ1bihzZWxmKToKICAgICAgICAgaWYgbm90IHNlbGYudmFsaWRhdGUoKToKLSAgICAg ICAgICAgIHJhaXNlIFBhdGNoSXNOb3RWYWxpZChzZWxmLl9wYXRjaCkKKyAgICAgICAgICAgIHJh aXNlIFBhdGNoSXNOb3RWYWxpZChzZWxmLl9wYXRjaCwgc2VsZi5lcnJvcikKICAgICAgICAgaWYg bm90IHNlbGYuX2NsZWFuKCk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgaWYg bm90IHNlbGYuX3VwZGF0ZSgpOgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv bW1hbmRzL3F1ZXVlc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMDQyMjkp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzX3VuaXR0ZXN0 LnB5CSh3b3JraW5nIGNvcHkpCkBAIC01MzQsMyArNTM0LDE0IEBAIE1PQ0s6IHJlbGVhc2Vfd29y a19pdGVtOiBzdHlsZS1xdWV1ZSAxMDAKICAgICAgICAgfQogICAgICAgICB0b29sID0gTW9ja1Rv b2woZXhlY3V0aXZlX3Rocm93c193aGVuX3J1bj1zZXQoWydhcHBseS13YXRjaGxpc3QtbG9jYWwn XSkpCiAgICAgICAgIHNlbGYuYXNzZXJ0X3F1ZXVlX291dHB1dHMoU3R5bGVRdWV1ZShob3N0PU1v Y2tIb3N0KCkpLCBleHBlY3RlZF9sb2dzPWV4cGVjdGVkX2xvZ3MsIHRvb2w9dG9vbCkKKworICAg IGRlZiB0ZXN0X25vbl92YWxpZF9wYXRjaChzZWxmKToKKyAgICAgICAgdG9vbCA9IE1vY2tUb29s KCkKKyAgICAgICAgcGF0Y2ggPSB0b29sLmJ1Z3MuZmV0Y2hfYXR0YWNobWVudCgxMDAwNykgICMg X3BhdGNoOCwgcmVzb2x2ZWQgYnVnLCB3aXRob3V0IHJldmlldyBmbGFnLCBub3QgbWFya2VkIG9i c29sZXRlIChtYXliZSBhbHJlYWR5IGxhbmRlZCkKKyAgICAgICAgZXhwZWN0ZWRfbG9ncyA9IHsK KyAgICAgICAgICAgICJiZWdpbl93b3JrX3F1ZXVlIjogc2VsZi5fZGVmYXVsdF9iZWdpbl93b3Jr X3F1ZXVlX2xvZ3MoInN0eWxlLXF1ZXVlIiksCisgICAgICAgICAgICAicHJvY2Vzc193b3JrX2l0 ZW0iOiAiIiJNT0NLOiB1cGRhdGVfc3RhdHVzOiBzdHlsZS1xdWV1ZSBFcnJvcjogc3R5bGUtcXVl dWUgZGlkIG5vdCBwcm9jZXNzIHBhdGNoLiBSZWFzb246IEJ1ZyBpcyBhbHJlYWR5IGNsb3NlZC4K K01PQ0s6IHJlbGVhc2Vfd29ya19pdGVtOiBzdHlsZS1xdWV1ZSAxMDAwNworIiIiLAorICAgICAg ICB9CisgICAgICAgIHNlbGYuYXNzZXJ0X3F1ZXVlX291dHB1dHMoU3R5bGVRdWV1ZShob3N0PU1v Y2tIb3N0KCkpLCB0b29sPXRvb2wsIHdvcmtfaXRlbT1wYXRjaCwgZXhwZWN0ZWRfbG9ncz1leHBl Y3RlZF9sb2dzKQo=